Skip to contentSkip to conversation

lib: add crc16.o if CONFIG_MMC_SPI_CRC_ON for SPL build

PATCH In review Andreas Schwab 3 participants 4 messages Aug 17, 2021 – Sep 3, 2021

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 lib: add crc16.o if CONFIG_MMC_SPI_CRC_ON for SPL build

CONFIG_MMC_SPI_CRC_ON needs the crc16 functions, but it was not included in an SPL build. For non-SPL builds, crc16.o is already added unconditionally. This also removes CONFIG_SPL_YMODEM_SUPPORT from the sifive board configs, which is only relevant for some ARM boards and was only set for its side effect of adding crc16.o.

---
 configs/sifive_unleashed_defconfig | 1 -
 configs/sifive_unmatched_defconfig | 1 -
 lib/Makefile                       | 1 +
 3 files changed, 1 insertion(+), 2 deletions(-)
configs/sifive_unleashed_defconfig +0 -1
index fd686dfadc..d6448dbf5e 100644
@@ -22,7 +22,6 @@ CONFIG_SPL_SEPARATE_BSS=y
 CONFIG_SPL_DM_SPI_FLASH=y
 CONFIG_SPL_DM_RESET=y
 CONFIG_SPL_SPI_LOAD=y
-CONFIG_SPL_YMODEM_SUPPORT=y
 CONFIG_SYS_RELOC_GD_ENV_ADDR=y
 CONFIG_SPL_DM_SEQ_ALIAS=y
 CONFIG_SPL_CLK=y
configs/sifive_unmatched_defconfig +0 -1
index 6c40a35bc2..59c4a383e0 100644
@@ -20,7 +20,6 @@ CONFIG_DISPLAY_BOARDINFO=y
 CONFIG_DISPLAY_BOARDINFO_LATE=y
 CONFIG_SPL_SEPARATE_BSS=y
 CONFIG_SPL_DM_RESET=y
-CONFIG_SPL_YMODEM_SUPPORT=y
 CONFIG_CMD_EEPROM=y
 CONFIG_CMD_MEMINFO=y
 CONFIG_CMD_PWM=y
lib/Makefile +1 -0
index 8ba745faa0..2d29cdad1e 100644
@@ -88,6 +88,7 @@ endif
 ifdef CONFIG_SPL_BUILD
 obj-$(CONFIG_SPL_YMODEM_SUPPORT) += crc16.o
 obj-$(CONFIG_$(SPL_TPL_)HASH_SUPPORT) += crc16.o
+obj-$(CONFIG_MMC_SPI_CRC_ON) += crc16.o
 obj-y += net_utils.o
 endif
 obj-$(CONFIG_ADDR_MAP) += addr_map.o
Signature · 7 lines
2.33.0


-- 
Andreas Schwab, SUSE Labs, [email protected]
GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE  1748 E4D4 88E3 0EEA B9D7
"And now for something completely different."
#1 lore raw
Quoted 5 lines · Andreas Schwab

CONFIG_MMC_SPI_CRC_ON needs the crc16 functions, but it was not included in an SPL build. For non-SPL builds, crc16.o is already added unconditionally. This also removes CONFIG_SPL_YMODEM_SUPPORT from the sifive board configs, which is only relevant for some ARM boards and was only set for its side effect of adding crc16.o.

Applied to u-boot/next, thanks!

Signature · 1 line
Tom
#2 lore raw
Quoted 10 lines · Tom Rini
Quoted 5 lines · Andreas Schwab

CONFIG_MMC_SPI_CRC_ON needs the crc16 functions, but it was not included in an SPL build. For non-SPL builds, crc16.o is already added unconditionally. This also removes CONFIG_SPL_YMODEM_SUPPORT from the sifive board configs, which is only relevant for some ARM boards and was only set for its side effect of adding crc16.o.

Applied to u-boot/next, thanks!

I thought I replied this email, but it seems not.

This patch is missing SoB tag.

Regards,
Bin

#3 lore raw
Quoted 10 lines · Bin Meng
Quoted 9 lines · Tom Rini
Quoted 5 lines · Andreas Schwab

CONFIG_MMC_SPI_CRC_ON needs the crc16 functions, but it was not included in an SPL build. For non-SPL builds, crc16.o is already added unconditionally. This also removes CONFIG_SPL_YMODEM_SUPPORT from the sifive board configs, which is only relevant for some ARM boards and was only set for its side effect of adding crc16.o.

Quoted 5 lines
Quoted 1 line

Applied to u-boot/next, thanks!

I thought I replied this email, but it seems not.

This patch is missing SoB tag.

Yes, I also saw, but it's also small / obvious enough that it's not worrisome. By which I also mean, if you check through the linux kernel, there's still an occasional no-SoB tag commit. Not often, but non-zero.

Signature · 1 line
Tom