Skip to contentSkip to conversation

arm64: dts: qcom: sc7280: Add WPSS remoteproc node

PATCH Superseded Rakesh Pillai 2 participants 3 messages Nov 18, 2021 – Nov 19, 2021

Subsystems (4)
Device tree bindings Arm Qualcomm mailing list Arm Qualcomm support Arm/Qualcomm chromebook support

v6 of 7 Superseded Latest is v7 →

lore
Share & tools
lore

Rakesh Pillai

author
#0 lore raw

PATCH v6 1/1 arm64: dts: qcom: sc7280: Add WPSS remoteproc node

Add the WPSS remoteproc node in dts for
PIL loading.

Signed-off-by Rakesh Pillai <[email protected]>

---
Changes from v5:
- Update the clock names

---
 arch/arm64/boot/dts/qcom/sc7280-idp.dts |  4 +++
 arch/arm64/boot/dts/qcom/sc7280.dtsi    | 56 +++++++++++++++++++++++++++++++++
 2 files changed, 60 insertions(+)
arch/arm64/boot/dts/qcom/sc7280-idp.dts +4 -0
index 9b991ba..ddab150 100644
@@ -80,3 +80,7 @@
 		qcom,pre-scaling = <1 1>;
 	};
 };
+
+&remoteproc_wpss {
+	status = "okay";
+};
arch/arm64/boot/dts/qcom/sc7280.dtsi +56 -0

68 lines not on this page · raw message

Signature · 1 line
2.7.4
Reviewed-by on v6 1/1
#1 lore raw

Quoting Rakesh Pillai (2021-11-18 07:56:56)

Quoted 29 lines

Add the WPSS remoteproc node in dts for
PIL loading.

Signed-off-by Rakesh Pillai <[email protected]>

---
Changes from v5:
- Update the clock names

---
 arch/arm64/boot/dts/qcom/sc7280-idp.dts |  4 +++
 arch/arm64/boot/dts/qcom/sc7280.dtsi    | 56 +++++++++++++++++++++++++++++++++
 2 files changed, 60 insertions(+)
arch/arm64/boot/dts/qcom/sc7280-idp.dts +4 -0
index 9b991ba..ddab150 100644
@@ -80,3 +80,7 @@
                qcom,pre-scaling = <1 1>;
        };
 };
+
+&remoteproc_wpss {
+       status = "okay";
+};
arch/arm64/boot/dts/qcom/sc7280.dtsi +0 -0
index 365a2e0..76c2a90 100644

arch/arm64/boot/dts/qcom/sc7280.dtsi line 139

Quoted 6 lines
arch/arm64/boot/dts/qcom/sc7280.dtsi +3 -0
@@ -134,6 +134,11 @@
                        no-map;
                };
 
+               wpss_mem: memory@9ae00000 {
+                       no-map;
+                       reg = <0x0 0x9ae00000 0x0 0x1900000>;

Almost always reg comes first. Please swap the order of these two properties.

arch/arm64/boot/dts/qcom/sc7280.dtsi line 144

Quoted 5 lines
arch/arm64/boot/dts/qcom/sc7280.dtsi +2 -0
+               };
+
                rmtfs_mem: memory@9c900000 {
                        compatible = "qcom,rmtfs-mem";
                        reg = <0x0 0x9c900000 0x0 0x280000>;

Otherwise

Reviewed-by Stephen Boyd <[email protected]>
author
#2 lore raw
Quoted 48 lines

-----Original Message-----
From: Stephen Boyd <[email protected]>
Sent: Friday, November 19, 2021 6:22 AM
To: Rakesh Pillai <[email protected]>; [email protected]; [email protected]; [email protected]
Cc: [email protected]; [email protected]; linux- [email protected]; [email protected]; [email protected]; [email protected]
Subject: Re: [PATCH v6] arm64: dts: qcom: sc7280: Add WPSS remoteproc node

Quoting Rakesh Pillai (2021-11-18 07:56:56)

Quoted 9 lines

Add the WPSS remoteproc node in dts for PIL loading.

Signed-off-by Rakesh Pillai <[email protected]>

---
Changes from v5:
- Update the clock names

---
 arch/arm64/boot/dts/qcom/sc7280-idp.dts |  4 +++
 arch/arm64/boot/dts/qcom/sc7280.dtsi    | 56

+++++++++++++++++++++++++++++++++

Quoted 24 lines
 2 files changed, 60 insertions(+)
arch/arm64/boot/dts/qcom/sc7280-idp.dts +4 -0
index 9b991ba..ddab150 100644
@@ -80,3 +80,7 @@
                qcom,pre-scaling = <1 1>;
        };
 };
+
+&remoteproc_wpss {
+       status = "okay";
+};
arch/arm64/boot/dts/qcom/sc7280.dtsi +0 -0
index 365a2e0..76c2a90 100644
@@ -134,6 +134,11 @@
                        no-map;
                };
Quoted 6 lines

arch/arm64/boot/dts/qcom/sc7280.dtsi line 139

Quoted 3 lines
arch/arm64/boot/dts/qcom/sc7280.dtsi +3 -0
+               wpss_mem: memory@9ae00000 {
+                       no-map;
+                       reg = <0x0 0x9ae00000 0x0 0x1900000>;

Almost always reg comes first. Please swap the order of these two properties.

Hi Stephen,
I have fixed this and sent v7 for the DTSI change.

Thanks,
Rakesh Pillai

Quoted 10 lines

arch/arm64/boot/dts/qcom/sc7280.dtsi line 144

Quoted 6 lines
arch/arm64/boot/dts/qcom/sc7280.dtsi +2 -0
+               };
+
                rmtfs_mem: memory@9c900000 {
                        compatible = "qcom,rmtfs-mem";
                        reg = <0x0 0x9c900000 0x0 0x280000>;

Otherwise

Reviewed-by Stephen Boyd <[email protected]>