ASoC: max98390: Add reset gpio control
PATCH RESEND v2 1/1 ASoC: max98390: Add reset gpio control
Add reset gpio control to support RESET PIN connected to gpio.
--- sound/soc/codecs/max98390.c | 12 ++++++++++++ 1 file changed, 12 insertions(+)
sound/soc/codecs/max98390.c +12 -0
@@ -1022,6 +1022,7 @@ static int max98390_i2c_probe(struct i2c_client *i2c,struct max98390_priv *max98390 =NULL ;struct i2c_adapter *adapter = i2c->adapter; +struct gpio_desc *reset_gpio; ret =i2c_check_functionality (adapter, I2C_FUNC_SMBUS_BYTE
@@ -1073,6 +1074,17 @@ static int max98390_i2c_probe(struct i2c_client *i2c,return ret; } + reset_gpio =devm_gpiod_get_optional (&i2c->dev, +"maxim,reset-gpios" ,GPIOD_OUT_LOW ); + +/* Power on device */ +if (reset_gpio) { +usleep_range (1000 ,2000 ); +/* bring out of reset */ +gpiod_set_value_cansleep (reset_gpio,1 ); +usleep_range (1000 ,2000 ); + } +/* Check Revision ID */ ret =regmap_read (max98390->regmap,MAX98390_R24FF_REV_ID , ®);
Signature · 1 line
2.17.1
Quoted 20 lines · Steve Lee
Add reset gpio control to support RESET PIN connected to gpio.
Signed-off-by Steve Lee <[email protected]>--- sound/soc/codecs/max98390.c | 12 ++++++++++++ 1 file changed, 12 insertions(+)sound/soc/codecs/max98390.c +1
-0@@ -1022,6 +1022,7 @@ static int max98390_i2c_probe(struct i2c_client *i2c,struct max98390_priv *max98390 =NULL ;struct i2c_adapter *adapter = i2c->adapter; +struct gpio_desc *reset_gpio; ret =i2c_check_functionality (adapter, I2C_FUNC_SMBUS_BYTE
sound/soc/codecs/max98390.c static int max98390_i2c_probe(struct i2c_client *i2c, · line 1079
Quoted 6 lines
sound/soc/codecs/max98390.c +3
-0@@ -1073,6 +1074,17 @@ static int max98390_i2c_probe(struct i2c_client *i2c,return ret; } + reset_gpio =devm_gpiod_get_optional (&i2c->dev, +"maxim,reset-gpios" ,GPIOD_OUT_LOW ); +
I don't know why did you CC me, but since I am looking at this - you have to update bindings.
Do not add random properties to drivers without updating bindings.
Best regards,
Krzysztof
Quoted 32 lines · Krzysztof Kozlowski
Quoted 20 lines · Steve Lee
Add reset gpio control to support RESET PIN connected to gpio.
Signed-off-by Steve Lee <[email protected]>--- sound/soc/codecs/max98390.c | 12 ++++++++++++ 1 file changed, 12 insertions(+)sound/soc/codecs/max98390.c +1
-0@@ -1022,6 +1022,7 @@ static int max98390_i2c_probe(struct i2c_client *i2c,struct max98390_priv *max98390 =NULL ;struct i2c_adapter *adapter = i2c->adapter; +struct gpio_desc *reset_gpio; ret =i2c_check_functionality (adapter, I2C_FUNC_SMBUS_BYTEsound/soc/codecs/max98390.c static int max98390_i2c_probe(struct i2c_client *i2c, · line 1079
Quoted 6 lines
sound/soc/codecs/max98390.c +3
-0@@ -1073,6 +1074,17 @@ static int max98390_i2c_probe(struct i2c_client *i2c,return ret; } + reset_gpio =devm_gpiod_get_optional (&i2c->dev, +"maxim,reset-gpios" ,GPIOD_OUT_LOW ); +I don't know why did you CC me, but since I am looking at this - you have to update bindings.
Quoted 4 lines
Do not add random properties to drivers without updating bindings.
Best regards,
Krzysztof
Thanks for comment. Yes, I update bingding too.
Quoted 25 lines · Steve Lee
Add reset gpio control to support RESET PIN connected to gpio.
Signed-off-by Steve Lee <[email protected]>---
sound/soc/codecs/max98390.c | 12 ++++++++++++1 file changed, 12 insertions(+)sound/soc/codecs/max98390.c +0
-0@@ -1022,6 +1022,7 @@ static int max98390_i2c_probe(struct i2c_client *i2c,
structmax98390_priv*max98390 = NULL; structi2c_adapter*adapter =i2c->adapter; + structgpio_desc*reset_gpio;
ret = i2c_check_functionality(adapter,I2C_FUNC_SMBUS_BYTEsound/soc/codecs/max98390.c +0
-0@@ -1073,6 +1074,17 @@ static int max98390_i2c_probe(structi2c_client *i2c, return ret; }
Quoted 4 lines
+ reset_gpio = devm_gpiod_get_optional(&i2c->dev, + "maxim,reset-gpios",GPIOD_OUT_LOW);
A reset GPIO is a standard property so there's no need for a vendor prefix. This should be devm_gpiod_get_optional(&i2c->dev, "reset", ...). And, as said before, you need to add a reset-gpios property to the bindings in a different patch.
I'm also not sure why you have this as RESEND...
- Nuno Sá
Quoted 1 line
Quoted 37 lines · Nuno Sá
Quoted 22 lines · Steve Lee
Add reset gpio control to support RESET PIN connected to gpio.
Signed-off-by Steve Lee <[email protected]>--- sound/soc/codecs/max98390.c | 12 ++++++++++++ 1 file changed, 12 insertions(+)sound/soc/codecs/max98390.c +1
-0@@ -1022,6 +1022,7 @@ static int max98390_i2c_probe(struct i2c_client *i2c, struct max98390_priv *max98390 = NULL;struct i2c_adapter *adapter = i2c->adapter; +struct gpio_desc *reset_gpio; ret = i2c_check_functionality(adapter,
I2C_FUNC_SMBUS_BYTEsound/soc/codecs/max98390.c static int max98390_i2c_probe(struct · line 1080
Quoted 7 lines
sound/soc/codecs/max98390.c +2
-0@@ -1073,6 +1074,17 @@ static int max98390_i2c_probe(structi2c_client *i2c, return ret; } + reset_gpio =devm_gpiod_get_optional (&i2c->dev, +"maxim,reset-gpios" ,GPIOD_OUT_LOW );A reset GPIO is a standard property so there's no need for a vendor prefix. This should be
devm_gpiod_get_optional(&i2c->dev, "reset", ...). And, as said before, you need to add a reset-gpios property to the bindings in a different patch.
Quoted 5 lines
I'm also not sure why you have this as RESEND...
- Nuno Sá
Quoted 1 line
I forgot to add another patch mail. I will check it before sending patch again.