Skip to contentSkip to conversation

x86: efi: Add a 64-bit coreboot payload

PATCH Superseded Simon Glass 4 participants 13 messages Apr 26, 2020 – Apr 30, 2020

Subsystems (2)

v2 of 5 Superseded Latest is v5 →

lore
Share & tools
lore
#0 lore raw

v2 cover x86: efi: Add a 64-bit coreboot payload

This series creates a new 64-bit 'coreboot64' build which can be launched from coreboot. It uses SPL to effect the jump to 64-bit mode.

This was done in an attempt to get the Ubuntu FirmwareTestSuite[1] working. Unfortunately the latest version shows a splash screen and hangs, perhaps due to some missing EFI support.

[1] https://wiki.ubuntu.com/FirmwareTestSuite

Changes in v2:
- Add a new patch to indicate 32/64-bit in bdinfo

Simon Glass (7):
x86: Allow building an SPL image for coreboot
x86: Move work-around out of cpu_jump_to_64bit_uboot()
x86: Update SPL for coreboot
x86: cbfs: Drop unwanted declaration
x86: coreboot: Allow building an SPL image
x86: Add an indication of 32/64-bit to bdinfo
x86: Add a 64-bit coreboot build

 Makefile                             |  6 ++++
 arch/x86/cpu/Makefile                |  4 ++-
 arch/x86/cpu/coreboot/Kconfig        |  1 +
 arch/x86/cpu/coreboot/Makefile       |  8 ++++-
 arch/x86/cpu/coreboot/coreboot.c     |  3 +-
 arch/x86/cpu/coreboot/coreboot_spl.c | 12 +++++++
 arch/x86/cpu/i386/cpu.c              | 10 ------
 arch/x86/cpu/intel_common/Makefile   |  2 ++
 arch/x86/cpu/x86_64/cpu.c            |  2 ++
 arch/x86/dts/coreboot-u-boot.dtsi    | 18 +++++++++++
 arch/x86/lib/spl.c                   | 23 ++++++++++---
 board/coreboot/coreboot/MAINTAINERS  |  7 ++++
 cmd/bdinfo.c                         |  1 +
 configs/coreboot64_defconfig         | 48 ++++++++++++++++++++++++++++
 doc/board/coreboot/coreboot.rst      | 10 ++++++
 include/cbfs.h                       |  2 +-
 16 files changed, 139 insertions(+), 18 deletions(-)
 create mode 100644 arch/x86/cpu/coreboot/coreboot_spl.c
 create mode 100644 arch/x86/dts/coreboot-u-boot.dtsi
 create mode 100644 configs/coreboot64_defconfig
Signature · 1 line
2.26.2.303.gf8c07b1a785-goog
#1 lore raw

PATCH v2 1/7 x86: Allow building an SPL image for coreboot

Coreboot runs in 32-bit mode and cannot run a 64-bit U-Boot. To get around this we can build a combined image with 32-bit SPL and 64-bit U-Boot. Add a build rule and binman definition for this.

---

Changes in v2: None

 Makefile                          |  6 ++++++
 arch/x86/cpu/coreboot/Kconfig     |  1 +
 arch/x86/dts/coreboot-u-boot.dtsi | 18 ++++++++++++++++++
 3 files changed, 25 insertions(+)
 create mode 100644 arch/x86/dts/coreboot-u-boot.dtsi
Makefile +6 -0
index b8a4b5058a..a6db812f6d 100644
@@ -926,6 +926,9 @@ ALL-$(CONFIG_EFI_STUB) += u-boot-payload.efi
 ifneq ($(BUILD_ROM)$(CONFIG_BUILD_ROM),)
 ALL-$(CONFIG_X86_RESET_VECTOR) += u-boot.rom
 endif
+ifeq ($(CONFIG_SYS_COREBOOT)$(CONFIG_SPL),yy)
+ALL-$(CONFIG_BINMAN) += u-boot-x86-with-spl.bin
+endif
 
 # Build a combined spl + u-boot image for sunxi
 ifeq ($(CONFIG_ARCH_SUNXI)$(CONFIG_SPL),yy)
@@ -1611,6 +1614,9 @@ u-boot-sunxi-with-spl.bin: spl/sunxi-spl.bin u-boot.itb FORCE
 endif
 endif
 
+u-boot-x86-with-spl.bin: spl/u-boot-spl.bin u-boot.bin FORCE
+	$(call if_changed,binman)
+
 ifneq ($(CONFIG_TEGRA),)
 ifneq ($(CONFIG_BINMAN),)
 # Makes u-boot-dtb-tegra.bin u-boot-tegra.bin u-boot-nodtb-tegra.bin
arch/x86/cpu/coreboot/Kconfig +1 -0
index c8e6a889d0..497d6284ac 100644
@@ -25,5 +25,6 @@ config SYS_COREBOOT
 	imply FS_CBFS
 	imply CBMEM_CONSOLE
 	imply X86_TSC_READ_BASE
+	select BINMAN if X86_64
 
 endif
arch/x86/dts/coreboot-u-boot.dtsi new file +18 -0
new file mode 100644
index 0000000000..38efc48d83
@@ -0,0 +1,18 @@
+// SPDX-License-Identifier: GPL-2.0+
+/*
+ * Copyright 2020 Google LLC
+ * Written by Simon Glass <[email protected]>
+ */
+
+#include <config.h>
+
+/ {
+	binman {
+		filename = "u-boot-x86-with-spl.bin";
+		u-boot-spl {
+		};
+		u-boot {
+			offset = <0x10000>;
+		};
+	};
+};
Signature · 1 line
2.26.2.303.gf8c07b1a785-goog
#2 lore raw

PATCH v2 2/7 x86: Move work-around out of cpu_jump_to_64bit_uboot()

In reply to Simon Glass

At present this function copies U-Boot from the last 1MB of ROM. This is not the right way to do it. Instead, the binman symbol should provide the location.

But in any case the code should live in the caller, spl_board_load_image(), so that the 64-bit jump function can be used elsewhere. Move it.

---

Changes in v2: None

 arch/x86/cpu/i386/cpu.c | 10 ----------
 arch/x86/lib/spl.c      | 13 +++++++++++++
 2 files changed, 13 insertions(+), 10 deletions(-)
arch/x86/cpu/i386/cpu.c +0 -10
index c8da7f10e9..45416a9be5 100644
@@ -611,16 +611,6 @@ int cpu_jump_to_64bit_uboot(ulong target)
 
 	func = (func_t)ptr;
 
-	/*
-	 * Copy U-Boot from ROM
-	 * TODO(sjg at chromium.org): Figure out a way to get the text base
-	 * correctly here, and in the device-tree binman definition.
-	 *
-	 * Also consider using FIT so we get the correct image length and
-	 * parameters.
-	 */
-	memcpy((char *)target, (char *)0xfff00000, 0x100000);
-
 	/* Jump to U-Boot */
 	func((ulong)pgtable, 0, (ulong)target);
 
arch/x86/lib/spl.c +13 -0
index 90baec2a17..95a89c072d 100644
@@ -207,6 +207,19 @@ static int spl_board_load_image(struct spl_image_info *spl_image,
 	spl_image->os = IH_OS_U_BOOT;
 	spl_image->name = "U-Boot";
 
+	if (!IS_ENABLED(CONFIG_SYS_COREBOOT)) {
+		/*
+		 * Copy U-Boot from ROM
+		 * TODO(sjg at chromium.org): Figure out a way to get the text base
+		 * correctly here, and in the device-tree binman definition.
+		 *
+		 * Also consider using FIT so we get the correct image length
+		 * and parameters.
+		 */
+		memcpy((char *)spl_image->load_addr, (char *)0xfff00000,
+		       0x100000);
+	}
+
 	debug("Loading to %lx\n", spl_image->load_addr);
 
 	return 0;
Signature · 1 line
2.26.2.303.gf8c07b1a785-goog
#3 lore raw

PATCH v2 3/7 x86: Update SPL for coreboot

In reply to Simon Glass

At present SPL only works on bare-metal builds. With a few tweaks it can be used for coreboot also.

---

Changes in v2: None

 arch/x86/lib/spl.c | 10 ++++++----
 1 file changed, 6 insertions(+), 4 deletions(-)
arch/x86/lib/spl.c +6 -4
index 95a89c072d..212b4d596d 100644
@@ -63,7 +63,7 @@ static int x86_spl_init(void)
 	 * is not needed. We could make this a CONFIG option or perhaps
 	 * place it immediately below CONFIG_SYS_TEXT_BASE.
 	 */
-	char *ptr = (char *)0x110000;
+	__maybe_unused char *ptr = (char *)0x110000;
 #else
 	struct udevice *punit;
 #endif
@@ -111,7 +111,8 @@ static int x86_spl_init(void)
 			      __func__, ret);
 	}
 
-#ifndef CONFIG_TPL
+#ifndef CONFIG_SYS_COREBOOT
+# ifndef CONFIG_TPL
 	memset(&__bss_start, 0, (ulong)&__bss_end - (ulong)&__bss_start);
 
 	/* TODO(sjg at chromium.org): Consider calling cpu_init_r() here */
@@ -140,7 +141,7 @@ static int x86_spl_init(void)
 		return ret;
 	}
 	mtrr_commit(true);
-#else
+# else
 	ret = syscon_get_by_driver_data(X86_SYSCON_PUNIT, &punit);
 	if (ret)
 		debug("Could not find PUNIT (err=%d)\n", ret);
@@ -148,6 +149,7 @@ static int x86_spl_init(void)
 	ret = set_max_freq();
 	if (ret)
 		debug("Failed to set CPU frequency (err=%d)\n", ret);
+# endif
 #endif
 
 	return 0;
@@ -162,7 +164,7 @@ void board_init_f(ulong flags)
 		debug("Error %d\n", ret);
 		panic("x86_spl_init fail");
 	}
-#ifdef CONFIG_TPL
+#if IS_ENABLED(CONFIG_TPL) || IS_ENABLED(CONFIG_SYS_COREBOOT)
 	gd->bd = malloc(sizeof(*gd->bd));
 	if (!gd->bd) {
 		printf("Out of memory for bd_info size %x\n", sizeof(*gd->bd));
Signature · 1 line
2.26.2.303.gf8c07b1a785-goog
#4 lore raw

PATCH v2 4/7 x86: cbfs: Drop unwanted declaration

In reply to Simon Glass

The intention here is add a forward declaration, not actually declare a variable. Fix it.

---

Changes in v2: None

 include/cbfs.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
include/cbfs.h +1 -1
index f3bc8ca24a..d915f9426d 100644
@@ -135,7 +135,7 @@ void file_cbfs_get_next(const struct cbfs_cachenode **file);
  */
 const struct cbfs_cachenode *file_cbfs_find(const char *name);
 
-struct cbfs_priv *priv;
+struct cbfs_priv;
 
 /**
  * cbfs_find_file() - Find a file in a given CBFS
Signature · 1 line
2.26.2.303.gf8c07b1a785-goog
#5 lore raw

PATCH v2 5/7 x86: coreboot: Allow building an SPL image

In reply to Simon Glass

Make a few adjustments to allow us to build an SPL image for coreboot.

---

Changes in v2: None

 arch/x86/cpu/Makefile                |  4 +++-
 arch/x86/cpu/coreboot/Makefile       |  8 +++++++-
 arch/x86/cpu/coreboot/coreboot.c     |  3 ++-
 arch/x86/cpu/coreboot/coreboot_spl.c | 12 ++++++++++++
 arch/x86/cpu/intel_common/Makefile   |  2 ++
 arch/x86/cpu/x86_64/cpu.c            |  2 ++
 6 files changed, 28 insertions(+), 3 deletions(-)
 create mode 100644 arch/x86/cpu/coreboot/coreboot_spl.c
arch/x86/cpu/Makefile +3 -1
index 307267a8fb..ee0499f5d7 100644
@@ -54,9 +54,11 @@ obj-$(CONFIG_INTEL_QUARK) += quark/
 obj-$(CONFIG_INTEL_QUEENSBAY) += queensbay/
 obj-$(CONFIG_INTEL_TANGIER) += tangier/
 obj-$(CONFIG_APIC) += lapic.o ioapic.o
-obj-$(CONFIG_$(SPL_TPL_)X86_32BIT_INIT) += irq.o
 obj-$(CONFIG_$(SPL_TPL_)ACPI_GPE) += acpi_gpe.o
 obj-$(CONFIG_QFW) += qfw_cpu.o
+ifndef CONFIG_SYS_COREBOOT
+obj-$(CONFIG_$(SPL_TPL_)X86_32BIT_INIT) += irq.o
+endif
 ifndef CONFIG_$(SPL_)X86_64
 obj-$(CONFIG_SMP) += mp_init.o
 endif
arch/x86/cpu/coreboot/Makefile +7 -1
index 35b15bb1da..605f90304e 100644
@@ -11,8 +11,14 @@
 # (C) Copyright 2002
 # Daniel Engstr?m, Omicron Ceti AB, daniel at omicron.se.
 
+ifndef CONFIG_SPL
 obj-y += car.o
+endif
+ifdef CONFIG_SPL_BUILD
+obj-y += coreboot_spl.o
+else
+obj-y += sdram.o
+endif
 obj-y += coreboot.o
 obj-y += tables.o
-obj-y += sdram.o
 obj-y += timestamp.o
arch/x86/cpu/coreboot/coreboot.c +2 -1
index 0c4c6348d1..624caf67a6 100644
@@ -27,7 +27,8 @@ int arch_cpu_init(void)
 
 	timestamp_init();
 
-	return x86_cpu_init_f();
+	return IS_ENABLED(CONFIG_X86_RUN_64BIT) ? x86_cpu_reinit_f() :
+		 x86_cpu_init_f();
 }
 
 int checkcpu(void)
arch/x86/cpu/coreboot/coreboot_spl.c new file +12 -0
new file mode 100644
index 0000000000..36661871e9
@@ -0,0 +1,12 @@
+// SPDX-License-Identifier: GPL-2.0+
+/*
+ * Copyright 2020 Google LLC
+ */
+
+#include <common.h>
+#include <init.h>
+
+int dram_init(void)
+{
+	return 0;
+}
arch/x86/cpu/intel_common/Makefile +2 -0
index 1736bd2b53..374803b876 100644
@@ -32,6 +32,8 @@ obj-$(CONFIG_HAVE_P2SB) += p2sb.o
 
 ifdef CONFIG_SPL
 ifndef CONFIG_SPL_BUILD
+ifndef CONFIG_SYS_COREBOOT
 obj-y += cpu_from_spl.o
 endif
 endif
+endif
arch/x86/cpu/x86_64/cpu.c +2 -0
index 90925e46ea..4b64339f25 100644
@@ -53,6 +53,7 @@ int misc_init_r(void)
 	return 0;
 }
 
+#ifndef CONFIG_SYS_COREBOOT
 int checkcpu(void)
 {
 	return 0;
@@ -62,6 +63,7 @@ int print_cpuinfo(void)
 {
 	return 0;
 }
+#endif
 
 int x86_cpu_reinit_f(void)
 {
Signature · 1 line
2.26.2.303.gf8c07b1a785-goog
#6 lore raw

PATCH v2 6/7 x86: Add an indication of 32/64-bit to bdinfo

In reply to Simon Glass

It is useful to know what mode U-Boot is running in. Add a message at the end of the 'bdinfo' output.

---

Changes in v2:
- Add a new patch to indicate 32/64-bit in bdinfo

 cmd/bdinfo.c | 1 +
 1 file changed, 1 insertion(+)
cmd/bdinfo.c +1 -0
index d6a7175b37..a3129c9fe1 100644
@@ -388,6 +388,7 @@ int do_bdinfo(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])
 	print_mhz("ethspeed",	    bd->bi_ethspeed);
 #endif
 	print_baudrate();
+	printf("Build: %d-bit\n", CONFIG_IS_ENABLED(X86_64) ? 64 : 32);
 
 	return 0;
 }
Signature · 1 line
2.26.2.303.gf8c07b1a785-goog
#7 lore raw

PATCH v2 6/7 x86: Add an indication of 32/64-bit to bdinfo

Quoted 2 lines · Simon Glass

It is useful to know what mode U-Boot is running in. Add a message at the end of the 'bdinfo' output.

X86 is not the only architecture that can run both in 32bit and 64bit mode. The same is true for ARM and SANDBOX. Shouldn't we provide the information for these architecture too?

The Raspberry Pi 3 is an example of an ARM board where building either 32bit or 64bit U-Boot is used depending on the bitness of the OS.

Best regards

Heinrich

Quoted 23 lines

---

Changes in v2:
- Add a new patch to indicate 32/64-bit in bdinfo

 cmd/bdinfo.c | 1 +
 1 file changed, 1 insertion(+)
cmd/bdinfo.c +1 -0
index d6a7175b37..a3129c9fe1 100644
@@ -388,6 +388,7 @@ int do_bdinfo(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])
 	print_mhz("ethspeed",	    bd->bi_ethspeed);
 #endif
 	print_baudrate();
+	printf("Build: %d-bit\n", CONFIG_IS_ENABLED(X86_64) ? 64 : 32);
 
 	return 0;
 }
#8 lore raw

PATCH v2 6/7 x86: Add an indication of 32/64-bit to bdinfo

Hi Heinrich,

Quoted 11 lines · Heinrich Schuchardt
Quoted 2 lines · Simon Glass

It is useful to know what mode U-Boot is running in. Add a message at the end of the 'bdinfo' output.

X86 is not the only architecture that can run both in 32bit and 64bit mode. The same is true for ARM and SANDBOX. Shouldn't we provide the information for these architecture too?

The Raspberry Pi 3 is an example of an ARM board where building either 32bit or 64bit U-Boot is used depending on the bitness of the OS.

Yes I think that would be good. But do we have a generic way to tell? sizeof(int) ?

Regards,
Simon

Quoted 29 lines

Best regards

Heinrich

Quoted 23 lines

---

Changes in v2:
- Add a new patch to indicate 32/64-bit in bdinfo

 cmd/bdinfo.c | 1 +
 1 file changed, 1 insertion(+)
cmd/bdinfo.c +1 -0
index d6a7175b37..a3129c9fe1 100644
@@ -388,6 +388,7 @@ int do_bdinfo(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])
      print_mhz("ethspeed",       bd->bi_ethspeed);
 #endif
      print_baudrate();
+     printf("Build: %d-bit\n", CONFIG_IS_ENABLED(X86_64) ? 64 : 32);
 
      return 0;
 }
#9 lore raw

PATCH v2 6/7 x86: Add an indication of 32/64-bit to bdinfo

Quoted 12 lines · Simon Glass

Hi Heinrich,

Quoted 9 lines · Heinrich Schuchardt
Quoted 2 lines · Simon Glass

It is useful to know what mode U-Boot is running in. Add a message at the end of the 'bdinfo' output.

X86 is not the only architecture that can run both in 32bit and 64bit mode. The same is true for ARM and SANDBOX. Shouldn't we provide the information for these architecture too?

Quoted 5 lines
Quoted 2 lines

The Raspberry Pi 3 is an example of an ARM board where building either 32bit or 64bit U-Boot is used depending on the bitness of the OS.

Yes I think that would be good. But do we have a generic way to tell? sizeof(int) ?

sizeof(int) = 4 on aarch64.

Using these should be fine:

CONFIG_ARM64=y
CONFIG_ARCH_RV64I=y
CONFIG_SANDBOX64=y

(continued below)

Quoted 20 lines

Regards,
Simon

Quoted 15 lines

Best regards

Heinrich

Quoted 10 lines

---

Changes in v2:
- Add a new patch to indicate 32/64-bit in bdinfo

 cmd/bdinfo.c | 1 +
 1 file changed, 1 insertion(+)
Quoted 9 lines
Quoted 9 lines

cmd/bdinfo.c int do_bdinfo(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[]) · line 391

Quoted 9 lines
cmd/bdinfo.c +1 -0
index d6a7175b37..a3129c9fe1 100644
@@ -388,6 +388,7 @@ int do_bdinfo(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])
      print_mhz("ethspeed",       bd->bi_ethspeed);
 #endif
      print_baudrate();
+     printf("Build: %d-bit\n", CONFIG_IS_ENABLED(X86_64) ? 64 : 32);

"Build" it usually used to refer to a software release.

Should this be:

    printf("bitness     = %d\n", ...

or simply

    printf("%d-bit\n", ...

Best regards

Heinrich

Quoted 5 lines
Quoted 5 lines
Quoted 4 lines
cmd/bdinfo.c +0 -0
      return 0;
 }
 
#10 lore raw

PATCH v2 6/7 x86: Add an indication of 32/64-bit to bdinfo

Quoted 16 lines

From: Heinrich Schuchardt <[email protected]>
Date: Sun, 26 Apr 2020 23:14:25 +0200

Quoted 12 lines · Simon Glass

Hi Heinrich,

Quoted 9 lines · Heinrich Schuchardt
Quoted 2 lines · Simon Glass

It is useful to know what mode U-Boot is running in. Add a message at the end of the 'bdinfo' output.

X86 is not the only architecture that can run both in 32bit and 64bit mode. The same is true for ARM and SANDBOX. Shouldn't we provide the information for these architecture too?

Quoted 7 lines
Quoted 5 lines
Quoted 2 lines

The Raspberry Pi 3 is an example of an ARM board where building either 32bit or 64bit U-Boot is used depending on the bitness of the OS.

Yes I think that would be good. But do we have a generic way to tell? sizeof(int) ?

sizeof(int) = 4 on aarch64.

sizeof(void *) should work

(and sizeof(long) should work as well, but then there is Windows)

Quoted 5 lines

Using these should be fine:

CONFIG_ARM64=y
CONFIG_ARCH_RV64I=y
CONFIG_SANDBOX64=y

MIPS and PowerPC can be 64-bit as well. I don't think checking config options scales.

#11 lore raw

PATCH v2 7/7 x86: Add a 64-bit coreboot build

In reply to Simon Glass

Add a build for running 64-bit U-Boot from coreboot (which is 32-bit). This uses binman to create an image with a 32-bit SPL and a 64-bit U-Boot.

Coreboot boots into SPL and then SPL boots into U-Boot.

This allows running 64-bit EFI images on x86.

---

Changes in v2: None

 board/coreboot/coreboot/MAINTAINERS |  7 +++++
 configs/coreboot64_defconfig        | 48 +++++++++++++++++++++++++++++
 doc/board/coreboot/coreboot.rst     | 10 ++++++
 3 files changed, 65 insertions(+)
 create mode 100644 configs/coreboot64_defconfig
board/coreboot/coreboot/MAINTAINERS +7 -0
index 188906b080..a05673bb0b 100644
@@ -4,3 +4,10 @@ S:	Maintained
 F:	board/coreboot/coreboot/
 F:	include/configs/chromebook_link.h
 F:	configs/coreboot_defconfig
+
+COREBOOT64 BOARD
+M:	Simon Glass <[email protected]>
+S:	Maintained
+F:	board/coreboot/coreboot/
+F:	include/configs/chromebook_link.h
+F:	configs/coreboot64_defconfig
configs/coreboot64_defconfig new file +48 -0

48 lines not on this page · raw message

doc/board/coreboot/coreboot.rst +10 -0
index fd974229eb..9c44c025a4 100644
@@ -40,3 +40,13 @@ To enable video you must enable these options in coreboot:
 At present it seems that for Minnowboard Max, coreboot does not pass through
 the video information correctly (it always says the resolution is 0x0). This
 works correctly for link though.
+
+64-bit U-Boot
+-------------
+
+In addition to the 32-bit 'coreboot' build there is a 'coreboot64' build. This
+produces an image which can be booted from coreboot (32-bit). Internally it
+works by using a 32-bit SPL binary to switch to 64-bit for running U-Boot. It
+can be useful for running UEFI applications, for example.
+
+This has only been lightly tested.
Signature · 1 line
2.26.2.303.gf8c07b1a785-goog
#12 lore raw

v2 cover x86: efi: Add a 64-bit coreboot payload

In reply to Simon Glass

Hi Simon,

Quoted 4 lines · Simon Glass

This series creates a new 64-bit 'coreboot64' build which can be launched from coreboot. It uses SPL to effect the jump to 64-bit mode.

Quoted 9 lines

This was done in an attempt to get the Ubuntu FirmwareTestSuite[1] working. Unfortunately the latest version shows a splash screen and hangs, perhaps due to some missing EFI support.

[1] https://wiki.ubuntu.com/FirmwareTestSuite

Changes in v2:
- Add a new patch to indicate 32/64-bit in bdinfo

When testing this series, it does not build on top of u-boot-x86/master.

arch/x86/cpu/built-in.o: In function `get_coreboot_info':
u-boot/arch/x86/cpu/coreboot/tables.c:228: undefined reference to `locate_coreboot_table'
Segmentation fault (core dumped)
Makefile:1769: recipe for target 'u-boot' failed
make: *** [u-boot] Error 139
make: *** Deleting file 'u-boot'

Please take a look.

Regards,
Bin