Skip to contentSkip to conversation

SATA framework and FSL SATA support patch set

PATCH Superseded Dave Liu 3 participants 6 messages Mar 20, 2008 – Mar 26, 2008

v2 of 4 Superseded Latest is v4 →

lore
Share & tools
lore

Dave Liu

author
#0 lore raw

v2 cover SATA framework and FSL SATA support patch set

Hello all,

The patch set include two parts:
1. SATA framework support
2. The Freescale SATA controller support

I hope these patches to go v1.3.3.

Thanks,
Dave

The following changes since commit 23e20aa6488e6c0622496549861bfdc74108debe:
Yuri Tikhonov (1):
lwmon5: Fix register test logic to match the specific GDC h/w.

are available in the git repository at:

git://git.ap.freescale.net/git/u-boot.git develop

Anton Vorontsov (1):
mpc83xx: serdes setup routines

Dave Liu (8):
ATA: Add the support for SATA framework
ATA: Add the libata support
ATA: Add the fis struct for SATA
ATA: enable the sata init on bootup
ATA: Add the readme for SATA command line
mpc83xx: enable serdes1 for 837x SATA
drivers: Add the support for Freescale SATA controller
mpc83xx: enable the SATA interface on mpc837xemds board

 board/freescale/mpc837xemds/mpc837xemds.c |    3 +
 common/Makefile                           |    1 +
 common/cmd_sata2.c                        |  206 +++++++
 cpu/mpc83xx/Makefile                      |    2 +-
 cpu/mpc83xx/serdes.c                      |  156 +++++
 disk/part.c                               |   14 +
 disk/part_dos.c                           |    2 +
 disk/part_iso.c                           |    1 +
 doc/README.sata                           |   69 +++
 drivers/block/Makefile                    |    2 +
 drivers/block/fsl_sata.c                  |  921 ++++++++++++++++++++++
+++++++
 drivers/block/fsl_sata.h                  |  374 ++++++++++++
 drivers/block/libata.c                    |  158 +++++
 include/asm-ppc/fsl_serdes.h              |   25 +
 include/configs/MPC837XEMDS.h             |   32 +
 include/fis.h                             |  156 +++++
 include/libata.h                          |  207 +++++++
 include/part.h                            |    3 +
 lib_ppc/board.c                           |    8 +
 19 files changed, 2339 insertions(+), 1 deletions(-)
 create mode 100644 common/cmd_sata2.c
 create mode 100644 cpu/mpc83xx/serdes.c
 create mode 100644 doc/README.sata
 create mode 100644 drivers/block/fsl_sata.c
 create mode 100644 drivers/block/fsl_sata.h
 create mode 100644 drivers/block/libata.c
 create mode 100644 include/asm-ppc/fsl_serdes.h
 create mode 100644 include/fis.h
 create mode 100644 include/libata.h
#1 lore raw

v2 cover SATA framework and FSL SATA support patch set

Dear Dave,

Quoted 4 lines · in message <[email protected]> you wrote:

The patch set include two parts:
1. SATA framework support
2. The Freescale SATA controller support

...

Quoted 2 lines

Dave Liu (8):
ATA: Add the support for SATA framework

Why add new support? We already have some...

Quoted 3 lines
 board/freescale/mpc837xemds/mpc837xemds.c |    3 +
 common/Makefile                           |    1 +
 common/cmd_sata2.c                        |  206 +++++++

Can you please explain why we need a new file common/cmd_sata2.c
which duplicates a lot of functions of the already existing
common/cmd_sata.c ?

I think this needs to be cleaned up. I will not accept multiple similar but conflicting implementations of the very same functions.

I hereby NAK the whole patch series.

Best regards,

Wolfgang Denk

Signature · 6 lines
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Man is the best computer we can put aboard a spacecraft ...  and  the
only one that can be mass produced with unskilled labor.
                                                 -- Wernher von Braun
#2 lore raw

v2 cover SATA framework and FSL SATA support patch set

-----Original Message-----
From: Wolfgang Denk [mailto:wd at denx.de]
Sent: Wed 3/26/2008 7:58 AM
To: Liu Dave
Cc: u-boot-external; Phillips Kim
Subject: Re: [PATCH V2 0/9] SATA framework and FSL SATA support patch set

Dear Dave,

Quoted 4 lines · in message <[email protected]> you wrote:

The patch set include two parts:
1. SATA framework support
2. The Freescale SATA controller support

...

Quoted 2 lines

Dave Liu (8):
ATA: Add the support for SATA framework

Why add new support? We already have some...

[dave] really, I didn't find any SATA framework support in u-boot. if you are saying the cmd_sata.c. I don't agree it.

Quoted 3 lines
 board/freescale/mpc837xemds/mpc837xemds.c |    3 +
 common/Makefile                           |    1 +
 common/cmd_sata2.c                        |  206 +++++++

Can you please explain why we need a new file common/cmd_sata2.c
which duplicates a lot of functions of the already existing
common/cmd_sata.c ?

[dave]the common/cmd_sata.c is more likely controller specificed driver, not sata framework. the cmd_sata2.c is more generic. can connect to different SATA controller driver.

I think this needs to be cleaned up. I will not accept multiple similar but conflicting implementations of the very same functions.

[dave]after the cmd_sata2.c is merge, I plan to move the cmd_sata.c to drivers/block.

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.denx.de/pipermail/u-boot/attachments/20080326/fb2b4fdb/attachment.htm

#3 lore raw

v2 cover SATA framework and FSL SATA support patch set

Dear Dave,

Quoted 15 lines · in message <58A20A281BAF1047B4EAE68DE5C0BDC2C821F5@zch01exm21.fsl.freescale.net…

-----Original Message-----
From: Wolfgang Denk [mailto:wd at denx.de]
Sent: Wed 3/26/2008 7:58 AM
To: Liu Dave
Cc: u-boot-external; Phillips Kim
Subject: Re: [PATCH V2 0/9] SATA framework and FSL SATA support patch > set

Dear Dave,

Quoted 4 lines · in message <[email protected]> you wrote:

The patch set include two parts:
1. SATA framework support
2. The Freescale SATA controller support

Quoted 8 lines

...

Quoted 2 lines

Dave Liu (8):
ATA: Add the support for SATA framework

Why add new support? We already have some...

[dave] really, I didn't find any SATA framework support in u-boot. if you are saying the cmd_sata.c. I don't agree it.

Your message is extremely difficult to read. Can you please use proper quoting? Please read http://www.netmeister.org/news/learn2quote.html
if you need help...

Quoted 11 lines
Quoted 3 lines
 board/freescale/mpc837xemds/mpc837xemds.c |    3 +
 common/Makefile                           |    1 +
 common/cmd_sata2.c                        |  206 +++++++

Can you please explain why we need a new file common/cmd_sata2.c
which duplicates a lot of functions of the already existing
common/cmd_sata.c ?

[dave]the common/cmd_sata.c is more likely controller specificed driver, not sata framework. the cmd_sata2.c is more generic. can connect to different SATA controller driver.

Maybe. But still both the existing common/cmd_sata.c and your new cmd_sata2.c implement the very same functions (like do_sata()) with more or less the same sub-commands etc.

Quoted 4 lines

I think this needs to be cleaned up. I will not accept multiple similar but conflicting implementations of the very same functions.

[dave]after the cmd_sata2.c is merge, I plan to move the cmd_sata.c to drivers/block.

Sorry, but this will not work. I will not add such duplicated code. Please add command level stuff to the (existing) common/cmd_sata.c file and do not add any new cmd_sata2.c which duplicates it. If necessary, clean up the code while you're there.

Best regards,

Wolfgang Denk

Signature · 4 lines
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Whom the gods would destroy, they first teach BASIC.
#4 lore raw

v2 cover SATA framework and FSL SATA support patch set

Your message is extremely difficult to read. Can you please use proper quoting? Please read http://www.netmeister.org/news/learn2quote.html
if you need help...

[dave] sorry for that, I'm using the webmail to access my mailbox. the webmail is stupid.

Quoted 3 lines

[dave]the common/cmd_sata.c is more likely controller specificed driver, not sata framework. the cmd_sata2.c is more generic. can connect to different SATA controller driver.

Maybe. But still both the existing common/cmd_sata.c and your new cmd_sata2.c implement the very same functions (like do_sata()) with more or less the same sub-commands etc.

[dave] I think the same part is focusing on command line.

Quoted 4 lines

I think this needs to be cleaned up. I will not accept multiple similar but conflicting implementations of the very same functions.

[dave]after the cmd_sata2.c is merge, I plan to move the cmd_sata.c to drivers/block.

Sorry, but this will not work. I will not add such duplicated code. Please add command level stuff to the (existing) common/cmd_sata.c file and do not add any new cmd_sata2.c which duplicates it. If necessary, clean up the code while you're there.

[dave] if I choose current command/cmd_sata.c, and don't move the drivers part of cmd_sata.c to drivers/block. I think it will add extra-space for my image. so, the best choice is move the drivers part of cmd_sata.c to drivers/block. what do you think about it?
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.denx.de/pipermail/u-boot/attachments/20080326/8743a5e6/attachment.htm

#5 lore raw

v2 cover SATA framework and FSL SATA support patch set

Dear Dave,

Quoted 3 lines · in message <58A20A281BAF1047B4EAE68DE5C0BDC2C821F6@zch01exm21.fsl.freescale.net…

[dave] sorry for that, I'm using the webmail to access my mailbox. the webmail is stupid.

I see :-(

Quoted 5 lines

Maybe. But still both the existing common/cmd_sata.c and your new cmd_sata2.c implement the very same functions (like do_sata()) with more or less the same sub-commands etc.

[dave] I think the same part is focusing on command line.

Not only. I think implementations of functions like sata_read() or sata_write() should be generic enough and not need to be duplicated.

Quoted 4 lines

[dave] if I choose current command/cmd_sata.c, and don't move the drivers part of cmd_sata.c to drivers/block. I think it will add extra-space for my image. so, the best choice is move the drivers part of cmd_sata.c to drivers/block. what do you think about it?

Probably you are right.

Best regards,

Wolfgang Denk

Signature · 5 lines
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
No one may kill a man.  Not for any purpose.  It cannot be condoned.
	-- Kirk, "Spock's Brain", stardate 5431.6