Next June 04:PPC64 randconfig [drivers/usb/host/ohci-hcd.o]
Subsystems (2)
Quoted 11 lines · Jon Smirl
Quoted 8 lines · Subrata Modak
CC
drivers/usb/host/ohci-hcd.o
In file included fromdrivers/usb/host/ohci-hcd.c:1060:drivers/usb/host/ohci-ppc-of.c:242:2: error: #error "No endianess selected for ppc-of-ohci" make[3]: *** [drivers/usb/host/ohci-hcd.o] Error 1
make[2]: *** [drivers/usb/host] Error 2
make[1]: *** [drivers/usb] Error 2
make: *** [drivers] Error 2
Quoted 5 lines
Quoted 2 lines
I reported this earlier, and there were some discussions:
http://groups.google.co.kr/group/linux.kernel/browse_thread/thread/edff9d5572d3d225Proposed patch by Arnd should fix this. It has not been merged.
http://lkml.org/lkml/2009/4/22/49
Correct, it fixes the issue. However, since few changes might have gone to the Kconfig, the patch does not apply cleanly. Below is the patch, just a retake of the earlier one, but on the latest code.
David,
Can you please pickup the following patch ?
---
drivers/usb/host/Kconfig renamed from drivers/usb/host/Kconfig.orig +14 -14
@@ -181,26 +181,26 @@ config USB_OHCI_HCD_PPC_SOC Enables support for the USB controller on the MPC52xx or STB03xxx processor chip. If unsure, say Y. -config USB_OHCI_HCD_PPC_OF - bool "OHCI support for PPC USB controller on OF platform bus" - depends on USB_OHCI_HCD && PPC_OF - default y - ---help--- - Enables support for the USB controller PowerPC present on the - OpenFirmware platform bus. - config USB_OHCI_HCD_PPC_OF_BE - bool "Support big endian HC" - depends on USB_OHCI_HCD_PPC_OF - default y + bool "OHCI support for OF platform bus (big endian)" + depends on USB_OHCI_HCD && PPC_OF select USB_OHCI_BIG_ENDIAN_DESC select USB_OHCI_BIG_ENDIAN_MMIO + ---help--- + Enables support for big-endian USB controllers present on the + OpenFirmware platform bus. config USB_OHCI_HCD_PPC_OF_LE - bool "Support little endian HC" - depends on USB_OHCI_HCD_PPC_OF - default n + bool "OHCI support for OF platform bus (little endian)" + depends on USB_OHCI_HCD && PPC_OF select USB_OHCI_LITTLE_ENDIAN + ---help--- + Enables support for little-endian USB controllers present on the + OpenFirmware platform bus. + + config USB_OHCI_HCD_PPC_OF + bool + default USB_OHCI_HCD_PPC_OF_BE || USB_OHCI_HCD_PPC_OF_LE config USB_OHCI_HCD_PCI bool "OHCI support for PCI-bus USB controllers"
---
Regards--
Subrata
Quoted 1 line
Quoted 17 lines · Subrata Modak
Quoted 11 lines · Jon Smirl
Quoted 8 lines · Subrata Modak
CC
drivers/usb/host/ohci-hcd.o
In file included fromdrivers/usb/host/ohci-hcd.c:1060:drivers/usb/host/ohci-ppc-of.c:242:2: error: #error "No endianess selected for ppc-of-ohci" make[3]: *** [drivers/usb/host/ohci-hcd.o] Error 1
make[2]: *** [drivers/usb/host] Error 2
make[1]: *** [drivers/usb] Error 2
make: *** [drivers] Error 2Quoted 5 lines
Quoted 2 lines
I reported this earlier, and there were some discussions:
http://groups.google.co.kr/group/linux.kernel/browse_thread/thread/edff9d5572d3d225Proposed patch by Arnd should fix this. It has not been merged.
http://lkml.org/lkml/2009/4/22/49
Quoted 7 lines
Correct, it fixes the issue. However, since few changes might have gone to the
Kconfig, the patch does not apply cleanly. Below is the patch, just a retake of the earlier one, but on the latest code.David,
Can you please pickup the following patch ?
David,
Is it you who will be merging this patch. Or, do i need to send it to somebody else ?
Regards--
Subrata
Quoted 50 lines
Signed-off-by Arnd Bergmann <[email protected]>,Resent-by Subrata Modak <[email protected]>---
drivers/usb/host/Kconfig renamed from drivers/usb/host/Kconfig.orig +14
-15@@ -181,26 +181,26 @@ config USB_OHCI_HCD_PPC_SOC Enables support for the USB controller on the MPC52xx or STB03xxx processor chip. If unsure, say Y. -config USB_OHCI_HCD_PPC_OF - bool "OHCI support for PPC USB controller on OF platform bus" - depends on USB_OHCI_HCD && PPC_OF - default y - ---help--- - Enables support for the USB controller PowerPC present on the - OpenFirmware platform bus. - config USB_OHCI_HCD_PPC_OF_BE - bool "Support big endian HC" - depends on USB_OHCI_HCD_PPC_OF - default y + bool "OHCI support for OF platform bus (big endian)" + depends on USB_OHCI_HCD && PPC_OF select USB_OHCI_BIG_ENDIAN_DESC select USB_OHCI_BIG_ENDIAN_MMIO + ---help--- + Enables support for big-endian USB controllers present on the + OpenFirmware platform bus. config USB_OHCI_HCD_PPC_OF_LE - bool "Support little endian HC" - depends on USB_OHCI_HCD_PPC_OF - default n + bool "OHCI support for OF platform bus (little endian)" + depends on USB_OHCI_HCD && PPC_OF select USB_OHCI_LITTLE_ENDIAN + ---help--- + Enables support for little-endian USB controllers present on the + OpenFirmware platform bus. + + config USB_OHCI_HCD_PPC_OF + bool + default USB_OHCI_HCD_PPC_OF_BE || USB_OHCI_HCD_PPC_OF_LE config USB_OHCI_HCD_PCI bool "OHCI support for PCI-bus USB controllers" ---
Quoted 3 lines
Regards--
SubrataQuoted 1 line
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
Quoted 3 lines · Subrata Modak
Correct, it fixes the issue. However, since few changes might have gone to the
Kconfig, the patch does not apply cleanly. Below is the patch, just a retake of the earlier one, but on the latest code.
And it got mangled a bit along the way. Plus, the original one goofed up Kconfig dependency displays ... both issues fixed in this version, against current mainline GIT.
If someone can verify all four PPC/OF/OHCI configs build on on PPC64, I'm OK with it.
- Dave
========== CUT HERE
From: Arnd Bergmann <[email protected]>
Subject: fix build failure for PPC64 randconfig [usb/ohci]
We could just make the USB_OHCI_HCD_PPC_OF option implicit and selected only if at least one of USB_OHCI_HCD_PPC_OF_BE and USB_OHCI_HCD_PPC_OF_LE are set.
[ [email protected]: fix patch manglation and dependencies ]
--- drivers/usb/host/Kconfig | 29 +++++++++++++++-------------- 1 file changed, 15 insertions(+), 14 deletions(-)
drivers/usb/host/Kconfig +15 -14
@@ -180,26 +180,27 @@ config USB_OHCI_HCD_PPC_SOC Enables support for the USB controller on the MPC52xx or STB03xxx processor chip. If unsure, say Y. -config USB_OHCI_HCD_PPC_OF - bool "OHCI support for PPC USB controller on OF platform bus" - depends on USB_OHCI_HCD && PPC_OF - default y - ---help--- - Enables support for the USB controller PowerPC present on the - OpenFirmware platform bus. - config USB_OHCI_HCD_PPC_OF_BE - bool "Support big endian HC" - depends on USB_OHCI_HCD_PPC_OF - default y + bool "OHCI support for OF platform bus (big endian)" + depends on USB_OHCI_HCD && PPC_OF select USB_OHCI_BIG_ENDIAN_DESC select USB_OHCI_BIG_ENDIAN_MMIO + ---help--- + Enables support for big-endian USB controllers present on the + OpenFirmware platform bus. config USB_OHCI_HCD_PPC_OF_LE - bool "Support little endian HC" - depends on USB_OHCI_HCD_PPC_OF - default n + bool "OHCI support for OF platform bus (little endian)" + depends on USB_OHCI_HCD && PPC_OF select USB_OHCI_LITTLE_ENDIAN + ---help--- + Enables support for little-endian USB controllers present on the + OpenFirmware platform bus. + +config USB_OHCI_HCD_PPC_OF + bool + depends on USB_OHCI_HCD && PPC_OF + default USB_OHCI_HCD_PPC_OF_BE || USB_OHCI_HCD_PPC_OF_LE config USB_OHCI_HCD_PCI bool "OHCI support for PCI-bus USB controllers"
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
Quoted 5 lines · David Brownell
Quoted 3 lines · Subrata Modak
Correct, it fixes the issue. However, since few changes might have gone to the
Kconfig, the patch does not apply cleanly. Below is the patch, just a retake of the earlier one, but on the latest code.
Quoted 8 lines
And it got mangled a bit along the way. Plus, the original one goofed up
Kconfigdependency displays ... both issues fixed in this version, against current mainline GIT.If someone can verify all four PPC/OF/OHCI configs build on on PPC64, I'm OK with it.
- Dave
Dave,
Sorry for being late. The patch fixes the issue on the latest git for PPC64. Infact, the whole drivers/usb/host/ builds just fine:
linux-2.6 # make drivers/usb/host/
CHK include/linux/version.h
CHK include/linux/utsrelease.h
SYMLINK include/asm -> include/asm-powerpc
CALL scripts/checksyscalls.sh CC drivers/usb/host/ohci-hcd.o CC drivers/usb/host/pci-quirks.o CC drivers/usb/host/uhci-hcd.o LD drivers/usb/host/built-in.o CC [M] drivers/usb/host/isp116x-hcd.o CC [M] drivers/usb/host/u132-hcd.o
You can check in the patch now.
Regards--
Subrata
Quoted 54 lines
========== CUT HERE
From: Arnd Bergmann <[email protected]>
Subject: fix build failure for PPC64 randconfig [usb/ohci]We could just make the
USB_OHCI_HCD_PPC_OFoption implicit and selected only if at least one ofUSB_OHCI_HCD_PPC_OF_BEandUSB_OHCI_HCD_PPC_OF_LEare set.[ [email protected]: fix patch manglation and dependencies ]
Signed-off-by Arnd Bergmann <[email protected]>Resent-by Subrata Modak <[email protected]>Signed-off-by David Brownell <[email protected]>--- drivers/usb/host/Kconfig | 29 +++++++++++++++-------------- 1 file changed, 15 insertions(+), 14 deletions(-)drivers/usb/host/Kconfig +8
-14@@ -180,26 +180,27 @@ config USB_OHCI_HCD_PPC_SOC Enables support for the USB controller on the MPC52xx or STB03xxx processor chip. If unsure, say Y. -config USB_OHCI_HCD_PPC_OF - bool "OHCI support for PPC USB controller on OF platform bus" - depends on USB_OHCI_HCD && PPC_OF - default y - ---help--- - Enables support for the USB controller PowerPC present on the - OpenFirmware platform bus. - config USB_OHCI_HCD_PPC_OF_BE - bool "Support big endian HC" - depends on USB_OHCI_HCD_PPC_OF - default y + bool "OHCI support for OF platform bus (big endian)" + depends on USB_OHCI_HCD && PPC_OF select USB_OHCI_BIG_ENDIAN_DESC select USB_OHCI_BIG_ENDIAN_MMIO + ---help--- + Enables support for big-endian USB controllers present on the + OpenFirmware platform bus. config USB_OHCI_HCD_PPC_OF_LE - bool "Support little endian HC" - depends on USB_OHCI_HCD_PPC_OF - default n + bool "OHCI support for OF platform bus (little endian)" + depends on USB_OHCI_HCD && PPC_OF select USB_OHCI_LITTLE_ENDIAN + ---help---
drivers/usb/host/Kconfig config USB_OHCI_HCD_PPC_SOC · line 206
Quoted 10 lines
drivers/usb/host/Kconfig +7
-0+ Enables support for little-endian USB controllers present on the + OpenFirmware platform bus. + +config USB_OHCI_HCD_PPC_OF + bool + depends on USB_OHCI_HCD && PPC_OF + default USB_OHCI_HCD_PPC_OF_BE || USB_OHCI_HCD_PPC_OF_LE config USB_OHCI_HCD_PCI bool "OHCI support for PCI-bus USB controllers"
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
Quoted 32 lines · Subrata Modak
Quoted 5 lines · David Brownell
Quoted 3 lines · Subrata Modak
Correct, it fixes the issue. However, since few changes might have gone to the
Kconfig, the patch does not apply cleanly. Below is the patch, just a retake of the earlier one, but on the latest code.Quoted 8 lines
And it got mangled a bit along the way. Plus, the original one goofed up
Kconfigdependency displays ... both issues fixed in this version, against current mainline GIT.If someone can verify all four PPC/OF/OHCI configs build on on PPC64, I'm OK with it.
- Dave
Dave,
Sorry for being late. The patch fixes the issue on the latest git for PPC64. Infact, the whole
drivers/usb/host/builds just fine:linux-2.6 # make
drivers/usb/host/
CHKinclude/linux/version.h
CHKinclude/linux/utsrelease.h
SYMLINKinclude/asm->include/asm-powerpcCALL scripts/checksyscalls.sh CC drivers/usb/host/ohci-hcd.o CC drivers/usb/host/pci-quirks.o CC drivers/usb/host/uhci-hcd.o LD drivers/usb/host/built-in.o CC [M] drivers/usb/host/isp116x-hcd.o CC [M] drivers/usb/host/u132-hcd.o
Quoted 1 line
You can check in the patch now.
Dave,
Have you checked in this patch ? Or, does it require some more modification/updates from somebody´s side ?
Regards--
Subrata
Quoted 65 lines
Regards--
SubrataQuoted 61 lines
========== CUT HERE
From: Arnd Bergmann <[email protected]>
Subject: fix build failure for PPC64 randconfig [usb/ohci]We could just make the
USB_OHCI_HCD_PPC_OFoption implicit and selected only if at least one ofUSB_OHCI_HCD_PPC_OF_BEandUSB_OHCI_HCD_PPC_OF_LEare set.[ [email protected]: fix patch manglation and dependencies ]
Signed-off-by Arnd Bergmann <[email protected]>Resent-by Subrata Modak <[email protected]>Signed-off-by David Brownell <[email protected]>--- drivers/usb/host/Kconfig | 29 +++++++++++++++-------------- 1 file changed, 15 insertions(+), 14 deletions(-)drivers/usb/host/Kconfig +15
-14@@ -180,26 +180,27 @@ config USB_OHCI_HCD_PPC_SOC Enables support for the USB controller on the MPC52xx or STB03xxx processor chip. If unsure, say Y. -config USB_OHCI_HCD_PPC_OF - bool "OHCI support for PPC USB controller on OF platform bus" - depends on USB_OHCI_HCD && PPC_OF - default y - ---help--- - Enables support for the USB controller PowerPC present on the - OpenFirmware platform bus. - config USB_OHCI_HCD_PPC_OF_BE - bool "Support big endian HC" - depends on USB_OHCI_HCD_PPC_OF - default y + bool "OHCI support for OF platform bus (big endian)" + depends on USB_OHCI_HCD && PPC_OF select USB_OHCI_BIG_ENDIAN_DESC select USB_OHCI_BIG_ENDIAN_MMIO + ---help--- + Enables support for big-endian USB controllers present on the + OpenFirmware platform bus. config USB_OHCI_HCD_PPC_OF_LE - bool "Support little endian HC" - depends on USB_OHCI_HCD_PPC_OF - default n + bool "OHCI support for OF platform bus (little endian)" + depends on USB_OHCI_HCD && PPC_OF select USB_OHCI_LITTLE_ENDIAN + ---help--- + Enables support for little-endian USB controllers present on the + OpenFirmware platform bus. + +config USB_OHCI_HCD_PPC_OF + bool + depends on USB_OHCI_HCD && PPC_OF + default USB_OHCI_HCD_PPC_OF_BE || USB_OHCI_HCD_PPC_OF_LE
Quoted 3 lines
drivers/usb/host/Kconfig config USB_OHCI_HCD_PPC_SOC · line 206
Quoted 3 lines
drivers/usb/host/Kconfig +0
-0config USB_OHCI_HCD_PCI bool "OHCI support for PCI-bus USB controllers"
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
PATCH 2/4 Next June 04:PPC64 randconfig [drivers/usb/host/ohci-hcd.o]
Quoted 33 lines · Subrata Modak
Quoted 32 lines · Subrata Modak
Quoted 5 lines · David Brownell
Quoted 3 lines · Subrata Modak
Correct, it fixes the issue. However, since few changes might have gone to the
Kconfig, the patch does not apply cleanly. Below is the patch, just a retake of the earlier one, but on the latest code.Quoted 8 lines
And it got mangled a bit along the way. Plus, the original one goofed up
Kconfigdependency displays ... both issues fixed in this version, against current mainline GIT.If someone can verify all four PPC/OF/OHCI configs build on on PPC64, I'm OK with it.
- Dave
Dave,
Sorry for being late. The patch fixes the issue on the latest git for PPC64. Infact, the whole
drivers/usb/host/builds just fine:linux-2.6 # make
drivers/usb/host/
CHKinclude/linux/version.h
CHKinclude/linux/utsrelease.h
SYMLINKinclude/asm->include/asm-powerpcCALL scripts/checksyscalls.sh CC drivers/usb/host/ohci-hcd.o CC drivers/usb/host/pci-quirks.o CC drivers/usb/host/uhci-hcd.o LD drivers/usb/host/built-in.o CC [M] drivers/usb/host/isp116x-hcd.o CC [M] drivers/usb/host/u132-hcd.o
Quoted 7 lines
Quoted 1 line
You can check in the patch now.
Dave,
Have you checked in this patch ? Or, does it require some more modification/updates from somebody´s side ?
Dave,
Would you consider checking in this patch ?
Regards--
Subrata
Quoted 68 lines
Regards--
SubrataQuoted 65 lines
Regards--
SubrataQuoted 61 lines
========== CUT HERE
From: Arnd Bergmann <[email protected]>
Subject: fix build failure for PPC64 randconfig [usb/ohci]We could just make the
USB_OHCI_HCD_PPC_OFoption implicit and selected only if at least one ofUSB_OHCI_HCD_PPC_OF_BEandUSB_OHCI_HCD_PPC_OF_LEare set.[ [email protected]: fix patch manglation and dependencies ]
Signed-off-by Arnd Bergmann <[email protected]>Resent-by Subrata Modak <[email protected]>Signed-off-by David Brownell <[email protected]>--- drivers/usb/host/Kconfig | 29 +++++++++++++++-------------- 1 file changed, 15 insertions(+), 14 deletions(-)drivers/usb/host/Kconfig +15
-14@@ -180,26 +180,27 @@ config USB_OHCI_HCD_PPC_SOC Enables support for the USB controller on the MPC52xx or STB03xxx processor chip. If unsure, say Y. -config USB_OHCI_HCD_PPC_OF - bool "OHCI support for PPC USB controller on OF platform bus" - depends on USB_OHCI_HCD && PPC_OF - default y - ---help--- - Enables support for the USB controller PowerPC present on the - OpenFirmware platform bus. - config USB_OHCI_HCD_PPC_OF_BE - bool "Support big endian HC" - depends on USB_OHCI_HCD_PPC_OF - default y + bool "OHCI support for OF platform bus (big endian)" + depends on USB_OHCI_HCD && PPC_OF select USB_OHCI_BIG_ENDIAN_DESC select USB_OHCI_BIG_ENDIAN_MMIO + ---help--- + Enables support for big-endian USB controllers present on the + OpenFirmware platform bus. config USB_OHCI_HCD_PPC_OF_LE - bool "Support little endian HC" - depends on USB_OHCI_HCD_PPC_OF - default n + bool "OHCI support for OF platform bus (little endian)" + depends on USB_OHCI_HCD && PPC_OF select USB_OHCI_LITTLE_ENDIAN + ---help--- + Enables support for little-endian USB controllers present on the + OpenFirmware platform bus. + +config USB_OHCI_HCD_PPC_OF + bool + depends on USB_OHCI_HCD && PPC_OF + default USB_OHCI_HCD_PPC_OF_BE || USB_OHCI_HCD_PPC_OF_LE
Quoted 3 lines
Quoted 3 lines
drivers/usb/host/Kconfig config USB_OHCI_HCD_PPC_SOC · line 206
Quoted 3 lines
drivers/usb/host/Kconfig +0
-0config USB_OHCI_HCD_PCI bool "OHCI support for PCI-bus USB controllers"
_______________________________________________
Linuxppc-dev mailing list
[email protected]
https://lists.ozlabs.org/listinfo/linuxppc-dev
Quoted 38 lines · Subrata Modak
Quoted 37 lines · Subrata Modak
Quoted 32 lines · Subrata Modak
Quoted 5 lines · David Brownell
Quoted 3 lines · Subrata Modak
Correct, it fixes the issue. However, since few changes might have gone to the
Kconfig, the patch does not apply cleanly. Below is the patch, just a retake of the earlier one, but on the latest code.Quoted 8 lines
And it got mangled a bit along the way. Plus, the original one goofed up
Kconfigdependency displays ... both issues fixed in this version, against current mainline GIT.If someone can verify all four PPC/OF/OHCI configs build on on PPC64, I'm OK with it.
- Dave
Dave,
Sorry for being late. The patch fixes the issue on the latest git for PPC64. Infact, the whole
drivers/usb/host/builds just fine:linux-2.6 # make
drivers/usb/host/
CHKinclude/linux/version.h
CHKinclude/linux/utsrelease.h
SYMLINKinclude/asm->include/asm-powerpc
CALL scripts/checksyscalls.sh
CC drivers/usb/host/ohci-hcd.o
CC drivers/usb/host/pci-quirks.o
CC drivers/usb/host/uhci-hcd.o
LD drivers/usb/host/built-in.o
CC [M] drivers/usb/host/isp116x-hcd.o
CC [M] drivers/usb/host/u132-hcd.oQuoted 1 line
You can check in the patch now.
Dave,
Quoted 7 lines
Quoted 3 lines
Have you checked in this patch ? Or, does it require some more modification/updates from somebody´s side ?
Dave,
Would you consider checking in this patch ?
Hold off please; give me a couple of hours to investigate.
g.
Signature · 2 lines
Grant Likely, B.Sc., P.Eng. Secret Lab Technologies Ltd.
Quoted 44 lines · Grant Likely
Quoted 42 lines · Subrata Modak
Quoted 40 lines · Subrata Modak
Quoted 32 lines · Subrata Modak
Quoted 5 lines · David Brownell
Quoted 3 lines · Subrata Modak
Correct, it fixes the issue. However, since few changes might have gone to the
Kconfig, the patch does not apply cleanly. Below is the patch, just a retake of the earlier one, but on the latest code.Quoted 8 lines
And it got mangled a bit along the way. Plus, the original one goofed up
Kconfigdependency displays ... both issues fixed in this version, against current mainline GIT.If someone can verify all four PPC/OF/OHCI configs build on on PPC64, I'm OK with it.
- Dave
Dave,
Sorry for being late. The patch fixes the issue on the latest git for PPC64. Infact, the whole
drivers/usb/host/builds just fine:linux-2.6 # make
drivers/usb/host/
CHKinclude/linux/version.h
CHKinclude/linux/utsrelease.h
SYMLINKinclude/asm->include/asm-powerpc
CALL scripts/checksyscalls.sh
CC drivers/usb/host/ohci-hcd.o
CC drivers/usb/host/pci-quirks.o
CC drivers/usb/host/uhci-hcd.o
LD drivers/usb/host/built-in.o
CC [M] drivers/usb/host/isp116x-hcd.o
CC [M] drivers/usb/host/u132-hcd.oQuoted 1 line
You can check in the patch now.
Dave,
Have you checked in this patch ? Or, does it require some more modification/updates from somebody´s side ?
Quoted 5 lines
Quoted 3 lines
Dave,
Would you consider checking in this patch ?
Hold off please; give me a couple of hours to investigate.
Never mind; I replied to the wrong email. Please ignore my comments.
g.
Signature · 2 lines
Grant Likely, B.Sc., P.Eng. Secret Lab Technologies Ltd.