Add support for the IGEP v2 board.
v2 cover Add support for the IGEP v2 board.
Hello,
This is the second version of patch series to add initial support for OMAP3 IGEP v2 board. Thanks Steve for your comments.
Changes since v1:
- [2/3] fix parens in NUMONYX_V_ACTIMB_165 define
- [3/3] add extra space after first &ctrl_base in file igep0020.c
- [3/3] add a space after the 57600 comma in file igep0020.h
- [3/3] remove CONFIG_SYS_ARM_WITHOUT_RELOC undef
$ git diff --stat origin/master MAKEALL | 1 + arch/arm/include/asm/arch-omap3/mem.h | 42 ++++++ board/isee/igep0020/Makefile | 49 +++++++ board/isee/igep0020/config.mk | 33 +++++ board/isee/igep0020/igep0020.c | 128 ++++++++++++++++++ board/isee/igep0020/igep0020.h | 156 ++++++++++++++++++++++ boards.cfg | 1 + drivers/mtd/onenand/onenand_base.c | 1 + include/configs/igep0020.h | 228 +++++++++++++++++++++++++++++++++ include/linux/mtd/onenand.h | 1 + 10 files changed, 640 insertions(+), 0 deletions(-)
PATCH v2 1/3 mtd: OneNAND: add support for OneNAND manufactured by Numonyx
This patch adds the Numonyx manufacturer code (0x20) to onenand manufacturers.
--- drivers/mtd/onenand/onenand_base.c | 1 + include/linux/mtd/onenand.h | 1 + 2 files changed, 2 insertions(+), 0 deletions(-)
drivers/mtd/onenand/onenand_base.c +1 -0
@@ -2214,6 +2214,7 @@ char *onenand_print_device_info(int device, int version)static const struct onenand_manufacturers onenand_manuf_ids[] = { {ONENAND_MFR_SAMSUNG ,"Samsung" }, + {ONENAND_MFR_NUMONYX ,"Numonyx" }, };/**
include/linux/mtd/onenand.h +1 -0
@@ -155,6 +155,7 @@ struct onenand_chip {* OneNAND Flash Manufacturer ID Codes */ #define ONENAND_MFR_SAMSUNG 0xec +#define ONENAND_MFR_NUMONYX 0x20/** * struct nand_manufacturers - NAND Flash Manufacturer ID Structure
Signature · 1 line
1.7.0.4
PATCH v2 1/3 mtd: OneNAND: add support for OneNAND manufactured by Numonyx
Dear Enric Balletbo i Serra,
Quoted 14 lines · In message <[email protected]> you wrote:
This patch adds the Numonyx manufacturer code (
0x20) to onenand manufacturers.Signed-off-by Enric Balletbo i Serra <[email protected]>--- drivers/mtd/onenand/onenand_base.c | 1 + include/linux/mtd/onenand.h | 1 + 2 files changed, 2 insertions(+), 0 deletions(-)drivers/mtd/onenand/onenand_base.c +0
-0
drivers/mtd/onenand/onenand_base.c char *onenand_print_device_info(int device, int version) · line 2218
Quoted 5 lines
drivers/mtd/onenand/onenand_base.c +1
-0@@ -2214,6 +2214,7 @@ char *onenand_print_device_info(int device, int version)static const struct onenand_manufacturers onenand_manuf_ids[] = { {ONENAND_MFR_SAMSUNG ,"Samsung" }, + {ONENAND_MFR_NUMONYX ,"Numonyx" }, };
Can we please keep lists like this...
include/linux/mtd/onenand.h struct onenand_chip { · line 158
Quoted 9 lines
include/linux/mtd/onenand.h +1
-0@@ -155,6 +155,7 @@ struct onenand_chip {* OneNAND Flash Manufacturer ID Codes */ #define ONENAND_MFR_SAMSUNG 0xec +#define ONENAND_MFR_NUMONYX 0x20
...and this sorted? Thanks.
Best regards,
Wolfgang Denk
Signature · 6 lines
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de Genius doesn't work on an assembly line basis. You can't simply say, "Today I will be brilliant." -- Kirk, "The Ultimate Computer", stardate 4731.3
PATCH v2 2/3 OMAP3: SDRC: Introduce Numonyx DDR type
In reply to Enric Balletbo i SerraIntroduce Numonyx DDR timings and provide CONFIG_OMAP3_NUMONYX_DDR config options to allow for platform files to setup their timings.
--- arch/arm/include/asm/arch-omap3/mem.h | 42 +++++++++++++++++++++++++++++++++ 1 files changed, 42 insertions(+), 0 deletions(-)
arch/arm/include/asm/arch-omap3/mem.h +42 -0
@@ -128,6 +128,44 @@ enum { (MICRON_XSR_165 << 0) | (MICRON_TXP_165 << 8) | \ (MICRON_TWTR_165 << 16)) +/* NUMONYX part of IGEP v2 (165MHz optimized) 6.06ns +* ACTIMA +* TDAL = Twr/Tck + Trp/tck = 15/6 + 18/6 = 2.5 + 3 = 5.5 -> 6 +* TDPL (Twr) = 15/6 = 2.5 -> 3 +* TRRD = 12/6 = 2 +* TRCD = 22.5/6 = 3.75 -> 4 +* TRP = 18/6 = 3 +* TRAS = 42/6 = 7 +* TRC = 60/6 = 10 +* TRFC = 140/6 = 23.3 -> 24 +* ACTIMB +* TWTR = 2 +* TCKE = 2 +* TXSR = 200/6 = 33.3 -> 34 +* TXP = 1.0 + 1.1 = 2.1 -> 3 +*/ +#define NUMONYX_TDAL_165 6 +#define NUMONYX_TDPL_165 3 +#define NUMONYX_TRRD_165 2 +#define NUMONYX_TRCD_165 4 +#define NUMONYX_TRP_165 3 +#define NUMONYX_TRAS_165 7 +#define NUMONYX_TRC_165 10 +#define NUMONYX_TRFC_165 24 +#define NUMONYX_V_ACTIMA_165 ((NUMONYX_TRFC_165 << 27) | \ + (NUMONYX_TRC_165 << 22) | (NUMONYX_TRAS_165 << 18) | \ + (NUMONYX_TRP_165 << 15) | (NUMONYX_TRCD_165 << 12) | \ + (NUMONYX_TRRD_165 << 9) | (NUMONYX_TDPL_165 << 6) | \ + (NUMONYX_TDAL_165)) + +#define NUMONYX_TWTR_165 2 +#define NUMONYX_TCKE_165 2 +#define NUMONYX_TXP_165 3 +#define NUMONYX_XSR_165 34 +#define NUMONYX_V_ACTIMB_165 ((NUMONYX_TCKE_165 << 12) | \ + (NUMONYX_XSR_165 << 0) | (NUMONYX_TXP_165 << 8) | \ + (NUMONYX_TWTR_165 << 16)) +#ifdef CONFIG_OMAP3_INFINEON_DDR #define V_ACTIMA_165 INFINEON_V_ACTIMA_165#define V_ACTIMB_165 INFINEON_V_ACTIMB_165
@@ -136,6 +174,10 @@ enum {#define V_ACTIMA_165 MICRON_V_ACTIMA_165#define V_ACTIMB_165 MICRON_V_ACTIMB_165#endif +#ifdef CONFIG_OMAP3_NUMONYX_DDR +#define V_ACTIMA_165 NUMONYX_V_ACTIMA_165 +#define V_ACTIMB_165 NUMONYX_V_ACTIMB_165 +#endif #if !defined(V_ACTIMA_165 ) || !defined(V_ACTIMB_165 )#error "Please choose the right DDR type in config header"
Signature · 1 line
1.7.0.4
PATCH v2 2/3 OMAP3: SDRC: Introduce Numonyx DDR type
Dear Enric Balletbo i Serra,
Quoted 13 lines · In message <[email protected]> you wrote:
Introduce Numonyx DDR timings and provide
CONFIG_OMAP3_NUMONYX_DDRconfig options to allow for platform files to setup their timings.Signed-off-by Enric Balletbo i Serra <[email protected]>--- arch/arm/include/asm/arch-omap3/mem.h | 42 +++++++++++++++++++++++++++++++++ 1 files changed, 42 insertions(+), 0 deletions(-)arch/arm/include/asm/arch-omap3/mem.h +0
-0
arch/arm/include/asm/arch-omap3/mem.h enum { · line 132
Quoted 5 lines
arch/arm/include/asm/arch-omap3/mem.h +2
-0@@ -128,6 +128,44 @@ enum { (MICRON_XSR_165 <<0 ) | (MICRON_TXP_165 <<8 ) | \ (MICRON_TWTR_165 << 16)) +/* NUMONYX part of IGEP v2 (165MHz optimized) 6.06ns +* ACTIMA
Incorrect multiline comment style. Please break into:
/* * NUMONYX part ...
Quoted 40 lines
arch/arm/include/asm/arch-omap3/mem.h +36
-0+* TDAL = Twr/Tck + Trp/tck = 15/6 + 18/6 = 2.5 + 3 = 5.5 -> 6 +* TDPL (Twr) = 15/6 = 2.5 -> 3 +* TRRD = 12/6 = 2 +* TRCD = 22.5/6 = 3.75 -> 4 +* TRP = 18/6 = 3 +* TRAS = 42/6 = 7 +* TRC = 60/6 = 10 +* TRFC = 140/6 = 23.3 -> 24 +* ACTIMB +* TWTR = 2 +* TCKE = 2 +* TXSR = 200/6 = 33.3 -> 34 +* TXP = 1.0 + 1.1 = 2.1 -> 3 +*/ +#define NUMONYX_TDAL_165 6 +#define NUMONYX_TDPL_165 3 +#define NUMONYX_TRRD_165 2 +#define NUMONYX_TRCD_165 4 +#define NUMONYX_TRP_165 3 +#define NUMONYX_TRAS_165 7 +#define NUMONYX_TRC_165 10 +#define NUMONYX_TRFC_165 24 +#define NUMONYX_V_ACTIMA_165 ((NUMONYX_TRFC_165 << 27) | \ + (NUMONYX_TRC_165 << 22) | (NUMONYX_TRAS_165 << 18) | \ + (NUMONYX_TRP_165 << 15) | (NUMONYX_TRCD_165 << 12) | \ + (NUMONYX_TRRD_165 << 9) | (NUMONYX_TDPL_165 << 6) | \ + (NUMONYX_TDAL_165)) + +#define NUMONYX_TWTR_165 2 +#define NUMONYX_TCKE_165 2 +#define NUMONYX_TXP_165 3 +#define NUMONYX_XSR_165 34 +#define NUMONYX_V_ACTIMB_165 ((NUMONYX_TCKE_165 << 12) | \ + (NUMONYX_XSR_165 << 0) | (NUMONYX_TXP_165 << 8) | \ + (NUMONYX_TWTR_165 << 16)) +#ifdef CONFIG_OMAP3_INFINEON_DDR #define V_ACTIMA_165 INFINEON_V_ACTIMA_165#define V_ACTIMB_165 INFINEON_V_ACTIMB_165
arch/arm/include/asm/arch-omap3/mem.h enum { · line 180
Quoted 7 lines
arch/arm/include/asm/arch-omap3/mem.h +4
-0@@ -136,6 +174,10 @@ enum {#define V_ACTIMA_165 MICRON_V_ACTIMA_165#define V_ACTIMB_165 MICRON_V_ACTIMB_165#endif +#ifdef CONFIG_OMAP3_NUMONYX_DDR +#define V_ACTIMA_165 NUMONYX_V_ACTIMA_165 +#define V_ACTIMB_165 NUMONYX_V_ACTIMB_165 +#endif
You are using exactly the same settings as for the #ifdef CONFIG_OMAP3_MICRON_DDR above. Why do you repeat the lines then? Rather use a "#if defined(...) || defined(...)"
Best regards,
Wolfgang Denk
Signature · 4 lines
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de Often it is fatal to live too long. - Racine
PATCH v2 2/3 OMAP3: SDRC: Introduce Numonyx DDR type
Hi Wolfgang
2010/10/10 Wolfgang Denk <[email protected]>:
Quoted 19 lines
Dear Enric Balletbo i Serra,
Quoted 16 lines · In message <[email protected]> you wrote:
Introduce Numonyx DDR timings and provide
CONFIG_OMAP3_NUMONYX_DDRconfig options to allow for platform files to setup their timings.Signed-off-by Enric Balletbo i Serra <[email protected]>---
?arch/arm/include/asm/arch-omap3/mem.h | ? 42 +++++++++++++++++++++++++++++++++ ?1 files changed, 42 insertions(+), 0 deletions(-)arch/arm/include/asm/arch-omap3/mem.h +0
-0@@ -128,6 +128,44 @@ enum { ? ? ? ? ? ? ? (MICRON_XSR_165 << 0) | (MICRON_TXP_165 << 8) | \ ? ? ? ? ? ? ? (MICRON_TWTR_165 << 16))
Quoted 7 lines
arch/arm/include/asm/arch-omap3/mem.h enum { · line 132
Quoted 2 lines
arch/arm/include/asm/arch-omap3/mem.h +2
-0+/* NUMONYX part of IGEP v2 (165MHz optimized) 6.06ns +* ? ACTIMA Incorrect multiline comment style. Please break into:
? ? ? ?/*
? ? ? ? * NUMONYX part ...
I'll fix in version 3
Quoted 45 lines
Quoted 45 lines
arch/arm/include/asm/arch-omap3/mem.h +36
-0+* ? ? ?TDAL = Twr/Tck + Trp/tck = 15/6 + 18/6 = 2.5 + 3 = 5.5 -> 6 +* ? ? ?TDPL (Twr) = 15/6 = 2.5 -> 3 +* ? ? ?TRRD = 12/6 = 2 +* ? ? ?TRCD = 22.5/6 = 3.75 -> 4 +* ? ? ?TRP ?= 18/6 = 3 +* ? ? ?TRAS = 42/6 = 7 +* ? ? ?TRC ?= 60/6 = 10 +* ? ? ?TRFC = 140/6 = 23.3 -> 24 +* ? ACTIMB +* ? TWTR = 2 +* ? TCKE = 2 +* ? TXSR = 200/6 = ?33.3 -> 34 +* ? TXP ?= 1.0 + 1.1 = 2.1 -> 3 +*/ +#define NUMONYX_TDAL_165 ? 6 +#define NUMONYX_TDPL_165 ? 3 +#define NUMONYX_TRRD_165 ? 2 +#define NUMONYX_TRCD_165 ? 4 +#define NUMONYX_TRP_165 ? ?3 +#define NUMONYX_TRAS_165 ? 7 +#define NUMONYX_TRC_165 ? 10 +#define NUMONYX_TRFC_165 ?24 +#define NUMONYX_V_ACTIMA_165 ((NUMONYX_TRFC_165 << 27) | \ + ? ? ? ? ? ? (NUMONYX_TRC_165 << 22) | (NUMONYX_TRAS_165 << 18) | \ + ? ? ? ? ? ? (NUMONYX_TRP_165 << 15) | (NUMONYX_TRCD_165 << 12) | \ + ? ? ? ? ? ? (NUMONYX_TRRD_165 << 9) | (NUMONYX_TDPL_165 << 6) | \ + ? ? ? ? ? ? (NUMONYX_TDAL_165)) + +#define NUMONYX_TWTR_165 ? 2 +#define NUMONYX_TCKE_165 ? 2 +#define NUMONYX_TXP_165 ? ?3 +#define NUMONYX_XSR_165 ? ?34 +#define NUMONYX_V_ACTIMB_165 ((NUMONYX_TCKE_165 << 12) | \ + ? ? ? ? ? ? (NUMONYX_XSR_165 << 0) | (NUMONYX_TXP_165 << 8) | \ + ? ? ? ? ? ? (NUMONYX_TWTR_165 << 16)) +?#ifdef
CONFIG_OMAP3_INFINEON_DDR
?#defineV_ACTIMA_165INFINEON_V_ACTIMA_165
?#defineV_ACTIMB_165INFINEON_V_ACTIMB_165arch/arm/include/asm/arch-omap3/mem.h +0
-0@@ -136,6 +174,10 @@ enum {?#define
V_ACTIMA_165MICRON_V_ACTIMA_165
?#defineV_ACTIMB_165MICRON_V_ACTIMB_165
?#endif
Quoted 8 lines
arch/arm/include/asm/arch-omap3/mem.h enum { · line 180
Quoted 4 lines
arch/arm/include/asm/arch-omap3/mem.h +4
-0+#ifdef CONFIG_OMAP3_NUMONYX_DDR +#define V_ACTIMA_165 NUMONYX_V_ACTIMA_165 +#define V_ACTIMB_165 NUMONYX_V_ACTIMB_165 +#endif You are using exactly the same settings as for the #ifdef
CONFIG_OMAP3_MICRON_DDR?above. Why do you repeat the lines then? Rather use a "#if defined(...) || defined(...)"
I'm not agree the timmings are not the same, here a list of differences
MICRON_TRCD_165(3) != NUMONYX_TRCD_165(4)MICRON_TRFC_165(21) != NUMONYX_TRFC_165(24)MICRON_TWTR_165(1) != NUMONYX_TWTR_165(2)MICRON_TCKE_165(1) != NUMONYX_TCKE_165(2)MICRON_XSR_165(23) != NUMONYX_XSR_165(34)MICRON_TXP_165(5) != NUMONYX_TXP_165(3)
I'll send the version 3 with all your comments except this.
Cheers,
Enric
PATCH v2 2/3 OMAP3: SDRC: Introduce Numonyx DDR type
Dear =?UTF-8?Q?Enric_Balletb=C3=B2_i_Serra?=,
Quoted 14 lines · In message <[email protected]> you…
Quoted 13 lines
arch/arm/include/asm/arch-omap3/mem.h enum { · line 180
Quoted 9 lines
arch/arm/include/asm/arch-omap3/mem.h +4
-0@@ -136,6 +174,10 @@ enum {#define V_ACTIMA_165 MICRON_V_ACTIMA_165#define V_ACTIMB_165 MICRON_V_ACTIMB_165#endif +#ifdef CONFIG_OMAP3_NUMONYX_DDR +#define V_ACTIMA_165 NUMONYX_V_ACTIMA_165 +#define V_ACTIMB_165 NUMONYX_V_ACTIMB_165 +#endif You are using exactly the same settings as for the
#ifdefCONFIG_OMAP3_MICRON_DDRabove. Why do you repeat the lines
then? Rather use a "#if defined(...) || defined(...)"
Quoted 1 line
I'm not agree the timmings are not the same, here a list of differences
Oops. I misread this. Sorry for the confusion.
Best regards,
Wolfgang Denk
Signature · 5 lines
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de "Anyone attempting to generate random numbers by deterministic means is, of course, living in a state of sin." - John Von Neumann
PATCH v2 3/3 OMAP3: Add support for the IGEP v2 board.
In reply to Enric Balletbo i SerraThe IGEP v2 board is a low-cost, fan-less and industrial temperature range single board computer that unleashes laptop-like performance and expandability without the bulk, expense, or noise of typical desktop machines. Its architecture shares much in common with other OMAP3 boards.
--- MAKEALL | 1 + board/isee/igep0020/Makefile | 49 +++++++++ board/isee/igep0020/config.mk | 33 ++++++ board/isee/igep0020/igep0020.c | 128 ++++++++++++++++++++++ board/isee/igep0020/igep0020.h | 156 +++++++++++++++++++++++++++ boards.cfg | 1 + include/configs/igep0020.h | 228 ++++++++++++++++++++++++++++++++++++++++ 7 files changed, 596 insertions(+), 0 deletions(-) create mode 100644 board/isee/igep0020/Makefile create mode 100644 board/isee/igep0020/config.mk create mode 100644 board/isee/igep0020/igep0020.c create mode 100644 board/isee/igep0020/igep0020.h create mode 100644 include/configs/igep0020.h
MAKEALL +1 -0
@@ -490,6 +490,7 @@ LIST_ARM11=" \ LIST_ARMV7=" \ am3517_evm \ devkit8000 \ + igep0020 \ mx51evk \ omap3_beagle \ omap3_overo \
board/isee/igep0020/Makefile new file +49 -0
49 lines not on this page · raw message
board/isee/igep0020/config.mk new file +33 -0
@@ -0,0 +1,33 @@ +# +# (C) Copyright 2009 +# ISEE 2007 SL, <www.iseebcn.com> +# +# IGEP0020 uses OMAP3 (ARM-CortexA8) cpu +# see http://www.ti.com/ for more information on Texas Instruments +# +# See file CREDITS for list of people who contributed to this +# project. +# +# This program is free software; you can redistribute it and/or +# modify it under the terms of the GNU General Public License as +# published by the Free Software Foundation; either version 2 of +# the License, or (at your option) any later version. +# +# This program is distributed in the hope that it will be useful, +# but WITHOUT ANY WARRANTY; without even the implied warranty of +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +# GNU General Public License for more details. +# +# You should have received a copy of the GNU General Public License +# along with this program; if not, write to the Free Software +# Foundation, Inc., 59 Temple Place, Suite 330, Boston, +# MA 02111-1307 USA +# +# Physical Address: +# 8000'0000 (bank0) +# A000/0000 (bank1) +# Linux-Kernel is expected to be at 8000'8000, entry 8000'8000 +# (mem base + reserved) + +# For use with external or internal boots. +TEXT_BASE = 0x80008000
board/isee/igep0020/igep0020.c new file +128 -0
128 lines not on this page · raw message
board/isee/igep0020/igep0020.h new file +156 -0
156 lines not on this page · raw message
boards.cfg +1 -0
@@ -262,6 +262,7 @@ omap4_panda arm armv7 panda ti omap4 omap4_sdp4430 arm armv7 sdp4430 ti omap4 am3517_evm arm armv7 am3517evm logicpd omap3 devkit8000 arm armv7 devkit8000 timll omap3 +igep0020 arm armv7 igep0020 isee omap3 s5p_goni arm armv7 goni samsung s5pc1xx smdkc100 arm armv7 smdkc100 samsung s5pc1xx ixdpg425 arm ixp
include/configs/igep0020.h new file +228 -0
228 lines not on this page · raw message
Signature · 1 line
1.7.0.4
PATCH v2 3/3 OMAP3: Add support for the IGEP v2 board.
Dear Enric Balletbo i Serra,
Quoted 6 lines · In message <[email protected]> you wrote:
The IGEP v2 board is a low-cost, fan-less and industrial temperature range single board computer that unleashes laptop-like performance and expandability without the bulk, expense, or noise of typical desktop machines. Its architecture shares much in common with other OMAP3 boards.
Signed-off-by Enric Balletbo i Serra <[email protected]>
Quoted 14 lines
--- MAKEALL | 1 + board/isee/igep0020/Makefile | 49 +++++++++ board/isee/igep0020/config.mk | 33 ++++++ board/isee/igep0020/igep0020.c | 128 ++++++++++++++++++++++ board/isee/igep0020/igep0020.h | 156 +++++++++++++++++++++++++++ boards.cfg | 1 + include/configs/igep0020.h | 228 ++++++++++++++++++++++++++++++++++++++++ 7 files changed, 596 insertions(+), 0 deletions(-) create mode 100644 board/isee/igep0020/Makefile create mode 100644 board/isee/igep0020/config.mk create mode 100644 board/isee/igep0020/igep0020.c create mode 100644 board/isee/igep0020/igep0020.h create mode 100644 include/configs/igep0020.h
Entry to MAINTAINERS missing.
Best regards,
Wolfgang Denk
Signature · 5 lines
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de Fascinating, a totally parochial attitude. -- Spock, "Metamorphosis", stardate 3219.8