Skip to contentSkip to conversation

Add USB audio quirk supporting Roland VG-99 advanced mode

PATCH Applied [email protected] 2 participants 4 messages Oct 20, 2012 – Oct 21, 2012 Sound

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Add USB audio quirk supporting Roland VG-99 advanced mode

From: Pete Leigh <[email protected]>

sound/usb/quirks-table.h +34 -0
index 88d8ceb..ffeabf8 100644
@@ -1457,6 +1457,40 @@ YAMAHA_DEVICE(0x7010, "UB99"),
 	}
 },
 {
+	/* Advanced mode of the Roland VG-99, with MIDI and 24-bit PCM at 44.1
+	 * kHz. In standard mode, the device has ID 0582:00b3, and offers
+	 * 16-bit PCM at 44.1 kHz with no MIDI.
+	 */
+	USB_DEVICE(0x0582, 0x00b2),
+	.driver_info = (unsigned long) & (const struct snd_usb_audio_quirk) {
+		.vendor_name = "Roland",
+		.product_name = "VG-99",
+		.ifnum = QUIRK_ANY_INTERFACE,
+		.type = QUIRK_COMPOSITE,
+		.data = (const struct snd_usb_audio_quirk[]) {
+			{
+				.ifnum = 0,
+				.type = QUIRK_AUDIO_STANDARD_INTERFACE
+			},
+			{
+				.ifnum = 1,
+				.type = QUIRK_AUDIO_STANDARD_INTERFACE
+			},
+			{
+				.ifnum = 2,
+				.type = QUIRK_MIDI_FIXED_ENDPOINT,
+				.data = & (const struct snd_usb_midi_endpoint_info) {
+					.out_cables = 0x0003,
+					.in_cables  = 0x0003
+				}
+			},
+			{
+				.ifnum = -1
+			}
+		}
+	}
+},
+{
 	/* Roland SonicCell */
 	USB_DEVICE(0x0582, 0x00c2),
 	.driver_info = (unsigned long) & (const struct snd_usb_audio_quirk) {
Signature · 1 line
1.7.11.7
#1 lore raw

At Sat, 20 Oct 2012 10:01:04 +0100,

Quoted 5 lines · [email protected] wrote:

From: Pete Leigh <[email protected]>

Could you give a bit more descriptive commit log?
I see you put more in comments, but it'd be also good to have more information in the changelog.

thanks,

Takashi

Quoted 54 lines
sound/usb/quirks-table.h +34 -0
index 88d8ceb..ffeabf8 100644
@@ -1457,6 +1457,40 @@ YAMAHA_DEVICE(0x7010, "UB99"),
 	}
 },
 {
+	/* Advanced mode of the Roland VG-99, with MIDI and 24-bit PCM at 44.1
+	 * kHz. In standard mode, the device has ID 0582:00b3, and offers
+	 * 16-bit PCM at 44.1 kHz with no MIDI.
+	 */
+	USB_DEVICE(0x0582, 0x00b2),
+	.driver_info = (unsigned long) & (const struct snd_usb_audio_quirk) {
+		.vendor_name = "Roland",
+		.product_name = "VG-99",
+		.ifnum = QUIRK_ANY_INTERFACE,
+		.type = QUIRK_COMPOSITE,
+		.data = (const struct snd_usb_audio_quirk[]) {
+			{
+				.ifnum = 0,
+				.type = QUIRK_AUDIO_STANDARD_INTERFACE
+			},
+			{
+				.ifnum = 1,
+				.type = QUIRK_AUDIO_STANDARD_INTERFACE
+			},
+			{
+				.ifnum = 2,
+				.type = QUIRK_MIDI_FIXED_ENDPOINT,
+				.data = & (const struct snd_usb_midi_endpoint_info) {
+					.out_cables = 0x0003,
+					.in_cables  = 0x0003
+				}
+			},
+			{
+				.ifnum = -1
+			}
+		}
+	}
+},
+{
 	/* Roland SonicCell */
 	USB_DEVICE(0x0582, 0x00c2),
 	.driver_info = (unsigned long) & (const struct snd_usb_audio_quirk) {
Signature · 6 lines
1.7.11.7

_______________________________________________
Alsa-devel mailing list
[email protected]
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
author
#2 lore raw
Quoted 3 lines · Takashi Iwai

Could you give a bit more descriptive commit log?
I see you put more in comments, but it'd be also good to have more information in the changelog.

Ok, done I hope.

Perhaps it's worth noting - I ran the patch checking script, and it did not like the spaces after '&', nor line lengths, in a couple of places in the patch, but I obeyed the conventions of the existing code in the file rather than what the script said, and kept things as they were. Hope that's ok.

Cheers.

- Pete.

Applied
#3 lore raw

At Sun, 21 Oct 2012 10:34:57 +0100,

Quoted 8 lines · Pete Leigh
Quoted 3 lines · Takashi Iwai

Could you give a bit more descriptive commit log?
I see you put more in comments, but it'd be also good to have more information in the changelog.

Ok, done I hope.

Thanks, applied now.

Quoted 5 lines

Perhaps it's worth noting - I ran the patch checking script, and it did not like the spaces after '&', nor line lengths, in a couple of places in the patch, but I obeyed the conventions of the existing code in the file rather than what the script said, and kept things as they were. Hope that's ok.

Don't worry about that. checkpatch.pl is just too picky.

Takashi