drm/i915: Error state should print /sys/kernel/debug
Subsystems (2)
PATCH 1/2 drm/i915: Error state should print /sys/kernel/debug
/sys/kernel/debug has more or less been the standard location of debugfs for several years now. Other parts of DRM already use this location, so we should as well.
--- drivers/gpu/drm/i915/i915_irq.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/i915/i915_irq.c +1 -1
@@ -1305,7 +1305,7 @@ static void i915_capture_error_state(struct drm_device *dev)return ; } -DRM_INFO ("capturing error event; look for more information in /debug/dri/%d/i915_error_state\n" , +DRM_INFO ("capturing error event; look for more information in /sys/kernel/debug/dri/%d/i915_error_state\n" , dev->primary->index);kref_init (&error->ref);
Signature · 1 line
1.8.1.1
PATCH 2/2 drm/i915: Adding a warning to FBC description
It should only be used with caution...
--- drivers/gpu/drm/i915/i915_drv.c | 1 + 1 file changed, 1 insertion(+)
drivers/gpu/drm/i915/i915_drv.c +1 -0
@@ -76,6 +76,7 @@ int i915_enable_fbc __read_mostly = -1;module_param_named (i915_enable_fbc, i915_enable_fbc, int,0600 );MODULE_PARM_DESC (i915_enable_fbc,"Enable frame buffer compression for power savings " +"WARNING: FBC has been implicated in hangs over the years, and should likely be left to the default value. " "(default: -1 (use per-chip default))" );unsigned int i915_lvds_downclock__read_mostly =0 ;
Signature · 1 line
1.8.1.1
Re: [PATCH 2/2] drm/i915: Adding a warning to FBC description
Quoted 3 lines · Ben Widawsky
It should only be used with caution...
Signed-off-by Ben Widawsky <[email protected]>
Isn't that like the general assumption of these module parameters that they can have pretty massive bad side-effects? Meaning I'm routinely checking these already anyway in bug reports, same for non-standard rc6 settings.
-Daniel
Quoted 23 lines
--- drivers/gpu/drm/i915/i915_drv.c | 1 + 1 file changed, 1 insertion(+)drivers/gpu/drm/i915/i915_drv.c +1
-0@@ -76,6 +76,7 @@ int i915_enable_fbc __read_mostly = -1;module_param_named (i915_enable_fbc, i915_enable_fbc, int,0600 );MODULE_PARM_DESC (i915_enable_fbc,"Enable frame buffer compression for power savings " +"WARNING: FBC has been implicated in hangs over the years, and should likely be left to the default value. " "(default: -1 (use per-chip default))" );unsigned int i915_lvds_downclock__read_mostly =0 ;Signature · 6 lines
1.8.1.1 _______________________________________________ Intel-gfx mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/intel-gfx
Signature · 3 lines
Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch
Re: [PATCH 2/2] drm/i915: Adding a warning to FBC description
Quoted 11 lines · On Tue, 29 Jan 2013 09:49:13 +0100 Daniel Vetter <[email protected]> wrote:
Quoted 3 lines · Ben Widawsky
It should only be used with caution...
Signed-off-by Ben Widawsky <[email protected]>Isn't that like the general assumption of these module parameters that they can have pretty massive bad side-effects? Meaning I'm routinely checking these already anyway in bug reports, same for non-standard rc6 settings.
-Daniel
I felt that way too, until we got a complain in #intel-gfx and it changed my mind.
Whatevs, I ain't gonna fight for this one, I'll just punt the bug reporter to you next time.
Jani Nikula
maintainerRe: [PATCH 2/2] drm/i915: Adding a warning to FBC description
Quoted 15 lines · Ben Widawsky
Quoted 11 lines · On Tue, 29 Jan 2013 09:49:13 +0100 Daniel Vetter <[email protected]> wrote:
Quoted 3 lines · Ben Widawsky
It should only be used with caution...
Signed-off-by Ben Widawsky <[email protected]>Isn't that like the general assumption of these module parameters that they can have pretty massive bad side-effects? Meaning I'm routinely checking these already anyway in bug reports, same for non-standard rc6 settings.
-Daniel
Quoted 5 lines
I felt that way too, until we got a complain in #intel-gfx and it changed my mind.
Whatevs, I ain't gonna fight for this one, I'll just punt the bug reporter to you next time.
Yeah, I agree it's *our* general assumption that these may have bad side-effects. People just see the random forum posts recommending this and that module param, and stick them in... Hmm, which means they won't read that warning anyway. DRM_INFO("don't report a bug about this") when enabling a feature that's disabled by default on a platform?
Jani.
Re: [PATCH 2/2] drm/i915: Adding a warning to FBC description
Quoted 22 lines · Jani Nikula
Quoted 15 lines · Ben Widawsky
Quoted 11 lines · On Tue, 29 Jan 2013 09:49:13 +0100 Daniel Vetter <[email protected]> wrote:
Quoted 3 lines · Ben Widawsky
It should only be used with caution...
Signed-off-by Ben Widawsky <[email protected]>Isn't that like the general assumption of these module parameters that they can have pretty massive bad side-effects? Meaning I'm routinely checking these already anyway in bug reports, same for non-standard rc6 settings.
-DanielQuoted 5 lines
I felt that way too, until we got a complain in #intel-gfx and it changed my mind.
Whatevs, I ain't gonna fight for this one, I'll just punt the bug reporter to you next time.
Quoted 7 lines
Yeah, I agree it's *our* general assumption that these may have bad side-effects. People just see the random forum posts recommending this and that module param, and stick them in... Hmm, which means they won't read that warning anyway.
DRM_INFO("don't report a bug about this")when enabling a feature that's disabled by default on a platform?Jani.
Now that's the kind of pessimism I like to hear! OTOH, the current
message: "Enable frame buffer compression for power savings" wouldn't indicate any reason to not use it. And yes, I know, what git blame says. I was on a personal crusade to fix FBC on ILK when I wrote that.
I like DRM_INFO as well, but I don't really see a reason not to change the modinfo (DRM_INFO requires loading the wrong setting first).
Signature · 1 line
Ben Widawsky, Intel Open Source Technology Center
Re: [PATCH 2/2] drm/i915: Adding a warning to FBC description
Quoted 8 lines · Ben Widawsky
Quoted 7 lines
Yeah, I agree it's *our* general assumption that these may have bad side-effects. People just see the random forum posts recommending this and that module param, and stick them in... Hmm, which means they won't read that warning anyway.
DRM_INFO("don't report a bug about this")when enabling a feature that's disabled by default on a platform?Jani.
Quoted 7 lines
Now that's the kind of pessimism I like to hear! OTOH, the current
message: "Enable frame buffer compression for power savings" wouldn't indicate any reason to not use it. And yes, I know, what git blame says. I was on a personal crusade to fix FBC on ILK when I wrote that.I like
DRM_INFOas well, but I don't really see a reason not to change the modinfo (DRM_INFOrequires loading the wrong setting first).
Ok, count me convinced to merge such patches. Though I personally don't care and don't mind checking bug reports for these, it looks like I'm in the minority opinion.
I'd like though that such a solution not just takes care of fbc, but also some of the other dangerous options (which are most): rc6 can cause hangs, advanced power features can lead to flashing displays,
...
Cheers, Daniel
Signature · 3 lines
Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch
Quoted 5 lines · Ben Widawsky
/sys/kernel/debughas more or less been the standard location of debugfs for several years now. Other parts of DRM already use this location, so we should as well.Signed-off-by Ben Widawsky <[email protected]>
-Carl
_______________________________________________
Intel-gfx mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
Quoted 5 lines · Ben Widawsky
/sys/kernel/debughas more or less been the standard location of debugfs for several years now. Other parts of DRM already use this location, so we should as well.Signed-off-by Ben Widawsky <[email protected]>
Signature · 1 line
Damien
Daniel Vetter
AppliedQuoted 8 lines · Damien Lespiau
Quoted 5 lines · Ben Widawsky
/sys/kernel/debughas more or less been the standard location of debugfs for several years now. Other parts of DRM already use this location, so we should as well.Signed-off-by Ben Widawsky <[email protected]>Reviewed-by Damien Lespiau <[email protected]>
Queued for -next, thanks for the patch. Oh and fixed up a bikeshed from checkpatch.pl while applying:
Applying: drm/i915: Error state should print /sys/kernel/debug
WARNING: line over 80 characters
#22: FILE: drivers/gpu/drm/i915/i915_irq.c:1308:
+ DRM_INFO("capturing error event; look for more information in /sys/kernel/debug/dri/%d/i915_error_state\n",
total: 0 errors, 1 warnings, 8 lines checked
Yeah, I've added that OCD thing to my patch apply pipeline, let's see how much fun it is ;-)
-Daniel
Quoted 7 lines
Signature · 6 lines
-- Damien _______________________________________________ Intel-gfx mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/intel-gfx
Signature · 3 lines
Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch
Jani Nikula
maintainerQuoted 8 lines · Daniel Vetter
Queued for -next, thanks for the patch. Oh and fixed up a bikeshed from checkpatch.pl while applying:
Applying: drm/i915: Error state should print
/sys/kernel/debug
WARNING: line over 80 characters
#22: FILE:drivers/gpu/drm/i915/i915_irq.c:1308:
+ DRM_INFO("capturing error event; look for more information in /sys/kernel/debug/dri/%d/i915_error_state\n",
Quoted 4 lines
total: 0 errors, 1 warnings, 8 lines checked
Yeah, I've added that OCD thing to my patch apply pipeline, let's see how much fun it is ;-)
You could go all the way: http://lwn.net/Articles/488992/ ;)
J.
Quoted 19 lines · On Tue, 29 Jan 2013 09:54:18 +0100 Daniel Vetter <[email protected]> wrote:
Quoted 8 lines · Damien Lespiau
Quoted 5 lines · Ben Widawsky
/sys/kernel/debughas more or less been the standard location of debugfs for several years now. Other parts of DRM already use this location, so we should as well.Signed-off-by Ben Widawsky <[email protected]>Reviewed-by Damien Lespiau <[email protected]>Queued for -next, thanks for the patch. Oh and fixed up a bikeshed from checkpatch.pl while applying:
Applying: drm/i915: Error state should print
/sys/kernel/debug
WARNING: line over 80 characters
#22: FILE:drivers/gpu/drm/i915/i915_irq.c:1308:
+ DRM_INFO("capturing error event; look for more information
in /sys/kernel/debug/dri/%d/i915_error_state\n",
Quoted 4 lines
total: 0 errors, 1 warnings, 8 lines checked
Yeah, I've added that OCD thing to my patch apply pipeline, let's see how much fun it is ;-)
I've not looked at the final patch yet, but I think breaking up constant strings is considered bad form, and lines above 80 are generally favored for grepability.
At least James Bottomley said that in his talk and LPC, and a bunch of other maintainers seemed to agree. (and I agree)
Quoted 4 lines
-Daniel
Quoted 3 lines
Signature · 2 lines
-- Damien
Quoted 27 lines · Ben Widawsky
Quoted 19 lines · On Tue, 29 Jan 2013 09:54:18 +0100 Daniel Vetter <[email protected]> wrote:
Quoted 8 lines · Damien Lespiau
Quoted 5 lines · Ben Widawsky
/sys/kernel/debughas more or less been the standard location of debugfs for several years now. Other parts of DRM already use this location, so we should as well.Signed-off-by Ben Widawsky <[email protected]>Reviewed-by Damien Lespiau <[email protected]>Queued for -next, thanks for the patch. Oh and fixed up a bikeshed from checkpatch.pl while applying:
Applying: drm/i915: Error state should print
/sys/kernel/debug
WARNING: line over 80 characters
#22: FILE:drivers/gpu/drm/i915/i915_irq.c:1308:
+ DRM_INFO("capturing error event; look for more information
in /sys/kernel/debug/dri/%d/i915_error_state\n",Quoted 4 lines
total: 0 errors, 1 warnings, 8 lines checked
Yeah, I've added that OCD thing to my patch apply pipeline, let's see how much fun it is ;-)
Quoted 6 lines
I've not looked at the final patch yet, but I think breaking up constant strings is considered bad form, and lines above 80 are generally favored for grepability.
At least James Bottomley said that in his talk and LPC, and a bunch of other maintainers seemed to agree. (and I agree)
I routinely ignore the 80 cols warnings. I'm sure a significant part of my patches violate it, even the ones w/o long strings.
Signature · 2 lines
Ville Syrjälä Intel OTC