kvm:ppc: enable doorbell exception with CONFIG_PPC_DOORBELL
Subsystems (3)
PATCH v2 1/1 kvm:ppc: enable doorbell exception with CONFIG_PPC_DOORBELL
CONFIG_PPC_DOORBELL is enough to cover all variants.
--- arch/powerpc/kvm/booke.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
arch/powerpc/kvm/booke.c +1 -1
@@ -795,7 +795,7 @@ static void kvmppc_restart_interrupt(struct kvm_vcpu *vcpu,kvmppc_fill_pt_regs (®s);timer_interrupt (®s);break ; -#if defined(CONFIG_PPC_FSL_BOOK3E ) || defined(CONFIG_PPC_BOOK3E_64 ) +#if defined(CONFIG_PPC_DOORBELL )case BOOKE_INTERRUPT_DOORBELL :kvmppc_fill_pt_regs (®s);doorbell_exception (®s);
Signature · 1 line
1.7.9.5
Quoted 12 lines · Tiejun Chen
CONFIG_PPC_DOORBELLis enough to cover all variants.Signed-off-by Tiejun Chen <[email protected]>---
arch/powerpc/kvm/booke.c| 2 +-1 file changed, 1 insertion(+), 1 deletion(-)arch/powerpc/kvm/booke.c +0
-0
arch/powerpc/kvm/booke.c static void kvmppc_restart_interrupt(struct kvm_vcpu *vcpu, · line 798
Quoted 5 lines
arch/powerpc/kvm/booke.c +1
-1@@ -795,7 +795,7 @@ static void kvmppc_restart_interrupt(struct kvm_vcpu *vcpu,kvmppc_fill_pt_regs (®s);timer_interrupt (®s);break ; -#if defined(CONFIG_PPC_FSL_BOOK3E ) || defined(CONFIG_PPC_BOOK3E_64 ) +#if defined(CONFIG_PPC_DOORBELL )
The same question still holds. How is this an improvement over the previous code? Does this fix any issues for you? Is this just a coding style cleanup?
Alex
Quoted 6 lines
arch/powerpc/kvm/booke.c +0
-0case BOOKE_INTERRUPT_DOORBELL :kvmppc_fill_pt_regs (®s);doorbell_exception (®s);Signature · 1 line
1.7.9.5
Quoted 16 lines · Alexander Graf
arch/powerpc/kvm/booke.c static void kvmppc_restart_interrupt(struct
Quoted 12 lines · Tiejun Chen
CONFIG_PPC_DOORBELLis enough to cover all variants.Signed-off-by Tiejun Chen <[email protected]>---
arch/powerpc/kvm/booke.c| 2 +-1 file changed, 1 insertion(+), 1 deletion(-)arch/powerpc/kvm/booke.c +0
-0@@ -795,7 +795,7 @@ static void kvmppc_restart_interrupt(struct
kvm_vcpu*vcpu,
Quoted 7 lines
arch/powerpc/kvm/booke.c static void kvmppc_restart_interrupt(struct kvm_vcpu *vcpu, · line 798
Quoted 5 lines
arch/powerpc/kvm/booke.c +1
-1kvmppc_fill_pt_regs (®s);timer_interrupt (®s);break ; -#if defined(CONFIG_PPC_FSL_BOOK3E ) || defined(CONFIG_PPC_BOOK3E_64 ) +#if defined(CONFIG_PPC_DOORBELL )The same question still holds. How is this an improvement over the previous code? Does this fix any issues for you? Is this just a coding style cleanup?
This is an improvement because CONFIG_PPC_DOORBELL is what controls whether the function that is called inside the ifdef exists.
-Scott
Quoted 21 lines · Scott Wood
Quoted 8 lines · Alexander Graf
Quoted 7 lines · Tiejun Chen
CONFIG_PPC_DOORBELLis enough to cover all variants.Signed-off-by Tiejun Chen <[email protected]>---
arch/powerpc/kvm/booke.c| 2 +-1 file changed, 1 insertion(+), 1 deletion(-)Quoted 11 lines
arch/powerpc/kvm/booke.c static void kvmppc_restart_interrupt(struct kvm_vcpu *vcpu, · line 798
Quoted 10 lines
arch/powerpc/kvm/booke.c +1
-1@@ -795,7 +795,7 @@ static void kvmppc_restart_interrupt(struct kvm_vcpu *vcpu,kvmppc_fill_pt_regs (®s);timer_interrupt (®s);break ; -#if defined(CONFIG_PPC_FSL_BOOK3E ) || defined(CONFIG_PPC_BOOK3E_64 ) +#if defined(CONFIG_PPC_DOORBELL )The same question still holds. How is this an improvement over the previous code? Does this fix any issues for you? Is this just a coding style cleanup?
Quoted 1 line
This is an improvement because
CONFIG_PPC_DOORBELLis what controls whether the function that is called inside the ifdef exists.
Aha! Now that's a good reason. Tiejun, please adjust your patch description accordingly.
Alex