Skip to contentSkip to conversation

kvm:ppc: enable doorbell exception with CONFIG_PPC_DOORBELL

PATCH Superseded Tiejun Chen 3 participants 4 messages May 7, 2013 – May 10, 2013

Subsystems (3)

v2 of 3 Superseded Latest is v3 →

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 kvm:ppc: enable doorbell exception with CONFIG_PPC_DOORBELL

CONFIG_PPC_DOORBELL is enough to cover all variants.

---
 arch/powerpc/kvm/booke.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/powerpc/kvm/booke.c +1 -1
index 1020119..62d4ece 100644
@@ -795,7 +795,7 @@ static void kvmppc_restart_interrupt(struct kvm_vcpu *vcpu,
 		kvmppc_fill_pt_regs(&regs);
 		timer_interrupt(&regs);
 		break;
-#if defined(CONFIG_PPC_FSL_BOOK3E) || defined(CONFIG_PPC_BOOK3E_64)
+#if defined(CONFIG_PPC_DOORBELL)
 	case BOOKE_INTERRUPT_DOORBELL:
 		kvmppc_fill_pt_regs(&regs);
 		doorbell_exception(&regs);
Signature · 1 line
1.7.9.5
#1 lore raw
Quoted 12 lines · Tiejun Chen

CONFIG_PPC_DOORBELL is enough to cover all variants.

---
arch/powerpc/kvm/booke.c | 2 +-

1 file changed, 1 insertion(+), 1 deletion(-)
arch/powerpc/kvm/booke.c +0 -0
index 1020119..62d4ece 100644

arch/powerpc/kvm/booke.c static void kvmppc_restart_interrupt(struct kvm_vcpu *vcpu, · line 798

Quoted 5 lines
arch/powerpc/kvm/booke.c +1 -1
@@ -795,7 +795,7 @@ static void kvmppc_restart_interrupt(struct kvm_vcpu *vcpu,
 		kvmppc_fill_pt_regs(&regs);
 		timer_interrupt(&regs);
 		break;
-#if defined(CONFIG_PPC_FSL_BOOK3E) || defined(CONFIG_PPC_BOOK3E_64)
+#if defined(CONFIG_PPC_DOORBELL)

The same question still holds. How is this an improvement over the previous code? Does this fix any issues for you? Is this just a coding style cleanup?

Alex

Quoted 6 lines
arch/powerpc/kvm/booke.c +0 -0
 	case BOOKE_INTERRUPT_DOORBELL:
 		kvmppc_fill_pt_regs(&regs);
 		doorbell_exception(&regs);
Signature · 1 line
1.7.9.5
#2 lore raw
Quoted 16 lines · Alexander Graf

arch/powerpc/kvm/booke.c static void kvmppc_restart_interrupt(struct

Quoted 12 lines · Tiejun Chen

CONFIG_PPC_DOORBELL is enough to cover all variants.

---
arch/powerpc/kvm/booke.c | 2 +-

1 file changed, 1 insertion(+), 1 deletion(-)
arch/powerpc/kvm/booke.c +0 -0
index 1020119..62d4ece 100644
@@ -795,7 +795,7 @@ static void kvmppc_restart_interrupt(struct  

kvm_vcpu *vcpu,

Quoted 7 lines

arch/powerpc/kvm/booke.c static void kvmppc_restart_interrupt(struct kvm_vcpu *vcpu, · line 798

Quoted 5 lines
arch/powerpc/kvm/booke.c +1 -1
 		kvmppc_fill_pt_regs(&regs);
 		timer_interrupt(&regs);
 		break;
-#if defined(CONFIG_PPC_FSL_BOOK3E) || defined(CONFIG_PPC_BOOK3E_64)
+#if defined(CONFIG_PPC_DOORBELL)

The same question still holds. How is this an improvement over the previous code? Does this fix any issues for you? Is this just a coding style cleanup?

This is an improvement because CONFIG_PPC_DOORBELL is what controls whether the function that is called inside the ifdef exists.

-Scott

#3 lore raw
Quoted 21 lines · Scott Wood
Quoted 8 lines · Alexander Graf
Quoted 7 lines · Tiejun Chen

CONFIG_PPC_DOORBELL is enough to cover all variants.

---
arch/powerpc/kvm/booke.c | 2 +-

1 file changed, 1 insertion(+), 1 deletion(-)
Quoted 11 lines

arch/powerpc/kvm/booke.c static void kvmppc_restart_interrupt(struct kvm_vcpu *vcpu, · line 798

Quoted 10 lines
arch/powerpc/kvm/booke.c +1 -1
index 1020119..62d4ece 100644
@@ -795,7 +795,7 @@ static void kvmppc_restart_interrupt(struct kvm_vcpu *vcpu,
 		kvmppc_fill_pt_regs(&regs);
 		timer_interrupt(&regs);
 		break;
-#if defined(CONFIG_PPC_FSL_BOOK3E) || defined(CONFIG_PPC_BOOK3E_64)
+#if defined(CONFIG_PPC_DOORBELL)

The same question still holds. How is this an improvement over the previous code? Does this fix any issues for you? Is this just a coding style cleanup?

Quoted 1 line

This is an improvement because CONFIG_PPC_DOORBELL is what controls whether the function that is called inside the ifdef exists.

Aha! Now that's a good reason. Tiejun, please adjust your patch description accordingly.

Alex