Lager i2c bus support
cover Lager i2c bus support
This is the i2c part of the previously posted HDMI encoder RFC. The following suggestions have been applied:
- keep platform device out of SoC setup
- use device ID to trigger H2-specific behavior in i2c driver instead of platform data
- minor adjustments for style
- subjects cleared up
(The pinmux patch has been adopted by Laurent and thus omitted here.)
CU
Uli
Nguyen Viet Dung (2):
i2c: rcar: support R-Car H2 in i2c bus driver
ARM: shmobile: r8a7790: add the I2C bus clock
Ulrich Hecht (1):
ARM: shmobile: r8a7790: lager: i2c support
arch/arm/mach-shmobile/board-lager.c | 60 ++++++++++++++++++++++++++++++++++ arch/arm/mach-shmobile/clock-r8a7790.c | 11 +++++++ drivers/i2c/busses/i2c-rcar.c | 35 ++++++++++++++++++-- 3 files changed, 104 insertions(+), 2 deletions(-)
Signature · 1 line
1.8.1.4
Hi Ulrich
Quoted 15 lines · Ulrich Hecht
This is the i2c part of the previously posted HDMI encoder RFC. The following suggestions have been applied:
- keep platform device out of SoC setup
- use device ID to trigger H2-specific behavior in i2c driver instead of platform data
- minor adjustments for style
- subjects cleared up(The pinmux patch has been adopted by Laurent and thus omitted here.)
CU
Uli
Quoted 6 lines
Nguyen Viet Dung (2):
i2c: rcar: support R-Car H2 in i2c bus driver
ARM: shmobile: r8a7790: add the I2C bus clockUlrich Hecht (1):
ARM: shmobile: r8a7790: lager: i2c support
Some of this patches will conflict with this my series
http://thread.gmane.org/gmane.linux.kernel/1558455
Most conflicts won't be hard to resolve, you only add I2C busses 1 and 2, whereas I'm more interested in bus #3 (DVFS) on r8a7790. But there are also some other differences: if these my patches
http://thread.gmane.org/gmane.linux.ports.sh.devel/26975
get accepted, then the clock scheme for I2C on H2 will change a bit, e.g. the peripheral_clock won't be needed. And I really think that should be the right way to go. Let's wait for some comments.
Thanks
Guennadi
Quoted 14 lines
arch/arm/mach-shmobile/board-lager.c | 60 ++++++++++++++++++++++++++++++++++ arch/arm/mach-shmobile/clock-r8a7790.c | 11 +++++++ drivers/i2c/busses/i2c-rcar.c | 35 ++++++++++++++++++-- 3 files changed, 104 insertions(+), 2 deletions(-)Signature · 6 lines
1.8.1.4 -- To unsubscribe from this list: send the line "unsubscribe linux-sh" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
---
Guennadi Liakhovetski, Ph.D.
Freelance Open-Source Software Developer
http://www.open-technology.de/
Hi Simon
Quoted 34 lines · Guennadi Liakhovetski
Hi Ulrich
Quoted 15 lines · Ulrich Hecht
This is the i2c part of the previously posted HDMI encoder RFC. The following suggestions have been applied:
- keep platform device out of SoC setup
- use device ID to trigger H2-specific behavior in i2c driver instead of platform data
- minor adjustments for style
- subjects cleared up(The pinmux patch has been adopted by Laurent and thus omitted here.)
CU
UliQuoted 6 lines
Nguyen Viet Dung (2):
i2c: rcar: support R-Car H2 in i2c bus driver
ARM: shmobile: r8a7790: add the I2C bus clockUlrich Hecht (1):
ARM: shmobile: r8a7790: lager: i2c supportSome of this patches will conflict with this my series
http://thread.gmane.org/gmane.linux.kernel/1558455
Most conflicts won't be hard to resolve, you only add I2C busses 1 and 2, whereas I'm more interested in bus #3 (DVFS) on r8a7790. But there are also some other differences: if these my patches
Quoted 5 lines
http://thread.gmane.org/gmane.linux.ports.sh.devel/26975
get accepted, then the clock scheme for I2C on H2 will change a bit, e.g. the
peripheral_clockwon't be needed. And I really think that should be the right way to go. Let's wait for some comments.
What is your preferred way to resolve this? We can choose one of the following:
1. merge the two i2c clock patches into one - feel free to take my code into "ARM: shmobile: r8a7790: add the I2C bus clock" from this series
2. port one of the patches on top of the other one - if this series isn't going to be modified again, I can port my patch on top of it.
Thanks
Guennadi
Quoted 7 lines
Quoted 7 lines
arch/arm/mach-shmobile/board-lager.c | 60 ++++++++++++++++++++++++++++++++++ arch/arm/mach-shmobile/clock-r8a7790.c | 11 +++++++ drivers/i2c/busses/i2c-rcar.c | 35 ++++++++++++++++++-- 3 files changed, 104 insertions(+), 2 deletions(-)Signature · 1 line
1.8.1.4
---
Guennadi Liakhovetski, Ph.D.
Freelance Open-Source Software Developer
http://www.open-technology.de/
Quoted 8 lines · Guennadi Liakhovetski
What is your preferred way to resolve this? We can choose one of the following:
1. merge the two i2c clock patches into one - feel free to take my code into "ARM: shmobile: r8a7790: add the I2C bus clock" from this series
2. port one of the patches on top of the other one - if this series isn't going to be modified again, I can port my patch on top of it.
Since my DU stuff will have to be ported to DT anyway and I have found that my work towards that on the rcar-i2c driver is virtually identical to what Guennadi has already posted, I'd suggest to go with his version.
CU
Uli
Quoted 2 lines · Ulrich Hecht
On Thu, Sep 12, 2013 at 3:51 PM, Guennadi Liakhovetski <[email protected]> wrote:
Apologies for me excessively slow response.
Quoted 6 lines
Quoted 6 lines
What is your preferred way to resolve this? We can choose one of the following:
1. merge the two i2c clock patches into one - feel free to take my code into "ARM: shmobile: r8a7790: add the I2C bus clock" from this series
Quoted 7 lines
Quoted 2 lines
2. port one of the patches on top of the other one - if this series isn't going to be modified again, I can port my patch on top of it.
Since my DU stuff will have to be ported to DT anyway and I have found that my work towards that on the rcar-i2c driver is virtually identical to what Guennadi has already posted, I'd suggest to go with his version.
That sounds like a good resolution to me.
Quoted 15 lines · Simon Horman
Quoted 2 lines · Ulrich Hecht
On Thu, Sep 12, 2013 at 3:51 PM, Guennadi Liakhovetski <[email protected]> wrote:
Apologies for me excessively slow response.
Quoted 9 lines
Quoted 8 lines
What is your preferred way to resolve this? We can choose one of the following:
1. merge the two i2c clock patches into one - feel free to take my code into "ARM: shmobile: r8a7790: add the I2C bus clock" from this series
2. port one of the patches on top of the other one - if this series isn't going to be modified again, I can port my patch on top of it.
Quoted 6 lines
Quoted 4 lines
Since my DU stuff will have to be ported to DT anyway and I have found that my work towards that on the rcar-i2c driver is virtually identical to what Guennadi has already posted, I'd suggest to go with his version.
That sounds like a good resolution to me.
Btw, as far as I can see the current status of this work is as follows.
1. Awaiting Ack from Laurent on
"pinctrl: sh-pfc: r8a7790: add pin definitions for the I2C3 interface" by Guennadi. This patch is targeted at Linus Walleji's tree.
2. Once Linus has queued up that patch I will queue up "ARM: shmobile: r8a7790: add I2C support in Device Tree mode" in the renesas tree.
3. From there I think you should be able to repost the parts of your series that aren't included in Guennadi's work.
To be clear: I have marked this series as "Changes Requested" in patchwork and it is will not be on my radar unless it is re-posted in some form.
Hi Simon,
Quoted 20 lines · On Wednesday 25 September 2013 13:59:26 Simon Horman wrote:
Quoted 19 lines · Simon Horman
Quoted 1 line · Ulrich Hecht
On Thu, Sep 12, 2013 at 3:51 PM, Guennadi Liakhovetski wrote:
Apologies for me excessively slow response.
Quoted 14 lines
Quoted 9 lines
What is your preferred way to resolve this? We can choose one of the following:
1. merge the two i2c clock patches into one - feel free to take my code into "ARM: shmobile: r8a7790: add the I2C bus clock" from this series
2. port one of the patches on top of the other one - if this series isn't going to be modified again, I can port my patch on top of it.
Since my DU stuff will have to be ported to DT anyway and I have found that my work towards that on the rcar-i2c driver is virtually identical to what Guennadi has already posted, I'd suggest to go with his version.
Quoted 7 lines
Quoted 1 line
That sounds like a good resolution to me.
Btw, as far as I can see the current status of this work is as follows.
1. Awaiting Ack from Laurent on
"pinctrl: sh-pfc: r8a7790: add pin definitions for the I2C3 interface" by Guennadi. This patch is targeted at Linus Walleji's tree.
I've replied to Guennadi's patch, there will likely be a v2.
Quoted 3 lines
2. Once Linus has queued up that patch I will queue up "ARM: shmobile: r8a7790: add I2C support in Device Tree mode" in the renesas tree.
There's no dependency between the two patches, you can thus queue it up already.
Quoted 5 lines
3. From there I think you should be able to repost the parts of your series that aren't included in Guennadi's work.
To be clear: I have marked this series as "Changes Requested" in patchwork and it is will not be on my radar unless it is re-posted in some form.
Signature · 3 lines
Regards, Laurent Pinchart
Quoted 25 lines · Laurent Pinchart
Hi Simon,
Quoted 22 lines · On Wednesday 25 September 2013 13:59:26 Simon Horman wrote:
Quoted 20 lines · Simon Horman
Quoted 1 line · Ulrich Hecht
On Thu, Sep 12, 2013 at 3:51 PM, Guennadi Liakhovetski wrote:
Apologies for me excessively slow response.
Quoted 7 lines
Quoted 7 lines
What is your preferred way to resolve this? We can choose one of the following:
1. merge the two i2c clock patches into one - feel free to take my code into "ARM: shmobile: r8a7790: add the I2C bus clock" from this series
Quoted 7 lines
Quoted 2 lines
2. port one of the patches on top of the other one - if this series isn't going to be modified again, I can port my patch on top of it.
Since my DU stuff will have to be ported to DT anyway and I have found that my work towards that on the rcar-i2c driver is virtually identical to what Guennadi has already posted, I'd suggest to go with his version.
That sounds like a good resolution to me.
Quoted 7 lines
Quoted 5 lines
Btw, as far as I can see the current status of this work is as follows.
1. Awaiting Ack from Laurent on
"pinctrl: sh-pfc: r8a7790: add pin definitions for the I2C3 interface" by Guennadi. This patch is targeted at Linus Walleji's tree.I've replied to Guennadi's patch, there will likely be a v2.
Thanks, noted.
Quoted 6 lines
Quoted 3 lines
2. Once Linus has queued up that patch I will queue up "ARM: shmobile: r8a7790: add I2C support in Device Tree mode" in the renesas tree.
There's no dependency between the two patches, you can thus queue it up already.
Thanks. I will see about queuing it up.
Quoted 5 lines
Quoted 5 lines
3. From there I think you should be able to repost the parts of your series that aren't included in Guennadi's work.
To be clear: I have marked this series as "Changes Requested" in patchwork and it is will not be on my radar unless it is re-posted in some form.