x86/boot/early_serial_console: Remove unnecessary check
PATCH v2 1/1 x86/boot/early_serial_console: Remove unnecessary check
There is already the same check before.
--- arch/x86/boot/early_serial_console.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)
arch/x86/boot/early_serial_console.c +1 -2
@@ -74,8 +74,7 @@ static void parse_earlyprintk(void)static const int bases[] = {0x3f8 ,0x2f8 };int idx =0 ; -if (!strncmp (arg + pos,"ttyS" ,4 )) - pos +=4 ; + pos +=4 ;if (arg[pos++] =='1' ) idx =1 ;
Signature · 1 line
2.2.1.202.g44ae4ee.dirty
Borislav Petkov
maintainerQuoted 12 lines · Alexander Kuleshov
There is already the same check before.
Signed-off-by Alexander Kuleshov <[email protected]>--- arch/x86/boot/early_serial_console.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)arch/x86/boot/early_serial_console.c +0
-0
arch/x86/boot/early_serial_console.c static void parse_earlyprintk(void) · line 78
Quoted 5 lines
arch/x86/boot/early_serial_console.c +0
-2@@ -74,8 +74,7 @@ static void parse_earlyprintk(void)static const int bases[] = {0x3f8 ,0x2f8 };int idx =0 ; -if (!strncmp (arg + pos,"ttyS" ,4 )) - pos +=4 ;
You might need a comment to explain the advancing of pos to people who look at this in the future, i.e. something like
/* += strlen("ttyS"); */
pos += 4;Quoted 3 lines
arch/x86/boot/early_serial_console.c +0
-0if (arg[pos++] =='1' ) idx =1 ;
Signature · 3 lines
Regards/Gruss,
Boris.
--Do i need to send patch v3 to separate mail thread or add to it?
2014-12-30 21:48 GMT+06:00 Borislav Petkov <[email protected]>:
Quoted 32 lines · Alexander Kuleshov
Quoted 12 lines
There is already the same check before.
Signed-off-by Alexander Kuleshov <[email protected]>--- arch/x86/boot/early_serial_console.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)arch/x86/boot/early_serial_console.c +0
-0arch/x86/boot/early_serial_console.c static void parse_earlyprintk(void) · line 78
Quoted 5 lines
arch/x86/boot/early_serial_console.c +0
-2@@ -74,8 +74,7 @@ static void parse_earlyprintk(void)static const int bases[] = {0x3f8 ,0x2f8 };int idx =0 ; -if (!strncmp (arg + pos,"ttyS" ,4 )) - pos +=4 ;You might need a comment to explain the advancing of pos to people who look at this in the future, i.e. something like
/* += strlen("ttyS"); */ pos += 4;arch/x86/boot/early_serial_console.c static void parse_earlyprintk(void) · line 80
Quoted 3 lines
arch/x86/boot/early_serial_console.c +0
-0if (arg[pos++] =='1' ) idx =1 ;--
Regards/Gruss,
Boris.
--
Signature · 2 lines
_________________________ 0xAX