Skip to contentSkip to conversation

x86/boot/early_serial_console: Remove unnecessary check

PATCH In review Alexander Kuleshov 3 participants 3 messages Dec 31, 2014 – Jan 16, 2015 x86

lore
Share & tools
lore
#0 lore raw

PATCH v4 1/1 x86/boot/early_serial_console: Remove unnecessary check

There is already the same check before.

---
 arch/x86/boot/early_serial_console.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
arch/x86/boot/early_serial_console.c +2 -2
index 5df2869..2b1c403 100644
@@ -74,8 +74,8 @@ static void parse_earlyprintk(void)
 			static const int bases[] = { 0x3f8, 0x2f8 };
 			int idx = 0;
 
-			if (!strncmp(arg + pos, "ttyS", 4))
-				pos += 4;
+			/* += strlen("ttyS"); */
+			pos += 4;
 
 			if (arg[pos++] == '1')
 				idx = 1;
Signature · 1 line
2.2.1.202.g44ae4ee.dirty
#2 lore raw

[tip:x86/cleanups] x86, early_serial_console: Remove unnecessary check

In reply to Alexander Kuleshov
x86, early_serial_console: Remove unnecessary check
Commit-ID:  b34630014dad0ba69aadd8deb231ddc6d2efcf53
Gitweb:     http://git.kernel.org/tip/b34630014dad0ba69aadd8deb231ddc6d2efcf53
Author:     Alexander Kuleshov <[email protected]>
AuthorDate: Wed, 31 Dec 2014 13:12:38 +0600
Committer:  Borislav Petkov <[email protected]>
CommitDate: Tue, 13 Jan 2015 12:14:44 +0100

x86, early_serial_console: Remove unnecessary check

We do this check already a couple of lines up.

---
 arch/x86/boot/early_serial_console.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
arch/x86/boot/early_serial_console.c +2 -2
index 790586d..45a0768 100644
@@ -72,8 +72,8 @@ static void parse_earlyprintk(void)
 			static const int bases[] = { 0x3f8, 0x2f8 };
 			int idx = 0;
 
-			if (!strncmp(arg + pos, "ttyS", 4))
-				pos += 4;
+			/* += strlen("ttyS"); */
+			pos += 4;
 
 			if (arg[pos++] == '1')
 				idx = 1;