Skip to contentSkip to conversation

x86/boot/early_serial_console: Remove unnecessary check

PATCH Superseded Alexander Kuleshov 2 participants 2 messages Dec 30, 2014 x86

v3 of 4 Superseded Latest is v4 →

lore
Share & tools
lore
#0 lore raw

PATCH v3 1/1 x86/boot/early_serial_console: Remove unnecessary check

There is already the same check before.

---
 arch/x86/boot/early_serial_console.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)
arch/x86/boot/early_serial_console.c +2 -3
index 5df2869..c23bcae 100644
@@ -73,9 +73,8 @@ static void parse_earlyprintk(void)
 		} else if (!strncmp(arg + pos, "ttyS", 4)) {
 			static const int bases[] = { 0x3f8, 0x2f8 };
 			int idx = 0;
-
-			if (!strncmp(arg + pos, "ttyS", 4))
-				pos += 4;
+			/* += strlen("ttyS"); */
+			pos += 4;
 
 			if (arg[pos++] == '1')
 				idx = 1;
Signature · 1 line
2.2.1.202.g44ae4ee.dirty
maintainer
#1 lore raw
Quoted 12 lines · Alexander Kuleshov

There is already the same check before.

---
 arch/x86/boot/early_serial_console.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)
arch/x86/boot/early_serial_console.c +0 -0
index 5df2869..c23bcae 100644

arch/x86/boot/early_serial_console.c static void parse_earlyprintk(void) · line 76

Quoted 4 lines
arch/x86/boot/early_serial_console.c +0 -1
@@ -73,9 +73,8 @@ static void parse_earlyprintk(void)
 		} else if (!strncmp(arg + pos, "ttyS", 4)) {
 			static const int bases[] = { 0x3f8, 0x2f8 };
 			int idx = 0;
-

You've removed the newline here and we usually do leave an empty line between the function local variables declarations and the rest of the function for better readability.

And to answer your question from earlier: yes, if you want to send a corrected patch, please do send it as a reply to this one.

Thanks.

Signature · 5 lines
Regards/Gruss,
    Boris.

Sent from a fat crate under my desk. Formatting is fine.
--