Skip to contentSkip to conversation

armv8/ls2085ardb: Add support of LS2085ARDB platform

PATCH New York Sun 2 participants 6 messages Mar 21, 2015 – Mar 23, 2015 Arm (32-bit)

lore
Share & tools
lore

York Sun

author
#0 lore raw

PATCH v4 20/28 armv8/ls2085ardb: Add support of LS2085ARDB platform

The LS2080ARDB is a evaluation platform that supports LS2080A family SoCs. This patch add sbasic support for the platform.

Signed-off-by York Sun <[email protected]>
Signed-off-by Prabhakar Kushwaha <[email protected]>
Signed-off-by Bhupesh Sharma <[email protected]>
Signed-off-by Scott Wood <[email protected]>

---

Changes in v4:
Fix board README for inconsistent SoC name
Fix comments in board header file

Changes in v3: None
Changes in v2: None

 arch/arm/Kconfig                                   |   11 +++
 arch/arm/cpu/armv8/fsl-lsch3/README                |    4 +-
 board/freescale/{ls2085aqds => ls2085ardb}/Kconfig |    6 +-
 board/freescale/ls2085ardb/MAINTAINERS             |    7 ++
 .../freescale/{ls2085aqds => ls2085ardb}/Makefile  |    2 +-
 board/freescale/{ls2085aqds => ls2085ardb}/README  |   48 ++++---------
 board/freescale/{ls2085aqds => ls2085ardb}/ddr.c   |    0
 board/freescale/{ls2085aqds => ls2085ardb}/ddr.h   |    6 +-
 .../ls2085aqds.c => ls2085ardb/ls2085ardb.c}       |   54 +++-----------
 .../ls2085ardb_qixis.h}                            |   12 +---
 ...qds_ddr4_nor_defconfig => ls2085ardb_defconfig} |    2 +-
 include/configs/{ls2085aqds.h => ls2085ardb.h}     |   75 ++++++++------------
 12 files changed, 82 insertions(+), 145 deletions(-)
 copy board/freescale/{ls2085aqds => ls2085ardb}/Kconfig (66%)
 create mode 100644 board/freescale/ls2085ardb/MAINTAINERS
 copy board/freescale/{ls2085aqds => ls2085ardb}/Makefile (81%)
 copy board/freescale/{ls2085aqds => ls2085ardb}/README (73%)
 copy board/freescale/{ls2085aqds => ls2085ardb}/ddr.c (100%)
 copy board/freescale/{ls2085aqds => ls2085ardb}/ddr.h (93%)
 copy board/freescale/{ls2085aqds/ls2085aqds.c => ls2085ardb/ls2085ardb.c} (76%)
 copy board/freescale/{ls2085aqds/ls2085aqds_qixis.h => ls2085ardb/ls2085ardb_qixis.h} (61%)
 copy configs/{ls1021aqds_ddr4_nor_defconfig => ls2085ardb_defconfig} (66%)
 copy include/configs/{ls2085aqds.h => ls2085ardb.h} (79%)
arch/arm/Kconfig +11 -0
index f4a7851..7478eb4 100644
@@ -658,6 +658,16 @@ config TARGET_LS2085AQDS
 	  development platform that supports the QorIQ LS2085A
 	  Layerscape Architecture processor.
 
+config TARGET_LS2085ARDB
+	bool "Support ls2085ardb"
+	select ARM64
+	select ARMV8_MULTIENTRY
+	help
+	  Support for Freescale LS2085ARDB platform.
+	  The LS2080A Reference design board (RDB) is a high-performance
+	  development platform that supports the QorIQ LS2085A
+	  LayerScape Architecture processor.
+
 config TARGET_LS1021AQDS
 	bool "Support ls1021aqds"
 	select CPU_V7

@@ -804,6 +814,7 @@ source "board/embest/mx6boards/Kconfig"
 source "board/esg/ima3-mx53/Kconfig"
 source "board/freescale/ls2085a/Kconfig"
 source "board/freescale/ls2085aqds/Kconfig"
+source "board/freescale/ls2085ardb/Kconfig"
 source "board/freescale/ls1021aqds/Kconfig"
 source "board/freescale/ls1021atwr/Kconfig"
 source "board/freescale/mx23evk/Kconfig"
arch/arm/cpu/armv8/fsl-lsch3/README +2 -2
index 817ea1b..4f36e2a 100644
@@ -38,7 +38,7 @@ Flash Layout
 	32-MB NOR flash layout for pre-silicon platforms (simulator and emulator)
 
 (2) A typical layout of various images (including Linux and other firmware images)
-    is shown below considering a 128MB NOR flash device present on QDS
+    is shown below considering a 128MB NOR flash device present on QDS and RDB
     boards:
 	----------------------------------------- ----> 0x5_8800_0000 ---
 	|	.. Unused .. (7M)		|			|

@@ -86,7 +86,7 @@ Flash Layout
 	|	RCW and PBI (1M) 		|			|
 	----------------------------------------- ----> 0x5_8000_0000 ---
 
-	128-MB NOR flash layout for QDS board
+	128-MB NOR flash layout for QDS and RDB boards
 
 Environment Variables
 =====================
board/freescale/ls2085ardb/Kconfig renamed from board/freescale/ls2085aqds/Kconfig +3 -3
similarity index 66%
copy from board/freescale/ls2085aqds/Kconfig
copy to board/freescale/ls2085ardb/Kconfig
index deb640d..85a3dcd 100644
@@ -1,8 +1,8 @@
 
-if TARGET_LS2085AQDS
+if TARGET_LS2085ARDB
 
 config SYS_BOARD
-	default "ls2085aqds"
+	default "ls2085ardb"
 
 config SYS_VENDOR
 	default "freescale"

@@ -11,6 +11,6 @@ config SYS_SOC
 	default "fsl-lsch3"
 
 config SYS_CONFIG_NAME
-	default "ls2085aqds"
+	default "ls2085ardb"
 
 endif
board/freescale/ls2085ardb/MAINTAINERS new file +7 -0
new file mode 100644
index 0000000..436039f
@@ -0,0 +1,7 @@
+LS2085A BOARD
+M:	Prabhakar Kushwaha <[email protected]>
+S:	Maintained
+F:	board/freescale/ls2085ardb/
+F:	board/freescale/ls2085a/ls2085ardb.c
+F:	include/configs/ls2085ardb.h
+F:	configs/ls2085ardb_defconfig
board/freescale/ls2085ardb/Makefile renamed from board/freescale/ls2085aqds/Makefile +1 -1
similarity index 81%
copy from board/freescale/ls2085aqds/Makefile
copy to board/freescale/ls2085ardb/Makefile
index f174f33..0bfe21c 100644
@@ -4,5 +4,5 @@
 # SPDX-License-Identifier:	GPL-2.0+
 #
 
-obj-y += ls2085aqds.o
+obj-y += ls2085ardb.o
 obj-y += ddr.o
board/freescale/ls2085ardb/README renamed from board/freescale/ls2085aqds/README +14 -34

89 lines not on this page · raw message

board/freescale/ls2085ardb/ddr.c renamed from board/freescale/ls2085aqds/ddr.c +0 -0
similarity index 100%
copy from board/freescale/ls2085aqds/ddr.c
copy to board/freescale/ls2085ardb/ddr.c
board/freescale/ls2085ardb/ddr.h renamed from board/freescale/ls2085aqds/ddr.h +3 -3
similarity index 93%
copy from board/freescale/ls2085aqds/ddr.h
copy to board/freescale/ls2085ardb/ddr.h
index b76ea61..bda9d4a 100644
@@ -29,9 +29,9 @@ static const struct board_specific_parameters udimm0[] = {
 	 * ranks| mhz| GB  |adjst| start |   ctl2    |  ctl3
 	 */
 	{2,  1350, 0, 4,     6, 0x0708090B, 0x0C0D0E09,},
-	{2,  1666, 0, 4,     7, 0x08090A0C, 0x0D0F100B,},
-	{2,  1900, 0, 4,     7, 0x09090B0D, 0x0E10120B,},
-	{2,  2300, 0, 4,     8, 0x090A0C0F, 0x1012130C,},
+	{2,  1666, 0, 4,     8, 0x08090B0D, 0x0E10100C,},
+	{2,  1900, 0, 4,     8, 0x090A0C0E, 0x1012120D,},
+	{2,  2300, 0, 4,     9, 0x0A0B0C10, 0x1114140E,},
 	{}
 };
board/freescale/ls2085ardb/ls2085ardb.c renamed from board/freescale/ls2085aqds/ls2085aqds.c +8 -46

94 lines not on this page · raw message

board/freescale/ls2085ardb/ls2085ardb_qixis.h renamed from board/freescale/ls2085aqds/ls2085aqds_qixis.h +3 -9
similarity index 61%
copy from board/freescale/ls2085aqds/ls2085aqds_qixis.h
copy to board/freescale/ls2085ardb/ls2085ardb_qixis.h
index bb43e65..cb60c00 100644
@@ -4,8 +4,8 @@
  * SPDX-License-Identifier:	GPL-2.0+
  */
 
-#ifndef __LS2_QDS_QIXIS_H__
-#define __LS2_QDS_QIXIS_H__
+#ifndef __LS2_RDB_QIXIS_H__
+#define __LS2_RDB_QIXIS_H__
 
 /* SYSCLK */
 #define QIXIS_SYSCLK_66			0x0

@@ -17,10 +17,4 @@
 #define QIXIS_SYSCLK_160		0x6
 #define QIXIS_SYSCLK_166		0x7
 
-/* DDRCLK */
-#define QIXIS_DDRCLK_66			0x0
-#define QIXIS_DDRCLK_100		0x1
-#define QIXIS_DDRCLK_125		0x2
-#define QIXIS_DDRCLK_133		0x3
-
-#endif /*__LS2_QDS_QIXIS_H__*/
+#endif /*__LS2_RDB_QIXIS_H__*/
configs/ls2085ardb_defconfig renamed from configs/ls1021aqds_ddr4_nor_defconfig +1 -1
similarity index 66%
copy from configs/ls1021aqds_ddr4_nor_defconfig
copy to configs/ls2085ardb_defconfig
index 3c57481..6b64f71 100644
@@ -1,3 +1,3 @@
 CONFIG_SYS_EXTRA_OPTIONS="SYS_FSL_DDR4"
 CONFIG_ARM=y
-CONFIG_TARGET_LS1021AQDS=y
+CONFIG_TARGET_LS2085ARDB=y
include/configs/ls2085ardb.h renamed from include/configs/ls2085aqds.h +29 -46

142 lines not on this page · raw message

Signature · 1 line
1.7.9.5
#1 lore raw

PATCH v4 20/28 armv8/ls2085ardb: Add support of LS2085ARDB platform

Quoted 8 lines · York Sun
arch/arm/Kconfig +0 -0
index f4a7851..7478eb4 100644
@@ -658,6 +658,16 @@ config TARGET_LS2085AQDS
 	  development platform that supports the QorIQ LS2085A
 	  Layerscape Architecture processor.

arch/arm/Kconfig config TARGET_LS2085AQDS · line 670

Quoted 10 lines
arch/arm/Kconfig +10 -0
+config TARGET_LS2085ARDB
+	bool "Support ls2085ardb"
+	select ARM64
+	select ARMV8_MULTIENTRY
+	help
+	  Support for Freescale LS2085ARDB platform.
+	  The LS2080A Reference design board (RDB) is a high-performance
+	  development platform that supports the QorIQ LS2085A
+	  LayerScape Architecture processor.
+

s/LayerScape/Layerscape/

Quoted 8 lines
board/freescale/ls2085ardb/README renamed from board/freescale/ls2085aqds/README +0 -0
similarity index 73%
copy from board/freescale/ls2085aqds/README
copy to board/freescale/ls2085ardb/README
index a4d7b53..cfd5185 100644

board/freescale/ls2085ardb/README line 5

Quoted 10 lines
board/freescale/ls2085ardb/README renamed from board/freescale/ls2085aqds/README +3 -5
@@ -1,10 +1,8 @@
 Overview
 --------
-The LS2080A Development System (QDS) is a high-performance computing,
-evaluation, and development platform that supports the QorIQ LS2080A
-LayerScape Architecture processor. The LS2080AQDS provides validation and
-SW development platform for the Freescale LS2080A processor series, with
-a complete debugging environment.
+The LS2085A Reference Design (RDB) is a high-performance computing,
+evaluation, and development platform that supports the QorIQ LS2085A
+Layerscape Architecture processor.

"LayerScape" and 2080 should be fixed in the QDS patch as well.

board/freescale/ls2085ardb/README unsigned long get_board_ddr_clk(void); · line 111

Quoted 12 lines
board/freescale/ls2085ardb/README renamed from board/freescale/ls2085aqds/README +4 -4
@@ -113,25 +105,25 @@ unsigned long get_board_ddr_clk(void);
 #define CONFIG_SYS_NAND_CSOR    (CSOR_NAND_ECC_ENC_EN   /* ECC on encode */ \
 				| CSOR_NAND_ECC_DEC_EN  /* ECC on decode */ \
 				| CSOR_NAND_ECC_MODE_4  /* 4-bit ECC */ \
-				| CSOR_NAND_RAL_3	/* RAL = 2Byes */ \
-				| CSOR_NAND_PGS_2K	/* Page Size = 2K */ \
-				| CSOR_NAND_SPRZ_64/* Spare size = 64 */ \
-				| CSOR_NAND_PB(64))	/*Pages Per Block = 64*/
+				| CSOR_NAND_RAL_3	/* RAL = 3Byes */ \
+				| CSOR_NAND_PGS_4K	/* Page Size = 4K */ \
+				| CSOR_NAND_SPRZ_224	/* Spare size = 224 */ \
+				| CSOR_NAND_PB(128))	/*Pages Per Block = 128*/

From this it looks like the QDS patch still has a comment/code inconsistency with RAL.

-Scott

author
#2 lore raw

PATCH v4 20/28 armv8/ls2085ardb: Add support of LS2085ARDB platform

Quoted 43 lines · Scott Wood
Quoted 8 lines · York Sun
arch/arm/Kconfig +0 -0
index f4a7851..7478eb4 100644
@@ -658,6 +658,16 @@ config TARGET_LS2085AQDS
 	  development platform that supports the QorIQ LS2085A
 	  Layerscape Architecture processor.

arch/arm/Kconfig config TARGET_LS2085AQDS · line 670

Quoted 10 lines
arch/arm/Kconfig +10 -0
+config TARGET_LS2085ARDB
+	bool "Support ls2085ardb"
+	select ARM64
+	select ARMV8_MULTIENTRY
+	help
+	  Support for Freescale LS2085ARDB platform.
+	  The LS2080A Reference design board (RDB) is a high-performance
+	  development platform that supports the QorIQ LS2085A
+	  LayerScape Architecture processor.
+

s/LayerScape/Layerscape/

Quoted 8 lines
board/freescale/ls2085ardb/README renamed from board/freescale/ls2085aqds/README +0 -0
similarity index 73%
copy from board/freescale/ls2085aqds/README
copy to board/freescale/ls2085ardb/README
index a4d7b53..cfd5185 100644

board/freescale/ls2085ardb/README line 5

Quoted 10 lines
board/freescale/ls2085ardb/README renamed from board/freescale/ls2085aqds/README +3 -5
@@ -1,10 +1,8 @@
 Overview
 --------
-The LS2080A Development System (QDS) is a high-performance computing,
-evaluation, and development platform that supports the QorIQ LS2080A
-LayerScape Architecture processor. The LS2080AQDS provides validation and
-SW development platform for the Freescale LS2080A processor series, with
-a complete debugging environment.
+The LS2085A Reference Design (RDB) is a high-performance computing,
+evaluation, and development platform that supports the QorIQ LS2085A
+Layerscape Architecture processor.

"LayerScape" and 2080 should be fixed in the QDS patch as well.

Quoted 16 lines

board/freescale/ls2085ardb/README unsigned long get_board_ddr_clk(void); · line 111

Quoted 12 lines
board/freescale/ls2085ardb/README renamed from board/freescale/ls2085aqds/README +4 -4
@@ -113,25 +105,25 @@ unsigned long get_board_ddr_clk(void);
 #define CONFIG_SYS_NAND_CSOR    (CSOR_NAND_ECC_ENC_EN   /* ECC on encode */ \
 				| CSOR_NAND_ECC_DEC_EN  /* ECC on decode */ \
 				| CSOR_NAND_ECC_MODE_4  /* 4-bit ECC */ \
-				| CSOR_NAND_RAL_3	/* RAL = 2Byes */ \
-				| CSOR_NAND_PGS_2K	/* Page Size = 2K */ \
-				| CSOR_NAND_SPRZ_64/* Spare size = 64 */ \
-				| CSOR_NAND_PB(64))	/*Pages Per Block = 64*/
+				| CSOR_NAND_RAL_3	/* RAL = 3Byes */ \
+				| CSOR_NAND_PGS_4K	/* Page Size = 4K */ \
+				| CSOR_NAND_SPRZ_224	/* Spare size = 224 */ \
+				| CSOR_NAND_PB(128))	/*Pages Per Block = 128*/

From this it looks like the QDS patch still has a comment/code inconsistency with RAL.

Let me re-generate the patch using patman, without -C --find-copies-harder flag so they don't show as copy-n-modify.

York

#3 lore raw

PATCH v4 20/28 armv8/ls2085ardb: Add support of LS2085ARDB platform

Quoted 62 lines · York Sun
Quoted 43 lines · Scott Wood
Quoted 8 lines · York Sun
arch/arm/Kconfig +0 -0
index f4a7851..7478eb4 100644
@@ -658,6 +658,16 @@ config TARGET_LS2085AQDS
 	  development platform that supports the QorIQ LS2085A
 	  Layerscape Architecture processor.

arch/arm/Kconfig config TARGET_LS2085AQDS · line 670

Quoted 10 lines
arch/arm/Kconfig +10 -0
+config TARGET_LS2085ARDB
+	bool "Support ls2085ardb"
+	select ARM64
+	select ARMV8_MULTIENTRY
+	help
+	  Support for Freescale LS2085ARDB platform.
+	  The LS2080A Reference design board (RDB) is a high-performance
+	  development platform that supports the QorIQ LS2085A
+	  LayerScape Architecture processor.
+

s/LayerScape/Layerscape/

Quoted 8 lines
board/freescale/ls2085ardb/README renamed from board/freescale/ls2085aqds/README +0 -0
similarity index 73%
copy from board/freescale/ls2085aqds/README
copy to board/freescale/ls2085ardb/README
index a4d7b53..cfd5185 100644

board/freescale/ls2085ardb/README line 5

Quoted 10 lines
board/freescale/ls2085ardb/README renamed from board/freescale/ls2085aqds/README +3 -5
@@ -1,10 +1,8 @@
 Overview
 --------
-The LS2080A Development System (QDS) is a high-performance computing,
-evaluation, and development platform that supports the QorIQ LS2080A
-LayerScape Architecture processor. The LS2080AQDS provides validation and
-SW development platform for the Freescale LS2080A processor series, with
-a complete debugging environment.
+The LS2085A Reference Design (RDB) is a high-performance computing,
+evaluation, and development platform that supports the QorIQ LS2085A
+Layerscape Architecture processor.

"LayerScape" and 2080 should be fixed in the QDS patch as well.

Quoted 16 lines

board/freescale/ls2085ardb/README unsigned long get_board_ddr_clk(void); · line 111

Quoted 12 lines
board/freescale/ls2085ardb/README renamed from board/freescale/ls2085aqds/README +4 -4
@@ -113,25 +105,25 @@ unsigned long get_board_ddr_clk(void);
 #define CONFIG_SYS_NAND_CSOR    (CSOR_NAND_ECC_ENC_EN   /* ECC on encode */ \
 				| CSOR_NAND_ECC_DEC_EN  /* ECC on decode */ \
 				| CSOR_NAND_ECC_MODE_4  /* 4-bit ECC */ \
-				| CSOR_NAND_RAL_3	/* RAL = 2Byes */ \
-				| CSOR_NAND_PGS_2K	/* Page Size = 2K */ \
-				| CSOR_NAND_SPRZ_64/* Spare size = 64 */ \
-				| CSOR_NAND_PB(64))	/*Pages Per Block = 64*/
+				| CSOR_NAND_RAL_3	/* RAL = 3Byes */ \
+				| CSOR_NAND_PGS_4K	/* Page Size = 4K */ \
+				| CSOR_NAND_SPRZ_224	/* Spare size = 224 */ \
+				| CSOR_NAND_PB(128))	/*Pages Per Block = 128*/

From this it looks like the QDS patch still has a comment/code inconsistency with RAL.

Quoted 2 lines

Let me re-generate the patch using patman, without -C --find-copies-harder flag so they don't show as copy-n-modify.

Why? I found it rather useful. In any case, the error in the QDS file will still be there.

-SCott

author
#4 lore raw

PATCH v4 20/28 armv8/ls2085ardb: Add support of LS2085ARDB platform

Quoted 63 lines · Scott Wood
Quoted 62 lines · York Sun
Quoted 59 lines · Scott Wood
Quoted 8 lines · York Sun
arch/arm/Kconfig +0 -0
index f4a7851..7478eb4 100644
@@ -658,6 +658,16 @@ config TARGET_LS2085AQDS
 	  development platform that supports the QorIQ LS2085A
 	  Layerscape Architecture processor.

arch/arm/Kconfig config TARGET_LS2085AQDS · line 670

Quoted 10 lines
arch/arm/Kconfig +10 -0
+config TARGET_LS2085ARDB
+	bool "Support ls2085ardb"
+	select ARM64
+	select ARMV8_MULTIENTRY
+	help
+	  Support for Freescale LS2085ARDB platform.
+	  The LS2080A Reference design board (RDB) is a high-performance
+	  development platform that supports the QorIQ LS2085A
+	  LayerScape Architecture processor.
+

s/LayerScape/Layerscape/

Quoted 8 lines
board/freescale/ls2085ardb/README renamed from board/freescale/ls2085aqds/README +0 -0
similarity index 73%
copy from board/freescale/ls2085aqds/README
copy to board/freescale/ls2085ardb/README
index a4d7b53..cfd5185 100644

board/freescale/ls2085ardb/README line 5

Quoted 10 lines
board/freescale/ls2085ardb/README renamed from board/freescale/ls2085aqds/README +3 -5
@@ -1,10 +1,8 @@
 Overview
 --------
-The LS2080A Development System (QDS) is a high-performance computing,
-evaluation, and development platform that supports the QorIQ LS2080A
-LayerScape Architecture processor. The LS2080AQDS provides validation and
-SW development platform for the Freescale LS2080A processor series, with
-a complete debugging environment.
+The LS2085A Reference Design (RDB) is a high-performance computing,
+evaluation, and development platform that supports the QorIQ LS2085A
+Layerscape Architecture processor.

"LayerScape" and 2080 should be fixed in the QDS patch as well.

board/freescale/ls2085ardb/README unsigned long get_board_ddr_clk(void); · line 111

Quoted 12 lines
board/freescale/ls2085ardb/README renamed from board/freescale/ls2085aqds/README +4 -4
@@ -113,25 +105,25 @@ unsigned long get_board_ddr_clk(void);
 #define CONFIG_SYS_NAND_CSOR    (CSOR_NAND_ECC_ENC_EN   /* ECC on encode */ \
 				| CSOR_NAND_ECC_DEC_EN  /* ECC on decode */ \
 				| CSOR_NAND_ECC_MODE_4  /* 4-bit ECC */ \
-				| CSOR_NAND_RAL_3	/* RAL = 2Byes */ \
-				| CSOR_NAND_PGS_2K	/* Page Size = 2K */ \
-				| CSOR_NAND_SPRZ_64/* Spare size = 64 */ \
-				| CSOR_NAND_PB(64))	/*Pages Per Block = 64*/
+				| CSOR_NAND_RAL_3	/* RAL = 3Byes */ \
+				| CSOR_NAND_PGS_4K	/* Page Size = 4K */ \
+				| CSOR_NAND_SPRZ_224	/* Spare size = 224 */ \
+				| CSOR_NAND_PB(128))	/*Pages Per Block = 128*/

From this it looks like the QDS patch still has a comment/code inconsistency with RAL.

Quoted 6 lines
Quoted 2 lines

Let me re-generate the patch using patman, without -C --find-copies-harder flag so they don't show as copy-n-modify.

Why? I found it rather useful. In any case, the error in the QDS file will still be there.

I have to modify patman to have these flags. Personally I prefer to use them. But I guess if everyone uses the patman, so should I.

York

#5 lore raw

PATCH v4 20/28 armv8/ls2085ardb: Add support of LS2085ARDB platform

Quoted 65 lines · York Sun
Quoted 63 lines · Scott Wood
Quoted 62 lines · York Sun
Quoted 59 lines · Scott Wood
Quoted 8 lines · York Sun
arch/arm/Kconfig +0 -0
index f4a7851..7478eb4 100644
@@ -658,6 +658,16 @@ config TARGET_LS2085AQDS
 	  development platform that supports the QorIQ LS2085A
 	  Layerscape Architecture processor.

arch/arm/Kconfig config TARGET_LS2085AQDS · line 670

Quoted 10 lines
arch/arm/Kconfig +10 -0
+config TARGET_LS2085ARDB
+	bool "Support ls2085ardb"
+	select ARM64
+	select ARMV8_MULTIENTRY
+	help
+	  Support for Freescale LS2085ARDB platform.
+	  The LS2080A Reference design board (RDB) is a high-performance
+	  development platform that supports the QorIQ LS2085A
+	  LayerScape Architecture processor.
+

s/LayerScape/Layerscape/

Quoted 8 lines
board/freescale/ls2085ardb/README renamed from board/freescale/ls2085aqds/README +0 -0
similarity index 73%
copy from board/freescale/ls2085aqds/README
copy to board/freescale/ls2085ardb/README
index a4d7b53..cfd5185 100644

board/freescale/ls2085ardb/README line 5

Quoted 10 lines
board/freescale/ls2085ardb/README renamed from board/freescale/ls2085aqds/README +3 -5
@@ -1,10 +1,8 @@
 Overview
 --------
-The LS2080A Development System (QDS) is a high-performance computing,
-evaluation, and development platform that supports the QorIQ LS2080A
-LayerScape Architecture processor. The LS2080AQDS provides validation and
-SW development platform for the Freescale LS2080A processor series, with
-a complete debugging environment.
+The LS2085A Reference Design (RDB) is a high-performance computing,
+evaluation, and development platform that supports the QorIQ LS2085A
+Layerscape Architecture processor.

"LayerScape" and 2080 should be fixed in the QDS patch as well.

board/freescale/ls2085ardb/README unsigned long get_board_ddr_clk(void); · line 111

Quoted 12 lines
board/freescale/ls2085ardb/README renamed from board/freescale/ls2085aqds/README +4 -4
@@ -113,25 +105,25 @@ unsigned long get_board_ddr_clk(void);
 #define CONFIG_SYS_NAND_CSOR    (CSOR_NAND_ECC_ENC_EN   /* ECC on encode */ \
 				| CSOR_NAND_ECC_DEC_EN  /* ECC on decode */ \
 				| CSOR_NAND_ECC_MODE_4  /* 4-bit ECC */ \
-				| CSOR_NAND_RAL_3	/* RAL = 2Byes */ \
-				| CSOR_NAND_PGS_2K	/* Page Size = 2K */ \
-				| CSOR_NAND_SPRZ_64/* Spare size = 64 */ \
-				| CSOR_NAND_PB(64))	/*Pages Per Block = 64*/
+				| CSOR_NAND_RAL_3	/* RAL = 3Byes */ \
+				| CSOR_NAND_PGS_4K	/* Page Size = 4K */ \
+				| CSOR_NAND_SPRZ_224	/* Spare size = 224 */ \
+				| CSOR_NAND_PB(128))	/*Pages Per Block = 128*/

From this it looks like the QDS patch still has a comment/code inconsistency with RAL.

Quoted 8 lines
Quoted 6 lines
Quoted 2 lines

Let me re-generate the patch using patman, without -C --find-copies-harder flag so they don't show as copy-n-modify.

Why? I found it rather useful. In any case, the error in the QDS file will still be there.

I have to modify patman to have these flags. Personally I prefer to use them.

I don't understand what this has to do with my original comment.

Quoted 1 line

But I guess if everyone uses the patman, so should I.

I don't think it's mandatory. :-)

Assuming you're getting some benefit from patman, you could add support for those flags. They're useful.

-Scott