ARM: dts: odroidxu3: Enable USB3 regulators

PATCH Superseded Anand Moon 2 participants 4 messages May 29, 2015

Subsystems (2)

Device tree bindings Arm Samsung Exynos

lore

Share & tools

lore

Anand Moon

author

2015-05-29 13:34 UTC #0 lore raw

PATCH v2 1/1 ARM: dts: odroidxu3: Enable USB3 regulators

Enable regulator for usbdrd3_0 and usbdrd3_1.
Looking at the schematic pin diagram for MAX77802
USB3_0 and USB3_1 is regulated by LDO9 and LD011.

Fix the boot message of failed.

[    3.503539] exynos-dwc3 usb at 12000000: Looking up vdd33-supply from device tree
[    3.503556] exynos-dwc3 usb at 12000000: Looking up vdd33-supply property in node /usb at 12000000 failed
[    3.503568] usb at 12000000 supply vdd33 not found, using dummy regulator
[    3.509154] exynos-dwc3 usb at 12000000: Looking up vdd10-supply from device tree
[    3.509170] exynos-dwc3 usb at 12000000: Looking up vdd10-supply property in node /usb at 12000000 failed
[    3.509181] usb at 12000000 supply vdd10 not found, using dummy regulator
[    3.917548] exynos-dwc3 usb at 12400000: Looking up vdd33-supply from device tree
[    3.917565] exynos-dwc3 usb at 12400000: Looking up vdd33-supply property in node /usb at 12400000 failed
[    3.917578] usb at 12400000 supply vdd33 not found, using dummy regulator
[    3.922731] exynos-dwc3 usb at 12400000: Looking up vdd10-supply from device tree
[    3.922747] exynos-dwc3 usb at 12400000: Looking up vdd10-supply property in node /usb at 12400000 failed

---
This patch is based on Krzysztof github branch work-next/odroid-xu3-s2mps11-irq. v2 - Fixed the comment.
---

Tested-by Krzysztof Kozlowski <[email protected]>

Signed-off-by Anand Moon <[email protected]>

---
 arch/arm/boot/dts/exynos5422-odroidxu3.dts | 10 ++++++++++
 1 file changed, 10 insertions(+)

arch/arm/boot/dts/exynos5422-odroidxu3.dts +10 -0

index 27014bb..a353a58 100644
@@ -513,3 +513,13 @@
 &usbdrd_dwc3_1 {
 	dr_mode = "otg";
 };
+
+&usbdrd3_0 {
+	vdd33-supply = <&ldo9_reg>;
+	vdd10-supply = <&ldo11_reg>;
+};
+
+&usbdrd3_1 {
+	vdd33-supply = <&ldo9_reg>;
+	vdd10-supply = <&ldo11_reg>;
+};

Signature · 1 line

1.9.1

Javier Martinez Canillas

2015-05-29 13:49 UTC #1 lore raw

Hello Anand,

Quoted 22 lines · Anand Moon

Enable regulator for usbdrd3_0 and usbdrd3_1.
Looking at the schematic pin diagram for MAX77802
USB3_0 and USB3_1 is regulated by LDO9 and LD011.

Fix the boot message of failed.

[    3.503539] exynos-dwc3 usb at 12000000: Looking up vdd33-supply from device tree
[    3.503556] exynos-dwc3 usb at 12000000: Looking up vdd33-supply property in node /usb at 12000000 failed
[    3.503568] usb at 12000000 supply vdd33 not found, using dummy regulator
[    3.509154] exynos-dwc3 usb at 12000000: Looking up vdd10-supply from device tree
[    3.509170] exynos-dwc3 usb at 12000000: Looking up vdd10-supply property in node /usb at 12000000 failed
[    3.509181] usb at 12000000 supply vdd10 not found, using dummy regulator
[    3.917548] exynos-dwc3 usb at 12400000: Looking up vdd33-supply from device tree
[    3.917565] exynos-dwc3 usb at 12400000: Looking up vdd33-supply property in node /usb at 12400000 failed
[    3.917578] usb at 12400000 supply vdd33 not found, using dummy regulator
[    3.922731] exynos-dwc3 usb at 12400000: Looking up vdd10-supply from device tree
[    3.922747] exynos-dwc3 usb at 12400000: Looking up vdd10-supply property in node /usb at 12400000 failed

---
This patch is based on Krzysztof github branch work-next/odroid-xu3-s2mps11-irq. v2 - Fixed the comment.
---

Quoted 6 lines

Tested-by Krzysztof Kozlowski <[email protected]>
Signed-off-by Anand Moon <[email protected]>
---
 arch/arm/boot/dts/exynos5422-odroidxu3.dts | 10 ++++++++++
 1 file changed, 10 insertions(+)

Your commit message is again not correct. Sorry if this is a long explanation but I want you to understand how the git tools work.

What git am and other git tools do is to strip any text that is between the first "---" and the actual diff. With git format-patch the information that is placed there by default is the file(s) diffstat since that is a useful information for someone reviewing your patches but not so to be part of the commit message, you can get it anyways later with git $commitId --stat.

So what people do is to add information after the first "---" that is relevant for reviewers but don't want to end the commit message. Usually this is the patch change history but it can contain any other information like links to previous patches, dependencies posted previously, etc.

With your current patch, that means that git am will strip your Signed-off-by and Krzysztof's Tested-by tags which should be part of the commit message.

Krzysztof already mentioned but a good exercise would be to generate your patch with git format-patch and then apply again with git am to see if the end result is what you were expecting for.

Hope it helps,
Javier

Anand Moon

author Tested-by Krzysztof Kozlowski

2015-05-29 14:25 UTC #2 lore raw

Hi Javier,

Ok sorry for the mistake and not following the protocol. Now I clearly understood my mistake. It will not be repeated. I will resend the patch.

Is this correct format to follow.

Tested-by Krzysztof Kozlowski <[email protected]>

Signed-off-by Anand Moon <[email protected]>

---
This patch is based on Krzysztof github branch
work-next/odroid-xu3-s2mps11-irq.
v2 - Fixed the comment.

-Anand Moon

Quoted 58 lines · Javier Martinez Canillas

Hello Anand,
Quoted 22 lines · Anand Moon
Enable regulator for usbdrd3_0 and usbdrd3_1.
Looking at the schematic pin diagram for MAX77802
USB3_0 and USB3_1 is regulated by LDO9 and LD011.
Fix the boot message of failed.
[    3.503539] exynos-dwc3 usb at 12000000: Looking up vdd33-supply from device tree
[    3.503556] exynos-dwc3 usb at 12000000: Looking up vdd33-supply property in node /usb at 12000000 failed
[    3.503568] usb at 12000000 supply vdd33 not found, using dummy regulator
[    3.509154] exynos-dwc3 usb at 12000000: Looking up vdd10-supply from device tree
[    3.509170] exynos-dwc3 usb at 12000000: Looking up vdd10-supply property in node /usb at 12000000 failed
[    3.509181] usb at 12000000 supply vdd10 not found, using dummy regulator
[    3.917548] exynos-dwc3 usb at 12400000: Looking up vdd33-supply from device tree
[    3.917565] exynos-dwc3 usb at 12400000: Looking up vdd33-supply property in node /usb at 12400000 failed
[    3.917578] usb at 12400000 supply vdd33 not found, using dummy regulator
[    3.922731] exynos-dwc3 usb at 12400000: Looking up vdd10-supply from device tree
[    3.922747] exynos-dwc3 usb at 12400000: Looking up vdd10-supply property in node /usb at 12400000 failed
---
This patch is based on Krzysztof github branch work-next/odroid-xu3-s2mps11-irq. v2 - Fixed the comment.
---
Quoted 6 lines
Tested-by Krzysztof Kozlowski <[email protected]>
Signed-off-by Anand Moon <[email protected]>
---
 arch/arm/boot/dts/exynos5422-odroidxu3.dts | 10 ++++++++++
 1 file changed, 10 insertions(+)
Your commit message is again not correct. Sorry if this is a long explanation but I want you to understand how the git tools work.
What git am and other git tools do is to strip any text that is between the first "---" and the actual diff. With git format-patch the information that is placed there by default is the file(s) diffstat since that is a useful information for someone reviewing your patches but not so to be part of the commit message, you can get it anyways later with git $commitId --stat.
So what people do is to add information after the first "---" that is relevant for reviewers but don't want to end the commit message. Usually this is the patch change history but it can contain any other information like links to previous patches, dependencies posted previously, etc.
With your current patch, that means that git am will strip your Signed-off-by and Krzysztof's Tested-by tags which should be part of the commit message.
Krzysztof already mentioned but a good exercise would be to generate your patch with git format-patch and then apply again with git am to see if the end result is what you were expecting for.
Hope it helps,
Javier

Javier Martinez Canillas

2015-05-29 14:28 UTC #3 lore raw

Hello Anand,

Quoted 6 lines · Anand Moon

Hi Javier,
Ok sorry for the mistake and not following the protocol. Now I clearly understood my mistake. It will not be repeated. I will resend the patch.

Quoted 9 lines

Is this correct format to follow.
Tested-by Krzysztof Kozlowski <[email protected]>
Signed-off-by Anand Moon <[email protected]>
---
This patch is based on Krzysztof github branch
work-next/odroid-xu3-s2mps11-irq.
v2 - Fixed the comment.

Yes, that's a correct way of doing it.

One minor nit: I think your Signed-off-by tag should be before Krzysztof's Tested-by since first you posted the patch and then he tested it.

Quoted 2 lines

-Anand Moon

Best regards,
Javier

Quoted 59 lines · Javier Martinez Canillas

Quoted 58 lines
Hello Anand,
Quoted 22 lines · Anand Moon
Enable regulator for usbdrd3_0 and usbdrd3_1.
Looking at the schematic pin diagram for MAX77802
USB3_0 and USB3_1 is regulated by LDO9 and LD011.
Fix the boot message of failed.
[    3.503539] exynos-dwc3 usb at 12000000: Looking up vdd33-supply from device tree
[    3.503556] exynos-dwc3 usb at 12000000: Looking up vdd33-supply property in node /usb at 12000000 failed
[    3.503568] usb at 12000000 supply vdd33 not found, using dummy regulator
[    3.509154] exynos-dwc3 usb at 12000000: Looking up vdd10-supply from device tree
[    3.509170] exynos-dwc3 usb at 12000000: Looking up vdd10-supply property in node /usb at 12000000 failed
[    3.509181] usb at 12000000 supply vdd10 not found, using dummy regulator
[    3.917548] exynos-dwc3 usb at 12400000: Looking up vdd33-supply from device tree
[    3.917565] exynos-dwc3 usb at 12400000: Looking up vdd33-supply property in node /usb at 12400000 failed
[    3.917578] usb at 12400000 supply vdd33 not found, using dummy regulator
[    3.922731] exynos-dwc3 usb at 12400000: Looking up vdd10-supply from device tree
[    3.922747] exynos-dwc3 usb at 12400000: Looking up vdd10-supply property in node /usb at 12400000 failed
---
This patch is based on Krzysztof github branch work-next/odroid-xu3-s2mps11-irq. v2 - Fixed the comment.
---
Quoted 6 lines
Tested-by Krzysztof Kozlowski <[email protected]>
Signed-off-by Anand Moon <[email protected]>
---
 arch/arm/boot/dts/exynos5422-odroidxu3.dts | 10 ++++++++++
 1 file changed, 10 insertions(+)
Your commit message is again not correct. Sorry if this is a long explanation but I want you to understand how the git tools work.
What git am and other git tools do is to strip any text that is between the first "---" and the actual diff. With git format-patch the information that is placed there by default is the file(s) diffstat since that is a useful information for someone reviewing your patches but not so to be part of the commit message, you can get it anyways later with git $commitId --stat.
So what people do is to add information after the first "---" that is relevant for reviewers but don't want to end the commit message. Usually this is the patch change history but it can contain any other information like links to previous patches, dependencies posted previously, etc.
With your current patch, that means that git am will strip your Signed-off-by and Krzysztof's Tested-by tags which should be part of the commit message.
Krzysztof already mentioned but a good exercise would be to generate your patch with git format-patch and then apply again with git am to see if the end result is what you were expecting for.
Hope it helps,
Javier