Skip to contentSkip to conversation

ARM: dts: odroidxu3: Enable USB3 regulators

PATCH In review Anand Moon 2 participants 4 messages May 29, 2015 – Jun 7, 2015

Subsystems (2)
Device tree bindings Arm Samsung Exynos
lore
Share & tools
lore

Anand Moon

author
#0 lore raw

PATCH v3 1/1 ARM: dts: odroidxu3: Enable USB3 regulators

Enable regulator for usbdrd3_0 and usbdrd3_1. Looking at the schematic pin diagram for MAX77802 USB3_0 and USB3_1 is regulated by LDO9 and LD011.

Fix the boot message of failed.

[    3.503539] exynos-dwc3 usb at 12000000: Looking up vdd33-supply from device tree
[    3.503556] exynos-dwc3 usb at 12000000: Looking up vdd33-supply property in node /usb at 12000000 failed
[    3.503568] usb at 12000000 supply vdd33 not found, using dummy regulator
[    3.509154] exynos-dwc3 usb at 12000000: Looking up vdd10-supply from device tree
[    3.509170] exynos-dwc3 usb at 12000000: Looking up vdd10-supply property in node /usb at 12000000 failed
[    3.509181] usb at 12000000 supply vdd10 not found, using dummy regulator
[    3.917548] exynos-dwc3 usb at 12400000: Looking up vdd33-supply from device tree
[    3.917565] exynos-dwc3 usb at 12400000: Looking up vdd33-supply property in node /usb at 12400000 failed
[    3.917578] usb at 12400000 supply vdd33 not found, using dummy regulator
[    3.922731] exynos-dwc3 usb at 12400000: Looking up vdd10-supply from device tree
[    3.922747] exynos-dwc3 usb at 12400000: Looking up vdd10-supply property in node /usb at 12400000 failed
Tested-by Krzysztof Kozlowski <[email protected]>
Signed-off-by Anand Moon <[email protected]>
---
 arch/arm/boot/dts/exynos5422-odroidxu3.dts | 10 ++++++++++
 1 file changed, 10 insertions(+)
arch/arm/boot/dts/exynos5422-odroidxu3.dts +10 -0
index 27014bb..a353a58 100644
@@ -513,3 +513,13 @@
 &usbdrd_dwc3_1 {
 	dr_mode = "otg";
 };
+
+&usbdrd3_0 {
+	vdd33-supply = <&ldo9_reg>;
+	vdd10-supply = <&ldo11_reg>;
+};
+
+&usbdrd3_1 {
+	vdd33-supply = <&ldo9_reg>;
+	vdd10-supply = <&ldo11_reg>;
+};
Signature · 1 line
1.9.1
Reviewed-by on v3 1/1
#1 lore raw

W dniu 29.05.2015 o 23:30, Anand Moon pisze:

Quoted 17 lines

Enable regulator for usbdrd3_0 and usbdrd3_1. Looking at the schematic pin diagram for MAX77802 USB3_0 and USB3_1 is regulated by LDO9 and LD011.

Fix the boot message of failed.

[    3.503539] exynos-dwc3 usb at 12000000: Looking up vdd33-supply from device tree
[    3.503556] exynos-dwc3 usb at 12000000: Looking up vdd33-supply property in node /usb at 12000000 failed
[    3.503568] usb at 12000000 supply vdd33 not found, using dummy regulator
[    3.509154] exynos-dwc3 usb at 12000000: Looking up vdd10-supply from device tree
[    3.509170] exynos-dwc3 usb at 12000000: Looking up vdd10-supply property in node /usb at 12000000 failed
[    3.509181] usb at 12000000 supply vdd10 not found, using dummy regulator
[    3.917548] exynos-dwc3 usb at 12400000: Looking up vdd33-supply from device tree
[    3.917565] exynos-dwc3 usb at 12400000: Looking up vdd33-supply property in node /usb at 12400000 failed
[    3.917578] usb at 12400000 supply vdd33 not found, using dummy regulator
[    3.922731] exynos-dwc3 usb at 12400000: Looking up vdd10-supply from device tree
[    3.922747] exynos-dwc3 usb at 12400000: Looking up vdd10-supply property in node /usb at 12400000 failed
Quoted 2 lines
Tested-by Krzysztof Kozlowski <[email protected]>
Signed-off-by Anand Moon <[email protected]>

Looks good now, thanks.

Reviewed-by Krzysztof Kozlowski <[email protected]>

Best regards,
Krzysztof

#2 lore raw
In reply to Anand Moon

W dniu 29.05.2015 o 23:30, Anand Moon pisze:

Quoted 17 lines

Enable regulator for usbdrd3_0 and usbdrd3_1. Looking at the schematic pin diagram for MAX77802 USB3_0 and USB3_1 is regulated by LDO9 and LD011.

Fix the boot message of failed.

[    3.503539] exynos-dwc3 usb at 12000000: Looking up vdd33-supply from device tree
[    3.503556] exynos-dwc3 usb at 12000000: Looking up vdd33-supply property in node /usb at 12000000 failed
[    3.503568] usb at 12000000 supply vdd33 not found, using dummy regulator
[    3.509154] exynos-dwc3 usb at 12000000: Looking up vdd10-supply from device tree
[    3.509170] exynos-dwc3 usb at 12000000: Looking up vdd10-supply property in node /usb at 12000000 failed
[    3.509181] usb at 12000000 supply vdd10 not found, using dummy regulator
[    3.917548] exynos-dwc3 usb at 12400000: Looking up vdd33-supply from device tree
[    3.917565] exynos-dwc3 usb at 12400000: Looking up vdd33-supply property in node /usb at 12400000 failed
[    3.917578] usb at 12400000 supply vdd33 not found, using dummy regulator
[    3.922731] exynos-dwc3 usb at 12400000: Looking up vdd10-supply from device tree
[    3.922747] exynos-dwc3 usb at 12400000: Looking up vdd10-supply property in node /usb at 12400000 failed
Quoted 2 lines
Tested-by Krzysztof Kozlowski <[email protected]>
Signed-off-by Anand Moon <[email protected]>

The patch no longer applies because of creation of common Odroid DTSI. Can you rebase it on Kukjin's for-next?

Best regards,
Krzysztof

author
#3 lore raw
Quoted 18 lines · Krzysztof Kozlowski

W dniu 29.05.2015 o 23:30, Anand Moon pisze:

Quoted 17 lines

Enable regulator for usbdrd3_0 and usbdrd3_1. Looking at the schematic pin diagram for MAX77802 USB3_0 and USB3_1 is regulated by LDO9 and LD011.

Fix the boot message of failed.

[    3.503539] exynos-dwc3 usb at 12000000: Looking up vdd33-supply from device tree
[    3.503556] exynos-dwc3 usb at 12000000: Looking up vdd33-supply property in node /usb at 12000000 failed
[    3.503568] usb at 12000000 supply vdd33 not found, using dummy regulator
[    3.509154] exynos-dwc3 usb at 12000000: Looking up vdd10-supply from device tree
[    3.509170] exynos-dwc3 usb at 12000000: Looking up vdd10-supply property in node /usb at 12000000 failed
[    3.509181] usb at 12000000 supply vdd10 not found, using dummy regulator
[    3.917548] exynos-dwc3 usb at 12400000: Looking up vdd33-supply from device tree
[    3.917565] exynos-dwc3 usb at 12400000: Looking up vdd33-supply property in node /usb at 12400000 failed
[    3.917578] usb at 12400000 supply vdd33 not found, using dummy regulator
[    3.922731] exynos-dwc3 usb at 12400000: Looking up vdd10-supply from device tree
[    3.922747] exynos-dwc3 usb at 12400000: Looking up vdd10-supply property in node /usb at 12400000 failed
Quoted 9 lines
Quoted 2 lines
Tested-by Krzysztof Kozlowski <[email protected]>
Signed-off-by Anand Moon <[email protected]>

The patch no longer applies because of creation of common Odroid DTSI. Can you rebase it on Kukjin's for-next?

Best regards,
Krzysztof

Hi Krzysztof

Ok will do this.

-Anand Moon

Quoted 1 line