Skip to contentSkip to conversation

staging: xgifb: correct the multiple line dereference

PATCH Superseded Arushi Singhal 2 participants 2 messages Feb 26, 2017 Staging

v3 of 7 Superseded Latest is v7 →

lore
Share & tools
lore
#0 lore raw

PATCH v3 1/1 staging: xgifb: correct the multiple line dereference

Error was reported by checkpatch.pl as "Avoid multiple line dereference".And If there is boolean operator then it is fixed by Splitting line at boolean operator to satisfy coding style.

---
changes in v3
- changes done such that no other errors can generate.
- Improve the coding style.

 drivers/staging/xgifb/XGI_main_26.c | 30 +++++++++---------------------
 drivers/staging/xgifb/vb_setmode.c  | 14 +++++++-------
 2 files changed, 16 insertions(+), 28 deletions(-)
drivers/staging/xgifb/XGI_main_26.c +9 -21
index 6930f7eb741b..f363c7c1963d 100644
@@ -878,30 +878,18 @@ static void XGIfb_post_setmode(struct xgifb_video_info *xgifb_info)
 			}
 
 			if ((filter >= 0) && (filter <= 7)) {
+				const u8 *f = XGI_TV_filter[filter_tb].filter[filter];
+
 				pr_debug("FilterTable[%d]-%d: %*ph\n",
-					 filter_tb, filter,
-					 4, XGI_TV_filter[filter_tb].
-						   filter[filter]);
-				xgifb_reg_set(
-					XGIPART2,
-					0x35,
-					(XGI_TV_filter[filter_tb].
-						filter[filter][0]));
-				xgifb_reg_set(
-					XGIPART2,
-					0x36,
-					(XGI_TV_filter[filter_tb].
-						filter[filter][1]));
+					 filter_tb, filter, 4, f);
 				xgifb_reg_set(
-					XGIPART2,
-					0x37,
-					(XGI_TV_filter[filter_tb].
-						filter[filter][2]));
+					XGIPART2, 0x35, f[0]);
+			        xgifb_reg_set(
+					XGIPART2, 0x36, f[1]);
+			        xgifb_reg_set(
+					XGIPART2, 0x37, f[2]);
 				xgifb_reg_set(
-					XGIPART2,
-					0x38,
-					(XGI_TV_filter[filter_tb].
-						filter[filter][3]));
+					XGIPART2, 0x38, f[3]);
 			}
 		}
 	}
drivers/staging/xgifb/vb_setmode.c +7 -7
index 7c7c8c8f1df3..1220d0cea87d 100644
@@ -221,8 +221,8 @@ static unsigned char XGI_AjustCRT2Rate(unsigned short ModeIdIndex,
 
 	for (; XGI330_RefIndex[RefreshRateTableIndex + (*i)].ModeID ==
 	       tempbx; (*i)--) {
-		infoflag = XGI330_RefIndex[RefreshRateTableIndex + (*i)].
-				Ext_InfoFlag;
+		infoflag =
+		XGI330_RefIndex[RefreshRateTableIndex + (*i)].Ext_InfoFlag;
 		if (infoflag & tempax)
 			return 1;
 
@@ -231,8 +231,8 @@ static unsigned char XGI_AjustCRT2Rate(unsigned short ModeIdIndex,
 	}
 
 	for ((*i) = 0;; (*i)++) {
-		infoflag = XGI330_RefIndex[RefreshRateTableIndex + (*i)].
-				Ext_InfoFlag;
+		infoflag =
+		XGI330_RefIndex[RefreshRateTableIndex + (*i)].Ext_InfoFlag;
 		if (XGI330_RefIndex[RefreshRateTableIndex + (*i)].ModeID
 				!= tempbx) {
 			return 0;
@@ -5092,8 +5092,8 @@ unsigned short XGI_GetRatePtrCRT2(struct xgi_hw_device_info *pXGIHWDE,
 
 	i = 0;
 	do {
-		if (XGI330_RefIndex[RefreshRateTableIndex + i].
-			ModeID != ModeNo)
+		if (XGI330_RefIndex[RefreshRateTableIndex + i].ModeID
+				!= ModeNo)
 			break;
 		temp = XGI330_RefIndex[RefreshRateTableIndex + i].Ext_InfoFlag;
 		temp &= ModeTypeMask;
@@ -5484,7 +5484,7 @@ unsigned char XGISetModeNew(struct xgifb_video_info *xgifb_info,
 				return 0;
 
 		pVBInfo->ModeType = XGI330_EModeIDTable[ModeIdIndex].
-						Ext_ModeFlag & ModeTypeMask;
+				Ext_ModeFlag & ModeTypeMask;
 
 		pVBInfo->SetFlag = 0;
 		pVBInfo->VBInfo = DisableCRT2Display;
Signature · 1 line
2.11.0
#1 lore raw
Quoted 4 lines · Arushi Singhal

Error was reported by checkpatch.pl as "Avoid multiple line dereference".And If there is boolean operator then it is fixed by Splitting line at boolean operator to satisfy coding style.

[]

drivers/staging/xgifb/XGI_main_26.c

Quoted 1 line
drivers/staging/xgifb/XGI_main_26.c +0 -0

[]

drivers/staging/xgifb/XGI_main_26.c static void XGIfb_post_setmode(struct xgifb_video_info *xgifb_info) · line 878

Quoted 2 lines
drivers/staging/xgifb/XGI_main_26.c +0 -0
@@ -878,30 +878,18 @@ static void XGIfb_post_setmode(struct xgifb_video_info *xgifb_info)
 

[]

drivers/staging/xgifb/XGI_main_26.c static void XGIfb_post_setmode(struct xgifb_video_info *xgifb_info) · line 890

Quoted 10 lines
drivers/staging/xgifb/XGI_main_26.c +5 -4
 				xgifb_reg_set(
-					XGIPART2,
-					0x37,
-					(XGI_TV_filter[filter_tb].
-						filter[filter][2]));
+					XGIPART2, 0x35, f[0]);
+			        xgifb_reg_set(
+					XGIPART2, 0x36, f[1]);
+			        xgifb_reg_set(
+					XGIPART2, 0x37, f[2]);

0 1 2 3 4 5 6 7 8
12345678901234567890123456789012345678901234567890123456789012345678901234567890

				xgifb_reg_set(XGIPART2, 0x37, f[2]);

All of these fit nicely on a single line and you should submit patches that make the most sense and do not need revision when reformatting.

Please reformat all instances as above and resubmit.