USB: cdc-wdm: don't enable interrupts in USB-giveback
PATCH v2 1/1 USB: cdc-wdm: don't enable interrupts in USB-giveback
Quoted 4 lines · Sebastian Andrzej Siewior
Quoted 1 line · Oliver Neukum
Hi Oliver,
Hi Sebastian,
Quoted 6 lines
Quoted 4 lines
I am just looking at your patch and I am wondering why
wdm_in_callback()won't just callservice_outstanding_interrupt()again and again? OK, maybe I am dense and it may well be present now, but it just looks to me that way.But this part didn't change, did it?
Right, it didn't change, but that does not make it correct.
Quoted 1 line
The user blocks in
wdmw_read()
We can only hope that he does. The wait is interruptible. If a signal comes at the wrong time, nobody will be waiting.
Quoted 2 lines
Maybe we should delay the
WDM_READflag in the error case until the worker is done (before the wakeup).
I don't think that will help. It seems like we need to make sure that error recovery is a one shot activity.
Regards
Oliver
---
To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html