Skip to contentSkip to conversation

USB: cdc-wdm: don't enable interrupts in USB-giveback

PATCH New Oliver Neukum 1 participant 1 message Jun 19, 2018 USB

lore
Share & tools
lore
#0 lore raw

PATCH v4 1/1 USB: cdc-wdm: don't enable interrupts in USB-giveback

Quoted 11 lines · Sebastian Andrzej Siewior

In the code path
__usb_hcd_giveback_urb()
-> wdm_in_callback()
-> service_outstanding_interrupt()

The function service_outstanding_interrupt() will unconditionally enable interrupts during unlock and invoke usb_submit_urb() with GFP_KERNEL. If the HCD completes in BH (like ehci does) then the context remains atomic due local_bh_disable() and enabling interrupts does not change this.

Quoted 8 lines

Defer the error case handling to a workqueue as suggested by Oliver Neukum. In case of an error the worker performs the read out and wakes the user.

Fixes c1da59dad0eb ("cdc-wdm: Clear read pipeline in case of error")
Cc Robert Foss <[email protected]>
Cc Oliver Neukum <[email protected]>

<Acked-by: Oliver Neukum <[email protected]>

It fixes the identified issue.

Regards
Oliver
---
To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html