Skip to contentSkip to conversation

USB: cdc-wdm: don't enable interrupts in USB-giveback

PATCH Superseded Oliver Neukum 1 participant 1 message Jun 14, 2018 USB

v2 of 4 Superseded Latest is v4 →

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 USB: cdc-wdm: don't enable interrupts in USB-giveback

Quoted 9 lines · Sebastian Andrzej Siewior
(quoted diff) +1 -0
@@ -964,6 +975,7 @@ static void wdm_disconnect(struct usb_interface *intf)
        mutex_lock(&desc->wlock);
        kill_urbs(desc);
        cancel_work_sync(&desc->rxwork);
+       cancel_work_sync(&desc->service_outs_intr);
        mutex_unlock(&desc->wlock);
        mutex_unlock(&desc->rlock);
 

Review static int wdm_pre_reset(struct usb_interface *intf) · line 1081

Quoted 5 lines
(quoted diff) +1 -0
@@ -1065,6 +1077,7 @@ static int wdm_pre_reset(struct usb_interface *intf)
        mutex_lock(&desc->wlock);
        kill_urbs(desc);
        cancel_work_sync(&desc->rxwork);
+       cancel_work_sync(&desc->service_outs_intr);
        return 0;

Almost good. I am afraid the work also needs to be canceled in wdm_suspend()

Regards
Oliver
---
To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html