Skip to contentSkip to conversation

ASoC: Intel: boards: add dmic format constraint

PATCH In review [email protected] 2 participants 4 messages Jun 18, 2019

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ASoC: Intel: boards: add dmic format constraint

From: Mac Chiang <[email protected]>

platform dmic recording fixup 16bits

---
 sound/soc/intel/boards/bxt_da7219_max98357a.c | 3 +++
 1 file changed, 3 insertions(+)
sound/soc/intel/boards/bxt_da7219_max98357a.c +3 -0
index 5cadb7f..ac06408 100644
@@ -330,6 +330,9 @@ static int broxton_dmic_startup(struct snd_pcm_substream *substream)
 	snd_pcm_hw_constraint_list(runtime, 0, SNDRV_PCM_HW_PARAM_CHANNELS,
 			&constraints_channels_quad);
 
+	runtime->hw.formats = SNDRV_PCM_FMTBIT_S16_LE;
+	snd_pcm_hw_constraint_msbits(runtime, 0, 16, 16);
+
 	return snd_pcm_hw_constraint_list(substream->runtime, 0,
 			SNDRV_PCM_HW_PARAM_RATE, &constraints_rates);
 }
Signature · 1 line
2.7.4
#1 lore raw
Quoted 3 lines · On 6/18/19 7:48 AM, [email protected] wrote:

From: Mac Chiang <[email protected]>

platform dmic recording fixup 16bits

Which platforms is this needed for? IIRC this machine driver is shared with SOF-based solutions - which typically sets DMIC configs with topology - and I'd like to make sure there's no impact. Thanks!

Quoted 21 lines
---
  sound/soc/intel/boards/bxt_da7219_max98357a.c | 3 +++
  1 file changed, 3 insertions(+)
sound/soc/intel/boards/bxt_da7219_max98357a.c +3 -0
index 5cadb7f..ac06408 100644
@@ -330,6 +330,9 @@ static int broxton_dmic_startup(struct snd_pcm_substream *substream)
  	snd_pcm_hw_constraint_list(runtime, 0, SNDRV_PCM_HW_PARAM_CHANNELS,
  			&constraints_channels_quad);
 
+	runtime->hw.formats = SNDRV_PCM_FMTBIT_S16_LE;
+	snd_pcm_hw_constraint_msbits(runtime, 0, 16, 16);
+
  	return snd_pcm_hw_constraint_list(substream->runtime, 0,
  			SNDRV_PCM_HW_PARAM_RATE, &constraints_rates);
  }
#2 lore raw
Quoted 1 line

Which platforms is this needed for? IIRC this machine driver is shared with SOF-based solutions - which typically sets DMIC configs with topology - and I'd like to make sure there's no impact.

Hi Pierre, this is for APL platform.

-----Original Message-----
From: Pierre-Louis Bossart [mailto:[email protected]]
Sent: Tuesday, June 18, 2019 2:56 PM
To: Chiang, Mac <[email protected]>; [email protected]
Cc: N, Harshapriya <[email protected]>; [email protected]; Zhi, Yong <[email protected]>
Subject: Re: [alsa-devel] [PATCH] ASoC: Intel: boards: add dmic format constraint

Quoted 3 lines · On 6/18/19 7:48 AM, [email protected] wrote:

From: Mac Chiang <[email protected]>

platform dmic recording fixup 16bits

Which platforms is this needed for? IIRC this machine driver is shared with SOF-based solutions - which typically sets DMIC configs with topology - and I'd like to make sure there's no impact. Thanks!

Quoted 22 lines
---
  sound/soc/intel/boards/bxt_da7219_max98357a.c | 3 +++
  1 file changed, 3 insertions(+)
sound/soc/intel/boards/bxt_da7219_max98357a.c +3 -0
index 5cadb7f..ac06408 100644
@@ -330,6 +330,9 @@ static int broxton_dmic_startup(struct snd_pcm_substream *substream)
  	snd_pcm_hw_constraint_list(runtime, 0, SNDRV_PCM_HW_PARAM_CHANNELS,
  			&constraints_channels_quad);
 
+	runtime->hw.formats = SNDRV_PCM_FMTBIT_S16_LE;
+	snd_pcm_hw_constraint_msbits(runtime, 0, 16, 16);
+
  	return snd_pcm_hw_constraint_list(substream->runtime, 0,
  			SNDRV_PCM_HW_PARAM_RATE, &constraints_rates);
  }
#3 lore raw
Quoted 2 lines · Mac
Quoted 1 line

Which platforms is this needed for? IIRC this machine driver is shared with SOF-based solutions - which typically sets DMIC configs with topology - and I'd like to make sure there's no impact.

Hi Pierre, this is for APL platform.

ok. please don't top-post and copy/paste...

Quoted 8 lines

-----Original Message-----
From: Pierre-Louis Bossart [mailto:[email protected]]
Sent: Tuesday, June 18, 2019 2:56 PM
To: Chiang, Mac <[email protected]>; [email protected]
Cc: N, Harshapriya <[email protected]>; [email protected]; Zhi, Yong <[email protected]>
Subject: Re: [alsa-devel] [PATCH] ASoC: Intel: boards: add dmic format constraint

Quoted 10 lines
Quoted 3 lines · On 6/18/19 7:48 AM, [email protected] wrote:

From: Mac Chiang <[email protected]>

platform dmic recording fixup 16bits

Which platforms is this needed for? IIRC this machine driver is shared with SOF-based solutions - which typically sets DMIC configs with topology - and I'd like to make sure there's no impact. Thanks!

Quoted 2 lines

This change is only for front-ends that are overridden by SOF, so assuming the rest of the Chrome folks are aligned on this:

Quoted 26 lines
Quoted 11 lines
---
   sound/soc/intel/boards/bxt_da7219_max98357a.c | 3 +++
   1 file changed, 3 insertions(+)
sound/soc/intel/boards/bxt_da7219_max98357a.c +0 -0
index 5cadb7f..ac06408 100644

sound/soc/intel/boards/bxt_da7219_max98357a.c static int broxton_dmic_startup(struct snd_pcm_substream *substream) · line 338

Quoted 9 lines
sound/soc/intel/boards/bxt_da7219_max98357a.c +3 -0
@@ -330,6 +330,9 @@ static int broxton_dmic_startup(struct snd_pcm_substream *substream)
   	snd_pcm_hw_constraint_list(runtime, 0, SNDRV_PCM_HW_PARAM_CHANNELS,
   			&constraints_channels_quad);
 
+	runtime->hw.formats = SNDRV_PCM_FMTBIT_S16_LE;
+	snd_pcm_hw_constraint_msbits(runtime, 0, 16, 16);
+
   	return snd_pcm_hw_constraint_list(substream->runtime, 0,
   			SNDRV_PCM_HW_PARAM_RATE, &constraints_rates);
   }

_______________________________________________
Alsa-devel mailing list
[email protected]
https://mailman.alsa-project.org/mailman/listinfo/alsa-devel