Skip to contentSkip to conversation

ASoC: max98357a: avoid speaker pop when playback startup

PATCH Superseded [email protected] 1 participant 1 message Jun 19, 2019

Subsystems (3)

v2 of 3 Superseded Latest is v3 →

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 ASoC: max98357a: avoid speaker pop when playback startup

From: Mac Chiang <[email protected]>

Loud speaker pop happens during playback even when in slience playback. Specify Max98357a amp delay times to make sure clocks are always earlier than sdmode on.

---
Changelog:
v2:
- added device_property_read_u32() func
---

---
 .../devicetree/bindings/sound/max98357a.txt        |  4 ++
 sound/soc/codecs/max98357a.c                       | 68 +++++++++++++++++++---
 2 files changed, 63 insertions(+), 9 deletions(-)
Documentation/devicetree/bindings/sound/max98357a.txt +4 -0
index 28645a2..4bce14c 100644
@@ -9,6 +9,10 @@ Optional properties:
 - sdmode-gpios : GPIO specifier for the chip's SD_MODE pin.
         If this option is not specified then driver does not manage
         the pin state (e.g. chip is always on).
+- sdmode-delay : specify delay time for SD_MODE pin.
+        If this option is specified, which means it's required i2s clocks
+        ready before SD_MODE is unmuted in order to avoid the speaker pop noise.
+        It's observed that 5ms is sufficient.
 
 Example:
 
sound/soc/codecs/max98357a.c +59 -9

108 lines not on this page · raw message

Signature · 1 line
2.7.4