Skip to contentSkip to conversation

ASoC: max98357a: avoid speaker pop when playback startup

PATCH In review [email protected] 2 participants 2 messages Jun 19, 2019 – Jul 4, 2019

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH v3 1/1 ASoC: max98357a: avoid speaker pop when playback startup

From: Mac Chiang <[email protected]>

Loud speaker pop happens during playback even when in slience playback. Specify Max98357a amp delay times to make sure clocks are always earlier than sdmode on.

---
Changelog:
v3:
- rebase to branch for-next
v2:
- added device_property_read_u32() func
---

---
 .../devicetree/bindings/sound/max98357a.txt        |  4 ++
 sound/soc/codecs/max98357a.c                       | 55 ++++++++++++++++++----
 2 files changed, 50 insertions(+), 9 deletions(-)
Documentation/devicetree/bindings/sound/max98357a.txt +4 -0
index 28645a2..4bce14c 100644
@@ -9,6 +9,10 @@ Optional properties:
 - sdmode-gpios : GPIO specifier for the chip's SD_MODE pin.
         If this option is not specified then driver does not manage
         the pin state (e.g. chip is always on).
+- sdmode-delay : specify delay time for SD_MODE pin.
+        If this option is specified, which means it's required i2s clocks
+        ready before SD_MODE is unmuted in order to avoid the speaker pop noise.
+        It's observed that 5ms is sufficient.
 
 Example:
 
sound/soc/codecs/max98357a.c +46 -9

84 lines not on this page · raw message

Signature · 1 line
2.7.4
maintainer
#1 lore raw

Applied "ASoC: max98357a: avoid speaker pop when playback startup" to the asoc tree

The patch

ASoC: max98357a: avoid speaker pop when playback startup

has been applied to the asoc tree at

https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-5.3

All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying to this mail.

Thanks,
Mark

Quoted 1 line

From cec5b01f8f1c6064037f3181e7690e3765ed995b Mon Sep 17 00:00:00 2001

From: Mac Chiang <[email protected]>
Date: Wed, 19 Jun 2019 18:18:33 +0800
Subject: [PATCH] ASoC: max98357a: avoid speaker pop when playback startup

Loud speaker pop happens during playback even when in slience playback. Specify Max98357a amp delay times to make sure clocks are always earlier than sdmode on.

---
 .../devicetree/bindings/sound/max98357a.txt   |  4 ++
 sound/soc/codecs/max98357a.c                  | 55 ++++++++++++++++---
 2 files changed, 50 insertions(+), 9 deletions(-)
Documentation/devicetree/bindings/sound/max98357a.txt +4 -0
index 28645a2ff885..4bce14ce806f 100644
@@ -9,6 +9,10 @@ Optional properties:
 - sdmode-gpios : GPIO specifier for the chip's SD_MODE pin.
         If this option is not specified then driver does not manage
         the pin state (e.g. chip is always on).
+- sdmode-delay : specify delay time for SD_MODE pin.
+        If this option is specified, which means it's required i2s clocks
+        ready before SD_MODE is unmuted in order to avoid the speaker pop noise.
+        It's observed that 5ms is sufficient.
 
 Example:
 
sound/soc/codecs/max98357a.c +46 -9

84 lines not on this page · raw message

Signature · 1 line
2.20.1