ACPI / platform: Fix return value check in check_acpi_dev()
PATCH v2 1/1 ACPI / platform: Fix return value check in check_acpi_dev()
In the function check_acpi_dev(), if it fails to create platform device, the return value is ERR_PTR() or NULL. Thus it must use IS_ERR_OR_NULL to check return value.
Fixes ecc83e52b28c (intel-hid: new hid event driver for hotkeys)
Reported-by Hulk Robot <[email protected]>
Signed-off-by Lu Wei <[email protected]>
---v1->v2
- Modify commit message
drivers/platform/x86/intel-hid.c | 2 +- drivers/platform/x86/intel-vbtn.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)
drivers/platform/x86/intel-hid.c +1 -1
@@ -564,7 +564,7 @@ check_acpi_dev(acpi_handle handle, u32 lvl, void *context, void **rv)return AE_OK ;if (acpi_match_device_ids (dev, ids) ==0 ) -if (acpi_create_platform_device (dev,NULL )) +if (!IS_ERR_OR_NULL (acpi_create_platform_device (dev,NULL )))dev_info (&dev->dev,"intel-hid: created platform device\n" );
drivers/platform/x86/intel-vbtn.c +1 -1
@@ -251,7 +251,7 @@ check_acpi_dev(acpi_handle handle, u32 lvl, void *context, void **rv)return AE_OK ;if (acpi_match_device_ids (dev, ids) ==0 ) -if (acpi_create_platform_device (dev,NULL )) +if (!IS_ERR_OR_NULL (acpi_create_platform_device (dev,NULL )))dev_info (&dev->dev,"intel-vbtn: created platform device\n" );
Signature · 1 line
2.7.4
Quoted 5 lines · Lu Wei
In the function
check_acpi_dev(), if it fails to create platform device, the return value isERR_PTR()or NULL. Thus it must useIS_ERR_OR_NULLto check return value.
Thanks!
Quoted 1 line
Fixes ecc83e52b28c (intel-hid: new hid event driver for hotkeys)
This is not the correct format. Please, fix it in the next version, thanks!
Quoted 2 lines
drivers/platform/x86/intel-hid.c | 2 +- drivers/platform/x86/intel-vbtn.c | 2 +-
Please, split per driver.
Signature · 2 lines
With Best Regards, Andy Shevchenko