Add APSS clock controller support for IPQ6018
v7 cover Add APSS clock controller support for IPQ6018
The CPU on Qualcomm's IPQ6018 devices are primarily fed by APSS PLL and XO, these are connected to a clock mux and enable block.
This patch series adds support for these clocks and inturn enables clocks required for CPU freq.
[V7]
* Removed dts patch from this series, will send that separately
* Addressed Rob's minor comment on the binding
* Patch 1 depends on a53 pll bindings
https://lkml.org/lkml/2020/5/4/60
[V6]
* Split mailbox driver from this series, mailbox changes will sent as a separate series
* Addressed review comments from Stephen
[V5]
* Addressed Bjorn comments on apss clk and dt-bindings
* Patch 2 depends on a53 pll dt-bindings
https://www.spinics.net/lists/linux-clk/msg48358.html
[V4]
* Re-written PLL found on IPQ platforms as a separate driver
* Addressed stephen's comments on apss clock controller and pll
* Addressed Rob's review comments on bindings
* moved a53 pll binding from this series as it is not applicable, will send it separately.
[V3]
* Fixed dt binding check error in patch2
dt-bindings: clock: Add YAML schemas for QCOM A53 PLL
[V2]
* Restructred the patch series as there are two different HW blocks, the mux and enable belongs to the apcs block and PLL has a separate HW block.
* Converted qcom mailbox and qcom a53 pll documentation to yaml.
* Addressed review comments from Stephen, Rob and Sibi where it is applicable.
* Changed this cover letter to state the purpose of this patch series
Sivaprakash Murugesan (4):
dt-bindings: clock: add ipq6018 a53 pll compatible
clk: qcom: Add ipq apss pll driver
clk: qcom: Add DT bindings for ipq6018 apss clock controller
clk: qcom: Add ipq6018 apss clock controller
.../devicetree/bindings/clock/qcom,a53pll.yaml | 18 ++++ drivers/clk/qcom/Kconfig | 19 ++++ drivers/clk/qcom/Makefile | 2 + drivers/clk/qcom/apss-ipq-pll.c | 95 ++++++++++++++++++ drivers/clk/qcom/apss-ipq6018.c | 106 +++++++++++++++++++++ include/dt-bindings/clock/qcom,apss-ipq.h | 12 +++ 6 files changed, 252 insertions(+) create mode 100644 drivers/clk/qcom/apss-ipq-pll.c create mode 100644 drivers/clk/qcom/apss-ipq6018.c create mode 100644 include/dt-bindings/clock/qcom,apss-ipq.h
Signature · 1 line
2.7.4
PATCH v7 1/4 dt-bindings: clock: add ipq6018 a53 pll compatible
cpus on ipq6018 are clocked by a53 pll, add device compatible for a53 pll found on ipq6018 devices.
---
[V7]
* Addressed minor review comment from Rob
.../devicetree/bindings/clock/qcom,a53pll.yaml | 18 ++++++++++++++++++ 1 file changed, 18 insertions(+)
Documentation/devicetree/bindings/clock/qcom,a53pll.yaml +18 -0
@@ -15,6 +15,7 @@ description: properties: compatible: + const: qcom,ipq6018-a53pll const: qcom,msm8916-a53pll reg:
@@ -23,6 +24,14 @@ properties: '#clock-cells': const: 0 + clocks: + items: + - description: board XO clock + + clock-names: + items: + - const: xo + required: - compatible - reg
@@ -38,3 +47,12 @@ examples: reg = <0xb016000 0x40>; #clock-cells = <0>; }; + #Example 2 - A53 PLL found on IPQ6018 devices + - | + a53pll_ipq: clock-controller@b116000 { + compatible = "qcom,ipq6018-a53pll"; + reg = <0x0b116000 0x40>; + #clock-cells = <0>; + clocks = <&xo>; + clock-names = "xo"; + };
Signature · 1 line
2.7.4
Re: [PATCH V7 1/4] dt-bindings: clock: add ipq6018 a53 pll compatible
Quoted 10 lines · Sivaprakash Murugesan
cpus on ipq6018 are clocked by a53 pll, add device compatible for a53 pll found on ipq6018 devices.
Signed-off-by Sivaprakash Murugesan <[email protected]>---
[V7]
* Addressed minor review comment from Rob.../devicetree/bindings/clock/qcom,a53pll.yaml | 18 ++++++++++++++++++ 1 file changed, 18 insertions(+)
Stephen Boyd
maintainerRe: [PATCH V7 1/4] dt-bindings: clock: add ipq6018 a53 pll compatible
In reply to Sivaprakash MurugesanQuoting Sivaprakash Murugesan (2020-06-06 03:55:04)
Quoted 15 lines
cpus on ipq6018 are clocked by a53 pll, add device compatible for a53 pll found on ipq6018 devices.
Signed-off-by Sivaprakash Murugesan <[email protected]>---
[V7]
* Addressed minor review comment from Rob.../devicetree/bindings/clock/qcom,a53pll.yaml | 18 ++++++++++++++++++ 1 file changed, 18 insertions(+)Documentation/devicetree/bindings/clock/qcom,a53pll.yaml +0
-0
Documentation/devicetree/bindings/clock/qcom,a53pll.yaml description: · line 21
Quoted 7 lines
Documentation/devicetree/bindings/clock/qcom,a53pll.yaml +1
-0@@ -15,6 +15,7 @@ description: properties: compatible: + const: qcom,ipq6018-a53pll const: qcom,msm8916-a53pll reg:
I'm getting this error when running dt binding check:
ruamel.yaml.constructor.DuplicateKeyError: while constructing a mapping
in "<unicode string>", line 18, column 5
found duplicate key "const" with value "qcom,msm8916-a53pll" (original value: "qcom,ipq6018-a53pll")
in "<unicode string>", line 19, column 5
Re: [PATCH V7 1/4] dt-bindings: clock: add ipq6018 a53 pll compatible
Quoted 22 lines · Stephen Boyd
Quoting Sivaprakash Murugesan (2020-06-06 03:55:04)
Quoted 21 lines
cpus on ipq6018 are clocked by a53 pll, add device compatible for a53 pll found on ipq6018 devices.
Signed-off-by Sivaprakash Murugesan <[email protected]>---
[V7]
* Addressed minor review comment from Rob.../devicetree/bindings/clock/qcom,a53pll.yaml | 18 ++++++++++++++++++ 1 file changed, 18 insertions(+)Documentation/devicetree/bindings/clock/qcom,a53pll.yaml +1
-0@@ -15,6 +15,7 @@ description: properties: compatible: + const: qcom,ipq6018-a53pll const: qcom,msm8916-a53pll
Quoted 7 lines
Documentation/devicetree/bindings/clock/qcom,a53pll.yaml description: · line 21
Quoted 1 line
Documentation/devicetree/bindings/clock/qcom,a53pll.yaml +0
-0reg:I'm getting this error when running dt binding check:
ruamel.yaml.constructor.DuplicateKeyError: while constructing a mapping
in "<unicode string>", line 18, column 5
found duplicate key "const" with value "qcom,msm8916-a53pll" (original value: "qcom,ipq6018-a53pll")
in "<unicode string>", line 19, column 5
This error started coming after updating the dt-schema version.
Guess I need to replace const with enum to get rid of this error.
will address this.
PATCH v7 2/4 clk: qcom: Add ipq apss pll driver
In reply to Sivaprakash MurugesanThe CPUs on Qualcomm ipq based devices are clocked by an alpha PLL. Add support for the apss pll found on ipq based devices which can support CPU frequencies above 1Ghz.
--- drivers/clk/qcom/Kconfig | 8 ++++ drivers/clk/qcom/Makefile | 1 + drivers/clk/qcom/apss-ipq-pll.c | 95 +++++++++++++++++++++++++++++++++++++++++ 3 files changed, 104 insertions(+) create mode 100644 drivers/clk/qcom/apss-ipq-pll.c
drivers/clk/qcom/Kconfig +8 -0
@@ -89,6 +89,14 @@ config APQ_MMCC_8084 Say Y if you want to support multimedia devices such as display, graphics, video encode/decode, camera, etc. +config IPQ_APSS_PLL + tristate "IPQ APSS PLL" + help + Support for APSS PLL on ipq devices. The APSS PLL is the main + clock that feeds the CPUs on ipq based devices. + Say Y if you want to support CPU frequency scaling on ipq based + devices. + config IPQ_GCC_4019 tristate "IPQ4019 Global Clock Controller" help
drivers/clk/qcom/Makefile +1 -0
@@ -19,6 +19,7 @@ clk-qcom-$(CONFIG_QCOM_GDSC) += gdsc.o # Keep alphabetically sorted by config obj-$(CONFIG_APQ_GCC_8084) += gcc-apq8084.o obj-$(CONFIG_APQ_MMCC_8084) += mmcc-apq8084.o +obj-$(CONFIG_IPQ_APSS_PLL) += apss-ipq-pll.o obj-$(CONFIG_IPQ_GCC_4019) += gcc-ipq4019.o obj-$(CONFIG_IPQ_GCC_6018) += gcc-ipq6018.o obj-$(CONFIG_IPQ_GCC_806X) += gcc-ipq806x.o
drivers/clk/qcom/apss-ipq-pll.c new file +95 -0
95 lines not on this page · raw message
Signature · 1 line
2.7.4
PATCH v7 3/4 clk: qcom: Add DT bindings for ipq6018 apss clock controller
In reply to Sivaprakash MurugesanAdd dt-binding for ipq6018 apss clock controller
--- include/dt-bindings/clock/qcom,apss-ipq.h | 12 ++++++++++++ 1 file changed, 12 insertions(+) create mode 100644 include/dt-bindings/clock/qcom,apss-ipq.h
include/dt-bindings/clock/qcom,apss-ipq.h new file +12 -0
@@ -0,0 +1,12 @@ +/* SPDX-License-Identifier: GPL-2.0 */ +/* +* Copyright (c) 2018, The Linux Foundation. All rights reserved. +*/ + +#ifndef _DT_BINDINGS_CLOCK_QCA_APSS_IPQ6018_H +#define _DT_BINDINGS_CLOCK_QCA_APSS_IPQ6018_H + +#define APCS_ALIAS0_CLK_SRC 0 +#define APCS_ALIAS0_CORE_CLK 1 + +#endif
Signature · 1 line
2.7.4
Rob Herring
maintainerRe: [PATCH V7 3/4] clk: qcom: Add DT bindings for ipq6018 apss clock controller
Quoted 8 lines · Sivaprakash Murugesan
Add dt-binding for ipq6018 apss clock controller
Signed-off-by Sivaprakash Murugesan <[email protected]>--- include/dt-bindings/clock/qcom,apss-ipq.h | 12 ++++++++++++ 1 file changed, 12 insertions(+) create mode 100644 include/dt-bindings/clock/qcom,apss-ipq.h
Please add Acked-by/Reviewed-by tags when posting new versions. However, there's no need to repost patches *only* to add the tags. The upstream maintainer will do that for acks received on the version they apply.
If a tag was not added on purpose, please state why and what changed.
Stephen Boyd
maintainerRe: [PATCH V7 3/4] clk: qcom: Add DT bindings for ipq6018 apss clock controller
In reply to Sivaprakash MurugesanQuoting Sivaprakash Murugesan (2020-06-06 03:55:06)
Quoted 4 lines
Add dt-binding for ipq6018 apss clock controller
Signed-off-by Sivaprakash Murugesan <[email protected]>---
Please pick up Rob's tag when resending this.
PATCH v7 4/4 clk: qcom: Add ipq6018 apss clock controller
In reply to Sivaprakash MurugesanThe CPU on Qualcomm ipq6018 devices are clocked primarily by a aplha PLL and xo which are connected to a mux and enable block.
Add support for the mux and enable block which feeds the CPU on ipq6018 devices.
--- drivers/clk/qcom/Kconfig | 11 +++++ drivers/clk/qcom/Makefile | 1 + drivers/clk/qcom/apss-ipq6018.c | 106 ++++++++++++++++++++++++++++++++++++++++ 3 files changed, 118 insertions(+) create mode 100644 drivers/clk/qcom/apss-ipq6018.c
drivers/clk/qcom/Kconfig +11 -0
@@ -97,6 +97,17 @@ config IPQ_APSS_PLL Say Y if you want to support CPU frequency scaling on ipq based devices. +config IPQ_APSS_6018 + tristate "IPQ APSS Clock Controller" + select IPQ_APSS_PLL + depends on QCOM_APCS_IPC || COMPILE_TEST + help + Support for APSS clock controller on IPQ platforms. The + APSS clock controller manages the Mux and enable block that feeds the + CPUs. + Say Y if you want to support CPU frequency scaling on + ipq based devices. + config IPQ_GCC_4019 tristate "IPQ4019 Global Clock Controller" help
drivers/clk/qcom/Makefile +1 -0
@@ -20,6 +20,7 @@ clk-qcom-$(CONFIG_QCOM_GDSC) += gdsc.o obj-$(CONFIG_APQ_GCC_8084) += gcc-apq8084.o obj-$(CONFIG_APQ_MMCC_8084) += mmcc-apq8084.o obj-$(CONFIG_IPQ_APSS_PLL) += apss-ipq-pll.o +obj-$(CONFIG_IPQ_APSS_6018) += apss-ipq6018.o obj-$(CONFIG_IPQ_GCC_4019) += gcc-ipq4019.o obj-$(CONFIG_IPQ_GCC_6018) += gcc-ipq6018.o obj-$(CONFIG_IPQ_GCC_806X) += gcc-ipq806x.o
drivers/clk/qcom/apss-ipq6018.c new file +106 -0
106 lines not on this page · raw message
Signature · 1 line
2.7.4
Ping!
Hi Stephen,
Is it possible for you to review this series? We have regulators and few other patches
depend on this patch, it would be great if you could provide your inputs on this.
Thanks,
Siva
Quoted 53 lines · Sivaprakash Murugesan
The CPU on Qualcomm's IPQ6018 devices are primarily fed by APSS PLL and XO, these are connected to a clock mux and enable block.
This patch series adds support for these clocks and inturn enables clocks required for CPU freq.
[V7]
* Removed dts patch from this series, will send that separately
* Addressed Rob's minor comment on the binding
* Patch 1 depends on a53 pll bindingshttps://lkml.org/lkml/2020/5/4/60[V6]
* Split mailbox driver from this series, mailbox changes will sent as a separate series
* Addressed review comments from Stephen
[V5]
* Addressed Bjorn comments on apss clk and dt-bindings
* Patch 2 depends on a53 pll dt-bindingshttps://www.spinics.net/lists/linux-clk/msg48358.html[V4]
* Re-written PLL found on IPQ platforms as a separate driver
* Addressed stephen's comments on apss clock controller and pll
* Addressed Rob's review comments on bindings
* moved a53 pll binding from this series as it is not applicable, will send it separately.
[V3]
* Fixed dt binding check error in patch2
dt-bindings: clock: Add YAML schemas for QCOM A53 PLL
[V2]
* Restructred the patch series as there are two different HW blocks, the mux and enable belongs to the apcs block and PLL has a separate HW block.
* Converted qcom mailbox and qcom a53 pll documentation to yaml.
* Addressed review comments from Stephen, Rob and Sibi where it is applicable.
* Changed this cover letter to state the purpose of this patch seriesSivaprakash Murugesan (4):
dt-bindings: clock: add ipq6018 a53 pll compatible
clk: qcom: Add ipq apss pll driver
clk: qcom: Add DT bindings for ipq6018 apss clock controller
clk: qcom: Add ipq6018 apss clock controller.../devicetree/bindings/clock/qcom,a53pll.yaml | 18 ++++ drivers/clk/qcom/Kconfig | 19 ++++ drivers/clk/qcom/Makefile | 2 + drivers/clk/qcom/apss-ipq-pll.c | 95 ++++++++++++++++++ drivers/clk/qcom/apss-ipq6018.c | 106 +++++++++++++++++++++ include/dt-bindings/clock/qcom,apss-ipq.h | 12 +++ 6 files changed, 252 insertions(+)create mode 100644
drivers/clk/qcom/apss-ipq-pll.ccreate mode 100644drivers/clk/qcom/apss-ipq6018.ccreate mode 100644include/dt-bindings/clock/qcom,apss-ipq.h
Stephen Boyd
maintainerQuoting Sivaprakash Murugesan (2020-06-18 00:00:58)
Quoted 6 lines
Ping!
Hi Stephen,
Is it possible for you to review this series? We have regulators and few other patches
regulators depend on CPU clk patches?
Quoted 4 lines
depend on this patch, it would be great if you could provide your inputs on this.