qemu-dm monitor doesn't support the quit command
PATCH 1/1 qemu-dm monitor doesn't support the quit command
Hi All,
It is natural that there is quit command in original QEMU. However, I don't think that the HVM domain on Xen is necessary. Because there is a possibility of shutting down GuestOS due to the mistake. I think that I should prohibit the quit command of qemu-dm.
Thanks
--
Takanori Kasai
# HG changeset patch
# User [email protected]
# Node ID ef195d27a54ef7d5e256788d5a1a51ee55e2bcf6 # Parent 360eb996fa38319867a74bf581c734a80bf6839d qemu-dm monitor doesn't support the quit command.
tools/ioemu/monitor.c +1 -2
@@ -309,8 +309,7 @@ static void do_info_history (void)static void do_quit (void ) { -destroy_hvm_domain (); -exit (0 ); +term_printf ("quit is not supported\n" ); }static int eject_device (BlockDriverState *bs,int force)
_______________________________________________
Xen-devel mailing list
[email protected]
http://lists.xensource.com/xen-devel
Hi All,
Quoted 2 lines
It is natural that there is quit command in original QEMU. However, I don't think that the HVM domain on Xen is necessary. Because there is a possibility of shutting down GuestOS due to the mistake. I think that I should prohibit the quit command of qemu-dm.
So as to refuse the quit command, the patch was corrected. If there is any problem, please let me know.
Thanks
--
Takanori Kasai
# HG changeset patch
# User [email protected]
# Node ID 333949ed3a785141e4ae046d95483fcf185e5836 # Parent 367f0c6efe2178e26ba0194ca795ff098e22a80b qemu-dm monitor does not support the quit command
tools/ioemu/monitor.c +0 -8
@@ -305,12 +305,6 @@ static void do_info_history (void)term_printf ("%d: '%s'\n" , i, str); i++; } -} - -static void do_quit (void ) -{ -destroy_hvm_domain (); -exit (0 ); }static int eject_device (BlockDriverState *bs,int force)
@@ -1158,8 +1152,6 @@ static term_cmd_t term_cmds[] = { "", "commit changes to the disk images (if -snapshot is used)" }, {"info" ,"s?" , do_info, "subcommand", "show various information about the system state" }, - { "q|quit", "", do_quit, - "", "quit the emulator" }, { "eject", "-fB", do_eject, "[-f] device", "eject a removable media (use -f to force it)" }, { "change", "BF", do_change,
_______________________________________________
Xen-devel mailing list
[email protected]
http://lists.xensource.com/xen-devel
Hi All,
I sent the following patches the other day.
This patch makes qemu-dm monitor not support the quit command. Because there is a possibility of shutting down HVM Domain by mistake. We think that the HVM domain should shut down by xm shutdown/destroy command. Could you apply this patch?
Thanks,
--
Takanori Kasai
----- Original Message ----- From: "Kasai Takanori" <[email protected]>
To: "xen-devel" <[email protected]>
Sent: Monday, December 25, 2006 10:47 AM
Subject: Re: [Xen-devel] [PATCH] qemu-dm monitor doesn't support the quit command
Quoted 7 lines
Hi All,
Quoted 4 lines
It is natural that there is quit command in original QEMU. However, I don't think that the HVM domain on Xen is necessary. Because there is a possibility of shutting down GuestOS due to the mistake. I think that I should prohibit the quit command of qemu-dm.
Quoted 7 lines
So as to refuse the quit command, the patch was corrected. If there is any problem, please let me know.
Thanks
--
Takanori Kasai
# HG changeset patch
# User [email protected]
# Node ID 333949ed3a785141e4ae046d95483fcf185e5836 # Parent 367f0c6efe2178e26ba0194ca795ff098e22a80b qemu-dm monitor does not support the quit command
tools/ioemu/monitor.c +0 -8
@@ -305,12 +305,6 @@ static void do_info_history (void)term_printf ("%d: '%s'\n" , i, str); i++; } -} - -static void do_quit (void ) -{ -destroy_hvm_domain (); -exit (0 ); }static int eject_device (BlockDriverState *bs,int force)
@@ -1158,8 +1152,6 @@ static term_cmd_t term_cmds[] = { "", "commit changes to the disk images (if -snapshot is used)" }, {"info" ,"s?" , do_info, "subcommand", "show various information about the system state" }, - { "q|quit", "", do_quit, - "", "quit the emulator" }, { "eject", "-fB", do_eject, "[-f] device", "eject a removable media (use -f to force it)" }, { "change", "BF", do_change,
_______________________________________________
Xen-devel mailing list
[email protected]
http://lists.xensource.com/xen-devel
quit command is useful when we have no host console(e.g. qemu window on a remote X). and it's a normal exit that is different from xm destroy(by KILL sig).
maybe we can change "q" to "quit" to avoid typo? or provide confirm info?
BTW, "q" is most popular command when we debug qemu device model:)
Quoted 45 lines · Kasai Takanori
Hi All,
I sent the following patches the other day.
This patch makes qemu-dm monitor not support the quit command. Because there is a possibility of shutting down HVM Domain by mistake. We think that the HVM domain should shut down by xm shutdown/destroy command.
Could you apply this patch?Thanks,
--
Takanori Kasai----- Original Message -----
From: "Kasai Takanori" <[email protected]>
To: "xen-devel" <[email protected]>
Sent: Monday, December 25, 2006 10:47 AM
Subject: Re: [Xen-devel] [PATCH] qemu-dm monitor doesn't support the quit commandQuoted 8 lines
Hi All,
Quoted 5 lines
It is natural that there is quit command in original QEMU. However, I don't think that the HVM domain on Xen is necessary. Because there is a possibility of shutting down GuestOS due to the mistake.
I think that I should prohibit the quit command of qemu-dm.Quoted 7 lines
So as to refuse the quit command, the patch was corrected. If there is any problem, please let me know.
Thanks
--
Takanori Kasai_______________________________________________
Xen-devel mailing list
[email protected]
http://lists.xensource.com/xen-devel
Signature · 2 lines
best rgds, edwin
Hi Edwin,
Thank you for reply.
Quoted 6 lines
quit command is useful when we have no host console(e.g. qemu window on a remote X). and it's a normal exit that is different from xm destroy(by KILL sig).
maybe we can change "q" to "quit" to avoid typo? or provide confirm info?
BTW, "q" is most popular command when we debug qemu device model:)
I understood the "quit" or "q" command was necessary for debugging. However, there is a possibility that the user shuts down the HVM domain by mistake.
Cannot you change "quit" or "q" to "quitdomain"?
Thanks,
--
Takanori Kasai
Hi All,
I made the patch that changed it from quit or q to quitdomain. I think that the HVM domain can be prevented being shutted down by the mistake in this patch. If there is any problem, please let me know.
Quoted 11 lines
Quoted 6 lines
quit command is useful when we have no host console(e.g. qemu window on a remote X). and it's a normal exit that is different from xm destroy(by KILL sig).
maybe we can change "q" to "quit" to avoid typo? or provide confirm info?
BTW, "q" is most popular command when we debug qemu device model:)
I understood the "quit" or "q" command was necessary for debugging. However, there is a possibility that the user shuts down the HVM domain by mistake.
Cannot you change "quit" or "q" to "quitdomain"?
Thanks,
--
Takanori Kasai
# HG changeset patch
# User [email protected]
# Date 1169002068 -32400
# Node ID fa6a0785562dc576933f82aceab43628a877dbc0
# Parent 895d873a00b47cb7b0edf3d0b6a42f47a3f4854c
quit or q command is changed to the quitdomain on qemu-dm monitor
tools/ioemu/monitor.c +1 -1
@@ -1158,7 +1158,7 @@ static term_cmd_t term_cmds[] = { "", "commit changes to the disk images (if -snapshot is used)" }, {"info" ,"s?" , do_info, "subcommand", "show various information about the system state" }, - { "q|quit", "", do_quit, + { "quitdomain", "", do_quit, "", "quit the emulator" }, { "eject", "-fB", do_eject, "[-f] device", "eject a removable media (use -f to force it)" },
_______________________________________________
Xen-devel mailing list
[email protected]
http://lists.xensource.com/xen-devel
Quoted 5 lines · Kasai Takanori
Hi All,
I made the patch that changed it from quit or q to quitdomain. I think that the HVM domain can be prevented being shutted down by the mistake in this patch. If there is any problem, please let me know.
It seems to me that this is just one more thing to get us further away from the upstream QEMU tree and to me, that's a bad thing. It's not this one patch in particular but once you get enough of these, it starts getting hairy.
If you really thing the q command is poorly named, I think you should make that case to the QEMU community. It really isn't a Xen specific issue.
If this really is a problem for you, couldn't you just keep the patch around for your own use? I haven't seen anyone else complain of this issue before so I'm not sure it will do anything but confuse other people.
Regards,
Anthony Liguori
Quoted 28 lines
Quoted 8 lines
Quoted 8 lines
quit command is useful when we have no host console(e.g. qemu window on a remote
X). and it's a normal exit that is different from xm destroy(by KILL sig).maybe we can change "q" to "quit" to avoid typo? or provide confirm info?
Quoted 7 lines
Quoted 1 line
BTW, "q" is most popular command when we debug qemu device model:)
I understood the "quit" or "q" command was necessary for debugging. However, there is a possibility that the user shuts down the HVM domain by mistake.
Cannot you change "quit" or "q" to "quitdomain"?
Thanks,
Signature · 9 lines
Takanori Kasai ------------------------------------------------------------------------ _______________________________________________ Xen-devel mailing list [email protected] http://lists.xensource.com/xen-devel
Hi Anthony,
Thank you for reply.
I want to achieve it by other methods.
Quoted 8 lines
Quoted 3 lines
I made the patch that changed it from quit or q to quitdomain. I think that the HVM domain can be prevented being shutted down by the mistake in this patch. If there is any problem, please let me know.
It seems to me that this is just one more thing to get us further away from the upstream QEMU tree and to me, that's a bad thing. It's not this one patch in particular but once you get enough of these, it starts getting hairy.
I also think certainly like that.
Quoted 2 lines
If you really thing the q command is poorly named, I think you should make that case to the QEMU community. It really isn't a Xen specific issue.
It is natural that there is quit command in original QEMU. I do not think the agreement in the QEMU community.
Quoted 3 lines
If this really is a problem for you, couldn't you just keep the patch around for your own use? I haven't seen anyone else complain of this issue before so I'm not sure it will do anything but confuse other people.
It was thought that it was necessary for the user's using by the operational aspect.
Thanks,
--
Takanori Kasai