Skip to contentSkip to conversation

ARM: shmobile: Add CPUFreq support for r8a7790-lager platform

RFC In review Benoit Cousson 3 participants 5 messages Feb 26, 2014 – Feb 28, 2014 SuperH

lore
Share & tools
lore
#0 lore raw

cover ARM: shmobile: Add CPUFreq support for r8a7790-lager platform

Hi Magnus,

This not-yet-ready-to-merge series is adding CPUFreq support to Lager board.

Due to the missing data for the OPP voltage values, a safe 1.0v value is used for all OPPs.

At least this series can be used by Laurent to test the z-clock CCF node and the KICK bit fix I've just sent.

Bottom-line, no real DVFS so far, but just DFS :-)

Please note that this series is safe even in the case of Cortex A7 boot since the cpufreq-cpu0 driver is using the physical CPU@0 device node. In the case of CA7 boot, the first cpu will be the CPU@100, and thus the driver will fail at probe time due to the lack of CPU@0.

Regards,
Benoit

Benoit Cousson (4):
ARM: dts: r8a7790-lager: Add VDD MPU regulator for DVFS
ARM: dts: r8a7790-lager: Add DVFS parameters into cpu0 node for

    r8a7790

ARM: shmobile: lager-reference: Add cpufreq-cpu0 device for CPUFreq
support
ARM: shmobile: Make r8a77900 CPUFreq capable

 arch/arm/boot/dts/r8a7790-lager.dts            | 25 +++++++++++++++++++++++++
 arch/arm/boot/dts/r8a7790.dtsi                 | 11 +++++++++++
 arch/arm/mach-shmobile/Kconfig                 |  2 ++
 arch/arm/mach-shmobile/board-lager-reference.c |  3 +++
 4 files changed, 41 insertions(+)
Signature · 1 line
1.8.3.2
#1 lore raw

Hi Benoit,

Quoted 10 lines · On Thursday 27 February 2014 00:09:46 Benoit Cousson wrote:

Hi Magnus,

This not-yet-ready-to-merge series is adding CPUFreq support to Lager board.

Due to the missing data for the OPP voltage values, a safe 1.0v value is used for all OPPs.

At least this series can be used by Laurent to test the z-clock CCF node and the KICK bit fix I've just sent.

Quoted 6 lines

Bottom-line, no real DVFS so far, but just DFS :-)

Please note that this series is safe even in the case of Cortex A7 boot since the cpufreq-cpu0 driver is using the physical CPU@0 device node. In the case of CA7 boot, the first cpu will be the CPU@100, and thus the driver will fail at probe time due to the lack of CPU@0.

I'd like to test that on r8a7791, can I use the same parameters (voltages, frequencies and OPPs) ?

Quoted 13 lines

Benoit Cousson (4):
ARM: dts: r8a7790-lager: Add VDD MPU regulator for DVFS
ARM: dts: r8a7790-lager: Add DVFS parameters into cpu0 node for

    r8a7790

ARM: shmobile: lager-reference: Add cpufreq-cpu0 device for CPUFreq
support
ARM: shmobile: Make r8a77900 CPUFreq capable

 arch/arm/boot/dts/r8a7790-lager.dts            | 25 +++++++++++++++++++++++
 arch/arm/boot/dts/r8a7790.dtsi                 | 11 +++++++++++
 arch/arm/mach-shmobile/Kconfig                 |  2 ++
 arch/arm/mach-shmobile/board-lager-reference.c |  3 +++
 4 files changed, 41 insertions(+)
Signature · 3 lines
Regards,

Laurent Pinchart
#2 lore raw
In reply to Benoit Cousson

Salut Laurent,

Quoted 15 lines · Laurent Pinchart

Hi Benoit,

Quoted 12 lines · On Thursday 27 February 2014 00:09:46 Benoit Cousson wrote:

Hi Magnus,

This not-yet-ready-to-merge series is adding CPUFreq support to Lager board.

Due to the missing data for the OPP voltage values, a safe 1.0v value is used for all OPPs.

At least this series can be used by Laurent to test the z-clock CCF node and the KICK bit fix I've just sent.

Bottom-line, no real DVFS so far, but just DFS :-)

Quoted 7 lines
Quoted 4 lines

Please note that this series is safe even in the case of Cortex A7 boot since the cpufreq-cpu0 driver is using the physical CPU@0 device node. In the case of CA7 boot, the first cpu will be the CPU@100, and thus the driver will fail at probe time due to the lack of CPU@0.

I'd like to test that on r8a7791, can I use the same parameters (voltages, frequencies and OPPs) ?

For the frequency, it will be similar since the r8a7791 seems to run at 1.3 GHz as well.

For the voltage, it should be similar, but I do not have any information and I'm not sure that the regulator used on the Koelsh board is the same (da9210).
It might be safer to remove the phandle to the regulator.
I hope the cpufreq-cpu0 driver probe will not fail becasue of that.

Regards,
Benoit

Signature · 4 lines
Benoît Cousson
BayLibre
Embedded Linux Technology Lab
www.baylibre.com
#3 lore raw
In reply to Benoit Cousson
Quoted 3 lines · Benoit Cousson

For the voltage, it should be similar, but I do not have any information and I'm not sure that the regulator used on the Koelsh board is the same (da9210).

Koelsch also has a DA9210 regulator. At first sight, the wiring seems similar. It's connected to i2c6 instead of i2c3, though.

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]

In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds

#4 lore raw
In reply to Benoit Cousson
Quoted 7 lines · Geert Uytterhoeven
Quoted 3 lines · Benoit Cousson

For the voltage, it should be similar, but I do not have any information and I'm not sure that the regulator used on the Koelsh board is the same (da9210).

Koelsch also has a DA9210 regulator. At first sight, the wiring seems similar. It's connected to i2c6 instead of i2c3, though.

OK, that's a good news. Thanks for checking.

Laurent,

In order to check the voltage, just enable the DA9210 driver but do not enable cpufreq.

Then just check the regulator voltage. It was 1.08v by default on the Lager.

Regards,
Benoit

Quoted 16 lines

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]

In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
--
To unsubscribe from this list: send the line "unsubscribe linux-sh" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html

Signature · 4 lines
Benoît Cousson
BayLibre
Embedded Linux Technology Lab
www.baylibre.com