leds: Add powerdown gpio for is31fl32xx
Subsystems (2)
v3 cover leds: Add powerdown gpio for is31fl32xx
This patch series primarily adds the powerdown-gpios support for the IS31FL32xx controller.It also includes a fix and dt-bindings updates derived from previous attempts [1].
Patch 1 and patch 2 are based on a previous attempt [1]. The driver-related updates in patch 2 have already been merged.
Patch 3 and Patch 4 add support for the powerdown-gpios property, which corresponds to the SDB pin of the IS31FL32xx series chips. This pin is used to enter and exit the hardware powerdown mode.
Patch 5 fixes errors introduced by previous changes. It impacts the brightness control function of the IS31FL3236.
[1] https://lore.kernel.org/all/[email protected]/
Changes in v3:
- Replace shutdown-gpios with powerdown-gpios, follow gpio-consumer-common binding.
- Link to v2: https://lore.kernel.org/all/[email protected]/
Changes in v2:
- Fix $id mismatch with file name in dt-binding.
- Link to v1: https://lore.kernel.org/all/[email protected]/
Jun Yan (5):
dt-bindings: leds: is31fl32xx: convert the binding to yaml
dt-bindings: leds: leds-is31fl32xx: add support for is31fl3236a
dt-bindings: leds: leds-is31fl32xx: Add powerdown-gpios property
leds: is31fl32xx: Add powerdown pin to exit hardware shutdown mode
leds: is31f132xx: Fix missing brightness_steps for is31f13236
.../bindings/leds/issl,is31fl32xx.yaml | 200 ++++++++++++++++++ .../bindings/leds/leds-is31fl32xx.txt | 53 ----- drivers/leds/leds-is31fl32xx.c | 7 + 3 files changed, 207 insertions(+), 53 deletions(-) create mode 100644 Documentation/devicetree/bindings/leds/issl,is31fl32xx.yaml delete mode 100644 Documentation/devicetree/bindings/leds/leds-is31fl32xx.txt
Signature · 1 line
2.53.0
PATCH v3 1/5 dt-bindings: leds: is31fl32xx: convert the binding to yaml
Convert leds-is31fl32xx to DT schema format.
--- .../bindings/leds/issl,is31fl32xx.yaml | 163 ++++++++++++++++++ .../bindings/leds/leds-is31fl32xx.txt | 53 ------ 2 files changed, 163 insertions(+), 53 deletions(-) create mode 100644 Documentation/devicetree/bindings/leds/issl,is31fl32xx.yaml delete mode 100644 Documentation/devicetree/bindings/leds/leds-is31fl32xx.txt
Documentation/devicetree/bindings/leds/issl,is31fl32xx.yaml new file +163 -0
@@ -0,0 +1,163 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/leds/issl,is31fl32xx.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: IS31FL32xx and Si-En SN32xx LED controller + +maintainers: + - Lucca Fachinetti <[email protected]> + - Pavel Machek <[email protected]> + - Jun Yan <[email protected]> + +description: | + The IS31FL32xx/SN32xx family of LED drivers are I2C devices with multiple + constant-current channels, each with independent 256-level PWM control. + Each LED is represented as a sub-node of the device. + + For more product information please see the links below: + https://www.lumissil.com/assets/pdf/core/IS31FL3216_DS.pdf + https://www.lumissil.com/assets/pdf/core/IS31FL3218_DS.pdf + https://www.lumissil.com/assets/pdf/core/IS31FL3235_DS.pdf + https://www.lumissil.com/assets/pdf/core/IS31FL3236_DS.pdf + https://www.lumissil.com/assets/pdf/core/IS31FL3293_DS.pdf + +properties: + compatible: + enum: + - issi,is31fl3216 + - issi,is31fl3218 + - issi,is31fl3235 + - issi,is31fl3236 + - issi,is31fl3293 + - si-en,sn3216 + - si-en,sn3218 + + reg: + maxItems: 1 + + "#address-cells": + const: 1 + + "#size-cells": + const: 0 + +patternProperties: + "^led@([1-9])+$": + type: object + $ref: common.yaml# + unevaluatedProperties: false + + properties: + reg: + description: + LED channel number (1..N) + minimum: 1 + maximum: 36 + + required: + - reg + +allOf: + - if: + properties: + compatible: + contains: + enum: + - issi,is31fl3293 + then: + patternProperties: + "^led@([1-9])+$": + properties: + reg: + maximum: 3 + - if: + properties: + compatible: + contains: + enum: + - issi,is31fl3216 + - si-en,sn3216 + then: + patternProperties: + "^led@([1-9])+$": + properties: + reg: + maximum: 16 + - if: + properties: + compatible: + contains: + enum: + - issi,is31fl3218 + - si-en,sn3218 + then: + patternProperties: + "^led@([1-9])+$": + properties: + reg: + maximum: 18 + - if: + properties: + compatible: + contains: + enum: + - issi,is31fl3235 + then: + patternProperties: + "^led@([1-9])+$": + properties: + reg: + maximum: 28 + - if: + properties: + compatible: + contains: + enum: + - issi,is31fl3236 + then: + patternProperties: + "^led@([1-9])+$": + properties: + reg: + maximum: 36 + +required: + - compatible + - reg + - "#address-cells" + - "#size-cells" + +additionalProperties: false + +examples: + - | + #include <dt-bindings/leds/common.h> + + i2c { + #address-cells = <1>; + #size-cells = <0>; + + led-controller@3c { + compatible = "issi,is31fl3236"; + reg = <0x3c>; + #address-cells = <1>; + #size-cells = <0>; + + led@1 { + reg = <1>; + color = <LED_COLOR_ID_RED>; + function = LED_FUNCTION_STATUS; + }; + + led@5 { + reg = <5>; + color = <LED_COLOR_ID_GREEN>; + function = LED_FUNCTION_POWER; + linux,default-trigger = "default-on"; + }; + }; + }; +... +
Documentation/devicetree/bindings/leds/leds-is31fl32xx.txt deleted +0 -53
53 lines not on this page · raw message
Signature · 1 line
2.53.0
Rob Herring
maintainerRe: [PATCH v3 1/5] dt-bindings: leds: is31fl32xx: convert the binding to yaml
Quoted 57 lines · Jun Yan
Convert leds-is31fl32xx to DT schema format.
Co-developed-by Lucca Fachinetti <[email protected]>Signed-off-by Lucca Fachinetti <[email protected]>Co-developed-by Pawel Zalewski <[email protected]>Signed-off-by Pawel Zalewski <[email protected]>Signed-off-by Jun Yan <[email protected]>--- .../bindings/leds/issl,is31fl32xx.yaml | 163 ++++++++++++++++++ .../bindings/leds/leds-is31fl32xx.txt | 53 ------ 2 files changed, 163 insertions(+), 53 deletions(-) create mode 100644 Documentation/devicetree/bindings/leds/issl,is31fl32xx.yaml delete mode 100644 Documentation/devicetree/bindings/leds/leds-is31fl32xx.txtDocumentation/devicetree/bindings/leds/issl,is31fl32xx.yaml new file +37
-0@@ -0,0 +1,163 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/leds/issl,is31fl32xx.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: IS31FL32xx and Si-En SN32xx LED controller + +maintainers: + - Lucca Fachinetti <[email protected]> + - Pavel Machek <[email protected]> + - Jun Yan <[email protected]> + +description: | + The IS31FL32xx/SN32xx family of LED drivers are I2C devices with multiple + constant-current channels, each with independent 256-level PWM control. + Each LED is represented as a sub-node of the device. + + For more product information please see the links below: + https://www.lumissil.com/assets/pdf/core/IS31FL3216_DS.pdf + https://www.lumissil.com/assets/pdf/core/IS31FL3218_DS.pdf + https://www.lumissil.com/assets/pdf/core/IS31FL3235_DS.pdf + https://www.lumissil.com/assets/pdf/core/IS31FL3236_DS.pdf + https://www.lumissil.com/assets/pdf/core/IS31FL3293_DS.pdf + +properties: + compatible: + enum: + - issi,is31fl3216 + - issi,is31fl3218 + - issi,is31fl3235 + - issi,is31fl3236 + - issi,is31fl3293 + - si-en,sn3216 + - si-en,sn3218 + + reg:
Documentation/devicetree/bindings/leds/issl,is31fl32xx.yaml line 47
Quoted 10 lines
Documentation/devicetree/bindings/leds/issl,is31fl32xx.yaml new file +10
-0+ maxItems: 1 + + "#address-cells": + const: 1 + + "#size-cells": + const: 0 + +patternProperties: + "^led@([1-9])+$":
Unit-addresses are hex.
Quoted 14 lines
Documentation/devicetree/bindings/leds/issl,is31fl32xx.yaml new file +14
-0+ type: object + $ref: common.yaml# + unevaluatedProperties: false + + properties: + reg: + description: + LED channel number (1..N) + minimum: 1 + maximum: 36 + + required: + - reg +
Documentation/devicetree/bindings/leds/issl,is31fl32xx.yaml line 71
Quoted 10 lines
Documentation/devicetree/bindings/leds/issl,is31fl32xx.yaml new file +10
-0+allOf: + - if: + properties: + compatible: + contains: + enum: + - issi,is31fl3293 + then: + patternProperties: + "^led@([1-9])+$":
No need to repeat the unit-address pattern here. Just "^led@".
Quoted 43 lines
Documentation/devicetree/bindings/leds/issl,is31fl32xx.yaml new file +43
-0+ properties: + reg: + maximum: 3 + - if: + properties: + compatible: + contains: + enum: + - issi,is31fl3216 + - si-en,sn3216 + then: + patternProperties: + "^led@([1-9])+$": + properties: + reg: + maximum: 16 + - if: + properties: + compatible: + contains: + enum: + - issi,is31fl3218 + - si-en,sn3218 + then: + patternProperties: + "^led@([1-9])+$": + properties: + reg: + maximum: 18 + - if: + properties: + compatible: + contains: + enum: + - issi,is31fl3235 + then: + patternProperties: + "^led@([1-9])+$": + properties: + reg: + maximum: 28 + - if: + properties:
Documentation/devicetree/bindings/leds/issl,is31fl32xx.yaml line 124
Quoted 10 lines
Documentation/devicetree/bindings/leds/issl,is31fl32xx.yaml new file +10
-0+ compatible: + contains: + enum: + - issi,is31fl3236 + then: + patternProperties: + "^led@([1-9])+$": + properties: + reg: + maximum: 36
That's the default max, so you can drop this if/then.
Quoted 101 lines
Documentation/devicetree/bindings/leds/issl,is31fl32xx.yaml new file +39
-0+ +required: + - compatible + - reg + - "#address-cells" + - "#size-cells" + +additionalProperties: false + +examples: + - | + #include <dt-bindings/leds/common.h> + + i2c { + #address-cells = <1>; + #size-cells = <0>; + + led-controller@3c { + compatible = "issi,is31fl3236"; + reg = <0x3c>; + #address-cells = <1>; + #size-cells = <0>; + + led@1 { + reg = <1>; + color = <LED_COLOR_ID_RED>; + function = LED_FUNCTION_STATUS; + }; + + led@5 { + reg = <5>; + color = <LED_COLOR_ID_GREEN>; + function = LED_FUNCTION_POWER; + linux,default-trigger = "default-on"; + }; + }; + }; +... +Documentation/devicetree/bindings/leds/leds-is31fl32xx.txt deleted +0
-53@@ -1,53 +0,0 @@ -Binding for ISSI IS31FL32xx and Si-En SN32xx LED Drivers - -The IS31FL32xx/SN32xx family of LED drivers are I2C devices with multiple -constant-current channels, each with independent 256-level PWM control. -Each LED is represented as a sub-node of the device. - -Required properties: -- compatible: one of - issi,is31fl3236 - issi,is31fl3235 - issi,is31fl3218 - issi,is31fl3216 - issi,is31fl3293 - si-en,sn3218 - si-en,sn3216 -- reg: I2C slave address -- address-cells : must be 1 -- size-cells : must be 0 - -LED sub-node properties: -- reg : LED channel number (1..N) -- label : (optional) - see Documentation/devicetree/bindings/leds/common.txt -- linux,default-trigger : (optional) - see Documentation/devicetree/bindings/leds/common.txt - - -Example: - -is31fl3236: led-controller@3c { - compatible = "issi,is31fl3236"; - reg = <0x3c>; - #address-cells = <1>; - #size-cells = <0>; - - led@1 { - reg = <1>; - label = "EB:blue:usr0"; - }; - led@2 { - reg = <2>; - label = "EB:blue:usr1"; - }; - ... - led@36 { - reg = <36>; - label = "EB:blue:usr35"; - }; -}; - -For more product information please see the links below: -http://www.issi.com/US/product-analog-fxled-driver.shtml -http://www.si-en.com/product.asp?parentid=890Signature · 1 line
2.53.0
Re: [PATCH v3 1/5] dt-bindings: leds: is31fl32xx: convert the binding to yaml
Quoted 62 lines · Jun Yan
Quoted 61 lines
Convert leds-is31fl32xx to DT schema format.
Co-developed-by Lucca Fachinetti <[email protected]>Signed-off-by Lucca Fachinetti <[email protected]>Co-developed-by Pawel Zalewski <[email protected]>Signed-off-by Pawel Zalewski <[email protected]>Signed-off-by Jun Yan <[email protected]>--- .../bindings/leds/issl,is31fl32xx.yaml | 163 ++++++++++++++++++ .../bindings/leds/leds-is31fl32xx.txt | 53 ------ 2 files changed, 163 insertions(+), 53 deletions(-) create mode 100644 Documentation/devicetree/bindings/leds/issl,is31fl32xx.yaml delete mode 100644 Documentation/devicetree/bindings/leds/leds-is31fl32xx.txtDocumentation/devicetree/bindings/leds/issl,is31fl32xx.yaml new file +41
-0@@ -0,0 +1,163 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/leds/issl,is31fl32xx.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: IS31FL32xx and Si-En SN32xx LED controller + +maintainers: + - Lucca Fachinetti <[email protected]> + - Pavel Machek <[email protected]> + - Jun Yan <[email protected]> + +description: | + The IS31FL32xx/SN32xx family of LED drivers are I2C devices with multiple + constant-current channels, each with independent 256-level PWM control. + Each LED is represented as a sub-node of the device. + + For more product information please see the links below: + https://www.lumissil.com/assets/pdf/core/IS31FL3216_DS.pdf + https://www.lumissil.com/assets/pdf/core/IS31FL3218_DS.pdf + https://www.lumissil.com/assets/pdf/core/IS31FL3235_DS.pdf + https://www.lumissil.com/assets/pdf/core/IS31FL3236_DS.pdf + https://www.lumissil.com/assets/pdf/core/IS31FL3293_DS.pdf + +properties: + compatible: + enum: + - issi,is31fl3216 + - issi,is31fl3218 + - issi,is31fl3235 + - issi,is31fl3236 + - issi,is31fl3293 + - si-en,sn3216 + - si-en,sn3218 + + reg: + maxItems: 1 + + "#address-cells": + const: 1
Quoted 8 lines
Documentation/devicetree/bindings/leds/issl,is31fl32xx.yaml line 47
Quoted 6 lines
Documentation/devicetree/bindings/leds/issl,is31fl32xx.yaml new file +6
-0+ + "#size-cells": + const: 0 + +patternProperties: + "^led@([1-9])+$":Unit-addresses are hex.
Got it.
Quoted 18 lines
Quoted 18 lines
Documentation/devicetree/bindings/leds/issl,is31fl32xx.yaml new file +18
-0+ type: object + $ref: common.yaml# + unevaluatedProperties: false + + properties: + reg: + description: + LED channel number (1..N) + minimum: 1 + maximum: 36 + + required: + - reg + +allOf: + - if: + properties: + compatible:
Quoted 8 lines
Documentation/devicetree/bindings/leds/issl,is31fl32xx.yaml line 71
Quoted 6 lines
Documentation/devicetree/bindings/leds/issl,is31fl32xx.yaml new file +6
-0+ contains: + enum: + - issi,is31fl3293 + then: + patternProperties: + "^led@([1-9])+$":No need to repeat the unit-address pattern here. Just "^led@".
Got it.
Quoted 54 lines
Quoted 43 lines
Documentation/devicetree/bindings/leds/issl,is31fl32xx.yaml new file +43
-0+ properties: + reg: + maximum: 3 + - if: + properties: + compatible: + contains: + enum: + - issi,is31fl3216 + - si-en,sn3216 + then: + patternProperties: + "^led@([1-9])+$": + properties: + reg: + maximum: 16 + - if: + properties: + compatible: + contains: + enum: + - issi,is31fl3218 + - si-en,sn3218 + then: + patternProperties: + "^led@([1-9])+$": + properties: + reg: + maximum: 18 + - if: + properties: + compatible: + contains: + enum: + - issi,is31fl3235 + then: + patternProperties: + "^led@([1-9])+$": + properties: + reg: + maximum: 28 + - if: + properties:Documentation/devicetree/bindings/leds/issl,is31fl32xx.yaml line 124
Quoted 10 lines
Documentation/devicetree/bindings/leds/issl,is31fl32xx.yaml new file +10
-0+ compatible: + contains: + enum: + - issi,is31fl3236 + then: + patternProperties: + "^led@([1-9])+$": + properties: + reg: + maximum: 36
Quoted 1 line
That's the default max, so you can drop this if/then.
Agreed.
These changes will be implemented in v5.
Quoted 102 lines
Quoted 102 lines
Documentation/devicetree/bindings/leds/issl,is31fl32xx.yaml new file +39
-0+ +required: + - compatible + - reg + - "#address-cells" + - "#size-cells" + +additionalProperties: false + +examples: + - | + #include <dt-bindings/leds/common.h> + + i2c { + #address-cells = <1>; + #size-cells = <0>; + + led-controller@3c { + compatible = "issi,is31fl3236"; + reg = <0x3c>; + #address-cells = <1>; + #size-cells = <0>; + + led@1 { + reg = <1>; + color = <LED_COLOR_ID_RED>; + function = LED_FUNCTION_STATUS; + }; + + led@5 { + reg = <5>; + color = <LED_COLOR_ID_GREEN>; + function = LED_FUNCTION_POWER; + linux,default-trigger = "default-on"; + }; + }; + }; +... +Documentation/devicetree/bindings/leds/leds-is31fl32xx.txt deleted +0
-53@@ -1,53 +0,0 @@ -Binding for ISSI IS31FL32xx and Si-En SN32xx LED Drivers - -The IS31FL32xx/SN32xx family of LED drivers are I2C devices with multiple -constant-current channels, each with independent 256-level PWM control. -Each LED is represented as a sub-node of the device. - -Required properties: -- compatible: one of - issi,is31fl3236 - issi,is31fl3235 - issi,is31fl3218 - issi,is31fl3216 - issi,is31fl3293 - si-en,sn3218 - si-en,sn3216 -- reg: I2C slave address -- address-cells : must be 1 -- size-cells : must be 0 - -LED sub-node properties: -- reg : LED channel number (1..N) -- label : (optional) - see Documentation/devicetree/bindings/leds/common.txt -- linux,default-trigger : (optional) - see Documentation/devicetree/bindings/leds/common.txt - - -Example: - -is31fl3236: led-controller@3c { - compatible = "issi,is31fl3236"; - reg = <0x3c>; - #address-cells = <1>; - #size-cells = <0>; - - led@1 { - reg = <1>; - label = "EB:blue:usr0"; - }; - led@2 { - reg = <2>; - label = "EB:blue:usr1"; - }; - ... - led@36 { - reg = <36>; - label = "EB:blue:usr35"; - }; -}; - -For more product information please see the links below: -http://www.issi.com/US/product-analog-fxled-driver.shtml -http://www.si-en.com/product.asp?parentid=890Signature · 1 line
2.53.0
PATCH v3 2/5 dt-bindings: leds: leds-is31fl32xx: add support for is31fl3236a
In reply to Jun YanAdd an additional and optional control property for setting the output PWM frequency to 22kHz that exists on is31fl3236a. The default is 3kHz and this option puts the operational frequency outside of the audible range.
--- .../bindings/leds/issl,is31fl32xx.yaml | 25 +++++++++++++++++++ 1 file changed, 25 insertions(+)
Documentation/devicetree/bindings/leds/issl,is31fl32xx.yaml +25 -0
@@ -21,6 +21,7 @@ description: | https://www.lumissil.com/assets/pdf/core/IS31FL3218_DS.pdf https://www.lumissil.com/assets/pdf/core/IS31FL3235_DS.pdf https://www.lumissil.com/assets/pdf/core/IS31FL3236_DS.pdf + https://www.lumissil.com/assets/pdf/core/IS31FL3236A_DS.pdf https://www.lumissil.com/assets/pdf/core/IS31FL3293_DS.pdf properties:
@@ -30,6 +31,7 @@ properties: - issi,is31fl3218 - issi,is31fl3235 - issi,is31fl3236 + - issi,is31fl3236a - issi,is31fl3293 - si-en,sn3216 - si-en,sn3218
@@ -37,6 +39,12 @@ properties: reg: maxItems: 1 + issi,22khz-pwm: + type: boolean + description: + When present, the chip's PWM will operate at ~22kHz as opposed + to ~3kHz to move the operating frequency out of the audible range. + "#address-cells": const: 1
@@ -60,6 +68,22 @@ patternProperties: - reg allOf: + - if: + properties: + compatible: + contains: + enum: + - issi,is31fl3216 + - issi,is31fl3218 + - issi,is31fl3235 + - issi,is31fl3236 + - issi,is31fl3293 + - si-en,sn3216 + - si-en,sn3218 + then: + properties: + issi,22khz-pwm: false + - if: properties: compatible:
@@ -116,6 +140,7 @@ allOf: contains: enum: - issi,is31fl3236 + - issi,is31fl3236a then: patternProperties: "^led@([1-9])+$":
Signature · 1 line
2.53.0
Re: [PATCH v3 2/5] dt-bindings: leds: leds-is31fl32xx: add support for is31fl3236a
Quoted 5 lines · Jun Yan
Add an additional and optional control property for setting the output PWM frequency to 22kHz that exists on is31fl3236a. The default is 3kHz and this option puts the operational frequency outside of the audible range.
Quoted 7 lines
Co-developed-by Pawel Zalewski <[email protected]>Signed-off-by Pawel Zalewski <[email protected]>Signed-off-by Jun Yan <[email protected]>--- .../bindings/leds/issl,is31fl32xx.yaml | 25 +++++++++++++++++++ 1 file changed, 25 insertions(+)
PATCH v3 3/5 dt-bindings: leds: leds-is31fl32xx: Add powerdown-gpios property
In reply to Jun YanThe IS31FL32XX series features an SDB shutdown pin.
Driving it low (active low) places the chip into hardware shutdown mode for power saving, while all register contents are preserved and registers are not reset.
Add powerdown-gpios property to describe the GPIO connected to the SDB pin of IS31FL32XX series LED controllers.
--- .../devicetree/bindings/leds/issl,is31fl32xx.yaml | 12 ++++++++++++ 1 file changed, 12 insertions(+)
Documentation/devicetree/bindings/leds/issl,is31fl32xx.yaml +12 -0
@@ -45,6 +45,15 @@ properties: When present, the chip's PWM will operate at ~22kHz as opposed to ~3kHz to move the operating frequency out of the audible range. + powerdown-gpios: + maxItems: 1 + description: + GPIO connected to the chip's SDB pin. + Driving this GPIO low places the chip into hardware shutdown mode + for power saving. All register contents are preserved and registers + are not reset during shutdown. The chip exits hardware shutdown mode + when the SDB pin is pulled high. + "#address-cells": const: 1
@@ -158,6 +167,7 @@ additionalProperties: false examples: - | + #include <dt-bindings/gpio/gpio.h> #include <dt-bindings/leds/common.h> i2c {
@@ -170,6 +180,8 @@ examples: #address-cells = <1>; #size-cells = <0>; + powerdown-gpios = <&gpio0 11 GPIO_ACTIVE_LOW>; + led@1 { reg = <1>; color = <LED_COLOR_ID_RED>;
Signature · 1 line
2.53.0
Re: [PATCH v3 3/5] dt-bindings: leds: leds-is31fl32xx: Add powerdown-gpios property
Quoted 5 lines · Jun Yan
The IS31FL32XX series features an SDB shutdown pin.
Driving it low (active low) places the chip into hardware shutdown mode for power saving, while all register contents are preserved and registers are not reset.
Quoted 8 lines
Add powerdown-gpios property to describe the GPIO connected to the SDB pin of IS31FL32XX series LED controllers.
Signed-off-by Jun Yan <[email protected]>--- .../devicetree/bindings/leds/issl,is31fl32xx.yaml | 12 ++++++++++++ 1 file changed, 12 insertions(+)
PATCH v3 4/5 leds: is31fl32xx: Add powerdown pin to exit hardware shutdown mode
In reply to Jun YanThe IS31FL32XX series features an SDB shutdown pin. Driving it low (active low) places the chip into hardware shutdown mode for power saving, while all register contents are preserved and registers are not reset.
Drive the pin logic low during probe() to exit hardware shutdown mode.
--- drivers/leds/leds-is31fl32xx.c | 6 ++++++ 1 file changed, 6 insertions(+)
drivers/leds/leds-is31fl32xx.c +6 -0
@@ -60,6 +60,7 @@ struct is31fl32xx_led_data {struct is31fl32xx_priv {const struct is31fl32xx_chipdef *cdef;struct i2c_client *client; +struct gpio_desc *powerdown_gpio;unsigned int num_leds;struct is31fl32xx_led_data leds[]; };
@@ -421,6 +422,11 @@ static int is31fl32xx_parse_dt(struct device *dev,const struct is31fl32xx_chipdef *cdef = priv->cdef;int ret =0 ; + priv->powerdown_gpio =devm_gpiod_get_optional (dev,"powerdown" ,GPIOD_OUT_LOW ); +if (IS_ERR (priv->powerdown_gpio)) +return dev_err_probe (dev,PTR_ERR (priv->powerdown_gpio), +"Failed to get powerdown gpio\n" ); +if ((cdef->output_frequency_setting_reg !=IS31FL32XX_REG_NONE ) &&of_property_read_bool (dev_of_node (dev),"issi,22khz-pwm" )) {
Signature · 1 line
2.53.0
PATCH v3 5/5 leds: is31f132xx: Fix missing brightness_steps for is31f13236
In reply to Jun YanAdd missing brightness_steps for is31fl3236 to fix brightness control.
--- drivers/leds/leds-is31fl32xx.c | 1 + 1 file changed, 1 insertion(+)
drivers/leds/leds-is31fl32xx.c +1 -0
@@ -487,6 +487,7 @@ static const struct is31fl32xx_chipdef is31fl3236_cdef = { .pwm_register_base = 0x01, .led_control_register_base = 0x26, .enable_bits_per_led_control_register = 1, + .brightness_steps = 256, };static const struct is31fl32xx_chipdef is31fl3236a_cdef = {
Signature · 1 line
2.53.0