Add Radxa CM5 and IO Board
Subsystems (2)
v6 cover Add Radxa CM5 and IO Board
This patch series add support for the Radxa CM5 SoM and IO Board.
Changes in v6:
(Patch 1/3)
- Fix description; "Radxa CM5" is the correct name (Patch 2/3)
- Fix #include(s)
- Include rk3588s.dtsi
- Move alias for gmac1 from io board dts
- Add Maskrom key
- Add pinctrl-* for led-0
- Add vcc_1v1_nldo_s3 regulator for pmic
- Move gmac1 (except status) from io board dts
- Fix phy-supply for gmac1
- Fix compatible for vdd_cpu_big1_s0 regulator
- Add eeprom on i2c0
- Add vdd_npu_s0 regulator for rknn
- Fix compatible for rgmii_phy1
- Add pinctrl-* and reset-* for rgmii_phy1
- Add domain-supply for pd_npu
- Add rknn_*
- Add saradc
- Fix properties in sdhci
- Move pmic from io board dts
- Fix vcc*-supply for pmic
- Add regulators in pmic
- Add tsadc
- Move vop(_mmu) from io board dts
- Trivial changes (labels, names, etc) (Patch 3/3)
- Fix #include(s)
- Remove #include "rk3588s.dtsi"
- Fix model
- Add fan
- Add Recovery key
- Add pinctrl-* for vcc3v3_wf
- Add vcc_sysin regulator
- Add pinctrl-* for vbus5v0_typec
- Add rfkill-bt and rfkill-wlan for M.2 module
- Add sound for es8316
- Add phy-supply for combphy2_psu
- Fix power-role to "source" for fusb302
- Add rtc for hym8536
- Add audio-codec on i2c8 for es8316
- Add i2s0_8ch for es8316
- Add package_thermal for fan
- Add pinctrl-* for pcie2x1l2
- Add pwm11 for fan
- Fix properties in sdmmmc
- Add phy-supply for u2phy2_host and u2phy3_host
- Remove usb_host0_ohci
- Add pinctrl-* for usbdp_phy0
- Trivial changes (labels, names, etc)
Changes in v5:
(Patch 2/3, per Jimmy)
- Alias eMMC to mmc0
- Remove unused sdio alias
- Move gmac, hdmi0 nodes to carrier board dts
(Patch 3/3, per Jimmy)
- Enable hdmi0_sound and i2s5_8ch
- Remove redundant enablement of sdhci
- Enable usb_host2_xhci
- Tested HDMI audio
Changes in v4:
- Fixed XHCI initialization bug by changing try-power-role from source to sink
Changes in v3:
- Addressed YAML syntax error in dt binding (per Rob)
- Fixed whitespace issue in dts reported by checkpatch.pl
- Split base SoM and carrier board into separate patches
- Added further details about the SoM and carrier to the commit messages
Changes in v2:
- Added copyright header and data sheet links
- Removed non-existent property
- Sorted alphabetically
- Removed errant whitespace
- Moved status to the end of each node
- Removed pinctrl-names property from leds (indicated by CHECK_DTBS)
- Removed delays from gmac with internal delay
---
I have communicated with Joseph privately and taken ownership of moving this forward, with his blessing. All bugs belong to me.
---
FUKAUMI Naoki (3):
dt-bindings: arm: rockchip: Add Radxa CM5 IO Board
arm64: dts: rockchip: Add Radxa CM5
arm64: dts: rockchip: Add Radxa CM5 IO Board
.../devicetree/bindings/arm/rockchip.yaml | 7 + arch/arm64/boot/dts/rockchip/Makefile | 1 + .../dts/rockchip/rk3588s-radxa-cm5-io.dts | 503 +++++++++++++++ .../boot/dts/rockchip/rk3588s-radxa-cm5.dtsi | 602 ++++++++++++++++++ 4 files changed, 1113 insertions(+) create mode 100644 arch/arm64/boot/dts/rockchip/rk3588s-radxa-cm5-io.dts create mode 100644 arch/arm64/boot/dts/rockchip/rk3588s-radxa-cm5.dtsi
Signature · 7 lines
2.43.0 _______________________________________________ Linux-rockchip mailing list [email protected] http://lists.infradead.org/mailman/listinfo/linux-rockchip
PATCH v6 1/3 dt-bindings: arm: rockchip: Add Radxa CM5 IO Board
Add device tree binding documentation for the Radxa CM5 IO Board.
--- Documentation/devicetree/bindings/arm/rockchip.yaml | 7 +++++++ 1 file changed, 7 insertions(+)
Documentation/devicetree/bindings/arm/rockchip.yaml +7 -0
@@ -902,6 +902,13 @@ properties: - const: radxa,cm3i - const: rockchip,rk3568 + - description: Radxa CM5 + items: + - enum: + - radxa,cm5-io + - const: radxa,cm5 + - const: rockchip,rk3588s + - description: Radxa E20C items: - const: radxa,e20c
Signature · 7 lines
2.43.0 _______________________________________________ Linux-rockchip mailing list [email protected] http://lists.infradead.org/mailman/listinfo/linux-rockchip
Re: [PATCH v6 1/3] dt-bindings: arm: rockchip: Add Radxa CM5 IO Board
Quoted 5 lines · FUKAUMI Naoki
Add device tree binding documentation for the Radxa CM5 IO Board.
Signed-off-by FUKAUMI Naoki <[email protected]>Signed-off-by Joseph Kogut <[email protected]>
Wrong DCO chain.
Quoted 2 lines
--- Documentation/devicetree/bindings/arm/rockchip.yaml | 7 +++++++
NAK, you just stolen ownership of an already posted patch.
Best regards,
Krzysztof
Re: [PATCH v6 1/3] dt-bindings: arm: rockchip: Add Radxa CM5 IO Board
Quoted 7 lines · Krzysztof Kozlowski
Quoted 5 lines · FUKAUMI Naoki
Add device tree binding documentation for the Radxa CM5 IO Board.
Signed-off-by FUKAUMI Naoki <[email protected]>Signed-off-by Joseph Kogut <[email protected]>
Quoted 6 lines
Wrong DCO chain.
Quoted 2 lines
--- Documentation/devicetree/bindings/arm/rockchip.yaml | 7 +++++++NAK, you just stolen ownership of an already posted patch.
Read "Changes in v6" and patches; my patches are not the same as v5. Your reply is totally inappropriate.
Quoted 3 lines
Best regards,
Krzysztof
_______________________________________________
Linux-rockchip mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-rockchip
Re: [PATCH v6 1/3] dt-bindings: arm: rockchip: Add Radxa CM5 IO Board
Quoted 10 lines · FUKAUMI Naoki
Quoted 9 lines · Krzysztof Kozlowski
Quoted 5 lines · FUKAUMI Naoki
Add device tree binding documentation for the Radxa CM5 IO Board.
Signed-off-by FUKAUMI Naoki <[email protected]>Signed-off-by Joseph Kogut <[email protected]>Wrong DCO chain.
Quoted 7 lines
Quoted 4 lines
Quoted 2 lines
--- Documentation/devicetree/bindings/arm/rockchip.yaml | 7 +++++++NAK, you just stolen ownership of an already posted patch.
Read "Changes in v6" and patches; my patches are not the same as v5. Your reply is totally inappropriate.
Inappropriate is taking authorship of someone's patch, because we all expect to preserve the original authorship. That's not only basic decency but actually a standard.
Additionally, read Joseph's reply that he wants to continue the work:
https://lore.kernel.org/all/CAMWSM7iHtAxewW4JkRqRsifVnccqeFviaCgeOyprKDr92FOurg@mail.gmail.com/
You clearly do not understand how to continue with someone's work.
It is still a NAK.
Best regards,
Krzysztof
Re: [PATCH v6 1/3] dt-bindings: arm: rockchip: Add Radxa CM5 IO Board
Quoted 23 lines · Krzysztof Kozlowski
Quoted 10 lines · FUKAUMI Naoki
Quoted 9 lines · Krzysztof Kozlowski
Quoted 5 lines · FUKAUMI Naoki
Add device tree binding documentation for the Radxa CM5 IO Board.
Signed-off-by FUKAUMI Naoki <[email protected]>Signed-off-by Joseph Kogut <[email protected]>Wrong DCO chain.
Quoted 7 lines
Quoted 4 lines
Quoted 2 lines
--- Documentation/devicetree/bindings/arm/rockchip.yaml | 7 +++++++NAK, you just stolen ownership of an already posted patch.
Read "Changes in v6" and patches; my patches are not the same as v5. Your reply is totally inappropriate.
Inappropriate is taking authorship of someone's patch, because we all expect to preserve the original authorship. That's not only basic decency but actually a standard.
Quoted 6 lines
Additionally, read Joseph's reply that he wants to continue the work:
https://lore.kernel.org/all/CAMWSM7iHtAxewW4JkRqRsifVnccqeFviaCgeOyprKDr92FOurg@mail.gmail.com/You clearly do not understand how to continue with someone's work.
It is still a NAK.
And I still wait for justification why you took authorship of this patch, because to my eye you changed here nothing.
So what did you change HERE that you think you are the author now?
Best regards,
Krzysztof
Re: [PATCH v6 1/3] dt-bindings: arm: rockchip: Add Radxa CM5 IO Board
Hi Krzysztof,
Quoted 27 lines · Krzysztof Kozlowski
Quoted 26 lines · Krzysztof Kozlowski
Quoted 10 lines · FUKAUMI Naoki
Quoted 9 lines · Krzysztof Kozlowski
Quoted 5 lines · FUKAUMI Naoki
Add device tree binding documentation for the Radxa CM5 IO Board.
Signed-off-by FUKAUMI Naoki <[email protected]>Signed-off-by Joseph Kogut <[email protected]>Wrong DCO chain.
Quoted 7 lines
Quoted 4 lines
Quoted 2 lines
--- Documentation/devicetree/bindings/arm/rockchip.yaml | 7 +++++++NAK, you just stolen ownership of an already posted patch.
Read "Changes in v6" and patches; my patches are not the same as v5. Your reply is totally inappropriate.
Inappropriate is taking authorship of someone's patch, because we all expect to preserve the original authorship. That's not only basic decency but actually a standard.
Additionally, read Joseph's reply that he wants to continue the work:
https://lore.kernel.org/all/CAMWSM7iHtAxewW4JkRqRsifVnccqeFviaCgeOyprKDr92FOurg@mail.gmail.com/
Quoted 8 lines
Quoted 3 lines
You clearly do not understand how to continue with someone's work.
It is still a NAK.
And I still wait for justification why you took authorship of this patch, because to my eye you changed here nothing.
So what did you change HERE that you think you are the author now?
Changes in v6:
(Patch 1/3)
- Fix description; "Radxa CM5" is the correct name (Patch 2/3)
- Fix #include(s)
- Include rk3588s.dtsi
- Move alias for gmac1 from io board dts
- Add Maskrom key
- Add pinctrl-* for led-0
- Add vcc_1v1_nldo_s3 regulator for pmic
- Move gmac1 (except status) from io board dts
- Fix phy-supply for gmac1
- Fix compatible for vdd_cpu_big1_s0 regulator
- Add eeprom on i2c0
- Add vdd_npu_s0 regulator for rknn
- Fix compatible for rgmii_phy1
- Add pinctrl-* and reset-* for rgmii_phy1
- Add domain-supply for pd_npu
- Add rknn_*
- Add saradc
- Fix properties in sdhci
- Move pmic from io board dts
- Fix vcc*-supply for pmic
- Add regulators in pmic
- Add tsadc
- Move vop(_mmu) from io board dts
- Trivial changes (labels, names, etc) (Patch 3/3)
- Fix #include(s)
- Remove #include "rk3588s.dtsi"
- Fix model
- Add fan
- Add Recovery key
- Add pinctrl-* for vcc3v3_wf
- Add vcc_sysin regulator
- Add pinctrl-* for vbus5v0_typec
- Add rfkill-bt and rfkill-wlan for M.2 module
- Add sound for es8316
- Add phy-supply for combphy2_psu
- Fix power-role to "source" for fusb302
- Add rtc for hym8536
- Add audio-codec on i2c8 for es8316
- Add i2s0_8ch for es8316
- Add package_thermal for fan
- Add pinctrl-* for pcie2x1l2
- Add pwm11 for fan
- Fix properties in sdmmmc
- Add phy-supply for u2phy2_host and u2phy3_host
- Remove usb_host0_ohci
- Add pinctrl-* for usbdp_phy0
- Trivial changes (labels, names, etc)
Documentation/devicetree/bindings/arm/rockchip.yaml +7 -7
@@ -880,13 +880,6 @@ properties: - const: radxa,cm3 - const: rockchip,rk3566 - - description: Radxa Compute Module 5 (CM5) - items: - - enum: - - radxa,cm5-io - - const: radxa,cm5 - - const: rockchip,rk3588s - - description: Radxa CM3 Industrial items: - enum:
@@ -894,6 +887,13 @@ properties: - const: radxa,cm3i - const: rockchip,rk3568 + - description: Radxa CM5 + items: + - enum: + - radxa,cm5-io + - const: radxa,cm5 + - const: rockchip,rk3588s + - description: Radxa E20C items: - const: radxa,e20c
arch/arm64/boot/dts/rockchip/rk3588s-radxa-cm5-io.dts +245 -228
669 lines not on this page · raw message
arch/arm64/boot/dts/rockchip/rk3588s-radxa-cm5.dtsi +484 -17
571 lines not on this page · raw message
Best regards,
--
FUKAUMI Naoki
Radxa Computer (Shenzhen) Co., Ltd.
Quoted 3 lines
Best regards,
Krzysztof
_______________________________________________
Linux-rockchip mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-rockchip
Re: [PATCH v6 1/3] dt-bindings: arm: rockchip: Add Radxa CM5 IO Board
Quoted 34 lines · FUKAUMI Naoki
Hi Krzysztof,
Quoted 31 lines · Krzysztof Kozlowski
Quoted 29 lines · Krzysztof Kozlowski
Quoted 10 lines · FUKAUMI Naoki
Quoted 9 lines · Krzysztof Kozlowski
Quoted 5 lines · FUKAUMI Naoki
Add device tree binding documentation for the Radxa CM5 IO Board.
Signed-off-by FUKAUMI Naoki <[email protected]>Signed-off-by Joseph Kogut <[email protected]>Wrong DCO chain.
Quoted 7 lines
Quoted 4 lines
Quoted 2 lines
--- Documentation/devicetree/bindings/arm/rockchip.yaml | 7 +++++++NAK, you just stolen ownership of an already posted patch.
Read "Changes in v6" and patches; my patches are not the same as v5. Your reply is totally inappropriate.
Inappropriate is taking authorship of someone's patch, because we all expect to preserve the original authorship. That's not only basic decency but actually a standard.
Additionally, read Joseph's reply that he wants to continue the work:
https://lore.kernel.org/all/CAMWSM7iHtAxewW4JkRqRsifVnccqeFviaCgeOyprKDr92FOurg@mail.gmail.com/You clearly do not understand how to continue with someone's work.
It is still a NAK.
Quoted 8 lines
Quoted 4 lines
And I still wait for justification why you took authorship of this patch, because to my eye you changed here nothing.
So what did you change HERE that you think you are the author now?
Changes in v6:
(Patch 1/3)
- Fix description; "Radxa CM5" is the correct name
HERE, in this patch. Don't paste me hundreds of unrelated code. Write concise and precise answers/comments.
Best regards,
Krzysztof
Re: [PATCH v6 1/3] dt-bindings: arm: rockchip: Add Radxa CM5 IO Board
Quoted 38 lines · Krzysztof Kozlowski
Quoted 37 lines · FUKAUMI Naoki
Hi Krzysztof,
Quoted 34 lines · Krzysztof Kozlowski
Quoted 23 lines · Krzysztof Kozlowski
Quoted 10 lines · FUKAUMI Naoki
Quoted 9 lines · Krzysztof Kozlowski
Quoted 5 lines · FUKAUMI Naoki
Add device tree binding documentation for the Radxa CM5 IO Board.
Signed-off-by FUKAUMI Naoki <[email protected]>Signed-off-by Joseph Kogut <[email protected]>Wrong DCO chain.
Quoted 7 lines
Quoted 4 lines
Quoted 2 lines
--- Documentation/devicetree/bindings/arm/rockchip.yaml | 7 +++++++NAK, you just stolen ownership of an already posted patch.
Read "Changes in v6" and patches; my patches are not the same as v5. Your reply is totally inappropriate.
Inappropriate is taking authorship of someone's patch, because we all expect to preserve the original authorship. That's not only basic decency but actually a standard.
Quoted 6 lines
Additionally, read Joseph's reply that he wants to continue the work:
https://lore.kernel.org/all/CAMWSM7iHtAxewW4JkRqRsifVnccqeFviaCgeOyprKDr92FOurg@mail.gmail.com/You clearly do not understand how to continue with someone's work.
It is still a NAK.
And I still wait for justification why you took authorship of this patch, because to my eye you changed here nothing.
Quoted 8 lines
Quoted 5 lines
Quoted 1 line
So what did you change HERE that you think you are the author now?
Changes in v6:
(Patch 1/3)
- Fix description; "Radxa CM5" is the correct nameHERE, in this patch. Don't paste me hundreds of unrelated code. Write concise and precise answers/comments.
https://lore.kernel.org/linux-rockchip/[email protected]/
| By the way, at some point I switched from "continuing your work" to | "recreating a new one based on my current work." The results of my | current work(*3) have changed significantly.
Best regards,
--
FUKAUMI Naoki
Radxa Computer (Shenzhen) Co., Ltd.
Quoted 3 lines
Best regards,
Krzysztof
_______________________________________________
Linux-rockchip mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-rockchip
Re: [PATCH v6 1/3] dt-bindings: arm: rockchip: Add Radxa CM5 IO Board
Quoted 45 lines · FUKAUMI Naoki
Quoted 44 lines · Krzysztof Kozlowski
Quoted 42 lines · FUKAUMI Naoki
Hi Krzysztof,
Quoted 27 lines · Krzysztof Kozlowski
Quoted 26 lines · Krzysztof Kozlowski
Quoted 10 lines · FUKAUMI Naoki
Quoted 9 lines · Krzysztof Kozlowski
Quoted 5 lines · FUKAUMI Naoki
Add device tree binding documentation for the Radxa CM5 IO Board.
Signed-off-by FUKAUMI Naoki <[email protected]>Signed-off-by Joseph Kogut <[email protected]>Wrong DCO chain.
Quoted 7 lines
Quoted 4 lines
Quoted 2 lines
--- Documentation/devicetree/bindings/arm/rockchip.yaml | 7 +++++++NAK, you just stolen ownership of an already posted patch.
Read "Changes in v6" and patches; my patches are not the same as v5. Your reply is totally inappropriate.
Inappropriate is taking authorship of someone's patch, because we all expect to preserve the original authorship. That's not only basic decency but actually a standard.
Additionally, read Joseph's reply that he wants to continue the work:
https://lore.kernel.org/all/CAMWSM7iHtAxewW4JkRqRsifVnccqeFviaCgeOyprKDr92FOurg@mail.gmail.com/Quoted 8 lines
Quoted 3 lines
You clearly do not understand how to continue with someone's work.
It is still a NAK.
And I still wait for justification why you took authorship of this patch, because to my eye you changed here nothing.
So what did you change HERE that you think you are the author now?
Changes in v6:
(Patch 1/3)
- Fix description; "Radxa CM5" is the correct name
Quoted 8 lines
Quoted 2 lines
HERE, in this patch. Don't paste me hundreds of unrelated code. Write concise and precise answers/comments.
https://lore.kernel.org/linux-rockchip/[email protected]/
| By the way, at some point I switched from "continuing your work" to | "recreating a new one based on my current work." The results of my | current work(*3) have changed significantly.
So next time I will take your patch, your code, say "I recreated it" and submit under my authorship and for you it is fine?
Please take Joseph's patch instead. Read submitting patches doc to understand which one more tag has to be added when sending somoene else's work.
In the future, I sincerely suggest avoiding re-creating people's work but building on top, because you just duplicate the effort.
Best regards,
Krzysztof
Re: [PATCH v6 1/3] dt-bindings: arm: rockchip: Add Radxa CM5 IO Board
Quoted 49 lines · Krzysztof Kozlowski
Quoted 48 lines · FUKAUMI Naoki
Quoted 46 lines · Krzysztof Kozlowski
Quoted 34 lines · FUKAUMI Naoki
Hi Krzysztof,
Quoted 31 lines · Krzysztof Kozlowski
Quoted 29 lines · Krzysztof Kozlowski
Quoted 10 lines · FUKAUMI Naoki
Quoted 9 lines · Krzysztof Kozlowski
Quoted 5 lines · FUKAUMI Naoki
Add device tree binding documentation for the Radxa CM5 IO Board.
Signed-off-by FUKAUMI Naoki <[email protected]>Signed-off-by Joseph Kogut <[email protected]>Wrong DCO chain.
Quoted 7 lines
Quoted 4 lines
Quoted 2 lines
--- Documentation/devicetree/bindings/arm/rockchip.yaml | 7 +++++++NAK, you just stolen ownership of an already posted patch.
Read "Changes in v6" and patches; my patches are not the same as v5. Your reply is totally inappropriate.
Inappropriate is taking authorship of someone's patch, because we all expect to preserve the original authorship. That's not only basic decency but actually a standard.
Additionally, read Joseph's reply that he wants to continue the work:
https://lore.kernel.org/all/CAMWSM7iHtAxewW4JkRqRsifVnccqeFviaCgeOyprKDr92FOurg@mail.gmail.com/You clearly do not understand how to continue with someone's work.
It is still a NAK.
Quoted 8 lines
Quoted 4 lines
And I still wait for justification why you took authorship of this patch, because to my eye you changed here nothing.
So what did you change HERE that you think you are the author now?
Changes in v6:
(Patch 1/3)
- Fix description; "Radxa CM5" is the correct nameHERE, in this patch. Don't paste me hundreds of unrelated code. Write concise and precise answers/comments.
Quoted 8 lines
Quoted 5 lines
https://lore.kernel.org/linux-rockchip/[email protected]/
| By the way, at some point I switched from "continuing your work" to | "recreating a new one based on my current work." The results of my | current work(*3) have changed significantly.So next time I will take your patch, your code, say "I recreated it" and submit under my authorship and for you it is fine?
Regarding CM5 patches, I'm fine.
Quoted 6 lines
Please take Joseph's patch instead. Read submitting patches doc to understand which one more tag has to be added when sending somoene else's work.
In the future, I sincerely suggest avoiding re-creating people's work but building on top, because you just duplicate the effort.
I understand that you don't understand how I made efforts to build my work on top of Joseph's patches.
Thank you for your attention.
Best regards,
--
FUKAUMI Naoki
Radxa Computer (Shenzhen) Co., Ltd.
Quoted 3 lines
Best regards,
Krzysztof
_______________________________________________
Linux-rockchip mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-rockchip
Re: [PATCH v6 1/3] dt-bindings: arm: rockchip: Add Radxa CM5 IO Board
Quoted 65 lines · FUKAUMI Naoki
Quoted 49 lines · Krzysztof Kozlowski
Quoted 48 lines · FUKAUMI Naoki
Quoted 46 lines · Krzysztof Kozlowski
Quoted 34 lines · FUKAUMI Naoki
Hi Krzysztof,
Quoted 31 lines · Krzysztof Kozlowski
Quoted 29 lines · Krzysztof Kozlowski
Quoted 10 lines · FUKAUMI Naoki
Quoted 9 lines · Krzysztof Kozlowski
Quoted 5 lines · FUKAUMI Naoki
Add device tree binding documentation for the Radxa CM5 IO Board.
Signed-off-by FUKAUMI Naoki <[email protected]>Signed-off-by Joseph Kogut <[email protected]>Wrong DCO chain.
Quoted 7 lines
Quoted 4 lines
Quoted 2 lines
--- Documentation/devicetree/bindings/arm/rockchip.yaml | 7 +++++++NAK, you just stolen ownership of an already posted patch.
Read "Changes in v6" and patches; my patches are not the same as v5. Your reply is totally inappropriate.
Inappropriate is taking authorship of someone's patch, because we all expect to preserve the original authorship. That's not only basic decency but actually a standard.
Additionally, read Joseph's reply that he wants to continue the work:
https://lore.kernel.org/all/CAMWSM7iHtAxewW4JkRqRsifVnccqeFviaCgeOyprKDr92FOurg@mail.gmail.com/You clearly do not understand how to continue with someone's work.
It is still a NAK.
Quoted 8 lines
Quoted 4 lines
And I still wait for justification why you took authorship of this patch, because to my eye you changed here nothing.
So what did you change HERE that you think you are the author now?
Changes in v6:
(Patch 1/3)
- Fix description; "Radxa CM5" is the correct nameHERE, in this patch. Don't paste me hundreds of unrelated code. Write concise and precise answers/comments.
Quoted 8 lines
Quoted 5 lines
https://lore.kernel.org/linux-rockchip/[email protected]/
| By the way, at some point I switched from "continuing your work" to | "recreating a new one based on my current work." The results of my | current work(*3) have changed significantly.So next time I will take your patch, your code, say "I recreated it" and submit under my authorship and for you it is fine?
Regarding CM5 patches, I'm fine.
Quoted 4 lines
Please take Joseph's patch instead. Read submitting patches doc to understand which one more tag has to be added when sending somoene else's work.
Quoted 5 lines
Quoted 2 lines
In the future, I sincerely suggest avoiding re-creating people's work but building on top, because you just duplicate the effort.
I understand that you don't understand how I made efforts to build my work on top of Joseph's patches.
Maybe a solution for this huge mess could be that Naoki submits unmodified patches from Joseph first, using the standard procedure for that, and then the additional patch(es) that improve Joseph's work? All that in the same series.
Heiko Stübner
maintainerRe: [PATCH v6 1/3] dt-bindings: arm: rockchip: Add Radxa CM5 IO Board
Am Freitag, 14. November 2025, 09:32:29 Mitteleuropäische Normalzeit schrieb Dragan Simic:
Quoted 69 lines · FUKAUMI Naoki
Quoted 68 lines · Krzysztof Kozlowski
Quoted 49 lines · FUKAUMI Naoki
Quoted 48 lines · Krzysztof Kozlowski
Quoted 46 lines · FUKAUMI Naoki
Quoted 34 lines
Hi Krzysztof,
Quoted 31 lines · Krzysztof Kozlowski
Quoted 29 lines · Krzysztof Kozlowski
Quoted 10 lines · FUKAUMI Naoki
Quoted 9 lines · Krzysztof Kozlowski
Quoted 5 lines · FUKAUMI Naoki
Add device tree binding documentation for the Radxa CM5 IO Board.
Signed-off-by FUKAUMI Naoki <[email protected]>Signed-off-by Joseph Kogut <[email protected]>Wrong DCO chain.
Quoted 7 lines
Quoted 4 lines
Quoted 2 lines
--- Documentation/devicetree/bindings/arm/rockchip.yaml | 7 +++++++NAK, you just stolen ownership of an already posted patch.
Read "Changes in v6" and patches; my patches are not the same as v5. Your reply is totally inappropriate.
Inappropriate is taking authorship of someone's patch, because we all expect to preserve the original authorship. That's not only basic decency but actually a standard.
Additionally, read Joseph's reply that he wants to continue the work:
https://lore.kernel.org/all/CAMWSM7iHtAxewW4JkRqRsifVnccqeFviaCgeOyprKDr92FOurg@mail.gmail.com/You clearly do not understand how to continue with someone's work.
It is still a NAK.
Quoted 8 lines
Quoted 4 lines
And I still wait for justification why you took authorship of this patch, because to my eye you changed here nothing.
So what did you change HERE that you think you are the author now?
Changes in v6:
(Patch 1/3)
- Fix description; "Radxa CM5" is the correct nameHERE, in this patch. Don't paste me hundreds of unrelated code. Write concise and precise answers/comments.
Quoted 8 lines
Quoted 5 lines
https://lore.kernel.org/linux-rockchip/[email protected]/
| By the way, at some point I switched from "continuing your work" to | "recreating a new one based on my current work." The results of my | current work(*3) have changed significantly.So next time I will take your patch, your code, say "I recreated it" and submit under my authorship and for you it is fine?
Regarding CM5 patches, I'm fine.
Quoted 6 lines
Please take Joseph's patch instead. Read submitting patches doc to understand which one more tag has to be added when sending somoene else's work.
In the future, I sincerely suggest avoiding re-creating people's work but building on top, because you just duplicate the effort.
Quoted 7 lines
Quoted 2 lines
I understand that you don't understand how I made efforts to build my work on top of Joseph's patches.
Maybe a solution for this huge mess could be that Naoki submits unmodified patches from Joseph first, using the standard procedure for that, and then the additional patch(es) that improve Joseph's work? All that in the same series.
There is also Co-developed-by as an option.
Re: [PATCH v6 1/3] dt-bindings: arm: rockchip: Add Radxa CM5 IO Board
Hello Heiko,
Quoted 73 lines · Heiko Stübner
Am Freitag, 14. November 2025, 09:32:29 Mitteleuropäische Normalzeit schrieb Dragan Simic:
Quoted 72 lines · FUKAUMI Naoki
Quoted 70 lines · Krzysztof Kozlowski
Quoted 49 lines · FUKAUMI Naoki
Quoted 48 lines · Krzysztof Kozlowski
Quoted 46 lines · FUKAUMI Naoki
Quoted 34 lines
Hi Krzysztof,
Quoted 31 lines · Krzysztof Kozlowski
Quoted 29 lines · Krzysztof Kozlowski
Quoted 10 lines · FUKAUMI Naoki
Quoted 9 lines · Krzysztof Kozlowski
Quoted 5 lines · FUKAUMI Naoki
Add device tree binding documentation for the Radxa CM5 IO Board.
Signed-off-by FUKAUMI Naoki <[email protected]>Signed-off-by Joseph Kogut <[email protected]>Wrong DCO chain.
Quoted 7 lines
Quoted 4 lines
Quoted 2 lines
--- Documentation/devicetree/bindings/arm/rockchip.yaml | 7 +++++++NAK, you just stolen ownership of an already posted patch.
Read "Changes in v6" and patches; my patches are not the same as v5. Your reply is totally inappropriate.
Inappropriate is taking authorship of someone's patch, because we all expect to preserve the original authorship. That's not only basic decency but actually a standard.
Additionally, read Joseph's reply that he wants to continue the work:
https://lore.kernel.org/all/CAMWSM7iHtAxewW4JkRqRsifVnccqeFviaCgeOyprKDr92FOurg@mail.gmail.com/You clearly do not understand how to continue with someone's work.
It is still a NAK.
Quoted 8 lines
Quoted 4 lines
And I still wait for justification why you took authorship of this patch, because to my eye you changed here nothing.
So what did you change HERE that you think you are the author now?
Changes in v6:
(Patch 1/3)
- Fix description; "Radxa CM5" is the correct nameHERE, in this patch. Don't paste me hundreds of unrelated code. Write concise and precise answers/comments.
Quoted 8 lines
Quoted 5 lines
https://lore.kernel.org/linux-rockchip/[email protected]/
| By the way, at some point I switched from "continuing your work" to | "recreating a new one based on my current work." The results of my | current work(*3) have changed significantly.So next time I will take your patch, your code, say "I recreated it" and submit under my authorship and for you it is fine?
Regarding CM5 patches, I'm fine.
Quoted 6 lines
Please take Joseph's patch instead. Read submitting patches doc to understand which one more tag has to be added when sending somoene else's work.
In the future, I sincerely suggest avoiding re-creating people's work but building on top, because you just duplicate the effort.
I understand that you don't understand how I made efforts to build my work on top of Joseph's patches.
Quoted 6 lines
Quoted 4 lines
Maybe a solution for this huge mess could be that Naoki submits unmodified patches from Joseph first, using the standard procedure for that, and then the additional patch(es) that improve Joseph's work? All that in the same series.
There is also Co-developed-by as an option.
Ah, that's what the above-described option #1 involves, but it also raises some possible concerns, described in one of my responses. [1]
[1] https://lore.kernel.org/linux-rockchip/[email protected]/
Re: [PATCH v6 1/3] dt-bindings: arm: rockchip: Add Radxa CM5 IO Board
Quoted 81 lines · Dragan Simic
Hello Heiko,
Quoted 78 lines · Heiko Stübner
Am Freitag, 14. November 2025, 09:32:29 Mitteleuropäische Normalzeit schrieb Dragan Simic:
Quoted 76 lines · FUKAUMI Naoki
Quoted 65 lines · Krzysztof Kozlowski
Quoted 49 lines · FUKAUMI Naoki
Quoted 48 lines · Krzysztof Kozlowski
Quoted 46 lines · FUKAUMI Naoki
Quoted 34 lines
Hi Krzysztof,
Quoted 31 lines · Krzysztof Kozlowski
Quoted 29 lines · Krzysztof Kozlowski
Quoted 10 lines · FUKAUMI Naoki
Quoted 9 lines · Krzysztof Kozlowski
Quoted 5 lines · FUKAUMI Naoki
Add device tree binding documentation for the Radxa CM5 IO Board.
Link: https://dl.radxa.com/cm5/radxa_cm5_product_brief.pdf
Signed-off-by: FUKAUMI Naoki <[email protected]>
Signed-off-by: Joseph Kogut <[email protected]>Wrong DCO chain.
Quoted 7 lines
Quoted 4 lines
Quoted 2 lines
---
Documentation/devicetree/bindings/arm/rockchip.yaml | 7 +++++++NAK, you just stolen ownership of an already posted patch.
Read "Changes in v6" and patches; my patches are not the same as v5. Your reply is totally inappropriate.
Inappropriate is taking authorship of someone's patch, because we all expect to preserve the original authorship. That's not only basic decency but actually a standard.
Additionally, read Joseph's reply that he wants to continue the work:
https://lore.kernel.org/all/CAMWSM7iHtAxewW4JkRqRsifVnccqeFviaCgeOyprKDr92FOurg@mail.gmail.com/You clearly do not understand how to continue with someone's work.
It is still a NAK.
Quoted 8 lines
Quoted 4 lines
And I still wait for justification why you took authorship of this patch, because to my eye you changed here nothing.
So what did you change HERE that you think you are the author now?
Changes in v6:
(Patch 1/3)
- Fix description; "Radxa CM5" is the correct nameHERE, in this patch. Don't paste me hundreds of unrelated code. Write concise and precise answers/comments.
Quoted 8 lines
Quoted 5 lines
https://lore.kernel.org/linux-rockchip/[email protected]/
| By the way, at some point I switched from "continuing your work" to | "recreating a new one based on my current work." The results of my | current work(*3) have changed significantly.So next time I will take your patch, your code, say "I recreated it" and submit under my authorship and for you it is fine?
Regarding CM5 patches, I'm fine.
Quoted 4 lines
Please take Joseph's patch instead. Read submitting patches doc to understand which one more tag has to be added when sending somoene else's work.
Quoted 5 lines
Quoted 2 lines
In the future, I sincerely suggest avoiding re-creating people's work but building on top, because you just duplicate the effort.
I understand that you don't understand how I made efforts to build my work on top of Joseph's patches.
Maybe a solution for this huge mess could be that Naoki submits unmodified patches from Joseph first, using the standard procedure for that, and then the additional patch(es) that improve Joseph's work? All that in the same series.
Quoted 4 lines
Quoted 1 line
There is also Co-developed-by as an option.
Ah, that's what the above-described option #1 involves, but it also raises some possible concerns, described in one of my responses. [1]
There are no concerns to be raised. Please read DCO. The original author GAVE certified what is necessary, thus any person taking this work already can you that certification. You raised some uncertainty "I'm not sure how fair is it for someone to become responsible" which is just not right here. It is completely fair and completely correct from DCO point of view, because the certification was already provided. Also from certification point, there is no "weaker" form. Either you certify or not.
Best regards,
Krzysztof
Re: [PATCH v6 1/3] dt-bindings: arm: rockchip: Add Radxa CM5 IO Board
Quoted 82 lines · Krzysztof Kozlowski
Quoted 81 lines · Dragan Simic
Hello Heiko,
Quoted 78 lines · Heiko Stübner
Am Freitag, 14. November 2025, 09:32:29 Mitteleuropäische Normalzeit schrieb Dragan Simic:
Quoted 76 lines · FUKAUMI Naoki
Quoted 65 lines · Krzysztof Kozlowski
Quoted 49 lines · FUKAUMI Naoki
Quoted 48 lines · Krzysztof Kozlowski
Quoted 46 lines · FUKAUMI Naoki
Quoted 34 lines
Hi Krzysztof,
Quoted 31 lines · Krzysztof Kozlowski
Quoted 29 lines · Krzysztof Kozlowski
Quoted 10 lines · FUKAUMI Naoki
Quoted 9 lines · Krzysztof Kozlowski
On 05/11/2025 06:13, FUKAUMI Naoki wrote:
Add device tree binding documentation for the Radxa CM5 IO Board.Link: https://dl.radxa.com/cm5/radxa_cm5_product_brief.pdf
Signed-off-by: FUKAUMI Naoki <[email protected]>
Signed-off-by: Joseph Kogut <[email protected]>Wrong DCO chain.
Quoted 7 lines
Quoted 4 lines
---
Documentation/devicetree/bindings/arm/rockchip.yaml | 7 +++++++NAK, you just stolen ownership of an already posted patch.
Read "Changes in v6" and patches; my patches are not the same as v5. Your reply is totally inappropriate.
Inappropriate is taking authorship of someone's patch, because we all expect to preserve the original authorship. That's not only basic decency but actually a standard.
Additionally, read Joseph's reply that he wants to continue the work:
https://lore.kernel.org/all/CAMWSM7iHtAxewW4JkRqRsifVnccqeFviaCgeOyprKDr92FOurg@mail.gmail.com/You clearly do not understand how to continue with someone's work.
It is still a NAK.
Quoted 8 lines
Quoted 4 lines
And I still wait for justification why you took authorship of this patch, because to my eye you changed here nothing.
So what did you change HERE that you think you are the author now?
Changes in v6:
(Patch 1/3)
- Fix description; "Radxa CM5" is the correct nameHERE, in this patch. Don't paste me hundreds of unrelated code. Write concise and precise answers/comments.
Quoted 8 lines
Quoted 5 lines
https://lore.kernel.org/linux-rockchip/[email protected]/
| By the way, at some point I switched from "continuing your work" to | "recreating a new one based on my current work." The results of my | current work(*3) have changed significantly.So next time I will take your patch, your code, say "I recreated it" and submit under my authorship and for you it is fine?
Regarding CM5 patches, I'm fine.
Quoted 4 lines
Please take Joseph's patch instead. Read submitting patches doc to understand which one more tag has to be added when sending somoene else's work.
Quoted 5 lines
Quoted 2 lines
In the future, I sincerely suggest avoiding re-creating people's work but building on top, because you just duplicate the effort.
I understand that you don't understand how I made efforts to build my work on top of Joseph's patches.
Maybe a solution for this huge mess could be that Naoki submits unmodified patches from Joseph first, using the standard procedure for that, and then the additional patch(es) that improve Joseph's work? All that in the same series.
Quoted 8 lines
Quoted 4 lines
Quoted 1 line
There is also Co-developed-by as an option.
Ah, that's what the above-described option #1 involves, but it also raises some possible concerns, described in one of my responses. [1]
There are no concerns to be raised. Please read DCO. The original author GAVE certified what is necessary, thus any person taking this work already can you that certification. You raised some uncertainty "I'm not
Huh, that's barely English... ok, one more try:
There are no concerns to be raised. Please read DCO. The original author GAVE certification what is necessary, thus any person taking this work already can use that certification. You raised some uncertainty "I'm not sure how fair is it for someone to become responsible" which is just not right here. It is completely fair and completely correct from DCO point of view, because the certification was already provided. Also from certification point, there is no "weaker" form. Either you certify or not.
Quoted 4 lines
sure how fair is it for someone to become responsible" which is just not right here. It is completely fair and completely correct from DCO point of view, because the certification was already provided. Also from certification point, there is no "weaker" form. Either you certify or not.
Best regards,
Krzysztof
Re: [PATCH v6 1/3] dt-bindings: arm: rockchip: Add Radxa CM5 IO Board
In reply to Krzysztof KozlowskiQuoted 7 lines · Krzysztof Kozlowski
Quoted 5 lines · Dragan Simic
Quoted 1 line · Heiko Stübner
There is also Co-developed-by as an option.
Ah, that's what the above-described option #1 involves, but it also raises some possible concerns, described in one of my responses. [1]
Quoted 7 lines
There are no concerns to be raised. Please read DCO. The original author GAVE certified what is necessary, thus any person taking this work already can you that certification. You raised some uncertainty "I'm not sure how fair is it for someone to become responsible" which is just not right here. It is completely fair and completely correct from DCO point of view, because the certification was already provided. Also from certification point, there is no "weaker" form. Either you certify or not.
I see, you're following the documentation strictly and rigidly. In that case, I think Naoki now knows what's to be done when submitting these patches again.
Re: [PATCH v6 1/3] dt-bindings: arm: rockchip: Add Radxa CM5 IO Board
In reply to FUKAUMI NaokiQuoted 28 lines · FUKAUMI Naoki
Quoted 13 lines
Quoted 13 lines
Quoted 12 lines
Quoted 9 lines
Quoted 5 lines
And I still wait for justification why you took authorship of this patch, because to my eye you changed here nothing.
So what did you change HERE that you think you are the author now?
Changes in v6:
(Patch 1/3)
- Fix description; "Radxa CM5" is the correct nameHERE, in this patch. Don't paste me hundreds of unrelated code. Write concise and precise answers/comments.
Quoted 8 lines
Quoted 5 lines
https://lore.kernel.org/linux-rockchip/[email protected]/
| By the way, at some point I switched from "continuing your work" to | "recreating a new one based on my current work." The results of my | current work(*3) have changed significantly.So next time I will take your patch, your code, say "I recreated it" and submit under my authorship and for you it is fine?
Regarding CM5 patches, I'm fine.
Quoted 4 lines
Please take Joseph's patch instead. Read submitting patches doc to understand which one more tag has to be added when sending somoene else's work.
Quoted 5 lines
Quoted 2 lines
In the future, I sincerely suggest avoiding re-creating people's work but building on top, because you just duplicate the effort.
I understand that you don't understand how I made efforts to build my work on top of Joseph's patches.
This patch, I speak about this patch.
Not patches.
Best regards,
Krzysztof
PATCH v6 2/3 arm64: dts: rockchip: Add Radxa CM5
In reply to FUKAUMI NaokiThe Radxa CM5 is a high performance embedded SoM based on the Rockchip RK3588S2 SoC.
Specification:
- Quad-core Cortex-A76 and quad-core Cortex-A55 CPU
- Mali-G610 MP4 GPU
- 6TOPS NPU
- Up to 32GB LPDDR4x RAM
- Up to 128GB on-board eMMC
- On-board Gigabit Ethernet PHY
- RK806-1 PMIC
--- .../boot/dts/rockchip/rk3588s-radxa-cm5.dtsi | 602 ++++++++++++++++++ 1 file changed, 602 insertions(+) create mode 100644 arch/arm64/boot/dts/rockchip/rk3588s-radxa-cm5.dtsi
arch/arm64/boot/dts/rockchip/rk3588s-radxa-cm5.dtsi new file +602 -0
@@ -0,0 +1,602 @@ +// SPDX-License-Identifier: (GPL-2.0+ OR MIT) +/* + * Copyright (c) 2025 Radxa Computer (Shenzhen) Co., Ltd. + * Copyright (c) 2025 Joseph Kogut <[email protected]> + */ + +/* + * CM5 schematic + * https://dl.radxa.com/cm5/v2210/radxa_cm5_v2210_schematic.pdf + */ + +/dts-v1/; + +#include <dt-bindings/gpio/gpio.h> +#include <dt-bindings/input/input.h> +#include <dt-bindings/leds/common.h> +#include <dt-bindings/pinctrl/rockchip.h> +#include "rk3588s.dtsi" + +/ { + compatible = "radxa,cm5", "rockchip,rk3588s"; + + aliases { + ethernet0 = &gmac1; + mmc0 = &sdhci; + }; + + keys-0 { + compatible = "adc-keys"; + io-channels = <&saradc 0>; + io-channel-names = "buttons"; + keyup-threshold-microvolt = <1800000>; + poll-interval = <100>; + + button-0 { + label = "Maskrom"; + linux,code = <KEY_SETUP>; + press-threshold-microvolt = <0>; + }; + }; + + leds-0 { + compatible = "gpio-leds"; + + led-0 { + color = <LED_COLOR_ID_BLUE>; + default-state = "on"; + function = LED_FUNCTION_STATUS; + gpios = <&gpio4 RK_PB4 GPIO_ACTIVE_HIGH>; + linux,default-trigger = "heartbeat"; + pinctrl-names = "default"; + pinctrl-0 = <&gpio4_b4>; + }; + }; + + vcc_1v1_nldo_s3: regulator-1v1 { + compatible = "regulator-fixed"; + regulator-name = "vcc_1v1_nldo_s3"; + regulator-always-on; + regulator-boot-on; + regulator-min-microvolt = <1100000>; + regulator-max-microvolt = <1100000>; + vin-supply = <&vcc_sysin>; + }; +}; + +&cpu_b0 { + cpu-supply = <&vdd_cpu_big0_s0>; +}; + +&cpu_b1 { + cpu-supply = <&vdd_cpu_big0_s0>; +}; + +&cpu_b2 { + cpu-supply = <&vdd_cpu_big1_s0>; +}; + +&cpu_b3 { + cpu-supply = <&vdd_cpu_big1_s0>; +}; + +&cpu_l0 { + cpu-supply = <&vdd_cpu_lit_s0>; +}; + +&cpu_l1 { + cpu-supply = <&vdd_cpu_lit_s0>; +}; + +&cpu_l2 { + cpu-supply = <&vdd_cpu_lit_s0>; +}; + +&cpu_l3 { + cpu-supply = <&vdd_cpu_lit_s0>; +}; + +&gmac1 { + clock_in_out = "output"; + phy-handle = <&rgmii_phy1>; + phy-mode = "rgmii-id"; + phy-supply = <&vcc_3v3_s3>; + pinctrl-0 = <&gmac1_miim + &gmac1_tx_bus2 + &gmac1_rx_bus2 + &gmac1_rgmii_clk + &gmac1_rgmii_bus + &gmac1_clkinout>; + pinctrl-names = "default"; +}; + +&gpu { + mali-supply = <&vdd_gpu_s0>; + status = "okay"; +}; + +&i2c0 { + pinctrl-names = "default"; + pinctrl-0 = <&i2c0m2_xfer>; + status = "okay"; + + vdd_cpu_big0_s0: regulator@42 { + compatible = "rockchip,rk8602"; + reg = <0x42>; + fcs,suspend-voltage-selector = <1>; + regulator-name = "vdd_cpu_big0_s0"; + regulator-always-on; + regulator-boot-on; + regulator-min-microvolt = <550000>; + regulator-max-microvolt = <1050000>; + regulator-ramp-delay = <2300>; + vin-supply = <&vcc_sysin>; + + regulator-state-mem { + regulator-off-in-suspend; + }; + }; + + vdd_cpu_big1_s0: regulator@43 { + compatible = "rockchip,rk8603", "rockchip,rk8602"; + reg = <0x43>; + fcs,suspend-voltage-selector = <1>; + regulator-name = "vdd_cpu_big1_s0"; + regulator-always-on; + regulator-boot-on; + regulator-min-microvolt = <550000>; + regulator-max-microvolt = <1050000>; + regulator-ramp-delay = <2300>; + vin-supply = <&vcc_sysin>; + + regulator-state-mem { + regulator-off-in-suspend; + }; + }; + + eeprom@50 { + compatible = "belling,bl24c16a", "atmel,24c16"; + reg = <0x50>; + pagesize = <16>; + read-only; + vcc-supply = <&vcc_3v3_s3>; + }; +}; + +&i2c2 { + status = "okay"; + + vdd_npu_s0: regulator@42 { + compatible = "rockchip,rk8602"; + reg = <0x42>; + fcs,suspend-voltage-selector = <1>; + regulator-name = "vdd_npu_s0"; + regulator-always-on; + regulator-boot-on; + regulator-min-microvolt = <550000>; + regulator-max-microvolt = <950000>; + regulator-ramp-delay = <2300>; + vin-supply = <&vcc_sysin>; + + regulator-state-mem { + regulator-off-in-suspend; + }; + }; +}; + +&mdio1 { + rgmii_phy1: ethernet-phy@1 { + compatible = "ethernet-phy-id001c.c916"; + reg = <1>; + pinctrl-names = "default"; + pinctrl-0 = <&gmac1_rstn>; + reset-assert-us = <20000>; + reset-deassert-us = <100000>; + reset-gpios = <&gpio3 RK_PB2 GPIO_ACTIVE_LOW>; + }; +}; + +&pd_gpu { + domain-supply = <&vdd_gpu_s0>; +}; + +&pd_npu { + domain-supply = <&vdd_npu_s0>; +}; + +&pinctrl { + ethernet { + gmac1_rstn: gmac1-rstn { + rockchip,pins = <3 RK_PB2 RK_FUNC_GPIO &pcfg_pull_none>; + }; + }; + + leds { + gpio4_b4: gpio4-b4 { + rockchip,pins = <4 RK_PB4 RK_FUNC_GPIO &pcfg_pull_none>; + }; + }; +}; + +&rknn_core_0 { + npu-supply = <&vdd_npu_s0>; + sram-supply = <&vdd_npu_s0>; + status = "okay"; +}; + +&rknn_core_1 { + npu-supply = <&vdd_npu_s0>; + sram-supply = <&vdd_npu_s0>; + status = "okay"; +}; + +&rknn_core_2 { + npu-supply = <&vdd_npu_s0>; + sram-supply = <&vdd_npu_s0>; + status = "okay"; +}; + +&rknn_mmu_0 { + status = "okay"; +}; + +&rknn_mmu_1 { + status = "okay"; +}; + +&rknn_mmu_2 { + status = "okay"; +}; + +&saradc { + vref-supply = <&vcca_1v8_s0>; + status = "okay"; +}; + +&sdhci { + bus-width = <8>; + cap-mmc-highspeed; + mmc-hs400-1_8v; + mmc-hs400-enhanced-strobe; + no-sd; + no-sdio; + non-removable; + vmmc-supply = <&vcc_3v3_s3>; + vqmmc-supply = <&vcc_1v8_s3>; + status = "okay"; +}; + +&spi2 { + assigned-clocks = <&cru CLK_SPI2>; + assigned-clock-rates = <200000000>; + num-cs = <1>; + pinctrl-names = "default"; + pinctrl-0 = <&spi2m2_cs0 &spi2m2_pins>; + status = "okay"; + + pmic@0 { + compatible = "rockchip,rk806"; + reg = <0>; + gpio-controller; + #gpio-cells = <2>; + interrupt-parent = <&gpio0>; + interrupts = <7 IRQ_TYPE_LEVEL_LOW>; + pinctrl-names = "default"; + pinctrl-0 = <&pmic_pins>, <&rk806_dvs1_null>, + <&rk806_dvs2_null>, <&rk806_dvs3_null>; + spi-max-frequency = <1000000>; + system-power-controller; + + vcc1-supply = <&vcc_sysin>; + vcc2-supply = <&vcc_sysin>; + vcc3-supply = <&vcc_sysin>; + vcc4-supply = <&vcc_sysin>; + vcc5-supply = <&vcc_sysin>; + vcc6-supply = <&vcc_sysin>; + vcc7-supply = <&vcc_sysin>; + vcc8-supply = <&vcc_sysin>; + vcc9-supply = <&vcc_sysin>; + vcc10-supply = <&vcc_sysin>; + vcc11-supply = <&vcc_2v0_pldo_s3>; + vcc12-supply = <&vcc_sysin>; + vcc13-supply = <&vcc_1v1_nldo_s3>; + vcc14-supply = <&vcc_1v1_nldo_s3>; + vcca-supply = <&vcc_sysin>; + + rk806_dvs1_null: dvs1-null-pins { + pins = "gpio_pwrctrl1"; + function = "pin_fun0"; + }; + + rk806_dvs2_null: dvs2-null-pins { + pins = "gpio_pwrctrl2"; + function = "pin_fun0"; + }; + + rk806_dvs3_null: dvs3-null-pins { + pins = "gpio_pwrctrl3"; + function = "pin_fun0"; + }; + + regulators { + vdd_gpu_s0: dcdc-reg1 { + regulator-name = "vdd_gpu_s0"; + regulator-boot-on; + regulator-min-microvolt = <550000>; + regulator-max-microvolt = <950000>; + regulator-ramp-delay = <12500>; + regulator-enable-ramp-delay = <400>; + + regulator-state-mem { + regulator-off-in-suspend; + }; + }; + + vdd_cpu_lit_s0: dcdc-reg2 { + regulator-name = "vdd_cpu_lit_s0"; + regulator-always-on; + regulator-boot-on; + regulator-min-microvolt = <550000>; + regulator-max-microvolt = <950000>; + regulator-ramp-delay = <12500>; + + regulator-state-mem { + regulator-off-in-suspend; + }; + }; + + vdd_logic_s0: dcdc-reg3 { + regulator-name = "vdd_logic_s0"; + regulator-always-on; + regulator-boot-on; + regulator-min-microvolt = <675000>; + regulator-max-microvolt = <800000>; + regulator-ramp-delay = <12500>; + + regulator-state-mem { + regulator-on-in-suspend; + regulator-suspend-microvolt = <750000>; + }; + }; + + vdd_vdenc_s0: dcdc-reg4 { + regulator-name = "vdd_vdenc_s0"; + regulator-always-on; + regulator-boot-on; + regulator-min-microvolt = <550000>; + regulator-max-microvolt = <950000>; + regulator-ramp-delay = <12500>; + + regulator-state-mem { + regulator-off-in-suspend; + }; + }; + + vdd_ddr_s0: dcdc-reg5 { + regulator-name = "vdd_ddr_s0"; + regulator-always-on; + regulator-boot-on; + regulator-min-microvolt = <675000>; + regulator-max-microvolt = <900000>; + regulator-ramp-delay = <12500>; + + regulator-state-mem { + regulator-off-in-suspend; + regulator-suspend-microvolt = <850000>; + }; + }; + + vdd2_ddr_s3: dcdc-reg6 { + regulator-name = "vdd2_ddr_s3"; + regulator-always-on; + regulator-boot-on; + + regulator-state-mem { + regulator-on-in-suspend; + }; + }; + + vcc_2v0_pldo_s3: dcdc-reg7 { + regulator-name = "vcc_2v0_pldo_s3"; + regulator-always-on; + regulator-boot-on; + regulator-min-microvolt = <2000000>; + regulator-max-microvolt = <2000000>; + + regulator-state-mem { + regulator-on-in-suspend; + regulator-suspend-microvolt = <2000000>; + }; + }; + + vcc_3v3_s0: vcc_3v3_s3: dcdc-reg8 { + regulator-name = "vcc_3v3_s3"; + regulator-always-on; + regulator-boot-on; + regulator-min-microvolt = <3300000>; + regulator-max-microvolt = <3300000>; + + regulator-state-mem { + regulator-on-in-suspend; + regulator-suspend-microvolt = <3300000>; + }; + }; + + vddq_ddr_s0: dcdc-reg9 { + regulator-name = "vddq_ddr_s0"; + regulator-always-on; + regulator-boot-on; + + regulator-state-mem { + regulator-off-in-suspend; + }; + }; + + vcc_1v8_s3: dcdc-reg10 { + regulator-name = "vcc_1v8_s3"; + regulator-always-on; + regulator-boot-on; + regulator-min-microvolt = <1800000>; + regulator-max-microvolt = <1800000>; + + regulator-state-mem { + regulator-on-in-suspend; + regulator-suspend-microvolt = <1800000>; + }; + }; + + vcc_1v8_s0: pldo-reg1 { + regulator-name = "vcc_1v8_s0"; + regulator-always-on; + regulator-boot-on; + regulator-min-microvolt = <1800000>; + regulator-max-microvolt = <1800000>; + + regulator-state-mem { + regulator-on-in-suspend; + regulator-suspend-microvolt = <1800000>; + }; + }; + + vcca_1v8_s0: pldo-reg2 { + regulator-name = "vcca_1v8_s0"; + regulator-always-on; + regulator-boot-on; + regulator-min-microvolt = <1800000>; + regulator-max-microvolt = <1800000>; + + regulator-state-mem { + regulator-on-in-suspend; + regulator-suspend-microvolt = <1800000>; + }; + }; + + vdda_1v2_s0: pldo-reg3 { + regulator-name = "vdda_1v2_s0"; + regulator-always-on; + regulator-boot-on; + regulator-min-microvolt = <1200000>; + regulator-max-microvolt = <1200000>; + + regulator-state-mem { + regulator-off-in-suspend; + }; + }; + + vcca_3v3_s0: pldo-reg4 { + regulator-name = "vcca_3v3_s0"; + regulator-always-on; + regulator-boot-on; + regulator-min-microvolt = <3300000>; + regulator-max-microvolt = <3300000>; + + regulator-state-mem { + regulator-on-in-suspend; + regulator-suspend-microvolt = <3300000>; + }; + }; + + vccio_sd_s0: pldo-reg5 { + regulator-name = "vccio_sd_s0"; + regulator-always-on; + regulator-boot-on; + regulator-min-microvolt = <1800000>; + regulator-max-microvolt = <3300000>; + + regulator-state-mem { + regulator-off-in-suspend; + }; + }; + + pldo-reg6 { + regulator-name = "pldo_reg6"; + regulator-always-on; + regulator-boot-on; + regulator-min-microvolt = <1800000>; + regulator-max-microvolt = <1800000>; + + regulator-state-mem { + regulator-on-in-suspend; + regulator-suspend-microvolt = <1800000>; + }; + }; + + vdd_0v75_s3: nldo-reg1 { + regulator-name = "vdd_0v75_s3"; + regulator-always-on; + regulator-boot-on; + regulator-min-microvolt = <750000>; + regulator-max-microvolt = <750000>; + + regulator-state-mem { + regulator-on-in-suspend; + regulator-suspend-microvolt = <750000>; + }; + }; + + vdda_ddr_pll_s0: nldo-reg2 { + regulator-name = "vdda_ddr_pll_s0"; + regulator-always-on; + regulator-boot-on; + regulator-min-microvolt = <850000>; + regulator-max-microvolt = <850000>; + + regulator-state-mem { + regulator-on-in-suspend; + regulator-suspend-microvolt = <850000>; + }; + }; + + vdda_0v75_s0: nldo-reg3 { + regulator-name = "vdda_0v75_s0"; + regulator-always-on; + regulator-boot-on; + regulator-min-microvolt = <837500>; + regulator-max-microvolt = <837500>; + + regulator-state-mem { + regulator-on-in-suspend; + regulator-suspend-microvolt = <750000>; + }; + }; + + vdda_0v85_s0: nldo-reg4 { + regulator-name = "vdda_0v85_s0"; + regulator-always-on; + regulator-boot-on; + regulator-min-microvolt = <850000>; + regulator-max-microvolt = <850000>; + + regulator-state-mem { + regulator-off-in-suspend; + }; + }; + + hdmi_vdda0v85_s0: nldo-reg5 { + regulator-name = "hdmi_vdda0v85_s0"; + regulator-always-on; + regulator-boot-on; + regulator-min-microvolt = <837500>; + regulator-max-microvolt = <837500>; + + regulator-state-mem { + regulator-off-in-suspend; + }; + }; + }; + }; +}; + +&tsadc { + rockchip,hw-tshut-mode = <1>; /* tshut mode 0:CRU 1:GPIO */ + rockchip,hw-tshut-polarity = <0>; /* tshut polarity 0:LOW 1:HIGH */ + status = "okay"; +}; + +&vop { + status = "okay"; +}; + +&vop_mmu { + status = "okay"; +};
Signature · 7 lines
2.43.0 _______________________________________________ Linux-rockchip mailing list [email protected] http://lists.infradead.org/mailman/listinfo/linux-rockchip
Re: [PATCH v6 2/3] arm64: dts: rockchip: Add Radxa CM5
Quoted 12 lines · FUKAUMI Naoki
The Radxa CM5 is a high performance embedded SoM based on the Rockchip RK3588S2 SoC.
Specification:
- Quad-core Cortex-A76 and quad-core Cortex-A55 CPU
- Mali-G610 MP4 GPU
- 6TOPS NPU
- Up to 32GB LPDDR4x RAM
- Up to 128GB on-board eMMC
- On-board Gigabit Ethernet PHY
- RK806-1 PMIC
Quoted 3 lines
Signed-off-by FUKAUMI Naoki <[email protected]>Signed-off-by Joseph Kogut <[email protected]>
NAK, wrong DCO chain and not attributed true authorship.
Stop taking other people's work. This was already posted.
Best regards,
Krzysztof
PATCH v6 3/3 arm64: dts: rockchip: Add Radxa CM5 IO Board
In reply to FUKAUMI NaokiThe Radxa CM5 IO Board is an application board for the Radxa CM5.
Specification:
- 1x HDMI TX
- 2x MIPI DSI
- 2x MIPI CSI
- 1x USB 3.0 Type-A port
- 1x USB 3.0 Type-C port (supports DisplayPort Alt mode)
- 2x USB 2.0 Type-A ports
- 1x Gigabit Ethernet (supports PoE with add-on PoE HAT)
- 1x microSD card slot
- 1x Fan header
- 1x M.2 E Key slot
- 1x Headphone jack with microphone input
- 40-pin GPIO header
- RTC and battery holder
- 12V 5525 DC jack
--- arch/arm64/boot/dts/rockchip/Makefile | 1 + .../dts/rockchip/rk3588s-radxa-cm5-io.dts | 503 ++++++++++++++++++ 2 files changed, 504 insertions(+) create mode 100644 arch/arm64/boot/dts/rockchip/rk3588s-radxa-cm5-io.dts
arch/arm64/boot/dts/rockchip/Makefile +1 -0
@@ -205,6 +205,7 @@ dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3588s-nanopi-r6c.dtb dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3588s-odroid-m2.dtb dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3588s-orangepi-5.dtb dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3588s-orangepi-5b.dtb +dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3588s-radxa-cm5-io.dtb dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3588s-roc-pc.dtb dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3588s-rock-5a.dtb dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3588s-rock-5c.dtb
arch/arm64/boot/dts/rockchip/rk3588s-radxa-cm5-io.dts new file +503 -0
503 lines not on this page · raw message
Signature · 7 lines
2.43.0 _______________________________________________ Linux-rockchip mailing list [email protected] http://lists.infradead.org/mailman/listinfo/linux-rockchip
Re: [PATCH v6 3/3] arm64: dts: rockchip: Add Radxa CM5 IO Board
Quoted 18 lines · FUKAUMI Naoki
The Radxa CM5 IO Board is an application board for the Radxa CM5.
Specification:
- 1x HDMI TX
- 2x MIPI DSI
- 2x MIPI CSI
- 1x USB 3.0 Type-A port
- 1x USB 3.0 Type-C port (supports DisplayPort Alt mode)
- 2x USB 2.0 Type-A ports
- 1x Gigabit Ethernet (supports PoE with add-on PoE HAT)
- 1x microSD card slot
- 1x Fan header
- 1x M.2 E Key slot
- 1x Headphone jack with microphone input
- 40-pin GPIO header
- RTC and battery holder
- 12V 5525 DC jack
Quoted 3 lines
Wrong here as well - incorrect author. You cannot just take other people's work like that!
Best regards,
Krzysztof
Re: [PATCH v6 3/3] arm64: dts: rockchip: Add Radxa CM5 IO Board
In reply to FUKAUMI NaokiQuoted 6 lines · FUKAUMI Naoki
The Radxa CM5 IO Board is an application board for the Radxa CM5.
Specification:
- 1x microSD card slot
[ snip ]
Quoted 5 lines
arch/arm64/boot/dts/rockchip/rk3588s-radxa-cm5-io.dts new file +5
-0+ +&sdmmc { + bus-width = <4>; + cap-mmc-highspeed; + cap-sd-highspeed;
arch/arm64/boot/dts/rockchip/rk3588s-radxa-cm5-io.dts line 412
Quoted 10 lines
arch/arm64/boot/dts/rockchip/rk3588s-radxa-cm5-io.dts new file +10
-0+ cd-gpios = <&gpio0 RK_PA4 GPIO_ACTIVE_LOW>; + disable-wp; + no-sdio; + pinctrl-names = "default"; + pinctrl-0 = <&sdmmc_bus4 &sdmmc_clk &sdmmc_cmd>; + sd-uhs-sdr104; + vmmc-supply = <&vcc_3v3_s3>; + vqmmc-supply = <&vccio_sd_s0>; + status = "okay"; +};
When used as a TF slot, shouldn't there be a "no-mmc" also? That's how the Rock 5A, 5B, and 5C were defined.
Jimmy
Re: [PATCH v6 3/3] arm64: dts: rockchip: Add Radxa CM5 IO Board
Hi Jimmy,
Quoted 19 lines · Jimmy Hon
Quoted 6 lines · FUKAUMI Naoki
The Radxa CM5 IO Board is an application board for the Radxa CM5.
Specification:
- 1x microSD card slot
[ snip ]
Quoted 9 lines
arch/arm64/boot/dts/rockchip/rk3588s-radxa-cm5-io.dts new file +9
-0+ +&sdmmc { + bus-width = <4>; + cap-mmc-highspeed; + cap-sd-highspeed; + cd-gpios = <&gpio0 RK_PA4 GPIO_ACTIVE_LOW>; + disable-wp; + no-sdio; + pinctrl-names = "default";
Quoted 8 lines
arch/arm64/boot/dts/rockchip/rk3588s-radxa-cm5-io.dts line 412
Quoted 6 lines
arch/arm64/boot/dts/rockchip/rk3588s-radxa-cm5-io.dts new file +6
-0+ pinctrl-0 = <&sdmmc_bus4 &sdmmc_clk &sdmmc_cmd>; + sd-uhs-sdr104; + vmmc-supply = <&vcc_3v3_s3>; + vqmmc-supply = <&vccio_sd_s0>; + status = "okay"; +};When used as a TF slot, shouldn't there be a "no-mmc" also?
We have "eMMC to uSD."
https://radxa.com/products/accessories/emmc-to-usd
[ 202.176757] mmc_host mmc1: Bus speed (slot 0) = 49500000Hz (slot req 52000000Hz, actual 49500000HZ div = 0) [ 202.178477] mmc1: new high speed MMC card at address 0001 [ 202.179534] mmcblk1: mmc1:0001 SLD64G 57.6 GiB [ 202.207336] mmcblk1boot0: mmc1:0001 SLD64G 4.00 MiB [ 202.210374] mmcblk1boot1: mmc1:0001 SLD64G 4.00 MiB [ 202.212967] mmcblk1rpmb: mmc1:0001 SLD64G 4.00 MiB, chardev (511:1)
(I'm not sure why it says "Not work with the SD slot on the board." I will check.)
Quoted 1 line
That's how the Rock 5A, 5B, and 5C were defined.
I have submitted a patch without "no-mmc" before. I intend to send one again when I have the chance.
Best regards,
--
FUKAUMI Naoki
Radxa Computer (Shenzhen) Co., Ltd.
Quoted 2 lines
Jimmy
Re: [PATCH v6 3/3] arm64: dts: rockchip: Add Radxa CM5 IO Board
Quoted 34 lines · FUKAUMI Naoki
Hi Jimmy,
Quoted 19 lines · Jimmy Hon
Quoted 6 lines · FUKAUMI Naoki
The Radxa CM5 IO Board is an application board for the Radxa CM5.
Specification:
- 1x microSD card slot
[ snip ]
Quoted 9 lines
+
+&sdmmc {
+ bus-width = <4>;
+ cap-mmc-highspeed;
+ cap-sd-highspeed;
+ cd-gpios = <&gpio0RK_PA4GPIO_ACTIVE_LOW>; + disable-wp;
+ no-sdio;
+ pinctrl-names = "default";Quoted 8 lines
Quoted 6 lines
+ pinctrl-0 = <
&sdmmc_bus4&sdmmc_clk&sdmmc_cmd>; + sd-uhs-sdr104;
+ vmmc-supply = <&vcc_3v3_s3>;
+ vqmmc-supply = <&vccio_sd_s0>;
+ status = "okay";
+};When used as a TF slot, shouldn't there be a "no-mmc" also?
We have "eMMC to uSD."
https://radxa.com/products/accessories/emmc-to-usd
Quoted 8 lines
[ 202.176757]
mmc_hostmmc1: Bus speed (slot 0) = 49500000Hz (slot req 52000000Hz, actual 49500000HZ div = 0) [ 202.178477] mmc1: new high speed MMC card at address 0001
[ 202.179534] mmcblk1: mmc1:0001 SLD64G 57.6 GiB
[ 202.207336] mmcblk1boot0: mmc1:0001 SLD64G 4.00 MiB
[ 202.210374] mmcblk1boot1: mmc1:0001 SLD64G 4.00 MiB
[ 202.212967] mmcblk1rpmb: mmc1:0001 SLD64G 4.00 MiB, chardev (511:1)(I'm not sure why it says "Not work with the SD slot on the board." I will check.)
There is no hardware limitation. "eMMC to uSD" should work with microSD card slot on the board.
That notice means "dts need to be changed".
Best regards,
--
FUKAUMI Naoki
Radxa Computer (Shenzhen) Co., Ltd.
Quoted 14 lines
Quoted 1 line
That's how the Rock 5A, 5B, and 5C were defined.
I have submitted a patch without "no-mmc" before. I intend to send one again when I have the chance.
Best regards,
Signature · 2 lines
FUKAUMI Naoki Radxa Computer (Shenzhen) Co., Ltd.Quoted 2 lines
Jimmy
Re: [PATCH v6 3/3] arm64: dts: rockchip: Add Radxa CM5 IO Board
Hello Naoki,
Quoted 41 lines · FUKAUMI Naoki
Quoted 40 lines · FUKAUMI Naoki
Quoted 19 lines · Jimmy Hon
Quoted 6 lines · FUKAUMI Naoki
The Radxa CM5 IO Board is an application board for the Radxa CM5.
Specification:
- 1x microSD card slot
[ snip ]
Quoted 9 lines
+
+&sdmmc {
+ bus-width = <4>;
+ cap-mmc-highspeed;
+ cap-sd-highspeed;
+ cd-gpios = <&gpio0RK_PA4GPIO_ACTIVE_LOW>; + disable-wp;
+ no-sdio;
+ pinctrl-names = "default";Quoted 8 lines
Quoted 6 lines
+ pinctrl-0 = <
&sdmmc_bus4&sdmmc_clk&sdmmc_cmd>; + sd-uhs-sdr104;
+ vmmc-supply = <&vcc_3v3_s3>;
+ vqmmc-supply = <&vccio_sd_s0>;
+ status = "okay";
+};When used as a TF slot, shouldn't there be a "no-mmc" also?
We have "eMMC to uSD."
https://radxa.com/products/accessories/emmc-to-usd[ 202.176757]
mmc_hostmmc1: Bus speed (slot 0) = 49500000Hz (slot req 52000000Hz, actual 49500000HZ div = 0)
[ 202.178477] mmc1: new high speed MMC card at address 0001 [ 202.179534] mmcblk1: mmc1:0001 SLD64G 57.6 GiB
[ 202.207336] mmcblk1boot0: mmc1:0001 SLD64G 4.00 MiB
[ 202.210374] mmcblk1boot1: mmc1:0001 SLD64G 4.00 MiB
[ 202.212967] mmcblk1rpmb: mmc1:0001 SLD64G 4.00 MiB, chardev (511:1)
Quoted 7 lines
Quoted 2 lines
(I'm not sure why it says "Not work with the SD slot on the board." I will check.)
There is no hardware limitation. "eMMC to uSD" should work with microSD card slot on the board.
That notice means "dts need to be changed".
True, it can work when the microSD slot is put into the hybrid MMC/microSD mode, which I described in my previous response, but that's pretty much a hardware hack similar to accessing JTAG through the microSD slot on Rockchip boards, or to reconfiguring the USB 3.0 port to work as a native SATA port on the Pine64 Quartz64 SBC.
Re: [PATCH v6 3/3] arm64: dts: rockchip: Add Radxa CM5 IO Board
In reply to FUKAUMI NaokiHello Naoki,
Quoted 40 lines · FUKAUMI Naoki
Quoted 19 lines · Jimmy Hon
Quoted 6 lines · FUKAUMI Naoki
The Radxa CM5 IO Board is an application board for the Radxa CM5.
Specification:
- 1x microSD card slot
[ snip ]
Quoted 9 lines
arch/arm64/boot/dts/rockchip/rk3588s-radxa-cm5-io.dts new file +9
-0+ +&sdmmc { + bus-width = <4>; + cap-mmc-highspeed; + cap-sd-highspeed; + cd-gpios = <&gpio0 RK_PA4 GPIO_ACTIVE_LOW>; + disable-wp; + no-sdio; + pinctrl-names = "default";Quoted 8 lines
arch/arm64/boot/dts/rockchip/rk3588s-radxa-cm5-io.dts line 412
Quoted 6 lines
arch/arm64/boot/dts/rockchip/rk3588s-radxa-cm5-io.dts new file +6
-0+ pinctrl-0 = <&sdmmc_bus4 &sdmmc_clk &sdmmc_cmd>; + sd-uhs-sdr104; + vmmc-supply = <&vcc_3v3_s3>; + vqmmc-supply = <&vccio_sd_s0>; + status = "okay"; +};When used as a TF slot, shouldn't there be a "no-mmc" also?
We have "eMMC to uSD."
https://radxa.com/products/accessories/emmc-to-usd[ 202.176757] mmc_host mmc1: Bus speed (slot 0) = 49500000Hz (slot req 52000000Hz, actual 49500000HZ div = 0) [ 202.178477] mmc1: new high speed MMC card at address 0001 [ 202.179534] mmcblk1: mmc1:0001 SLD64G 57.6 GiB [ 202.207336] mmcblk1boot0: mmc1:0001 SLD64G 4.00 MiB [ 202.210374] mmcblk1boot1: mmc1:0001 SLD64G 4.00 MiB [ 202.212967] mmcblk1rpmb: mmc1:0001 SLD64G 4.00 MiB, chardev (511:1)
Quoted 2 lines
(I'm not sure why it says "Not work with the SD slot on the board." I will check.)
Thanks for bringing this up, I've always wondered how are such simple eMMC-to-microSD adapters supposed to work, so this was a good opportunity to research that a bit further.
In a few words, they're not supposed to work in true microSD card slots, and they seem to rely on USB card readers that support multiple card interface standards, but not more than a single card at once, by wiring their single interface lines in parallel to the different types of card slots that they provide.
To explain it a bit further, an eMMC chip supports different data bus widths and a backward-compatible MMC card mode, but they have very little knowledge about the SD specification, despite being somewhat similar; the exception is the simplified eMMC boot mode. This is explained further in the JEDEC JESD84-B51 standard, which is available freely from the JEDEC website after registration.
This is also confirmed by the kernel messages quoted above, which show that the eMMC chip is detected as an MMC card this way.
With all that in mind, we should specify "no-mmc" here, because we're describing a microSD slot, instead of describing some hybrid MMC/microSD slot. That also explains why the adapter sold by Radxa is described as not to be used with microSD card slots on SBCs. I'd also like to hear is this adapter/eMMC chip combo recognized by the kernel when "no-mmc" is specified; it should fail.
Actually, not specifying "no-mmc" here may result in some unforeseen issues with some (or perhaps many?) microSD cards, because the MMC drivers will treat them as MMC-capable devices and try to initialize them as such, which may cause all kinds of issues. In fact, I'm not really sure that the MMC drivers are actually implemented in a way that avoids all possible issues with the storage controllers that are capable of both SD and MMC modes when neither of "no-sd" and "no-mmc" is specified in their DT nodes.
Furthermore, it seems that specifying "cap-mmc-highspeed" together with "no-emmc" is actually redundant, which would make sense, but further research of the MMC drivers is needed. I've added that to my ever-growing TODO list. :)
Quoted 4 lines
Quoted 1 line
That's how the Rock 5A, 5B, and 5C were defined.
I have submitted a patch without "no-mmc" before. I intend to send one again when I have the chance.
Re: [PATCH v6 3/3] arm64: dts: rockchip: Add Radxa CM5 IO Board
Hi Dragan,
Quoted 73 lines · Dragan Simic
Hello Naoki,
Quoted 40 lines · FUKAUMI Naoki
Quoted 19 lines · Jimmy Hon
Quoted 6 lines · FUKAUMI Naoki
The Radxa CM5 IO Board is an application board for the Radxa CM5.
Specification:
- 1x microSD card slot
[ snip ]
Quoted 9 lines
arch/arm64/boot/dts/rockchip/rk3588s-radxa-cm5-io.dts new file +9
-0+ +&sdmmc { + bus-width = <4>; + cap-mmc-highspeed; + cap-sd-highspeed; + cd-gpios = <&gpio0 RK_PA4 GPIO_ACTIVE_LOW>; + disable-wp; + no-sdio; + pinctrl-names = "default";Quoted 8 lines
arch/arm64/boot/dts/rockchip/rk3588s-radxa-cm5-io.dts line 412
Quoted 6 lines
arch/arm64/boot/dts/rockchip/rk3588s-radxa-cm5-io.dts new file +6
-0+ pinctrl-0 = <&sdmmc_bus4 &sdmmc_clk &sdmmc_cmd>; + sd-uhs-sdr104; + vmmc-supply = <&vcc_3v3_s3>; + vqmmc-supply = <&vccio_sd_s0>; + status = "okay"; +};When used as a TF slot, shouldn't there be a "no-mmc" also?
We have "eMMC to uSD."
https://radxa.com/products/accessories/emmc-to-usd[ 202.176757] mmc_host mmc1: Bus speed (slot 0) = 49500000Hz (slot req 52000000Hz, actual 49500000HZ div = 0) [ 202.178477] mmc1: new high speed MMC card at address 0001 [ 202.179534] mmcblk1: mmc1:0001 SLD64G 57.6 GiB [ 202.207336] mmcblk1boot0: mmc1:0001 SLD64G 4.00 MiB [ 202.210374] mmcblk1boot1: mmc1:0001 SLD64G 4.00 MiB [ 202.212967] mmcblk1rpmb: mmc1:0001 SLD64G 4.00 MiB, chardev (511:1)Quoted 2 lines
(I'm not sure why it says "Not work with the SD slot on the board." I will check.)
Thanks for bringing this up, I've always wondered how are such simple eMMC-to-microSD adapters supposed to work, so this was a good opportunity to research that a bit further.
In a few words, they're not supposed to work in true microSD card slots, and they seem to rely on USB card readers that support multiple card interface standards, but not more than a single card at once, by wiring their single interface lines in parallel to the different types of card slots that they provide.
To explain it a bit further, an eMMC chip supports different data bus widths and a backward-compatible MMC card mode, but they have very little knowledge about the SD specification, despite being somewhat similar; the exception is the simplified eMMC boot mode. This is explained further in the JEDEC JESD84-B51 standard, which is available freely from the JEDEC website after registration.
This is also confirmed by the kernel messages quoted above, which show that the eMMC chip is detected as an MMC card this way.
With all that in mind, we should specify "no-mmc" here, because we're describing a microSD slot, instead of describing some hybrid MMC/microSD slot. That also explains why the adapter sold by Radxa is described as not to be used with microSD card slots on SBCs. I'd also like to hear is this adapter/eMMC chip combo recognized by the kernel when "no-mmc" is specified; it should fail.
Quoted 8 lines
Actually, not specifying "no-mmc" here may result in some unforeseen issues with some (or perhaps many?) microSD cards, because the MMC drivers will treat them as MMC-capable devices and try to initialize them as such, which may cause all kinds of issues. In fact, I'm not really sure that the MMC drivers are actually implemented in a way that avoids all possible issues with the storage controllers that are capable of both SD and MMC modes when neither of "no-sd" and "no-mmc" is specified in their DT nodes.
I have no objection to specifying no-mmc (and removing cap-mmc-highspeed). We have a USB eMMC/UFS Module Reader, which is much faster than an eMMC to uSD reader :)
Quoted 4 lines
Furthermore, it seems that specifying "cap-mmc-highspeed" together with "no-emmc" is actually redundant, which would make sense, but further research of the MMC drivers is needed. I've added that to my ever-growing TODO list. :)
Good luck with your ever-growing TODO list!
Best regards,
--
FUKAUMI Naoki
Radxa Computer (Shenzhen) Co., Ltd.
Quoted 6 lines
Quoted 4 lines
Quoted 1 line
That's how the Rock 5A, 5B, and 5C were defined.
I have submitted a patch without "no-mmc" before. I intend to send one again when I have the chance.
Re: [PATCH v6 3/3] arm64: dts: rockchip: Add Radxa CM5 IO Board
In reply to Dragan SimicOn Wed, Nov 5, 2025 at 9:31 PM Dragan Simic <[email protected]> wrote:
[ snip ]
Quoted 8 lines
With all that in mind, we should specify "no-mmc" here, because we're describing a microSD slot, instead of describing some hybrid MMC/microSD slot. That also explains why the adapter sold by Radxa is described as not to be used with microSD card slots on SBCs. I'd also like to hear is this adapter/eMMC chip combo recognized by the kernel when "no-mmc" is specified; it should fail.
Quoted 8 lines
Actually, not specifying "no-mmc" here may result in some unforeseen issues with some (or perhaps many?) microSD cards, because the MMC drivers will treat them as MMC-capable devices and try to initialize them as such, which may cause all kinds of issues. In fact, I'm not really sure that the MMC drivers are actually implemented in a way that avoids all possible issues with the storage controllers that are capable of both SD and MMC modes when neither of "no-sd" and "no-mmc" is specified in their DT nodes.
Hybrid MMC and SD slots are pretty normal on USB card readers. So it's normal for the host controller to figure out what kind of card is in the slot.
https://uditagarwal.in/understanding-sd-sdio-and-mmc-interface/
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=6ae3e537eab9f560b516b001eb89f0cd568bdced
was the commit that introduced the device tree properties. By the wording of the commit message, these device tree properties are used to indicate to the driver if the host controller hardware is capable of MMC initialization or SD initialization.
Since the host controller in the RK3588 is capable of all the modes, these properties do not need to be specified.
Since Radxa has the eMMC to uSD adapter, it makes sense Radxa would want to configure their microSD card slot on their boards to be a hybrid SD/MMC slot.
Now, the more fun question is if the adapter can handle eMMC HS200 using the 4-bit bus?
Jimmy
Re: [PATCH v6 3/3] arm64: dts: rockchip: Add Radxa CM5 IO Board
Hi Jimmy,
Quoted 35 lines · Jimmy Hon
On Wed, Nov 5, 2025 at 9:31 PM Dragan Simic <[email protected]> wrote:
[ snip ]
Quoted 8 lines
With all that in mind, we should specify "no-mmc" here, because we're describing a microSD slot, instead of describing some hybrid MMC/microSD slot. That also explains why the adapter sold by Radxa is described as not to be used with microSD card slots on SBCs. I'd also like to hear is this adapter/eMMC chip combo recognized by the kernel when "no-mmc" is specified; it should fail.
Quoted 8 lines
Actually, not specifying "no-mmc" here may result in some unforeseen issues with some (or perhaps many?) microSD cards, because the MMC drivers will treat them as MMC-capable devices and try to initialize them as such, which may cause all kinds of issues. In fact, I'm not really sure that the MMC drivers are actually implemented in a way that avoids all possible issues with the storage controllers that are capable of both SD and MMC modes when neither of "no-sd" and "no-mmc" is specified in their DT nodes.
Hybrid MMC and SD slots are pretty normal on USB card readers. So it's normal for the host controller to figure out what kind of card is in the slot.
https://uditagarwal.in/understanding-sd-sdio-and-mmc-interface/https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=6ae3e537eab9f560b516b001eb89f0cd568bdced
was the commit that introduced the device tree properties. By the wording of the commit message, these device tree properties are used to indicate to the driver if the host controller hardware is capable of MMC initialization or SD initialization.Since the host controller in the RK3588 is capable of all the modes, these properties do not need to be specified.
Quoted 6 lines
Since Radxa has the eMMC to uSD adapter, it makes sense Radxa would want to configure their microSD card slot on their boards to be a hybrid SD/MMC slot.
Now, the more fun question is if the adapter can handle eMMC HS200 using the 4-bit bus?
I added
mmc-hs200-1_8v;
I got
[ 226.099510] mmc_host mmc1: Bus speed (slot 0) = 400000Hz (slot req 400000Hz, actual 400000HZ div = 0) [ 226.546246] mmc_host mmc1: Bus speed (slot 0) = 49500000Hz (slot req 52000000Hz, actual 49500000HZ div = 0) [ 226.546371] mmc_host mmc1: Bus speed (slot 0) = 198000000Hz (slot req 200000000Hz, actual 198000000HZ div = 0) [ 226.656853] dwmmc_rockchip fe2c0000.mmc: Successfully tuned phase to 76 [ 226.657011] mmc1: error -110 whilst initialising MMC card [ 226.671469] mmc_host mmc1: Bus speed (slot 0) = 300000Hz (slot req 300000Hz, actual 300000HZ div = 0) [ 226.793733] mmc1: switch to bus width 4 failed [ 226.798915] mmc1: mmc_select_hs200 failed, error -110 [ 226.799390] mmc1: error -110 whilst initialising MMC card [ 226.811549] mmc_host mmc1: Bus speed (slot 0) = 200000Hz (slot req 200000Hz, actual 200000HZ div = 0) [ 226.947518] mmc1: switch to bus width 4 failed [ 226.954978] mmc1: mmc_select_hs200 failed, error -110 [ 226.955454] mmc1: error -110 whilst initialising MMC card
I don't know if this is board-dependent.
Best regards,
--
FUKAUMI Naoki
Radxa Computer (Shenzhen) Co., Ltd.
Quoted 2 lines
Jimmy
Re: [PATCH v6 3/3] arm64: dts: rockchip: Add Radxa CM5 IO Board
Quoted 70 lines · FUKAUMI Naoki
Hi Jimmy,
Quoted 35 lines · Jimmy Hon
On Wed, Nov 5, 2025 at 9:31 PM Dragan Simic <[email protected]> wrote:
[ snip ]
Quoted 8 lines
With all that in mind, we should specify "no-mmc" here, because we're describing a microSD slot, instead of describing some hybrid MMC/microSD slot. That also explains why the adapter sold by Radxa is described as not to be used with microSD card slots on SBCs. I'd also like to hear is this adapter/eMMC chip combo recognized by the kernel when "no-mmc" is specified; it should fail.
Quoted 8 lines
Actually, not specifying "no-mmc" here may result in some unforeseen issues with some (or perhaps many?) microSD cards, because the MMC drivers will treat them as MMC-capable devices and try to initialize them as such, which may cause all kinds of issues. In fact, I'm not really sure that the MMC drivers are actually implemented in a way that avoids all possible issues with the storage controllers that are capable of both SD and MMC modes when neither of "no-sd" and "no-mmc" is specified in their DT nodes.
Hybrid MMC and SD slots are pretty normal on USB card readers. So it's normal for the host controller to figure out what kind of card is in the slot.
https://uditagarwal.in/understanding-sd-sdio-and-mmc-interface/https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=6ae3e537eab9f560b516b001eb89f0cd568bdced
was the commit that introduced the device tree properties. By the wording of the commit message, these device tree properties are used to indicate to the driver if the host controller hardware is capable of MMC initialization or SD initialization.Since the host controller in the RK3588 is capable of all the modes, these properties do not need to be specified.
Quoted 6 lines
Since Radxa has the eMMC to uSD adapter, it makes sense Radxa would want to configure their microSD card slot on their boards to be a hybrid SD/MMC slot.
Now, the more fun question is if the adapter can handle eMMC HS200 using the 4-bit bus?
I added
mmc-hs200-1_8v;I got
[ 226.099510] mmc_host mmc1: Bus speed (slot 0) = 400000Hz (slot req 400000Hz, actual 400000HZ div = 0) [ 226.546246] mmc_host mmc1: Bus speed (slot 0) = 49500000Hz (slot req 52000000Hz, actual 49500000HZ div = 0) [ 226.546371] mmc_host mmc1: Bus speed (slot 0) = 198000000Hz (slot req 200000000Hz, actual 198000000HZ div = 0) [ 226.656853] dwmmc_rockchip fe2c0000.mmc: Successfully tuned phase to 76 [ 226.657011] mmc1: error -110 whilst initialising MMC card [ 226.671469] mmc_host mmc1: Bus speed (slot 0) = 300000Hz (slot req 300000Hz, actual 300000HZ div = 0) [ 226.793733] mmc1: switch to bus width 4 failed [ 226.798915] mmc1: mmc_select_hs200 failed, error -110 [ 226.799390] mmc1: error -110 whilst initialising MMC card [ 226.811549] mmc_host mmc1: Bus speed (slot 0) = 200000Hz (slot req 200000Hz, actual 200000HZ div = 0) [ 226.947518] mmc1: switch to bus width 4 failed [ 226.954978] mmc1: mmc_select_hs200 failed, error -110 [ 226.955454] mmc1: error -110 whilst initialising MMC card
Quoted 1 line
I don't know if this is board-dependent.
I was hoping for too much.
In the "RK3588 Datasheet", under the "eMMC Interface", it specifically lists support for HS400. However, for the "SD/MMC Interface", it only mentions "SD3.0, MMC ver4.51", so the more performant eMMC modes are not available on that interface.
Jimmy
Quoted 11 lines
Best regards,
--
FUKAUMI Naoki
Radxa Computer (Shenzhen) Co., Ltd.Quoted 2 lines
Jimmy
Re: [PATCH v6 3/3] arm64: dts: rockchip: Add Radxa CM5 IO Board
In reply to Jimmy HonHello Jimmy,
Quoted 28 lines · Jimmy Hon
Quoted 7 lines · Dragan Simic
With all that in mind, we should specify "no-mmc" here, because we're describing a microSD slot, instead of describing some hybrid MMC/microSD slot. That also explains why the adapter sold by Radxa is described as not to be used with microSD card slots on SBCs. I'd also like to hear is this adapter/eMMC chip combo recognized by the kernel when "no-mmc" is specified; it should fail.
Quoted 8 lines
Actually, not specifying "no-mmc" here may result in some unforeseen issues with some (or perhaps many?) microSD cards, because the MMC drivers will treat them as MMC-capable devices and try to initialize them as such, which may cause all kinds of issues. In fact, I'm not really sure that the MMC drivers are actually implemented in a way that avoids all possible issues with the storage controllers that are capable of both SD and MMC modes when neither of "no-sd" and "no-mmc" is specified in their DT nodes.
Hybrid MMC and SD slots are pretty normal on USB card readers. So it's normal for the host controller to figure out what kind of card is in the slot.
https://uditagarwal.in/understanding-sd-sdio-and-mmc-interface/https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=6ae3e537eab9f560b516b001eb89f0cd568bdced
was the commit that introduced the device tree properties. By the wording of the commit message, these device tree properties are used to indicate to the driver if the host controller hardware is capable of MMC initialization or SD initialization.
Quoted 6 lines
Since the host controller in the RK3588 is capable of all the modes, these properties do not need to be specified.
Since Radxa has the eMMC to uSD adapter, it makes sense Radxa would want to configure their microSD card slot on their boards to be a hybrid SD/MMC slot.
Thanks for providing further insights! After thinking a bit more about it and after remembering that HardKernel also offers a similar microSD-to-MMC adapter, [1] there should be very few roadblocks that may actually prevent us from defining physical microSD slots found on Rockchip boards as hybrid microSD/MMC slots wherever that's allowed by the slot implementation and tested to work as expected. Supporting more card standards is always good.
This approach shouldn't be limited to Radxa (or HardKernel) boards only, because the available microSD-to-MMC adapters aren't designed specifically to fit some boards only.
The possible roadblocks, as mentioned above, are some unexpected signal integrity issues that may prevent the MMC mode from working as expected on some boards, which Jonas pointed out already, [2][3] and any associated issues in the MMC drivers.
I'll keep checking the code of MMC drivers for the existence of any associated issues, and I'll possibly turn a few microSD-only slots into hybrid ones. :)
[1] https://www.hardkernel.com/shop/emmc-module-reader-board-for-os-upgrade/
[2] https://libera.catirclogs.org/linux-rockchip/2025-11-06#38976445;
[3] https://libera.catirclogs.org/linux-rockchip/2025-11-07#38981060;
Re: [PATCH v6 3/3] arm64: dts: rockchip: Add Radxa CM5 IO Board
In reply to Dragan SimicQuoted 73 lines · Dragan Simic
Hello Naoki,
Quoted 40 lines · FUKAUMI Naoki
Quoted 19 lines · Jimmy Hon
Quoted 6 lines · FUKAUMI Naoki
The Radxa CM5 IO Board is an application board for the Radxa CM5.
Specification:
- 1x microSD card slot
[ snip ]
Quoted 9 lines
arch/arm64/boot/dts/rockchip/rk3588s-radxa-cm5-io.dts new file +9
-0+ +&sdmmc { + bus-width = <4>; + cap-mmc-highspeed; + cap-sd-highspeed; + cd-gpios = <&gpio0 RK_PA4 GPIO_ACTIVE_LOW>; + disable-wp; + no-sdio; + pinctrl-names = "default";Quoted 8 lines
arch/arm64/boot/dts/rockchip/rk3588s-radxa-cm5-io.dts line 412
Quoted 6 lines
arch/arm64/boot/dts/rockchip/rk3588s-radxa-cm5-io.dts new file +6
-0+ pinctrl-0 = <&sdmmc_bus4 &sdmmc_clk &sdmmc_cmd>; + sd-uhs-sdr104; + vmmc-supply = <&vcc_3v3_s3>; + vqmmc-supply = <&vccio_sd_s0>; + status = "okay"; +};When used as a TF slot, shouldn't there be a "no-mmc" also?
We have "eMMC to uSD."
https://radxa.com/products/accessories/emmc-to-usd[ 202.176757] mmc_host mmc1: Bus speed (slot 0) = 49500000Hz (slot req 52000000Hz, actual 49500000HZ div = 0) [ 202.178477] mmc1: new high speed MMC card at address 0001 [ 202.179534] mmcblk1: mmc1:0001 SLD64G 57.6 GiB [ 202.207336] mmcblk1boot0: mmc1:0001 SLD64G 4.00 MiB [ 202.210374] mmcblk1boot1: mmc1:0001 SLD64G 4.00 MiB [ 202.212967] mmcblk1rpmb: mmc1:0001 SLD64G 4.00 MiB, chardev (511:1)Quoted 2 lines
(I'm not sure why it says "Not work with the SD slot on the board." I will check.)
Thanks for bringing this up, I've always wondered how are such simple eMMC-to-microSD adapters supposed to work, so this was a good opportunity to research that a bit further.
In a few words, they're not supposed to work in true microSD card slots, and they seem to rely on USB card readers that support multiple card interface standards, but not more than a single card at once, by wiring their single interface lines in parallel to the different types of card slots that they provide.
To explain it a bit further, an eMMC chip supports different data bus widths and a backward-compatible MMC card mode, but they have very little knowledge about the SD specification, despite being somewhat similar; the exception is the simplified eMMC boot mode. This is explained further in the JEDEC JESD84-B51 standard, which is available freely from the JEDEC website after registration.
This is also confirmed by the kernel messages quoted above, which show that the eMMC chip is detected as an MMC card this way.
With all that in mind, we should specify "no-mmc" here, because we're describing a microSD slot, instead of describing some hybrid MMC/microSD slot. That also explains why the adapter sold by Radxa is described as not to be used with microSD card slots on SBCs. I'd also like to hear is this adapter/eMMC chip combo recognized by the kernel when "no-mmc" is specified; it should fail.
Quoted 3 lines
Actually, not specifying "no-mmc" here may result in some unforeseen issues with some (or perhaps many?) microSD cards, because the MMC drivers will treat them as MMC-capable devices and try to initialize
Just chime in: The reason why we introduced these, is for controllers not cards. AFAITC, before commit 6ae3e537eab9f5, we had done that way for a decade, but rarely saw problems in this field.
Quoted 13 lines
them as such, which may cause all kinds of issues. In fact, I'm not really sure that the MMC drivers are actually implemented in a way that avoids all possible issues with the storage controllers that are capable of both SD and MMC modes when neither of "no-sd" and "no-mmc" is specified in their DT nodes.
Furthermore, it seems that specifying "cap-mmc-highspeed" together with "no-emmc" is actually redundant, which would make sense, but further research of the MMC drivers is needed. I've added that to my ever-growing TODO list. :)
Quoted 2 lines
Quoted 1 line
That's how the Rock 5A, 5B, and 5C were defined.
Quoted 8 lines
Quoted 2 lines
I have submitted a patch without "no-mmc" before. I intend to send one again when I have the chance.
_______________________________________________
Linux-rockchip mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-rockchip
_______________________________________________
Linux-rockchip mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-rockchip
I'd like to clarify the situation regarding the v6 patch series I submitted.
The original device tree work for the Radxa CM5 and IO Board was authored by Joseph Kogut. I took over the responsibility of getting it upstreamed with his agreement.
However, I now understand that I should have preserved the original Signed-off-by chain (and DCO) in the v6 series. This was my oversight.
To correct this, I would prefer for Joseph to post the patches himself, which will not include my Signed-off-by.
My apologies for the confusion this caused. Thank you for pointing this out.
Best regards,
--
FUKAUMI Naoki
Radxa Computer (Shenzhen) Co., Ltd.
Quoted 105 lines · FUKAUMI Naoki
This patch series add support for the Radxa CM5 SoM and IO Board.
Changes in v6:
(Patch 1/3)
- Fix description; "Radxa CM5" is the correct name (Patch 2/3)
- Fix #include(s)
- Includerk3588s.dtsi
- Move alias for gmac1 from io board dts
- Add Maskrom key
- Add pinctrl-* for led-0
- Addvcc_1v1_nldo_s3regulator for pmic
- Move gmac1 (except status) from io board dts
- Fix phy-supply for gmac1
- Fix compatible forvdd_cpu_big1_s0regulator
- Add eeprom on i2c0
- Addvdd_npu_s0regulator for rknn
- Fix compatible forrgmii_phy1
- Add pinctrl-* and reset-* forrgmii_phy1
- Add domain-supply forpd_npu
- Add rknn_*
- Add saradc
- Fix properties in sdhci
- Move pmic from io board dts
- Fix vcc*-supply for pmic
- Add regulators in pmic
- Add tsadc
- Movevop(_mmu)from io board dts
- Trivial changes (labels, names, etc) (Patch 3/3)
- Fix #include(s)
- Remove #include "rk3588s.dtsi"
- Fix model
- Add fan
- Add Recovery key
- Add pinctrl-* forvcc3v3_wf
- Addvcc_sysinregulator
- Add pinctrl-* forvbus5v0_typec
- Add rfkill-bt and rfkill-wlan for M.2 module
- Add sound for es8316
- Add phy-supply forcombphy2_psu
- Fix power-role to "source" for fusb302
- Add rtc for hym8536
- Add audio-codec on i2c8 for es8316
- Addi2s0_8chfor es8316
- Addpackage_thermalfor fan
- Add pinctrl-* for pcie2x1l2
- Add pwm11 for fan
- Fix properties in sdmmmc
- Add phy-supply foru2phy2_hostandu2phy3_host
- Removeusb_host0_ohci
- Add pinctrl-* forusbdp_phy0
- Trivial changes (labels, names, etc)Changes in v5:
(Patch 2/3, per Jimmy)
- Alias eMMC to mmc0
- Remove unused sdio alias
- Move gmac, hdmi0 nodes to carrier board dts
(Patch 3/3, per Jimmy)
- Enablehdmi0_soundandi2s5_8ch
- Remove redundant enablement of sdhci
- Enableusb_host2_xhci- Tested HDMI audio
Changes in v4:
- Fixed XHCI initialization bug by changing try-power-role from source to sinkChanges in v3:
- Addressed YAML syntax error in dt binding (per Rob)
- Fixed whitespace issue in dts reported by checkpatch.pl
- Split base SoM and carrier board into separate patches
- Added further details about the SoM and carrier to the commit messagesChanges in v2:
- Added copyright header and data sheet links
- Removed non-existent property
- Sorted alphabetically
- Removed errant whitespace
- Moved status to the end of each node
- Removed pinctrl-names property from leds (indicated byCHECK_DTBS)
- Removed delays from gmac with internal delaySigned-off-by FUKAUMI Naoki <[email protected]>Signed-off-by Joseph Kogut <[email protected]>---
I have communicated with Joseph privately and taken ownership of moving this forward, with his blessing. All bugs belong to me.
---
FUKAUMI Naoki (3):
dt-bindings: arm: rockchip: Add Radxa CM5 IO Board
arm64: dts: rockchip: Add Radxa CM5
arm64: dts: rockchip: Add Radxa CM5 IO Board.../devicetree/bindings/arm/rockchip.yaml | 7 + arch/arm64/boot/dts/rockchip/Makefile | 1 + .../dts/rockchip/rk3588s-radxa-cm5-io.dts | 503 +++++++++++++++ .../boot/dts/rockchip/rk3588s-radxa-cm5.dtsi | 602 ++++++++++++++++++ 4 files changed, 1113 insertions(+)create mode 100644
arch/arm64/boot/dts/rockchip/rk3588s-radxa-cm5-io.dtscreate mode 100644arch/arm64/boot/dts/rockchip/rk3588s-radxa-cm5.dtsi
Hello all,
Quoted 6 lines · FUKAUMI Naoki
I'd like to clarify the situation regarding the v6 patch series I submitted.
The original device tree work for the Radxa CM5 and IO Board was authored by Joseph Kogut. I took over the responsibility of getting it upstreamed with his agreement.
I'll confirm this. I've been in communication with Naoki. They made a large number of revisions to my original patch series, which I think have technical merit. I suggested they submit the patches themselves, and gave them explicit permission to add my Signed-off-by and CC me.
I assume this was the correct way for them to continue the work I started, but if not, please let us know the best way to proceed.
Best,
Joseph
Hi all,
Quoted 10 lines · Joseph Kogut
Hello all,
Quoted 6 lines · FUKAUMI Naoki
I'd like to clarify the situation regarding the v6 patch series I submitted.
The original device tree work for the Radxa CM5 and IO Board was authored by Joseph Kogut. I took over the responsibility of getting it upstreamed with his agreement.
Quoted 7 lines
I'll confirm this. I've been in communication with Naoki. They made a large number of revisions to my original patch series, which I think have technical merit. I suggested they submit the patches themselves, and gave them explicit permission to add my Signed-off-by and CC me.
I assume this was the correct way for them to continue the work I started, but if not, please let us know the best way to proceed.
Can anyone help us?
Best regards,
--
FUKAUMI Naoki
Radxa Computer (Shenzhen) Co., Ltd.
Quoted 3 lines
Best,
Joseph
Hello all,
Quoted 13 lines · FUKAUMI Naoki
Quoted 12 lines · Joseph Kogut
Quoted 5 lines · FUKAUMI Naoki
I'd like to clarify the situation regarding the v6 patch series I submitted.
The original device tree work for the Radxa CM5 and IO Board was authored by Joseph Kogut. I took over the responsibility of getting it upstreamed with his agreement.
I'll confirm this. I've been in communication with Naoki. They made a large number of revisions to my original patch series, which I think have technical merit. I suggested they submit the patches themselves, and gave them explicit permission to add my Signed-off-by and CC me.
Quoted 4 lines
Quoted 2 lines
I assume this was the correct way for them to continue the work I started, but if not, please let us know the best way to proceed.
Can anyone help us?
I'm not exactly sure how to resolve the current situation, but for Signed-off-by tags to be present, in this case you'd need to have Co-developed-by tags as well, because the final patch versions, which would be submitted by Naoki, would differ significantly from the versions that Joseph actively worked on, if I understood everything correctly. Though, for Joseph's Signed-off-by tags to be included there, he would also need to participate actively in the development of the final patch versions.
Another option, technically a bit simpler, would be to include just Originally-by tags for Joseph, which would indicate that Joseph gave up on the development of the patches and handed them over to Naoki for future development and submission to the mailing lists. Though, that would require Joseph to publicly state exactly that.
Hi Dragan, Joseph,
Quoted 21 lines · Dragan Simic
Hello all,
Quoted 13 lines · FUKAUMI Naoki
Quoted 12 lines · Joseph Kogut
Quoted 5 lines · FUKAUMI Naoki
I'd like to clarify the situation regarding the v6 patch series I submitted.
The original device tree work for the Radxa CM5 and IO Board was authored by Joseph Kogut. I took over the responsibility of getting it upstreamed with his agreement.
I'll confirm this. I've been in communication with Naoki. They made a large number of revisions to my original patch series, which I think have technical merit. I suggested they submit the patches themselves, and gave them explicit permission to add my Signed-off-by and CC me.
Quoted 4 lines
Quoted 2 lines
I assume this was the correct way for them to continue the work I started, but if not, please let us know the best way to proceed.
Can anyone help us?
Quoted 8 lines
I'm not exactly sure how to resolve the current situation, but for Signed-off-by tags to be present, in this case you'd need to have Co-developed-by tags as well, because the final patch versions, which would be submitted by Naoki, would differ significantly from the versions that Joseph actively worked on, if I understood everything correctly. Though, for Joseph's Signed-off-by tags to be included there, he would also need to participate actively in the development of the final patch versions.
If
----
From: Joseph Kogut <[email protected]>
<changelog>
----
then I can submit my patch series?
Or,
Quoted 5 lines
Another option, technically a bit simpler, would be to include just Originally-by tags for Joseph, which would indicate that Joseph gave up on the development of the patches and handed them over to Naoki for future development and submission to the mailing lists. Though, that would require Joseph to publicly state exactly that.
I cannot find any documentation about "Originally-by". Is this correct?
----
<changelog>
----
Best regards,
--
FUKAUMI Naoki
Radxa Computer (Shenzhen) Co., Ltd.
Hello Naoki,
Quoted 35 lines · FUKAUMI Naoki
Quoted 19 lines · Dragan Simic
Quoted 13 lines · FUKAUMI Naoki
Quoted 12 lines · Joseph Kogut
Quoted 5 lines · FUKAUMI Naoki
I'd like to clarify the situation regarding the v6 patch series I submitted.
The original device tree work for the Radxa CM5 and IO Board was authored by Joseph Kogut. I took over the responsibility of getting it upstreamed with his agreement.
I'll confirm this. I've been in communication with Naoki. They made a large number of revisions to my original patch series, which I think have technical merit. I suggested they submit the patches themselves, and gave them explicit permission to add my Signed-off-by and CC me.
Quoted 4 lines
Quoted 2 lines
I assume this was the correct way for them to continue the work I started, but if not, please let us know the best way to proceed.
Can anyone help us?
Quoted 8 lines
I'm not exactly sure how to resolve the current situation, but for Signed-off-by tags to be present, in this case you'd need to have Co-developed-by tags as well, because the final patch versions, which would be submitted by Naoki, would differ significantly from the versions that Joseph actively worked on, if I understood everything correctly. Though, for Joseph's Signed-off-by tags to be included there, he would also need to participate actively in the development of the final patch versions.
If
----
From: Joseph Kogut <[email protected]>
Quoted 7 lines
<changelog>
Signed-off-by Joseph Kogut <[email protected]>Co-developed-by FUKAUMI Naoki <[email protected]>Signed-off-by FUKAUMI Naoki <[email protected]>----
then I can submit my patch series?
Actually, the Co-developed-by tags would be pointing to Joseph in that case, but as I described it above, this approach basically cannot be used, because Joseph's original work differs a lot from what you'd actually submit to the mailing list(s).
Quoted 8 lines
Or,
Quoted 5 lines
Another option, technically a bit simpler, would be to include just Originally-by tags for Joseph, which would indicate that Joseph gave up on the development of the patches and handed them over to Naoki for future development and submission to the mailing lists. Though, that would require Joseph to publicly state exactly that.
Quoted 8 lines
I cannot find any documentation about "Originally-by". Is this correct?
----
<changelog>Originally-by Joseph Kogut <[email protected]>Signed-off-by FUKAUMI Naoki <[email protected]>----
That approach is the only I see applicable in this case. However, let's hear opinions from other people as well.
By the way, what you called changelogs in the examples above is usually called patch descriptions. When they become merged, they become called commit descriptions or, sometimes, commit messages. Using the standard lingo usually helps. :)
Hi Dragan, Joseph, all
Quoted 64 lines · Dragan Simic
Hello Naoki,
Quoted 35 lines · FUKAUMI Naoki
Quoted 19 lines · Dragan Simic
Quoted 13 lines · FUKAUMI Naoki
Quoted 12 lines · Joseph Kogut
Quoted 5 lines · FUKAUMI Naoki
I'd like to clarify the situation regarding the v6 patch series I submitted.
The original device tree work for the Radxa CM5 and IO Board was authored by Joseph Kogut. I took over the responsibility of getting it upstreamed with his agreement.
I'll confirm this. I've been in communication with Naoki. They made a large number of revisions to my original patch series, which I think have technical merit. I suggested they submit the patches themselves, and gave them explicit permission to add my Signed-off-by and CC me.
Quoted 4 lines
Quoted 2 lines
I assume this was the correct way for them to continue the work I started, but if not, please let us know the best way to proceed.
Can anyone help us?
Quoted 8 lines
I'm not exactly sure how to resolve the current situation, but for Signed-off-by tags to be present, in this case you'd need to have Co-developed-by tags as well, because the final patch versions, which would be submitted by Naoki, would differ significantly from the versions that Joseph actively worked on, if I understood everything correctly. Though, for Joseph's Signed-off-by tags to be included there, he would also need to participate actively in the development of the final patch versions.
If
----
From: Joseph Kogut <[email protected]>Quoted 7 lines
<changelog>
Signed-off-by Joseph Kogut <[email protected]>Co-developed-by FUKAUMI Naoki <[email protected]>Signed-off-by FUKAUMI Naoki <[email protected]>----
then I can submit my patch series?Actually, the Co-developed-by tags would be pointing to Joseph in that case, but as I described it above, this approach basically cannot be used, because Joseph's original work differs a lot from what you'd actually submit to the mailing list(s).
Quoted 13 lines
Or,
Quoted 5 lines
Another option, technically a bit simpler, would be to include just Originally-by tags for Joseph, which would indicate that Joseph gave up on the development of the patches and handed them over to Naoki for future development and submission to the mailing lists. Though, that would require Joseph to publicly state exactly that.
I cannot find any documentation about "Originally-by". Is this correct?
----
<changelog>
Quoted 6 lines
Quoted 3 lines
Originally-by Joseph Kogut <[email protected]>Signed-off-by FUKAUMI Naoki <[email protected]>----
That approach is the only I see applicable in this case. However, let's hear opinions from other people as well.
Thank you very much for your advice.
So I want to hear Joseph's public statement and the opinions of other people.
Quoted 4 lines
By the way, what you called changelogs in the examples above is usually called patch descriptions. When they become merged, they become called commit descriptions or, sometimes, commit messages. Using the standard lingo usually helps. :)
Ah, it comes from
https://www.kernel.org/doc/html/latest/process/submitting-patches.html#when-to-use-acked-by-cc-and-co-developed-by
Should it be fixed? ;)
Best regards
--
FUKAUMI Naoki
Radxa Computer (Shenzhen) Co., Ltd.
Quoted 10 lines · FUKAUMI Naoki
Quoted 4 lines · Dragan Simic
By the way, what you called changelogs in the examples above is usually called patch descriptions. When they become merged, they become called commit descriptions or, sometimes, commit messages. Using the standard lingo usually helps. :)
Ah, it comes from
https://www.kernel.org/doc/html/latest/process/submitting-patches.html#when-to-use-acked-by-cc-and-co-developed-byShould it be fixed? ;)
Ah, I see, thanks. IMHO, the wording in that document should be adjusted a bit, but I don't have the time and energy required to actually do that. :)
Hi Dragan, Joseph,
Quoted 64 lines · Dragan Simic
Hello Naoki,
Quoted 35 lines · FUKAUMI Naoki
Quoted 19 lines · Dragan Simic
Quoted 13 lines · FUKAUMI Naoki
Quoted 12 lines · Joseph Kogut
Quoted 5 lines · FUKAUMI Naoki
I'd like to clarify the situation regarding the v6 patch series I submitted.
The original device tree work for the Radxa CM5 and IO Board was authored by Joseph Kogut. I took over the responsibility of getting it upstreamed with his agreement.
I'll confirm this. I've been in communication with Naoki. They made a large number of revisions to my original patch series, which I think have technical merit. I suggested they submit the patches themselves, and gave them explicit permission to add my Signed-off-by and CC me.
Quoted 4 lines
Quoted 2 lines
I assume this was the correct way for them to continue the work I started, but if not, please let us know the best way to proceed.
Can anyone help us?
Quoted 8 lines
I'm not exactly sure how to resolve the current situation, but for Signed-off-by tags to be present, in this case you'd need to have Co-developed-by tags as well, because the final patch versions, which would be submitted by Naoki, would differ significantly from the versions that Joseph actively worked on, if I understood everything correctly. Though, for Joseph's Signed-off-by tags to be included there, he would also need to participate actively in the development of the final patch versions.
If
----
From: Joseph Kogut <[email protected]>Quoted 7 lines
<changelog>
Signed-off-by Joseph Kogut <[email protected]>Co-developed-by FUKAUMI Naoki <[email protected]>Signed-off-by FUKAUMI Naoki <[email protected]>----
then I can submit my patch series?Actually, the Co-developed-by tags would be pointing to Joseph in that case, but as I described it above, this approach basically cannot be used, because Joseph's original work differs a lot from what you'd actually submit to the mailing list(s).
Quoted 13 lines
Or,
Quoted 5 lines
Another option, technically a bit simpler, would be to include just Originally-by tags for Joseph, which would indicate that Joseph gave up on the development of the patches and handed them over to Naoki for future development and submission to the mailing lists. Though, that would require Joseph to publicly state exactly that.
I cannot find any documentation about "Originally-by". Is this correct?
----
<changelog>
Quoted 6 lines
Quoted 3 lines
Originally-by Joseph Kogut <[email protected]>Signed-off-by FUKAUMI Naoki <[email protected]>----
That approach is the only I see applicable in this case. However, let's hear opinions from other people as well.
I see. I want to do this approach.
Joseph, could you give me a statement to do this?
--
FUKAUMI Naoki
Radxa Computer (Shenzhen) Co., Ltd.
Quoted 6 lines
By the way, what you called changelogs in the examples above is usually called patch descriptions. When they become merged, they become called commit descriptions or, sometimes, commit messages. Using the standard lingo usually helps. :)
Quoted 68 lines · FUKAUMI Naoki
Hi Dragan, Joseph,
Quoted 65 lines · Dragan Simic
Hello Naoki,
Quoted 35 lines · FUKAUMI Naoki
Quoted 19 lines · Dragan Simic
Quoted 13 lines · FUKAUMI Naoki
Quoted 12 lines · Joseph Kogut
Quoted 5 lines · FUKAUMI Naoki
I'd like to clarify the situation regarding the v6 patch series I submitted.
The original device tree work for the Radxa CM5 and IO Board was authored by Joseph Kogut. I took over the responsibility of getting it upstreamed with his agreement.
I'll confirm this. I've been in communication with Naoki. They made a large number of revisions to my original patch series, which I think have technical merit. I suggested they submit the patches themselves, and gave them explicit permission to add my Signed-off-by and CC me.
Quoted 4 lines
Quoted 2 lines
I assume this was the correct way for them to continue the work I started, but if not, please let us know the best way to proceed.
Can anyone help us?
Quoted 8 lines
I'm not exactly sure how to resolve the current situation, but for Signed-off-by tags to be present, in this case you'd need to have Co-developed-by tags as well, because the final patch versions, which would be submitted by Naoki, would differ significantly from the versions that Joseph actively worked on, if I understood everything correctly. Though, for Joseph's Signed-off-by tags to be included there, he would also need to participate actively in the development of the final patch versions.
If
----
From: Joseph Kogut <[email protected]>Quoted 7 lines
<changelog>
Signed-off-by Joseph Kogut <[email protected]>Co-developed-by FUKAUMI Naoki <[email protected]>Signed-off-by FUKAUMI Naoki <[email protected]>----
then I can submit my patch series?Actually, the Co-developed-by tags would be pointing to Joseph in that case, but as I described it above, this approach basically cannot be used, because Joseph's original work differs a lot from what you'd actually submit to the mailing list(s).
Quoted 14 lines
Or,
Quoted 5 lines
Another option, technically a bit simpler, would be to include just Originally-by tags for Joseph, which would indicate that Joseph gave up on the development of the patches and handed them over to Naoki for future development and submission to the mailing lists. Though, that would require Joseph to publicly state exactly that.
I cannot find any documentation about "Originally-by". Is this correct?
----
<changelog>Originally-by Joseph Kogut <[email protected]>
There is no such tag. Don't invent tags.
Quoted 9 lines
Quoted 5 lines
Quoted 2 lines
Signed-off-by FUKAUMI Naoki <[email protected]>----
That approach is the only I see applicable in this case. However, let's hear opinions from other people as well.
I see. I want to do this approach.
Joseph, could you give me a statement to do this?
Use standard authorship and standard tags, some of which are explained in Submitting patches.
Best regards,
Krzysztof
Hello Krzysztof,
Quoted 59 lines · Krzysztof Kozlowski
Quoted 58 lines · FUKAUMI Naoki
Quoted 57 lines · Dragan Simic
Quoted 35 lines · FUKAUMI Naoki
Quoted 19 lines · Dragan Simic
Quoted 13 lines · FUKAUMI Naoki
Quoted 12 lines · Joseph Kogut
Quoted 5 lines · FUKAUMI Naoki
I'd like to clarify the situation regarding the v6 patch series I submitted.
The original device tree work for the Radxa CM5 and IO Board was authored by Joseph Kogut. I took over the responsibility of getting it upstreamed with his agreement.
I'll confirm this. I've been in communication with Naoki. They made a large number of revisions to my original patch series, which I think have technical merit. I suggested they submit the patches themselves, and gave them explicit permission to add my Signed-off-by and CC me.
Quoted 4 lines
Quoted 2 lines
I assume this was the correct way for them to continue the work I started, but if not, please let us know the best way to proceed.
Can anyone help us?
Quoted 8 lines
I'm not exactly sure how to resolve the current situation, but for Signed-off-by tags to be present, in this case you'd need to have Co-developed-by tags as well, because the final patch versions, which would be submitted by Naoki, would differ significantly from the versions that Joseph actively worked on, if I understood everything correctly. Though, for Joseph's Signed-off-by tags to be included there, he would also need to participate actively in the development of the final patch versions.
If
----
From: Joseph Kogut <[email protected]>Quoted 7 lines
<changelog>
Signed-off-by Joseph Kogut <[email protected]>Co-developed-by FUKAUMI Naoki <[email protected]>Signed-off-by FUKAUMI Naoki <[email protected]>----
then I can submit my patch series?Actually, the Co-developed-by tags would be pointing to Joseph in that case, but as I described it above, this approach basically cannot be used, because Joseph's original work differs a lot from what you'd actually submit to the mailing list(s).
Quoted 8 lines
Or,
Quoted 5 lines
Another option, technically a bit simpler, would be to include just Originally-by tags for Joseph, which would indicate that Joseph gave up on the development of the patches and handed them over to Naoki for future development and submission to the mailing lists. Though, that would require Joseph to publicly state exactly that.
Quoted 8 lines
Quoted 6 lines
Quoted 6 lines
Quoted 6 lines
I cannot find any documentation about "Originally-by". Is this correct?
----
<changelog>Originally-by Joseph Kogut <[email protected]>There is no such tag. Don't invent tags.
True, it doesn't exist officially, but it's been used fairly often.
Quoted 6 lines
Quoted 6 lines
Quoted 5 lines
Quoted 2 lines
Signed-off-by FUKAUMI Naoki <[email protected]>----
That approach is the only I see applicable in this case. However, let's hear opinions from other people as well.
Quoted 6 lines
Quoted 3 lines
I see. I want to do this approach.
Joseph, could you give me a statement to do this?
Use standard authorship and standard tags, some of which are explained in Submitting patches.
Frankly, your suggestion is useless, because it doesn't explain what to do in this particular case.
Quoted 81 lines · Dragan Simic
Hello Krzysztof,
Quoted 59 lines · Krzysztof Kozlowski
Quoted 58 lines · FUKAUMI Naoki
Quoted 57 lines · Dragan Simic
Quoted 35 lines · FUKAUMI Naoki
Quoted 19 lines · Dragan Simic
Quoted 13 lines · FUKAUMI Naoki
Quoted 12 lines · Joseph Kogut
Quoted 5 lines · FUKAUMI Naoki
I'd like to clarify the situation regarding the v6 patch series I submitted.
The original device tree work for the Radxa CM5 and IO Board was authored by Joseph Kogut. I took over the responsibility of getting it upstreamed with his agreement.
I'll confirm this. I've been in communication with Naoki. They made a large number of revisions to my original patch series, which I think have technical merit. I suggested they submit the patches themselves, and gave them explicit permission to add my Signed-off-by and CC me.
Quoted 4 lines
Quoted 2 lines
I assume this was the correct way for them to continue the work I started, but if not, please let us know the best way to proceed.
Can anyone help us?
Quoted 8 lines
I'm not exactly sure how to resolve the current situation, but for Signed-off-by tags to be present, in this case you'd need to have Co-developed-by tags as well, because the final patch versions, which would be submitted by Naoki, would differ significantly from the versions that Joseph actively worked on, if I understood everything correctly. Though, for Joseph's Signed-off-by tags to be included there, he would also need to participate actively in the development of the final patch versions.
If
----
From: Joseph Kogut <[email protected]>Quoted 7 lines
<changelog>
Signed-off-by Joseph Kogut <[email protected]>Co-developed-by FUKAUMI Naoki <[email protected]>Signed-off-by FUKAUMI Naoki <[email protected]>----
then I can submit my patch series?Actually, the Co-developed-by tags would be pointing to Joseph in that case, but as I described it above, this approach basically cannot be used, because Joseph's original work differs a lot from what you'd actually submit to the mailing list(s).
Quoted 8 lines
Or,
Quoted 5 lines
Another option, technically a bit simpler, would be to include just Originally-by tags for Joseph, which would indicate that Joseph gave up on the development of the patches and handed them over to Naoki for future development and submission to the mailing lists. Though, that would require Joseph to publicly state exactly that.
Quoted 8 lines
Quoted 6 lines
Quoted 6 lines
Quoted 6 lines
I cannot find any documentation about "Originally-by". Is this correct?
----
<changelog>Originally-by Joseph Kogut <[email protected]>There is no such tag. Don't invent tags.
True, it doesn't exist officially, but it's been used fairly often.
Quoted 8 lines
Quoted 8 lines
Quoted 5 lines
Quoted 2 lines
Signed-off-by FUKAUMI Naoki <[email protected]>----
That approach is the only I see applicable in this case. However, let's hear opinions from other people as well.
I see. I want to do this approach.
Quoted 7 lines
Quoted 4 lines
Quoted 1 line
Joseph, could you give me a statement to do this?
Use standard authorship and standard tags, some of which are explained in Submitting patches.
Frankly, your suggestion is useless, because it doesn't explain what to do in this particular case.
Maybe because you did not read the doc...
Best regards,
Krzysztof
Quoted 82 lines · Krzysztof Kozlowski
Quoted 81 lines · Dragan Simic
Quoted 59 lines · Krzysztof Kozlowski
Quoted 58 lines · FUKAUMI Naoki
Quoted 57 lines · Dragan Simic
Quoted 35 lines · FUKAUMI Naoki
Quoted 19 lines · Dragan Simic
Quoted 13 lines · FUKAUMI Naoki
Quoted 12 lines · Joseph Kogut
Quoted 5 lines · FUKAUMI Naoki
I'd like to clarify the situation regarding the v6 patch series I submitted.
The original device tree work for the Radxa CM5 and IO Board was authored by Joseph Kogut. I took over the responsibility of getting it upstreamed with his agreement.
I'll confirm this. I've been in communication with Naoki. They made a large number of revisions to my original patch series, which I think have technical merit. I suggested they submit the patches themselves, and gave them explicit permission to add my Signed-off-by and CC me.
Quoted 4 lines
Quoted 2 lines
I assume this was the correct way for them to continue the work I started, but if not, please let us know the best way to proceed.
Can anyone help us?
Quoted 8 lines
I'm not exactly sure how to resolve the current situation, but for Signed-off-by tags to be present, in this case you'd need to have Co-developed-by tags as well, because the final patch versions, which would be submitted by Naoki, would differ significantly from the versions that Joseph actively worked on, if I understood everything correctly. Though, for Joseph's Signed-off-by tags to be included there, he would also need to participate actively in the development of the final patch versions.
If
----
From: Joseph Kogut <[email protected]>Quoted 7 lines
<changelog>
Signed-off-by Joseph Kogut <[email protected]>Co-developed-by FUKAUMI Naoki <[email protected]>Signed-off-by FUKAUMI Naoki <[email protected]>----
then I can submit my patch series?Actually, the Co-developed-by tags would be pointing to Joseph in that case, but as I described it above, this approach basically cannot be used, because Joseph's original work differs a lot from what you'd actually submit to the mailing list(s).
Quoted 8 lines
Or,
Quoted 5 lines
Another option, technically a bit simpler, would be to include just Originally-by tags for Joseph, which would indicate that Joseph gave up on the development of the patches and handed them over to Naoki for future development and submission to the mailing lists. Though, that would require Joseph to publicly state exactly that.
Quoted 8 lines
Quoted 6 lines
Quoted 6 lines
Quoted 6 lines
I cannot find any documentation about "Originally-by". Is this correct?
----
<changelog>Originally-by Joseph Kogut <[email protected]>There is no such tag. Don't invent tags.
True, it doesn't exist officially, but it's been used fairly often.
Quoted 10 lines
Quoted 9 lines
Quoted 5 lines
Quoted 2 lines
Signed-off-by FUKAUMI Naoki <[email protected]>----
That approach is the only I see applicable in this case. However, let's hear opinions from other people as well.
I see. I want to do this approach.
Joseph, could you give me a statement to do this?
Quoted 7 lines
Quoted 5 lines
Quoted 2 lines
Use standard authorship and standard tags, some of which are explained in Submitting patches.
Frankly, your suggestion is useless, because it doesn't explain what to do in this particular case.
Maybe because you did not read the doc...
I think you already know the answer: I read it multiple times and used it as a reference more than once.
Quoted 86 lines · Dragan Simic
Quoted 85 lines · Krzysztof Kozlowski
Quoted 84 lines · Dragan Simic
Quoted 59 lines · Krzysztof Kozlowski
Quoted 58 lines · FUKAUMI Naoki
Quoted 57 lines · Dragan Simic
Quoted 35 lines · FUKAUMI Naoki
Quoted 19 lines · Dragan Simic
Quoted 13 lines · FUKAUMI Naoki
Quoted 12 lines · Joseph Kogut
Quoted 5 lines · FUKAUMI Naoki
I'd like to clarify the situation regarding the v6 patch series I submitted.
The original device tree work for the Radxa CM5 and IO Board was authored by Joseph Kogut. I took over the responsibility of getting it upstreamed with his agreement.
I'll confirm this. I've been in communication with Naoki. They made a large number of revisions to my original patch series, which I think have technical merit. I suggested they submit the patches themselves, and gave them explicit permission to add my Signed-off-by and CC me.
Quoted 4 lines
Quoted 2 lines
I assume this was the correct way for them to continue the work I started, but if not, please let us know the best way to proceed.
Can anyone help us?
Quoted 8 lines
I'm not exactly sure how to resolve the current situation, but for Signed-off-by tags to be present, in this case you'd need to have Co-developed-by tags as well, because the final patch versions, which would be submitted by Naoki, would differ significantly from the versions that Joseph actively worked on, if I understood everything correctly. Though, for Joseph's Signed-off-by tags to be included there, he would also need to participate actively in the development of the final patch versions.
If
----
From: Joseph Kogut <[email protected]>Quoted 7 lines
<changelog>
Signed-off-by Joseph Kogut <[email protected]>Co-developed-by FUKAUMI Naoki <[email protected]>Signed-off-by FUKAUMI Naoki <[email protected]>----
then I can submit my patch series?Actually, the Co-developed-by tags would be pointing to Joseph in that case, but as I described it above, this approach basically cannot be used, because Joseph's original work differs a lot from what you'd actually submit to the mailing list(s).
Quoted 8 lines
Or,
Quoted 5 lines
Another option, technically a bit simpler, would be to include just Originally-by tags for Joseph, which would indicate that Joseph gave up on the development of the patches and handed them over to Naoki for future development and submission to the mailing lists. Though, that would require Joseph to publicly state exactly that.
Quoted 8 lines
Quoted 6 lines
Quoted 6 lines
Quoted 6 lines
I cannot find any documentation about "Originally-by". Is this correct?
----
<changelog>Originally-by Joseph Kogut <[email protected]>There is no such tag. Don't invent tags.
True, it doesn't exist officially, but it's been used fairly often.
Quoted 12 lines
Quoted 9 lines
Quoted 5 lines
Quoted 2 lines
Signed-off-by FUKAUMI Naoki <[email protected]>----
That approach is the only I see applicable in this case. However, let's hear opinions from other people as well.
I see. I want to do this approach.
Joseph, could you give me a statement to do this?
Use standard authorship and standard tags, some of which are explained in Submitting patches.
Quoted 7 lines
Quoted 4 lines
Quoted 2 lines
Frankly, your suggestion is useless, because it doesn't explain what to do in this particular case.
Maybe because you did not read the doc...
I think you already know the answer: I read it multiple times and used it as a reference more than once.
Then if you read it and saw my objection to inventing tags, you could guess that only first solution for patches with changes coming from multiple authors is allowed. Also you would find from that doc, that patches which were not changed - like in this patchset - must be attributed to single author followed by SoB. So both cases nicely explained. Pretty simple once you remove the invented tag option, because it is really unnecessary.
Best regards,
Krzysztof
Quoted 95 lines · Krzysztof Kozlowski
Quoted 86 lines · Dragan Simic
Quoted 85 lines · Krzysztof Kozlowski
Quoted 84 lines · Dragan Simic
Quoted 59 lines · Krzysztof Kozlowski
Quoted 58 lines · FUKAUMI Naoki
Quoted 57 lines · Dragan Simic
Quoted 35 lines · FUKAUMI Naoki
Quoted 19 lines · Dragan Simic
Quoted 13 lines · FUKAUMI Naoki
Quoted 12 lines · Joseph Kogut
Quoted 5 lines · FUKAUMI Naoki
I'd like to clarify the situation regarding the v6 patch series I submitted.
The original device tree work for the Radxa CM5 and IO Board was authored by Joseph Kogut. I took over the responsibility of getting it upstreamed with his agreement.
I'll confirm this. I've been in communication with Naoki. They made a large number of revisions to my original patch series, which I think have technical merit. I suggested they submit the patches themselves, and gave them explicit permission to add my Signed-off-by and CC me.
Quoted 4 lines
Quoted 2 lines
I assume this was the correct way for them to continue the work I started, but if not, please let us know the best way to proceed.
Can anyone help us?
Quoted 8 lines
I'm not exactly sure how to resolve the current situation, but for Signed-off-by tags to be present, in this case you'd need to have Co-developed-by tags as well, because the final patch versions, which would be submitted by Naoki, would differ significantly from the versions that Joseph actively worked on, if I understood everything correctly. Though, for Joseph's Signed-off-by tags to be included there, he would also need to participate actively in the development of the final patch versions.
If
----
From: Joseph Kogut <[email protected]>Quoted 7 lines
<changelog>
Signed-off-by Joseph Kogut <[email protected]>Co-developed-by FUKAUMI Naoki <[email protected]>Signed-off-by FUKAUMI Naoki <[email protected]>----
then I can submit my patch series?Actually, the Co-developed-by tags would be pointing to Joseph in that case, but as I described it above, this approach basically cannot be used, because Joseph's original work differs a lot from what you'd actually submit to the mailing list(s).
Quoted 8 lines
Or,
Quoted 5 lines
Another option, technically a bit simpler, would be to include just Originally-by tags for Joseph, which would indicate that Joseph gave up on the development of the patches and handed them over to Naoki for future development and submission to the mailing lists. Though, that would require Joseph to publicly state exactly that.
Quoted 8 lines
Quoted 6 lines
Quoted 6 lines
Quoted 6 lines
I cannot find any documentation about "Originally-by". Is this correct?
----
<changelog>Originally-by Joseph Kogut <[email protected]>There is no such tag. Don't invent tags.
True, it doesn't exist officially, but it's been used fairly often.
Quoted 12 lines
Quoted 9 lines
Quoted 5 lines
Quoted 2 lines
Signed-off-by FUKAUMI Naoki <[email protected]>----
That approach is the only I see applicable in this case. However, let's hear opinions from other people as well.
I see. I want to do this approach.
Joseph, could you give me a statement to do this?
Use standard authorship and standard tags, some of which are explained in Submitting patches.
Quoted 7 lines
Quoted 4 lines
Quoted 2 lines
Frankly, your suggestion is useless, because it doesn't explain what to do in this particular case.
Maybe because you did not read the doc...
I think you already know the answer: I read it multiple times and used it as a reference more than once.
Quoted 7 lines
Then if you read it and saw my objection to inventing tags, you could guess that only first solution for patches with changes coming from multiple authors is allowed. Also you would find from that doc, that patches which were not changed - like in this patchset - must be attributed to single author followed by SoB. So both cases nicely explained. Pretty simple once you remove the invented tag option, because it is really unnecessary.
Thanks, I appreciate your detailed response.
Let's have a look at the following excerpt from Documentation/ process/submitting-patches.rst:
503 Co-developed-by: states that the patch was co-created by multiple developers; 504 it is used to give attribution to co-authors (in addition to the author 505 attributed by the From: tag) when several people work on a single patch. Since 506 Co-developed-by: denotes authorship, every Co-developed-by: must be immediately 507 followed by a Signed-off-by: of the associated co-author. Standard sign-off 508 procedure applies, i.e. the ordering of Signed-off-by: tags should reflect the 509 chronological history of the patch insofar as possible, regardless of whether 510 the author is attributed via From: or Co-developed-by:. Notably, the last 511 Signed-off-by: must always be that of the developer submitting the patch.
Following that, you're absolutely right that the above-described first approach is the way to go. However, providing a Signed-off-by actually means that, at least formally, the signer becomes legally responsible for the code in the patch; I'm not sure how fair is it for someone to become responsible for something that happened long time ago, about which they have no longer a clue about, which may happen in case someone rescues an old, abandoned patch, and changes or improves it a lot before submitting it to a mailing list?
Of course, what I described is more of a hypothetical case, but the documentation should be covering such cases as well.
That's where Originally-by, I think, comes as a possible solution; it's a bit like Acked-by, i.e. it's a "lighter" version of Signed- off-by, in the sense of effectively not making someone legally responsible for the code they originally authored but have had abandoned and which someone else is now submitting, while still providing the mandatory attribution.
I hope it makes sense.
Quoted 67 lines · Dragan Simic
Hello Krzysztof,
Quoted 64 lines · Krzysztof Kozlowski
Quoted 63 lines · FUKAUMI Naoki
Quoted 62 lines · Dragan Simic
Quoted 35 lines · FUKAUMI Naoki
Quoted 19 lines · Dragan Simic
Quoted 13 lines · FUKAUMI Naoki
Quoted 12 lines · Joseph Kogut
Quoted 5 lines · FUKAUMI Naoki
I'd like to clarify the situation regarding the v6 patch series I submitted.
The original device tree work for the Radxa CM5 and IO Board was authored by Joseph Kogut. I took over the responsibility of getting it upstreamed with his agreement.
I'll confirm this. I've been in communication with Naoki. They made a large number of revisions to my original patch series, which I think have technical merit. I suggested they submit the patches themselves, and gave them explicit permission to add my Signed-off-by and CC me.
Quoted 4 lines
Quoted 2 lines
I assume this was the correct way for them to continue the work I started, but if not, please let us know the best way to proceed.
Can anyone help us?
Quoted 8 lines
I'm not exactly sure how to resolve the current situation, but for Signed-off-by tags to be present, in this case you'd need to have Co-developed-by tags as well, because the final patch versions, which would be submitted by Naoki, would differ significantly from the versions that Joseph actively worked on, if I understood everything correctly. Though, for Joseph's Signed-off-by tags to be included there, he would also need to participate actively in the development of the final patch versions.
If
----
From: Joseph Kogut <[email protected]>Quoted 7 lines
<changelog>
Signed-off-by Joseph Kogut <[email protected]>Co-developed-by FUKAUMI Naoki <[email protected]>Signed-off-by FUKAUMI Naoki <[email protected]>----
then I can submit my patch series?Actually, the Co-developed-by tags would be pointing to Joseph in that case, but as I described it above, this approach basically cannot be used, because Joseph's original work differs a lot from what you'd actually submit to the mailing list(s).
Quoted 13 lines
Or,
Quoted 5 lines
Another option, technically a bit simpler, would be to include just Originally-by tags for Joseph, which would indicate that Joseph gave up on the development of the patches and handed them over to Naoki for future development and submission to the mailing lists. Though, that would require Joseph to publicly state exactly that.
I cannot find any documentation about "Originally-by". Is this correct?
----
<changelog>
Quoted 5 lines
Quoted 3 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Originally-by Joseph Kogut <[email protected]>There is no such tag. Don't invent tags.
True, it doesn't exist officially, but it's been used fairly often.
Hmm, actually this tag seems to be documented, or at least given as an example:
Quoted 70 lines · Cristian Ciocaltea
Quoted 69 lines · Dragan Simic
Hello Krzysztof,
Quoted 66 lines · Krzysztof Kozlowski
Quoted 64 lines · FUKAUMI Naoki
Quoted 63 lines · Dragan Simic
Quoted 35 lines · FUKAUMI Naoki
Quoted 19 lines · Dragan Simic
Quoted 13 lines · FUKAUMI Naoki
Quoted 12 lines · Joseph Kogut
Quoted 5 lines · FUKAUMI Naoki
I'd like to clarify the situation regarding the v6 patch series I submitted.
The original device tree work for the Radxa CM5 and IO Board was authored by Joseph Kogut. I took over the responsibility of getting it upstreamed with his agreement.
I'll confirm this. I've been in communication with Naoki. They made a large number of revisions to my original patch series, which I think have technical merit. I suggested they submit the patches themselves, and gave them explicit permission to add my Signed-off-by and CC me.
Quoted 4 lines
Quoted 2 lines
I assume this was the correct way for them to continue the work I started, but if not, please let us know the best way to proceed.
Can anyone help us?
Quoted 8 lines
I'm not exactly sure how to resolve the current situation, but for Signed-off-by tags to be present, in this case you'd need to have Co-developed-by tags as well, because the final patch versions, which would be submitted by Naoki, would differ significantly from the versions that Joseph actively worked on, if I understood everything correctly. Though, for Joseph's Signed-off-by tags to be included there, he would also need to participate actively in the development of the final patch versions.
If
----
From: Joseph Kogut <[email protected]>Quoted 7 lines
<changelog>
Signed-off-by Joseph Kogut <[email protected]>Co-developed-by FUKAUMI Naoki <[email protected]>Signed-off-by FUKAUMI Naoki <[email protected]>----
then I can submit my patch series?Actually, the Co-developed-by tags would be pointing to Joseph in that case, but as I described it above, this approach basically cannot be used, because Joseph's original work differs a lot from what you'd actually submit to the mailing list(s).
Quoted 14 lines
Or,
Quoted 5 lines
Another option, technically a bit simpler, would be to include just Originally-by tags for Joseph, which would indicate that Joseph gave up on the development of the patches and handed them over to Naoki for future development and submission to the mailing lists. Though, that would require Joseph to publicly state exactly that.
I cannot find any documentation about "Originally-by". Is this correct?
----
<changelog>Originally-by Joseph Kogut <[email protected]>
Quoted 7 lines
Quoted 3 lines
Quoted 1 line
There is no such tag. Don't invent tags.
True, it doesn't exist officially, but it's been used fairly often.
Hmm, actually this tag seems to be documented, or at least given as an example:
Yes, for the tip folks (so three people). If you send to the TIP, their maintainer profile applies. There are also other specific rules in TIP which are in contrary to common (as most used) process, e.g. completely reversed tags (see also Konstantin's explanation about the order which he implemented in b4).
If you want to use it outside of tip, first this should be added to common docs and checkpatch. Just like b4 should be changed if you want to use their order of tags.
Best regards,
Krzysztof
Hi Joseph,
Quoted 7 lines · FUKAUMI Naoki
I'd like to clarify the situation regarding the v6 patch series I submitted.
The original device tree work for the Radxa CM5 and IO Board was authored by Joseph Kogut. I took over the responsibility of getting it upstreamed with his agreement.
However, I now understand that I should have preserved the original Signed-off-by chain (and DCO) in the v6 series. This was my oversight.
To correct this, I would prefer for Joseph to post the patches himself, which will not include my Signed-off-by.
Could you please post the patches?
Best regards,
--
FUKAUMI Naoki
Radxa Computer (Shenzhen) Co., Ltd.
Quoted 116 lines
My apologies for the confusion this caused. Thank you for pointing this out.
Best regards,
Signature · 2 lines
FUKAUMI Naoki Radxa Computer (Shenzhen) Co., Ltd.Quoted 105 lines · FUKAUMI Naoki
This patch series add support for the Radxa CM5 SoM and IO Board.
Changes in v6:
(Patch 1/3)
- Fix description; "Radxa CM5" is the correct name (Patch 2/3)
- Fix #include(s)
- Includerk3588s.dtsi
- Move alias for gmac1 from io board dts
- Add Maskrom key
- Add pinctrl-* for led-0
- Addvcc_1v1_nldo_s3regulator for pmic
- Move gmac1 (except status) from io board dts
- Fix phy-supply for gmac1
- Fix compatible forvdd_cpu_big1_s0regulator
- Add eeprom on i2c0
- Addvdd_npu_s0regulator for rknn
- Fix compatible forrgmii_phy1
- Add pinctrl-* and reset-* forrgmii_phy1
- Add domain-supply forpd_npu
- Add rknn_*
- Add saradc
- Fix properties in sdhci
- Move pmic from io board dts
- Fix vcc*-supply for pmic
- Add regulators in pmic
- Add tsadc
- Movevop(_mmu)from io board dts
- Trivial changes (labels, names, etc) (Patch 3/3)
- Fix #include(s)
- Remove #include "rk3588s.dtsi"
- Fix model
- Add fan
- Add Recovery key
- Add pinctrl-* forvcc3v3_wf
- Addvcc_sysinregulator
- Add pinctrl-* forvbus5v0_typec
- Add rfkill-bt and rfkill-wlan for M.2 module
- Add sound for es8316
- Add phy-supply forcombphy2_psu
- Fix power-role to "source" for fusb302
- Add rtc for hym8536
- Add audio-codec on i2c8 for es8316
- Addi2s0_8chfor es8316
- Addpackage_thermalfor fan
- Add pinctrl-* for pcie2x1l2
- Add pwm11 for fan
- Fix properties in sdmmmc
- Add phy-supply foru2phy2_hostandu2phy3_host
- Removeusb_host0_ohci
- Add pinctrl-* forusbdp_phy0
- Trivial changes (labels, names, etc)Changes in v5:
(Patch 2/3, per Jimmy)
- Alias eMMC to mmc0
- Remove unused sdio alias
- Move gmac, hdmi0 nodes to carrier board dts
(Patch 3/3, per Jimmy)
- Enablehdmi0_soundandi2s5_8ch
- Remove redundant enablement of sdhci
- Enableusb_host2_xhci- Tested HDMI audio
Changes in v4:
- Fixed XHCI initialization bug by changing try-power-role from source to sinkChanges in v3:
- Addressed YAML syntax error in dt binding (per Rob)
- Fixed whitespace issue in dts reported by checkpatch.pl
- Split base SoM and carrier board into separate patches
- Added further details about the SoM and carrier to the commit messagesChanges in v2:
- Added copyright header and data sheet links
- Removed non-existent property
- Sorted alphabetically
- Removed errant whitespace
- Moved status to the end of each node
- Removed pinctrl-names property from leds (indicated byCHECK_DTBS)
- Removed delays from gmac with internal delaySigned-off-by FUKAUMI Naoki <[email protected]>Signed-off-by Joseph Kogut <[email protected]>---
I have communicated with Joseph privately and taken ownership of moving this forward, with his blessing. All bugs belong to me.
---
FUKAUMI Naoki (3):
dt-bindings: arm: rockchip: Add Radxa CM5 IO Board
arm64: dts: rockchip: Add Radxa CM5
arm64: dts: rockchip: Add Radxa CM5 IO Board.../devicetree/bindings/arm/rockchip.yaml | 7 + arch/arm64/boot/dts/rockchip/Makefile | 1 + .../dts/rockchip/rk3588s-radxa-cm5-io.dts | 503 +++++++++++++++ .../boot/dts/rockchip/rk3588s-radxa-cm5.dtsi | 602 ++++++++++++++++++
4 files changed, 1113 insertions(+)create mode 100644
arch/arm64/boot/dts/rockchip/rk3588s-radxa-cm5-io.dtscreate mode 100644arch/arm64/boot/dts/rockchip/rk3588s-radxa-cm5.dtsi
(Sorry, "To:" was wrong in previous email)
Hi Joseph,
Quoted 5 lines · FUKAUMI Naoki
Hi Joseph,
Quoted 2 lines · FUKAUMI Naoki
I'd like to clarify the situation regarding the v6 patch series I submitted.
Quoted 7 lines
Quoted 5 lines
The original device tree work for the Radxa CM5 and IO Board was authored by Joseph Kogut. I took over the responsibility of getting it upstreamed with his agreement.
However, I now understand that I should have preserved the original Signed-off-by chain (and DCO) in the v6 series. This was my oversight.
To correct this, I would prefer for Joseph to post the patches himself, which will not include my Signed-off-by.
Could you please post the patches?
Please ignore the patches I sent as v6. Also, I don't claim my copyright. Feel free (not) to use them.
Best regards,
--
FUKAUMI Naoki
Radxa Computer (Shenzhen) Co., Ltd.
Quoted 123 lines
Best regards,
Signature · 2 lines
FUKAUMI Naoki Radxa Computer (Shenzhen) Co., Ltd.Quoted 116 lines
My apologies for the confusion this caused. Thank you for pointing this out.
Best regards,
Signature · 2 lines
FUKAUMI Naoki Radxa Computer (Shenzhen) Co., Ltd.Quoted 105 lines · FUKAUMI Naoki
This patch series add support for the Radxa CM5 SoM and IO Board.
Changes in v6:
(Patch 1/3)
- Fix description; "Radxa CM5" is the correct name (Patch 2/3)
- Fix #include(s)
- Includerk3588s.dtsi
- Move alias for gmac1 from io board dts
- Add Maskrom key
- Add pinctrl-* for led-0
- Addvcc_1v1_nldo_s3regulator for pmic
- Move gmac1 (except status) from io board dts
- Fix phy-supply for gmac1
- Fix compatible forvdd_cpu_big1_s0regulator
- Add eeprom on i2c0
- Addvdd_npu_s0regulator for rknn
- Fix compatible forrgmii_phy1
- Add pinctrl-* and reset-* forrgmii_phy1
- Add domain-supply forpd_npu
- Add rknn_*
- Add saradc
- Fix properties in sdhci
- Move pmic from io board dts
- Fix vcc*-supply for pmic
- Add regulators in pmic
- Add tsadc
- Movevop(_mmu)from io board dts
- Trivial changes (labels, names, etc) (Patch 3/3)
- Fix #include(s)
- Remove #include "rk3588s.dtsi"
- Fix model
- Add fan
- Add Recovery key
- Add pinctrl-* forvcc3v3_wf
- Addvcc_sysinregulator
- Add pinctrl-* forvbus5v0_typec
- Add rfkill-bt and rfkill-wlan for M.2 module
- Add sound for es8316
- Add phy-supply forcombphy2_psu
- Fix power-role to "source" for fusb302
- Add rtc for hym8536
- Add audio-codec on i2c8 for es8316
- Addi2s0_8chfor es8316
- Addpackage_thermalfor fan
- Add pinctrl-* for pcie2x1l2
- Add pwm11 for fan
- Fix properties in sdmmmc
- Add phy-supply foru2phy2_hostandu2phy3_host
- Removeusb_host0_ohci
- Add pinctrl-* forusbdp_phy0
- Trivial changes (labels, names, etc)Changes in v5:
(Patch 2/3, per Jimmy)
- Alias eMMC to mmc0
- Remove unused sdio alias
- Move gmac, hdmi0 nodes to carrier board dts
(Patch 3/3, per Jimmy)
- Enablehdmi0_soundandi2s5_8ch
- Remove redundant enablement of sdhci
- Enableusb_host2_xhci- Tested HDMI audio
Changes in v4:
- Fixed XHCI initialization bug by changing try-power-role from source to sinkChanges in v3:
- Addressed YAML syntax error in dt binding (per Rob)
- Fixed whitespace issue in dts reported by checkpatch.pl
- Split base SoM and carrier board into separate patches
- Added further details about the SoM and carrier to the commit messagesChanges in v2:
- Added copyright header and data sheet links
- Removed non-existent property
- Sorted alphabetically
- Removed errant whitespace
- Moved status to the end of each node
- Removed pinctrl-names property from leds (indicated byCHECK_DTBS)
- Removed delays from gmac with internal delaySigned-off-by FUKAUMI Naoki <[email protected]>Signed-off-by Joseph Kogut <[email protected]>---
I have communicated with Joseph privately and taken ownership of moving this forward, with his blessing. All bugs belong to me.
---
FUKAUMI Naoki (3):
dt-bindings: arm: rockchip: Add Radxa CM5 IO Board
arm64: dts: rockchip: Add Radxa CM5
arm64: dts: rockchip: Add Radxa CM5 IO Board.../devicetree/bindings/arm/rockchip.yaml | 7 + arch/arm64/boot/dts/rockchip/Makefile | 1 + .../dts/rockchip/rk3588s-radxa-cm5-io.dts | 503 +++++++++++++++ .../boot/dts/rockchip/rk3588s-radxa-cm5.dtsi | 602 ++++++++++++++++++
4 files changed, 1113 insertions(+)create mode 100644
arch/arm64/boot/dts/rockchip/rk3588s-radxa-cm5-io.dtscreate mode 100644arch/arm64/boot/dts/rockchip/rk3588s-radxa-cm5.dtsi
Quoted 10 lines · FUKAUMI Naoki
This patch series add support for the Radxa CM5 SoM and IO Board.
Changes in v6:
(Patch 1/3)
- Fix description; "Radxa CM5" is the correct name (Patch 2/3)
- Fix #include(s)
- Includerk3588s.dtsi
- Move alias for gmac1 from io board dts
I'm curious why the alias was moved to the SoM? If the carrier board does not enable the gmac1, shouldn't we leave out the alias?
i.e. for the handheld without RJ45 jack [1], it wouldn't want the alias, right?
[1] https://github.com/StonedEdge/Retro-Lite-CM5
Jimmy
Hi Jimmy,
Quoted 12 lines · Jimmy Hon
Quoted 10 lines · FUKAUMI Naoki
This patch series add support for the Radxa CM5 SoM and IO Board.
Changes in v6:
(Patch 1/3)
- Fix description; "Radxa CM5" is the correct name (Patch 2/3)
- Fix #include(s)
- Includerk3588s.dtsi
- Move alias for gmac1 from io board dts
Quoted 3 lines
I'm curious why the alias was moved to the SoM? If the carrier board does not enable the gmac1, shouldn't we leave out the alias?
i.e. for the handheld without RJ45 jack [1], it wouldn't want the alias, right?
Indeed.
Best regards,
--
FUKAUMI Naoki
Radxa Computer (Shenzhen) Co., Ltd.
Quoted 4 lines
[1] https://github.com/StonedEdge/Retro-Lite-CM5
Jimmy