mm: report per-page metadata information
Subsystems (8)
PATCH v12 1/1 mm: report per-page metadata information
Today, we do not have any observability of per-page metadata and how much it takes away from the machine capacity. Thus, we want to describe the amount of memory that is going towards per-page metadata, which can vary depending on build configuration, machine architecture, and system use.
This patch adds 2 fields to /proc/vmstat that can used as shown below:
Accounting per-page metadata allocated by boot-allocator:
/proc/vmstat:nr_memmap_boot * PAGE_SIZE
Accounting per-page metadata allocated by buddy-allocator:
/proc/vmstat:nr_memmap * PAGE_SIZE
Accounting total Perpage metadata allocated on the machine:
(/proc/vmstat:nr_memmap_boot +
/proc/vmstat:nr_memmap) * PAGE_SIZE
Utility for userspace:
Observability: Describe the amount of memory overhead that is going to per-page metadata on the system at any given time since this overhead is not currently observable.
Debugging: Tracking the changes or absolute value in struct pages can help detect anomalies as they can be correlated with other metrics in the machine (e.g., memtotal, number of huge pages, etc).
page_ext overheads: Some kernel features such as page_owner page_table_check that use page_ext can be optionally enabled via kernel parameters. Having the total per-page metadata information helps users precisely measure impact. Furthermore, page-metadata metrics will reflect the amount of struct pages reliquished (or overhead reduced) when hugetlbfs pages are reserved which will vary depending on whether hugetlb vmemmap optimization is enabled or not.
For background and results see:
lore.kernel.org/all/[email protected]
---
Changelog:
Restructured the cover-letter.
Removed the Memmap field being exported to /proc/meminfo. Synchronized with 6.9-rc7.
v11:
https://lore.kernel.org/all/[email protected]
--- include/linux/mmzone.h | 2 ++ include/linux/vmstat.h | 4 ++++ mm/hugetlb_vmemmap.c | 17 +++++++++++++---- mm/mm_init.c | 3 +++ mm/page_alloc.c | 1 + mm/page_ext.c | 32 +++++++++++++++++++++++--------- mm/sparse-vmemmap.c | 8 ++++++++ mm/sparse.c | 7 ++++++- mm/vmstat.c | 26 +++++++++++++++++++++++++- 9 files changed, 85 insertions(+), 15 deletions(-)
include/linux/mmzone.h +2 -0
@@ -217,6 +217,8 @@ enum node_stat_item {PGDEMOTE_KSWAPD ,PGDEMOTE_DIRECT ,PGDEMOTE_KHUGEPAGED , +NR_MEMMAP ,/* page metadata allocated through buddy allocator */ +NR_MEMMAP_BOOT ,/* page metadata allocated through boot allocator */ NR_VM_NODE_STAT_ITEMS };
include/linux/vmstat.h +4 -0
@@ -632,4 +632,8 @@ static inline void lruvec_stat_sub_folio(struct folio *folio, {lruvec_stat_mod_folio (folio, idx, -folio_nr_pages (folio)); } + +void __meminit mod_node_early_perpage_metadata (int nid,long delta); +void __meminit store_early_perpage_metadata (void ); +#endif /* _LINUX_VMSTAT_H */
mm/hugetlb_vmemmap.c +13 -4
@@ -184,10 +184,13 @@ static int vmemmap_remap_range(unsigned long start, unsigned long end,*/ static inline void free_vmemmap_page (struct page *page) { -if (PageReserved (page)) +if (PageReserved (page)) {free_bootmem_page (page); -else +mod_node_page_state (page_pgdat (page),NR_MEMMAP_BOOT ,-1 ); + }else {__free_page (page); +mod_node_page_state (page_pgdat (page),NR_MEMMAP ,-1 ); + } }/* Free a list of the vmemmap pages */
@@ -338,6 +341,7 @@ static int vmemmap_remap_free(unsigned long start, unsigned long end,copy_page (page_to_virt (walk.reuse_page), (void *)walk.reuse_addr);list_add (&walk.reuse_page->lru, vmemmap_pages); +mod_node_page_state (NODE_DATA (nid),NR_MEMMAP ,1 ); }/*
@@ -384,14 +388,19 @@ static int alloc_vmemmap_page_list(unsigned long start, unsigned long end,unsigned long nr_pages = (end - start) >>PAGE_SHIFT ;int nid =page_to_nid ((struct page *)start);struct page *page, *next; +int i; -while (nr_pages--) { +for (i =0 ; i < nr_pages; i++) { page =alloc_pages_node (nid, gfp_mask,0 ); -if (!page) +if (!page) { +mod_node_page_state (NODE_DATA (nid),NR_MEMMAP , i); goto out; + }list_add (&page->lru, list); } +mod_node_page_state (NODE_DATA (nid),NR_MEMMAP , nr_pages); +return 0 ; out:list_for_each_entry_safe (page, next, list, lru)
mm/mm_init.c +3 -0
@@ -27,6 +27,7 @@#include <linux/swap.h> #include <linux/cma.h> #include <linux/crash_dump.h> +#include <linux/vmstat.h> #include "internal.h" #include "slab.h" #include "shuffle.h"
@@ -1656,6 +1657,8 @@ static void __init alloc_node_mem_map(struct pglist_data *pgdat)panic ("Failed to allocate %ld bytes for node %d memory map\n" , size, pgdat->node_id); pgdat->node_mem_map = map + offset; +mod_node_early_perpage_metadata (pgdat->node_id, +DIV_ROUND_UP (size,PAGE_SIZE ));pr_debug ("%s: node %d, pgdat %08lx, node_mem_map %08lx\n" , __func__, pgdat->node_id, (unsigned long )pgdat, (unsigned long )pgdat->node_mem_map);
mm/page_alloc.c +1 -0
@@ -5650,6 +5650,7 @@ void __init setup_per_cpu_pageset(void)for_each_online_pgdat (pgdat) pgdat->per_cpu_nodestats = alloc_percpu(struct per_cpu_nodestat); +store_early_perpage_metadata (); }__meminit void zone_pcp_init (struct zone *zone)
mm/page_ext.c +23 -9
@@ -201,6 +201,8 @@ static int __init alloc_node_page_ext(int nid)return -ENOMEM ;NODE_DATA (nid)->node_page_ext = base; total_usage += table_size; +mod_node_page_state (NODE_DATA (nid),NR_MEMMAP_BOOT , +DIV_ROUND_UP (table_size,PAGE_SIZE ));return 0 ; }
@@ -255,12 +257,15 @@ static void *__meminit alloc_page_ext(size_t size, int nid)void *addr =NULL ; addr =alloc_pages_exact_nid (nid, size, flags); -if (addr) { +if (addr)kmemleak_alloc (addr, size,1 , flags); -return addr; - } +else + addr =vzalloc_node (size, nid); - addr =vzalloc_node (size, nid); +if (addr) { +mod_node_page_state (NODE_DATA (nid),NR_MEMMAP , +DIV_ROUND_UP (size,PAGE_SIZE )); + }return addr; }
@@ -303,18 +308,27 @@ static int __meminit init_section_page_ext(unsigned long pfn, int nid)static void free_page_ext (void *addr) { +size_t table_size; +struct page *page; +struct pglist_data *pgdat; + + table_size = page_ext_size *PAGES_PER_SECTION ; +if (is_vmalloc_addr (addr)) { + page =vmalloc_to_page (addr); + pgdat =page_pgdat (page);vfree (addr); }else { -struct page *page =virt_to_page (addr); -size_t table_size; - - table_size = page_ext_size *PAGES_PER_SECTION ; - + page =virt_to_page (addr); + pgdat =page_pgdat (page);BUG_ON (PageReserved (page));kmemleak_free (addr);free_pages_exact (addr, table_size); } + +mod_node_page_state (pgdat,NR_MEMMAP , +-1L * (DIV_ROUND_UP (table_size,PAGE_SIZE ))); + }static void __free_page_ext (unsigned long pfn)
mm/sparse-vmemmap.c +8 -0
@@ -469,5 +469,13 @@ struct page * __meminit __populate_section_memmap(unsigned long pfn,if (r <0 )return NULL ; +if (system_state ==SYSTEM_BOOTING ) { +mod_node_early_perpage_metadata (nid,DIV_ROUND_UP (end - start, +PAGE_SIZE )); + }else { +mod_node_page_state (NODE_DATA (nid),NR_MEMMAP , +DIV_ROUND_UP (end - start,PAGE_SIZE )); + } +return pfn_to_page (pfn); }
mm/sparse.c +6 -1
@@ -14,7 +14,7 @@#include <linux/swap.h> #include <linux/swapops.h> #include <linux/bootmem_info.h> - +#include <linux/vmstat.h> #include "internal.h" #include <asm/dma.h>
@@ -465,6 +465,9 @@ static void __init sparse_buffer_init(unsigned long size, int nid)*/ sparsemap_buf =memmap_alloc (size,section_map_size (), addr, nid, true); sparsemap_buf_end = sparsemap_buf + size; +#ifndef CONFIG_SPARSEMEM_VMEMMAP +mod_node_early_perpage_metadata (nid,DIV_ROUND_UP (size,PAGE_SIZE )); +#endif }static void __init sparse_buffer_fini (void )
@@ -641,6 +644,8 @@ static void depopulate_section_memmap(unsigned long pfn, unsigned long nr_pages,unsigned long start = (unsigned long )pfn_to_page (pfn);unsigned long end = start + nr_pages *sizeof (struct page ); +mod_node_page_state (page_pgdat (pfn_to_page (pfn)),NR_MEMMAP , +-1L * (DIV_ROUND_UP (end - start,PAGE_SIZE )));vmemmap_free (start, end, altmap); }static void free_map_bootmem (struct page *memmap)
mm/vmstat.c +25 -1
@@ -1252,7 +1252,8 @@ const char * const vmstat_text[] = {"pgdemote_kswapd" ,"pgdemote_direct" ,"pgdemote_khugepaged" , - +"nr_memmap" , +"nr_memmap_boot" ,/* enum writeback_stat_item counters */ "nr_dirty_threshold" , "nr_dirty_background_threshold",
@@ -2279,4 +2280,27 @@ static int __init extfrag_debug_init(void) }module_init (extfrag_debug_init); +#endif + +/* +* Page metadata size (struct page and page_ext) in pages +*/ +static unsigned long early_perpage_metadata[MAX_NUMNODES ]__meminitdata ; + +void __meminit mod_node_early_perpage_metadata (int nid,long delta) +{ + early_perpage_metadata[nid] += delta; +} + +void __meminit store_early_perpage_metadata (void ) +{ +int nid; +struct pglist_data *pgdat; + +for_each_online_pgdat (pgdat) { + nid = pgdat->node_id; +mod_node_page_state (NODE_DATA (nid),NR_MEMMAP_BOOT , + early_perpage_metadata[nid]); + } +}
Signature · 1 line
2.45.0.118.g7fe29c98d7-goog
Quoted 39 lines · Sourav Panda
Today, we do not have any observability of per-page metadata and how much it takes away from the machine capacity. Thus, we want to describe the amount of memory that is going towards per-page metadata, which can vary depending on build configuration, machine architecture, and system use.
This patch adds 2 fields to
/proc/vmstatthat can used as shown below:Accounting per-page metadata allocated by boot-allocator:
/proc/vmstat:nr_memmap_boot *PAGE_SIZEAccounting per-page metadata allocated by buddy-allocator:
/proc/vmstat:nr_memmap *PAGE_SIZEAccounting total Perpage metadata allocated on the machine:
(/proc/vmstat:nr_memmap_boot +
/proc/vmstat:nr_memmap) *PAGE_SIZEUtility for userspace:
Observability: Describe the amount of memory overhead that is going to per-page metadata on the system at any given time since this overhead is not currently observable.
Debugging: Tracking the changes or absolute value in struct pages can help detect anomalies as they can be correlated with other metrics in the machine (e.g., memtotal, number of huge pages, etc).
page_extoverheads: Some kernel features such aspage_ownerpage_table_checkthat usepage_extcan be optionally enabled via kernel parameters. Having the total per-page metadata information helps users precisely measure impact. Furthermore, page-metadata metrics will reflect the amount of struct pages reliquished (or overhead reduced) when hugetlbfs pages are reserved which will vary depending on whether hugetlb vmemmap optimization is enabled or not.
Quoted 5 lines
For background and results see:
lore.kernel.org/all/[email protected]Signed-off-by Sourav Panda <[email protected]>Reviewed-by Pasha Tatashin <[email protected]>
Quoted 41 lines · David Rientjes
Quoted 39 lines · Sourav Panda
Today, we do not have any observability of per-page metadata and how much it takes away from the machine capacity. Thus, we want to describe the amount of memory that is going towards per-page metadata, which can vary depending on build configuration, machine architecture, and system use.
This patch adds 2 fields to
/proc/vmstatthat can used as shown below:Accounting per-page metadata allocated by boot-allocator:
/proc/vmstat:nr_memmap_boot *PAGE_SIZEAccounting per-page metadata allocated by buddy-allocator:
/proc/vmstat:nr_memmap *PAGE_SIZEAccounting total Perpage metadata allocated on the machine:
(/proc/vmstat:nr_memmap_boot +
/proc/vmstat:nr_memmap) *PAGE_SIZEUtility for userspace:
Observability: Describe the amount of memory overhead that is going to per-page metadata on the system at any given time since this overhead is not currently observable.
Debugging: Tracking the changes or absolute value in struct pages can help detect anomalies as they can be correlated with other metrics in the machine (e.g., memtotal, number of huge pages, etc).
page_extoverheads: Some kernel features such aspage_ownerpage_table_checkthat usepage_extcan be optionally enabled via kernel parameters. Having the total per-page metadata information helps users precisely measure impact. Furthermore, page-metadata metrics will reflect the amount of struct pages reliquished (or overhead reduced) when hugetlbfs pages are reserved which will vary depending on whether hugetlb vmemmap optimization is enabled or not.
Quoted 8 lines
Quoted 5 lines
For background and results see:
lore.kernel.org/all/[email protected]Signed-off-by Sourav Panda <[email protected]>Reviewed-by Pasha Tatashin <[email protected]>Acked-by David Rientjes <[email protected]>
This would be a very useful extension to be able to provide observability of per-page metadata overhead and the impact of things like HVO on the overall footprint. Today, we don't have observability for this memory overhead.
Andrew, anything else that can be addressed before this is eligible for staging in MM unstable?
Andrew Morton
maintainerQuoted 7 lines · On Fri, 24 May 2024 13:00:06 -0700 (PDT) David Rientjes <[email protected]>…
This would be a very useful extension to be able to provide observability of per-page metadata overhead and the impact of things like HVO on the overall footprint. Today, we don't have observability for this memory overhead.
Andrew, anything else that can be addressed before this is eligible for staging in MM unstable?
I've asked Sourav to prepare a v13, largely to see if we can get a few more eyeballs onto this.