Skip to contentSkip to conversation

tip - Solution of ath9k: turn off temporarily (66b5c4a2c638b5a69d3e41abe4a2bae55035a92e)

PATCH New Jaswinder Singh Rajput 4 participants 7 messages Jan 2, 2009 – Jan 5, 2009 Networking drivers (wireless)

lore
Share & tools
lore
#0 lore raw

Hello Ingo,

If you choose :
CONFIG_RFKILL=m
CONFIG_ATH9K=y

It will give linking error because ATH9K need RFKILL functions.

But if you choose :
CONFIG_RFKILL=y
CONFIG_ATH9K=y

OR

CONFIG_RFKILL=m
CONFIG_ATH9K=m

It is OK.

Thanks,
JSR

#1 lore raw
Quoted 12 lines · Jaswinder Singh Rajput

Hello Ingo,

If you choose :
CONFIG_RFKILL=m
CONFIG_ATH9K=y

It will give linking error because ATH9K need RFKILL functions.

But if you choose :
CONFIG_RFKILL=y
CONFIG_ATH9K=y

Quoted 6 lines

OR

CONFIG_RFKILL=m
CONFIG_ATH9K=m

It is OK.

this was just a quick hatchet job to make the build regression go away. Would you like to send a real fix, with the wireless list and maintainers Cc-ed? Then i can revert the hack below from tip/out-of-tree.

ngo

------------------>

#2 lore raw
Quoted 62 lines · Ingo Molnar
Quoted 12 lines · Jaswinder Singh Rajput

Hello Ingo,

If you choose :
CONFIG_RFKILL=m
CONFIG_ATH9K=y

It will give linking error because ATH9K need RFKILL functions.

But if you choose :
CONFIG_RFKILL=y
CONFIG_ATH9K=y

Quoted 6 lines

OR

CONFIG_RFKILL=m
CONFIG_ATH9K=m

It is OK.

this was just a quick hatchet job to make the build regression go away. Would you like to send a real fix, with the wireless list and maintainers Cc-ed? Then i can revert the hack below from tip/out-of-tree.

ngo

------------------>
From 66b5c4a2c638b5a69d3e41abe4a2bae55035a92e Mon Sep 17 00:00:00 2001
From: Ingo Molnar <[email protected]>
Date: Fri, 2 Jan 2009 16:04:03 +0100
Subject: [PATCH] ath9k: turn off temporarily

Impact: fix build failure

ath9k fails to build:

drivers/built-in.o: In function `ath_detach':
main.c:(.text+0x16720b): undefined reference to rfkill_unregister' drivers/built-in.o: In function ath_rfkill_poll':
main.c:(.text+0x167801): undefined reference to rfkill_force_state' drivers/built-in.o: In function ath9k_start':
main.c:(.text+0x167f01): undefined reference to rfkill_register' main.c:(.text+0x167f11): undefined reference to rfkill_free' drivers/built-in.o: In function `ath_pci_probe':
main.c:(.text+0x169754): undefined reference to `rfkill_allocate'

when:

CONFIG_RFKILL=m
CONFIG_ATH9K=y

---
 drivers/net/wireless/ath9k/Kconfig |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)
drivers/net/wireless/ath9k/Kconfig +0 -0
index c43bd32..b849a45 100644

drivers/net/wireless/ath9k/Kconfig line 8

Quoted 8 lines
drivers/net/wireless/ath9k/Kconfig +2 -0
@@ -1,6 +1,8 @@
 config ATH9K
       tristate "Atheros 802.11n wireless cards support"
       depends on PCI && MAC80211 && WLAN_80211
+       # build failures
+       depends on 0
       select MAC80211_LEDS
       select LEDS_CLASS
       select NEW_LEDS

OK , I CCed to wireless and lets wait for solution :-)

JSR

#3 lore raw
Quoted 16 lines · Jaswinder Singh Rajput
Quoted 7 lines
drivers/net/wireless/ath9k/Kconfig +0 -0
index c43bd32..b849a45 100644

drivers/net/wireless/ath9k/Kconfig line 8

Quoted 8 lines
drivers/net/wireless/ath9k/Kconfig +2 -0
@@ -1,6 +1,8 @@
 config ATH9K
       tristate "Atheros 802.11n wireless cards support"
       depends on PCI && MAC80211 && WLAN_80211
+       # build failures
+       depends on 0
       select MAC80211_LEDS
       select LEDS_CLASS
       select NEW_LEDS

I thought the proper way to do this was "depends on BROKEN"...

-hpa

#4 lore raw
Quoted 18 lines · H. Peter Anvin
Quoted 16 lines · Jaswinder Singh Rajput
Quoted 7 lines
drivers/net/wireless/ath9k/Kconfig +0 -0
index c43bd32..b849a45 100644

drivers/net/wireless/ath9k/Kconfig line 8

Quoted 8 lines
drivers/net/wireless/ath9k/Kconfig +2 -0
@@ -1,6 +1,8 @@
 config ATH9K
       tristate "Atheros 802.11n wireless cards support"
       depends on PCI && MAC80211 && WLAN_80211
+       # build failures
+       depends on 0
       select MAC80211_LEDS
       select LEDS_CLASS
       select NEW_LEDS
Quoted 1 line

I thought the proper way to do this was "depends on BROKEN"...

this was just a temporary hack to work around a mild regression in -git that i'm sure will be sorted out in short order (if it has not been already).

CONFIG_BROKEN is a much different category: it blacklists ridiculously stale or mortally broken features/drivers, as a last warning before they get removed for good. I dont use it in such temporary, not-for-upstream testing hacks (even though the end result is obviously the same as 'depends on 0') - i didnt even have time to properly report the build breakage.

Ingo

#5 lore raw

PATCH 1/1 ath9k: Enforce module build if rfkill is a module

CONFIG_ATH9K=y results in build issues if CONFIG_RFKILL=m since ath9k does not depend on rfkill in kconfig (i.e., CONFIG_RFKILL is used to select whether to enable rfkill in ath9k), but uses its functions if rfkill is enabled. Enforce ath9k to be build as a module if CONFIG_RFKILL=m to avoid this invalid configuration.

---
 drivers/net/wireless/ath9k/Kconfig |    1 +
 1 file changed, 1 insertion(+)
drivers/net/wireless/ath9k/Kconfig +1 -0
@@ -1,6 +1,7 @@
 config ATH9K
 	tristate "Atheros 802.11n wireless cards support"
 	depends on PCI && MAC80211 && WLAN_80211
+	depends on RFKILL || RFKILL=n
 	select MAC80211_LEDS
 	select LEDS_CLASS
 	select NEW_LEDS
Signature · 1 line
Jouni Malinen                                            PGP id EFC895FA
#6 lore raw

PATCH 1/1 ath9k: Enforce module build if rfkill is a module

Quoted 15 lines · Jouni Malinen

CONFIG_ATH9K=y results in build issues if CONFIG_RFKILL=m since ath9k does not depend on rfkill in kconfig (i.e., CONFIG_RFKILL is used to select whether to enable rfkill in ath9k), but uses its functions if rfkill is enabled. Enforce ath9k to be build as a module if CONFIG_RFKILL=m to avoid this invalid configuration.

---
 drivers/net/wireless/ath9k/Kconfig |    1 +
 1 file changed, 1 insertion(+)

drivers/net/wireless/ath9k/Kconfig line 7

Quoted 7 lines
drivers/net/wireless/ath9k/Kconfig +1 -0
@@ -1,6 +1,7 @@
 config ATH9K
 	tristate "Atheros 802.11n wireless cards support"
 	depends on PCI && MAC80211 && WLAN_80211
+	depends on RFKILL || RFKILL=n
 	select MAC80211_LEDS
 	select LEDS_CLASS
 	select NEW_LEDS

thanks - i'll let you know if there's still any build failures in this area. (Sidenote: next time around please also add a Reported-by line crediting bugreporters. Doesnt matter to me but matters to contributors and testers in general.)

Ingo