Skip to contentSkip to conversation

Marvell Kirkwood family SOC support

PATCH Superseded Prafulla Wadaskar 10 participants 113 messages May 21, 2009 – Jul 23, 2009 1 message not in the archive

Subsystems (8)
lore
Share & tools
lore
#0 lore raw

PATCH v10 1/1 Marvell Kirkwood family SOC support

Kirkwood family controllers are highly integrated SOCs based on Feroceon-88FR131/Sheeva-88SV131 cpu core.

SOC versions supported:-
1) 88F6281-A0 define CONFIG_KW88F6281_A0
2) 88F6192-A0 define CONFIG_KW88F6192_A0

Other supported features:-
1) get_random_hex() fucntion
2) SPI port controller driver
3) PCI Express port initialization

Contributors:
Yotam Admon <[email protected]>
Michael Blostein <michaelbl at marvell.com

---
Change log:
v2: crated arch-kirkwood and moved some header files there renamed and moved spi.c to drivers/spi/
renamed and moved serial.c to drivers/serial/ doimage utility removed
soc_init.S renamed as lowlevel_init.S
debug prints removed

v3: lowlevel_init.S converted to lowlevel_init.c removed BITxx macros, removed entire assembly code Added CONFIG_ARCH_LOWLEVE_INIT support for arm926ejs core updated as per review commens for v2

v4: updated as per review comments for v3 print_cpuinfo used to display Soc info arch_misc_init support created and used for lib_arm mandatory readl/write macros used
asm/cache.h asm/arch/spi.h asm//arch/serial.h created and used

v5: updated as per review comments for v4
cosmetic updates, arch_misc_init and arch_cpu_init used
start.S updated to call arch_lowlevel_init in case if lowlevl_init is skipped bug fix in cpu.c

v6: lowlevel_init.S removed code moved under arch_cpu_init

v7: include <asm/arch/kirkwood.h> added to each c file reference removed from include/asm/config.h arch_misc_init defination kept as it is in include/common.h bugfixed in get_random_hex function

v7.1: u-boot.lds moved from board specific to kirkwood

v8: mpp configuration added
u-boot.lsd and config.mk removed
serial driver removed and used ns16550
register offsets replaced by c struct
updated as per review comments for v7

v9: updated as per v8 review comments
removed all (u32) typecasts
spi driver bugfix and magic constants removed
tabs used for all indentation

v10: struct for nand flash registers added

 cpu/arm926ejs/kirkwood/Makefile           |   49 +++++
 cpu/arm926ejs/kirkwood/cpu.c              |  316 +++++++++++++++++++++++++++++
 cpu/arm926ejs/kirkwood/dram.c             |   58 ++++++
 cpu/arm926ejs/kirkwood/mpp.c              |   80 ++++++++
 cpu/arm926ejs/kirkwood/timer.c            |  168 +++++++++++++++
 drivers/serial/serial.c                   |    3 +
 drivers/spi/Makefile                      |    1 +
 drivers/spi/kirkwood_spi.c                |  185 +++++++++++++++++
 include/asm-arm/arch-kirkwood/cpu.h       |  149 ++++++++++++++
 include/asm-arm/arch-kirkwood/kirkwood.h  |   69 +++++++
 include/asm-arm/arch-kirkwood/kw88f6192.h |   37 ++++
 include/asm-arm/arch-kirkwood/kw88f6281.h |   37 ++++
 include/asm-arm/arch-kirkwood/mpp.h       |  303 +++++++++++++++++++++++++++
 include/asm-arm/arch-kirkwood/spi.h       |   56 +++++
 include/asm-arm/cache.h                   |   41 ++++
 include/common.h                          |    1 +
 lib_arm/board.c                           |    4 +
 17 files changed, 1557 insertions(+), 0 deletions(-)
 create mode 100644 cpu/arm926ejs/kirkwood/Makefile
 create mode 100644 cpu/arm926ejs/kirkwood/cpu.c
 create mode 100644 cpu/arm926ejs/kirkwood/dram.c
 create mode 100644 cpu/arm926ejs/kirkwood/mpp.c
 create mode 100644 cpu/arm926ejs/kirkwood/timer.c
 create mode 100644 drivers/spi/kirkwood_spi.c
 create mode 100644 include/asm-arm/arch-kirkwood/cpu.h
 create mode 100644 include/asm-arm/arch-kirkwood/kirkwood.h
 create mode 100644 include/asm-arm/arch-kirkwood/kw88f6192.h
 create mode 100644 include/asm-arm/arch-kirkwood/kw88f6281.h
 create mode 100644 include/asm-arm/arch-kirkwood/mpp.h
 create mode 100644 include/asm-arm/arch-kirkwood/spi.h
 create mode 100644 include/asm-arm/cache.h
cpu/arm926ejs/kirkwood/Makefile new file +49 -0
new file mode 100644
index 0000000..b966ea1
@@ -0,0 +1,49 @@
+#
+# (C) Copyright 2009
+# Marvell Semiconductor <www.marvell.com>
+# Prafulla Wadaskar <[email protected]>
+#
+# See file CREDITS for list of people who contributed to this
+# project.
+#
+# This program is free software; you can redistribute it and/or
+# modify it under the terms of the GNU General Public License as
+# published by the Free Software Foundation; either version 2 of
+# the License, or (at your option) any later version.
+#
+# This program is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU General Public License
+# along with this program; if not, write to the Free Software
+# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston,
+# MA 02110-1301 USA
+#
+
+include $(TOPDIR)/config.mk
+
+LIB	= $(obj)lib$(SOC).a
+
+COBJS-y	= dram.o
+COBJS-y	+= cpu.o
+COBJS-y	+= mpp.o
+COBJS-y	+= timer.o
+
+SRCS	:= $(SOBJS:.o=.S) $(COBJS-y:.o=.c)
+OBJS	:= $(addprefix $(obj),$(SOBJS) $(COBJS-y))
+
+all:	$(obj).depend $(LIB)
+
+$(LIB):	$(OBJS)
+	$(AR) $(ARFLAGS) $@ $(OBJS)
+
+#########################################################################
+
+# defines $(obj).depend target
+include $(SRCTREE)/rules.mk
+
+sinclude $(obj).depend
+
+#########################################################################
cpu/arm926ejs/kirkwood/cpu.c new file +316 -0

316 lines not on this page · raw message

cpu/arm926ejs/kirkwood/dram.c new file +58 -0

58 lines not on this page · raw message

cpu/arm926ejs/kirkwood/mpp.c new file +80 -0

80 lines not on this page · raw message

cpu/arm926ejs/kirkwood/timer.c new file +168 -0

168 lines not on this page · raw message

drivers/serial/serial.c +3 -0
index 966df9a..dd5f332 100644
@@ -27,6 +27,9 @@
 #ifdef CONFIG_NS87308
 #include <ns87308.h>
 #endif
+#ifdef CONFIG_KIRKWOOD
+#include <asm/arch/kirkwood.h>
+#endif
 
 #if defined (CONFIG_SERIAL_MULTI)
 #include <serial.h>
drivers/spi/Makefile +1 -0
index 1350f3e..7ffa47d 100644
@@ -28,6 +28,7 @@ LIB	:= $(obj)libspi.a
 COBJS-$(CONFIG_ATMEL_DATAFLASH_SPI) += atmel_dataflash_spi.o
 COBJS-$(CONFIG_ATMEL_SPI) += atmel_spi.o
 COBJS-$(CONFIG_BFIN_SPI) += bfin_spi.o
+COBJS-$(CONFIG_KIRKWOOD_SPI) += kirkwood_spi.o
 COBJS-$(CONFIG_MPC8XXX_SPI) += mpc8xxx_spi.o
 COBJS-$(CONFIG_MXC_SPI) += mxc_spi.o
 COBJS-$(CONFIG_SOFT_SPI) += soft_spi.o
drivers/spi/kirkwood_spi.c new file +185 -0

185 lines not on this page · raw message

include/asm-arm/arch-kirkwood/cpu.h new file +149 -0

149 lines not on this page · raw message

include/asm-arm/arch-kirkwood/kirkwood.h new file +69 -0

69 lines not on this page · raw message

include/asm-arm/arch-kirkwood/kw88f6192.h new file +37 -0
new file mode 100644
index 0000000..a2b1f96
@@ -0,0 +1,37 @@
+/*
+ * (C) Copyright 2009
+ * Marvell Semiconductor <www.marvell.com>
+ * Prafulla Wadaskar <[email protected]>
+ *
+ * Header file for Feroceon CPU core 88FR131 Based KW88F6192 SOC.
+ *
+ * See file CREDITS for list of people who contributed to this
+ * project.
+ *
+ * This program is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU General Public License as
+ * published by the Free Software Foundation; either version 2 of
+ * the License, or (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program; if not, write to the Free Software
+ * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston,
+ * MA 02110-1301 USA
+ */
+
+#ifndef _CONFIG_KW88F6192_H
+#define _CONFIG_KW88F6192_H
+
+/* SOC specific definations */
+#define KW88F6192_REGS_PHYS_BASE	0xf1000000
+#define KW_REGS_PHY_BASE		KW88F6192_REGS_PHYS_BASE
+
+/* TCLK Core Clock defination */
+#define CONFIG_SYS_TCLK	  166000000 /* 166MHz */
+
+#endif /* _CONFIG_KW88F6192_H */
include/asm-arm/arch-kirkwood/kw88f6281.h new file +37 -0
new file mode 100644
index 0000000..9b89b93
@@ -0,0 +1,37 @@
+/*
+ * (C) Copyright 2009
+ * Marvell Semiconductor <www.marvell.com>
+ * Prafulla Wadaskar <[email protected]>
+ *
+ * Header file for Feroceon CPU core 88FR131 Based KW88F6281 SOC.
+ *
+ * See file CREDITS for list of people who contributed to this
+ * project.
+ *
+ * This program is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU General Public License as
+ * published by the Free Software Foundation; either version 2 of
+ * the License, or (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program; if not, write to the Free Software
+ * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston,
+ * MA 02110-1301 USA
+ */
+
+#ifndef _ASM_ARCH_KW88F6281_H
+#define _ASM_ARCH_KW88F6281_H
+
+/* SOC specific definations */
+#define KW88F6281_REGS_PHYS_BASE	0xf1000000
+#define KW_REGS_PHY_BASE		KW88F6281_REGS_PHYS_BASE
+
+/* TCLK Core Clock defination*/
+#define CONFIG_SYS_TCLK	  200000000 /* 200MHz */
+
+#endif /* _ASM_ARCH_KW88F6281_H */
include/asm-arm/arch-kirkwood/mpp.h new file +303 -0

303 lines not on this page · raw message

include/asm-arm/arch-kirkwood/spi.h new file +56 -0

56 lines not on this page · raw message

include/asm-arm/cache.h new file +41 -0

41 lines not on this page · raw message

include/common.h +1 -0
index 30fff7d..9e4b859 100644
@@ -294,6 +294,7 @@ void	pciinfo	      (int, int);
 #endif
 #endif
 
+int	arch_misc_init (void);
 int	misc_init_f   (void);
 int	misc_init_r   (void);
 
lib_arm/board.c +4 -0
index e081fbc..5c3bfec 100644
@@ -399,6 +399,10 @@ void start_armboot (void)
 
 	console_init_r ();	/* fully init console as a device */
 
+#if defined(CONFIG_ARCH_MISC_INIT)
+	/* miscellaneous arch dependent initialisations */
+	arch_misc_init ();
+#endif
 #if defined(CONFIG_MISC_INIT_R)
 	/* miscellaneous platform dependent initialisations */
 	misc_init_r ();
Signature · 1 line
1.5.3.3
#1 lore raw

PATCH 1/1 Marvell Sheevaplug Board support

References: http://plugcomputer.org/
Serial console Setup
http://openplug.org/plugwiki/index.php/Serial_terminal_program#Linux
OpenOCD Setup
http://openplug.org/plugwiki/index.php/Setting_Up_OpenOCD_Under_Linux

This patch is tested for-
1. Boot from DRAM/NAND flash
2. File transfer using tftp
3. NAND flash read/write/erase

---
 MAKEALL                               |    1 +
 Makefile                              |    8 +-
 board/Marvell/sheevaplug/Makefile     |   52 +++++++++
 board/Marvell/sheevaplug/config.mk    |   25 +++++
 board/Marvell/sheevaplug/nand.c       |   80 ++++++++++++++
 board/Marvell/sheevaplug/sheevaplug.c |  135 +++++++++++++++++++++++
 board/Marvell/sheevaplug/sheevaplug.h |   37 +++++++
 include/configs/sheevaplug.h          |  191 +++++++++++++++++++++++++++++++++
 8 files changed, 526 insertions(+), 3 deletions(-)
 create mode 100644 board/Marvell/sheevaplug/Makefile
 create mode 100644 board/Marvell/sheevaplug/config.mk
 create mode 100644 board/Marvell/sheevaplug/nand.c
 create mode 100644 board/Marvell/sheevaplug/sheevaplug.c
 create mode 100644 board/Marvell/sheevaplug/sheevaplug.h
 create mode 100644 include/configs/sheevaplug.h
MAKEALL +1 -0
index 6719d7b..e3d33cb 100755
@@ -144,6 +144,7 @@ LIST_8xx="		\
 	RPXlite		\
 	RPXlite_DW	\
 	RRvision	\
+	sheevaplug	\
 	SM850		\
 	spc1920		\
 	SPD823TS	\
Makefile +5 -3
index 8144ecd..34a863b 100644
@@ -1122,6 +1122,9 @@ RRvision_LCD_config:	unconfig
 	@echo "#define CONFIG_SHARP_LQ104V7DS01" >>$(obj)include/config.h
 	@$(MKCONFIG) -a RRvision ppc mpc8xx RRvision
 
+sheevaplug_config: unconfig
+	@$(MKCONFIG) $(@:_config=) arm arm926ejs $(@:_config=) Marvell kirkwood
+
 SM850_config	:	unconfig
 	@$(MKCONFIG) $(@:_config=) ppc mpc8xx tqm8xx tqc
 
@@ -2808,9 +2811,6 @@ lpd7a400_config \
 lpd7a404_config:	unconfig
 	@$(MKCONFIG) $(@:_config=) arm lh7a40x lpd7a40x
 
-mv88f6281gtw_ge_config: unconfig
-	@$(MKCONFIG) $(@:_config=) arm arm926ejs $(@:_config=) Marvell kirkwood
-
 mx1ads_config	:	unconfig
 	@$(MKCONFIG) $(@:_config=) arm arm920t mx1ads NULL imx
 
@@ -3110,6 +3110,8 @@ omap2420h4_config	: unconfig
 qong_config		: unconfig
 	@$(MKCONFIG) $(@:_config=) arm arm1136 qong davedenx mx31
 
+sheevapluge_config: unconfig
+	@$(MKCONFIG) $(@:_config=) arm arm926ejs $(@:_config=) Marvell kirkwood
 
 #########################################################################
 ## ARM1176 Systems
board/Marvell/sheevaplug/Makefile new file +52 -0

52 lines not on this page · raw message

board/Marvell/sheevaplug/config.mk new file +25 -0
new file mode 100644
index 0000000..fb29a1b
@@ -0,0 +1,25 @@
+#
+# (C) Copyright 2009
+# Marvell Semiconductor <www.marvell.com>
+# Prafulla Wadaskar <[email protected]>
+#
+# See file CREDITS for list of people who contributed to this
+# project.
+#
+# This program is free software; you can redistribute it and/or
+# modify it under the terms of the GNU General Public License as
+# published by the Free Software Foundation; either version 2 of
+# the License, or (at your option) any later version.
+#
+# This program is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU General Public License
+# along with this program; if not, write to the Free Software
+# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston,
+# MA 02110-1301 USA
+#
+
+TEXT_BASE = 0x00600000
board/Marvell/sheevaplug/nand.c new file +80 -0

80 lines not on this page · raw message

board/Marvell/sheevaplug/sheevaplug.c new file +135 -0

135 lines not on this page · raw message

board/Marvell/sheevaplug/sheevaplug.h new file +37 -0
new file mode 100644
index 0000000..45bfeca
@@ -0,0 +1,37 @@
+/*
+ * (C) Copyright 2009
+ * Marvell Semiconductor <www.marvell.com>
+ * Prafulla Wadaskar <[email protected]>
+ *
+ * See file CREDITS for list of people who contributed to this
+ * project.
+ *
+ * This program is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU General Public License as
+ * published by the Free Software Foundation; either version 2 of
+ * the License, or (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program; if not, write to the Free Software
+ * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston,
+ * MA 02110-1301 USA
+ */
+
+#ifndef __SHEEVAPLUG_H
+#define __SHEEVAPLUG_H
+
+#ifndef MACH_TYPE_SHEEVAPLUG
+#define MACH_TYPE_SHEEVAPLUG	2097
+#endif
+
+#define SHEEVAPLUG_OE_LOW		(~(0))
+#define SHEEVAPLUG_OE_HIGH		(~(0))
+#define SHEEVAPLUG_OE_VAL_LOW		(1 << 29)	/* USB_PWEN low */
+#define SHEEVAPLUG_OE_VAL_HIGH		(1 << 17)	/* LED pin high */
+
+#endif /* __SHEEVAPLUG_H */
include/configs/sheevaplug.h new file +191 -0

191 lines not on this page · raw message

Signature · 1 line
1.5.3.3
#2 lore raw

PATCH 1/1 Marvell MV88E1116 PHY Driver support

Suports Basic PHY init (i.e. PHY reset)
optional supported configurations:
led_init, mdipn_reverse, rgmii_delay config

This driver is tested with sheevaplug board

---
 drivers/net/phy/Makefile    |    1 +
 drivers/net/phy/mv88e1116.c |   90 +++++++++++++++++++++++++++++++++++++++++++
 drivers/net/phy/mv88e1116.h |   38 ++++++++++++++++++
 include/netdev.h            |   31 +++++++++++++++
 4 files changed, 160 insertions(+), 0 deletions(-)
 create mode 100644 drivers/net/phy/mv88e1116.c
 create mode 100644 drivers/net/phy/mv88e1116.h
drivers/net/phy/Makefile +1 -0
index 3b92614..ed624b4 100644
@@ -26,6 +26,7 @@ include $(TOPDIR)/config.mk
 LIB	:= $(obj)libphy.a
 
 COBJS-$(CONFIG_BITBANGMII) += miiphybb.o
+COBJS-$(CONFIG_MV88E1116_PHY) += mv88e1116.o
 COBJS-$(CONFIG_MV88E61XX_SWITCH) += mv88e61xx.o
 
 COBJS	:= $(COBJS-y)
drivers/net/phy/mv88e1116.c new file +90 -0

90 lines not on this page · raw message

drivers/net/phy/mv88e1116.h new file +38 -0
new file mode 100644
index 0000000..b12be22
@@ -0,0 +1,38 @@
+/*
+ * (C) Copyright 2009
+ * Marvell Semiconductor <www.marvell.com>
+ * Prafulla Wadaskar <[email protected]>
+ *
+ * See file CREDITS for list of people who contributed to this
+ * project.
+ *
+ * This program is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU General Public License as
+ * published by the Free Software Foundation; either version 2 of
+ * the License, or (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program; if not, write to the Free Software
+ * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston,
+ * MA 02110-1301 USA
+ */
+
+#ifndef _MV88E1116_H
+#define _MV88E1116_H
+
+#include <miiphy.h>
+
+#define MV88E1116_LED_FCTRL_REG		10
+#define MV88E1116_CPRSP_CR3_REG		21
+#define MV88E1116_MAC_CTRL_REG		21
+#define MV88E1116_PGADR_REG		22
+
+#define MV88E1116_RGMII_TXTM_CTRL	(1 << 4)
+#define MV88E1116_RGMII_RXTM_CTRL	(1 << 5)
+
+#endif /* _MV88E1116_H */
include/netdev.h +31 -0
index 4f2b23a..f37b6ae 100644
@@ -163,4 +163,35 @@ struct mv88e61xx_config {
 int mv88e61xx_switch_initialize(struct mv88e61xx_config *swconfig);
 #endif /* CONFIG_MV88E61XX_SWITCH */
 
+/*
+ * Boards with mv88e1116 PHY can use this by defining
+ * CONFIG_MV88E1116_PHY in respective board config header file
+ * the stuct and enums here are used to specify switch config params
+ */
+#if defined(CONFIG_MV88E1116_PHY)
+enum mv88e1116_cfg_mdip {
+	MV88E1116_MDIP_NOCHANGE,
+	MV88E1116_MDIP_REVERSE
+};
+
+enum mv88e1116_cfg_ledinit {
+	MV88E1116_LED_INIT_DIS,
+	MV88E1116_LED_INIT_EN
+};
+
+enum mv88e1116_cfg_rgmiid {
+	MV88E1116_RGMII_DELAY_DIS,
+	MV88E1116_RGMII_DELAY_EN
+};
+
+struct mv88e1116_config {
+	char *name;
+	enum mv88e1116_cfg_rgmiid rgmii_delay;
+	enum mv88e1116_cfg_ledinit led_init;
+	enum mv88e1116_cfg_mdip mdip;
+};
+
+int mv88e1116_phy_initialize(struct mv88e1116_config *phycfg);
+#endif /* CONFIG_MV88E1116_PHY */
+
 #endif /* _NETDEV_H_ */
Signature · 1 line
1.5.3.3
#3 lore raw

PATCH v4 1/1 Gbe Controller driver support for kirkwood SOCs

Contributors:
Yotam Admon <[email protected]>
Michael Blostein <michaelbl at marvell.com

Reviewed by: Ronen Shitrit <[email protected]>

---
Change log:
v2: entire rewrite/restructure of v1
used small names for variable/function names readl/writel used to access SoC registers
Soc registers accssed using pointers through net device struct miiphy registration done for external smi read/write access miiphy_link used to detect phy link presence
cleaned for cosmetic changes

v3: asm/arch/kirkwood.h included in c file

v4: bugfix for phy address read

 cpu/arm926ejs/kirkwood/cpu.c |    8 +
 drivers/net/Makefile         |    1 +
 drivers/net/kirkwood_egiga.c | 1670 ++++++++++++++++++++++++++++++++++++++++++
 drivers/net/kirkwood_egiga.h |  828 +++++++++++++++++++++
 include/netdev.h             |    1 +
 5 files changed, 2508 insertions(+), 0 deletions(-)
 create mode 100644 drivers/net/kirkwood_egiga.c
 create mode 100644 drivers/net/kirkwood_egiga.h
cpu/arm926ejs/kirkwood/cpu.c +8 -0
index 1286cac..d37c2e2 100644
@@ -314,3 +314,11 @@ int arch_misc_init(void)
 	return 0;
 }
 #endif /* CONFIG_ARCH_MISC_INIT */
+
+#ifdef CONFIG_KIRKWOOD_EGIGA
+int cpu_eth_init(bd_t *bis)
+{
+	kirkwood_egiga_initialize(bis);
+	return 0;
+}
+#endif
drivers/net/Makefile +1 -0
index a360a50..f0c5654 100644
@@ -40,6 +40,7 @@ COBJS-$(CONFIG_ENC28J60) += enc28j60.o
 COBJS-$(CONFIG_FSLDMAFEC) += fsl_mcdmafec.o mcfmii.o
 COBJS-$(CONFIG_GRETH) += greth.o
 COBJS-$(CONFIG_INCA_IP_SWITCH) += inca-ip_sw.o
+COBJS-$(CONFIG_KIRKWOOD_EGIGA) += kirkwood_egiga.o
 COBJS-$(CONFIG_DRIVER_KS8695ETH) += ks8695eth.o
 COBJS-$(CONFIG_DRIVER_LAN91C96) += lan91c96.o
 COBJS-$(CONFIG_MACB) += macb.o
drivers/net/kirkwood_egiga.c new file +1670 -0

1,670 lines not on this page · raw message

drivers/net/kirkwood_egiga.h new file +828 -0

828 lines not on this page · raw message

include/netdev.h +1 -0
index f37b6ae..3a59f4e 100644
@@ -52,6 +52,7 @@ int fec_initialize (bd_t *bis);
 int greth_initialize(bd_t *bis);
 void gt6426x_eth_initialize(bd_t *bis);
 int inca_switch_initialize(bd_t *bis);
+int kirkwood_egiga_initialize(bd_t *bis);
 int macb_eth_initialize(int id, void *regs, unsigned int phy_addr);
 int mcdmafec_initialize(bd_t *bis);
 int mcffec_initialize(bd_t *bis);
Signature · 1 line
1.5.3.3
#4 lore raw

PATCH v4 1/1 Gbe Controller driver support for kirkwood SOCs

Hi Prafulla,

Quoted 36 lines · Prafulla Wadaskar

Contributors:
Yotam Admon <[email protected]>
Michael Blostein <[email protected]

Reviewed by: Ronen Shitrit <[email protected]>

---
Change log:
v2: entire rewrite/restructure of v1
used small names for variable/function names readl/writel used to access SoC registers
Soc registers accssed using pointers through net device struct miiphy registration done for external smi read/write access miiphy_link used to detect phy link presence
cleaned for cosmetic changes

v3: asm/arch/kirkwood.h included in c file

v4: bugfix for phy address read

 cpu/arm926ejs/kirkwood/cpu.c |    8 +
 drivers/net/Makefile         |    1 +
 drivers/net/kirkwood_egiga.c | 1670 ++++++++++++++++++++++++++++++++++++++++++
 drivers/net/kirkwood_egiga.h |  828 +++++++++++++++++++++
 include/netdev.h             |    1 +
 5 files changed, 2508 insertions(+), 0 deletions(-)
 create mode 100644 drivers/net/kirkwood_egiga.c
 create mode 100644 drivers/net/kirkwood_egiga.h
cpu/arm926ejs/kirkwood/cpu.c +0 -0
index 1286cac..d37c2e2 100644
@@ -314,3 +314,11 @@ int arch_misc_init(void)
 	return 0;

cpu/arm926ejs/kirkwood/cpu.c int arch_misc_init(void) · line 324

Quoted 10 lines
cpu/arm926ejs/kirkwood/cpu.c +8 -0
 }
 #endif /* CONFIG_ARCH_MISC_INIT */
+
+#ifdef CONFIG_KIRKWOOD_EGIGA
+int cpu_eth_init(bd_t *bis)
+{
+	kirkwood_egiga_initialize(bis);
+	return 0;
+}
+#endif

Please move this part (cpu.c) to a different patch. This one should only include the driver itself, and I can't apply it since the cpu.c file doesn't exist yet...

I don't have any technical problems with this patch, but please consider the following:

1. Statistics are great to have, but most people won't look at them and all the associated logic makes the driver very big. Please conditionally compile that stuff in.

2. Please ensure that all lines are <= 78 characters long (80 minus the initial character that diff puts in)

regards,
Ben

#5 lore raw

PATCH v4 1/1 Gbe Controller driver support for kirkwood SOCs

Hi Ben

Thanks...

Quoted 12 lines
Quoted 12 lines
(quoted diff) +0 -0

b/cpu/arm926ejs/kirkwood/cpu.c index 1286cac..d37c2e2 100644

cpu/arm926ejs/kirkwood/cpu.c +4 -0
@@ -314,3 +314,11 @@ int arch_misc_init(void)
 	return 0;
 }
 #endif /* CONFIG_ARCH_MISC_INIT */
+
+#ifdef CONFIG_KIRKWOOD_EGIGA
+int cpu_eth_init(bd_t *bis)
+{
Quoted 8 lines

cpu/arm926ejs/kirkwood/cpu.c int arch_misc_init(void) · line 324

Quoted 5 lines
cpu/arm926ejs/kirkwood/cpu.c +4 -0
+	kirkwood_egiga_initialize(bis);
+	return 0;
+}
+#endif

Please move this part (cpu.c) to a different patch. This one should only include the driver itself, and I can't apply it since the cpu.c file doesn't exist yet...

Cool..I will provide separate Kirwood SOC Support patch for this

Quoted 6 lines

I don't have any technical problems with this patch, but please consider the following:

1. Statistics are great to have, but most people won't look at them and all the associated logic makes the driver very

As I said earlier I am removing this stuff, this will make code smaller

Quoted 1 line

big. Please conditionally compile that stuff in.

Probably in latter phase I will submit a patch to support statistics

Quoted 3 lines

2. Please ensure that all lines are <= 78 characters long (80 minus the initial character that diff puts in)

Yes. this was a problem with Wolfgang(I think) some lines in the code are 79/80 chars long I will correct them.

Regards..
Prafulla . .

#6 lore raw

PATCH v4 1/1 Gbe Controller driver support for kirkwood SOCs

In reply to Prafulla Wadaskar

Hi Prafulla,

Quoted 6 lines · On Thursday 21 May 2009 22:24:32 Prafulla Wadaskar wrote:

Contributors:
Yotam Admon <[email protected]>
Michael Blostein <[email protected]

Reviewed by: Ronen Shitrit <[email protected]>

Quoted 9 lines

---
Change log:
v2: entire rewrite/restructure of v1
used small names for variable/function names readl/writel used to access SoC registers
Soc registers accssed using pointers through net device struct miiphy registration done for external smi read/write access miiphy_link used to detect phy link presence
cleaned for cosmetic changes

Please find a comment below.

Quoted 37 lines
drivers/net/kirkwood_egiga.h new file +31 -0
new file mode 100644
index 0000000..9f3908e
@@ -0,0 +1,828 @@
+/*
+ * (C) Copyright 2009
+ * Marvell Semiconductor <www.marvell.com>
+ * Prafulla Wadaskar <[email protected]>
+ *
+ * based on - Driver for MV64360X ethernet ports
+ * Copyright (C) 2002 rabeeh at galileo.co.il
+ *
+ * See file CREDITS for list of people who contributed to this
+ * project.
+ *
+ * This program is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU General Public License as
+ * published by the Free Software Foundation; either version 2 of
+ * the License, or (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program; if not, write to the Free Software
+ * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston,
+ * MA 02110-1301 USA
+ */
+
+#ifndef __EGIGA_H__
+#define __EGIGA_H__
+
+#define MAX_KWGBE_DEVS	2	/*controller has two ports */

<snip>

drivers/net/kirkwood_egiga.h line 337

Quoted 11 lines
drivers/net/kirkwood_egiga.h new file +11 -0
+/* Default port serial control value */
+#define PORT_SERIAL_CONTROL_VALUE_TMP		  \
+	KWGBE_FORCE_LINK_PASS			| \
+	KWGBE_DIS_AUTO_NEG_FOR_DUPLX		| \
+	KWGBE_DIS_AUTO_NEG_FOR_FLOW_CTRL	| \
+	KWGBE_ADV_NO_FLOW_CTRL			| \
+	KWGBE_FORCE_FC_MODE_NO_PAUSE_DIS_TX	| \
+	KWGBE_FORCE_BP_MODE_NO_JAM		| \
+	(1 << 9)					| \
+	KWGBE_DO_NOT_FORCE_LINK_FAIL		| \
+	KWGBE_DIS_AUTO_NEG_SPEED_GMII		| \

You disable speed auto-negotiation here. Why are you doing this? Using auto- negotiation should be the default operation mode from my point of view.

Quoted 8 lines
drivers/net/kirkwood_egiga.h new file +8 -0
+	KWGBE_DTE_ADV_0				| \
+	KWGBE_MIIPHY_MAC_MODE			| \
+	KWGBE_AUTO_NEG_NO_CHANGE			| \
+	KWGBE_MAX_RX_PACKET_1552BYTE		| \
+	KWGBE_CLR_EXT_LOOPBACK			| \
+	KWGBE_SET_FULL_DUPLEX_MODE		| \
+	KWGBE_DIS_FLOW_CTRL_TX_RX_IN_FULL_DUPLEX | \
+	KWGBE_SET_MII_SPEED_TO_100

drivers/net/kirkwood_egiga.h line 355

Quoted 10 lines
drivers/net/kirkwood_egiga.h new file +10 -0
+
+#ifdef CONFIG_SYS_MII_MODE
+#define PORT_SERIAL_CONTROL_VALUE	\
+	PORT_SERIAL_CONTROL_VALUE_TMP |	\
+	KWGBE_SET_GMII_SPEED_TO_10_100
+#else
+#define PORT_SERIAL_CONTROL_VALUE	\
+	PORT_SERIAL_CONTROL_VALUE_TMP |	\
+	KWGBE_SET_GMII_SPEED_TO_1000
+#endif

If you need a fixed link speed configuration we should perhaps add a configuration option for this. What do you think?

Best regards,
Stefan

=====================================================================
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: office at denx.de
=====================================================================

#7 lore raw

PATCH v4 1/1 Gbe Controller driver support for kirkwood SOCs

Thanks a lot Stefan for your review feedback... You are thinking more similar to Linux Implementation :-)

I will try to address your suggestions, it provides more flexibility and readability. On the other hand I am currently putting my efforts to reduce patch size cutting some features. I will do it step-by-step.

Regards..
Prafulla . . .

Quoted 119 lines

-----Original Message-----
From: Stefan Roese [mailto:sr at denx.de]
Sent: Tuesday, May 26, 2009 8:26 PM
To: u-boot at lists.denx.de
Cc: Prafulla Wadaskar; Manas Saksena; Ronen Shitrit; Nicolas Pitre; Ashish Karkare; Prabhanjan Sarnaik; Lennert Buijtenhek
Subject: Re: [U-Boot] [PATCH v4] Gbe Controller driver support for kirkwood SOCs

Hi Prafulla,

Quoted 11 lines · On Thursday 21 May 2009 22:24:32 Prafulla Wadaskar wrote:

Contributors:
Yotam Admon <[email protected]>
Michael Blostein <[email protected]

Reviewed by: Ronen Shitrit <[email protected]>

---
Change log:
v2: entire rewrite/restructure of v1
used small names for variable/function names readl/writel used to access SoC registers Soc registers accssed using pointers

through net

Quoted 3 lines

device struct miiphy registration done for external smi read/write access miiphy_link used to detect phy link presence cleaned for cosmetic changes

Please find a comment below.

Quoted 18 lines
(quoted diff) +0 -0

b/drivers/net/kirkwood_egiga.h new file mode 100644 index 0000000..9f3908e

drivers/net/kirkwood_egiga.h new file +12 -0
@@ -0,0 +1,828 @@
+/*
+ * (C) Copyright 2009
+ * Marvell Semiconductor <www.marvell.com>
+ * Prafulla Wadaskar <[email protected]>
+ *
+ * based on - Driver for MV64360X ethernet ports
+ * Copyright (C) 2002 rabeeh at galileo.co.il
+ *
+ * See file CREDITS for list of people who contributed to this
+ * project.
+ *
+ * This program is free software; you can redistribute it and/or

drivers/net/kirkwood_egiga.h line 22

Quoted 10 lines
drivers/net/kirkwood_egiga.h new file +10 -0
+ * modify it under the terms of the GNU General Public License as
+ * published by the Free Software Foundation; either version 2 of
+ * the License, or (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General 

Public License

Quoted 9 lines
drivers/net/kirkwood_egiga.h new file +9 -0
+ * along with this program; if not, write to the Free Software
+ * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston,
+ * MA 02110-1301 USA
+ */
+
+#ifndef __EGIGA_H__
+#define __EGIGA_H__
+
+#define MAX_KWGBE_DEVS	2	/*controller has two ports */

<snip>

drivers/net/kirkwood_egiga.h line 337

Quoted 11 lines
drivers/net/kirkwood_egiga.h new file +11 -0
+/* Default port serial control value */
+#define PORT_SERIAL_CONTROL_VALUE_TMP		  \
+	KWGBE_FORCE_LINK_PASS			| \
+	KWGBE_DIS_AUTO_NEG_FOR_DUPLX		| \
+	KWGBE_DIS_AUTO_NEG_FOR_FLOW_CTRL	| \
+	KWGBE_ADV_NO_FLOW_CTRL			| \
+	KWGBE_FORCE_FC_MODE_NO_PAUSE_DIS_TX	| \
+	KWGBE_FORCE_BP_MODE_NO_JAM		| \
+	(1 << 9)					| \
+	KWGBE_DO_NOT_FORCE_LINK_FAIL		| \
+	KWGBE_DIS_AUTO_NEG_SPEED_GMII		| \

You disable speed auto-negotiation here. Why are you doing this? Using auto- negotiation should be the default operation mode from my point of view.

Quoted 8 lines
drivers/net/kirkwood_egiga.h new file +8 -0
+	KWGBE_DTE_ADV_0				| \
+	KWGBE_MIIPHY_MAC_MODE			| \
+	KWGBE_AUTO_NEG_NO_CHANGE			| \
+	KWGBE_MAX_RX_PACKET_1552BYTE		| \
+	KWGBE_CLR_EXT_LOOPBACK			| \
+	KWGBE_SET_FULL_DUPLEX_MODE		| \
+	KWGBE_DIS_FLOW_CTRL_TX_RX_IN_FULL_DUPLEX | \
+	KWGBE_SET_MII_SPEED_TO_100

drivers/net/kirkwood_egiga.h line 355

Quoted 10 lines
drivers/net/kirkwood_egiga.h new file +10 -0
+
+#ifdef CONFIG_SYS_MII_MODE
+#define PORT_SERIAL_CONTROL_VALUE	\
+	PORT_SERIAL_CONTROL_VALUE_TMP |	\
+	KWGBE_SET_GMII_SPEED_TO_10_100
+#else
+#define PORT_SERIAL_CONTROL_VALUE	\
+	PORT_SERIAL_CONTROL_VALUE_TMP |	\
+	KWGBE_SET_GMII_SPEED_TO_1000
+#endif

If you need a fixed link speed configuration we should perhaps add a configuration option for this. What do you think?

Best regards,
Stefan

=====================================================================
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email:
office at denx.de
=====================================================================

#8 lore raw

PATCH v4 1/1 Gbe Controller driver support for kirkwood SOCs

Quoted 6 lines · On Wednesday 27 May 2009 07:26:13 Prafulla Wadaskar wrote:

Thanks a lot Stefan for your review feedback... You are thinking more similar to Linux Implementation :-)

I will try to address your suggestions, it provides more flexibility and readability. On the other hand I am currently putting my efforts to reduce patch size cutting some features. I will do it step-by-step.

Understood. We can always fine-tune the code after it's accepted upstream. So please add my:

Thanks.

Best regards,
Stefan

=====================================================================
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: office at denx.de
=====================================================================

A message that is not in the archive (sent off-list or not yet received): [email protected]

#10 lore raw

PATCH 1/1 Marvell MV88E1116 PHY Driver support

Hi Prafulla,

Quoted 4 lines · Prafulla Wadaskar

Hi Ben
Thanks for accepting MV88E61xx driver code.
Ping for mv88f1116 driver....... :-)
This is dependency for sheevaplug board support.

I've already commented on this one. We don't currently have a framework for PHYs and I don't want to add PHY support ad-hoc. For now, PHY support needs to go in whatever ethernet driver uses it.

regards,
Ben

#11 lore raw

PATCH 1/1 Marvell MV88E1116 PHY Driver support

Quoted 19 lines

-----Original Message-----
From: Ben Warren [mailto:biggerbadderben at gmail.com]
Sent: Saturday, May 30, 2009 9:36 PM
To: Prafulla Wadaskar
Cc: u-boot at lists.denx.de
Subject: Re: [PATCH] Marvell MV88E1116 PHY Driver support

Hi Prafulla,

On Fri, May 29, 2009 at 11:34 PM, Prafulla Wadaskar <[email protected]> wrote:

Hi Ben
Thanks for accepting MV88E61xx driver code. Ping for mv88f1116 driver....... :-) This is dependency for sheevaplug board support.

Quoted 4 lines

I've already commented on this one. We don't currently have a framework for PHYs and I don't want to add PHY support ad-hoc. For now, PHY support needs to go in whatever ethernet driver uses it.

Hi Ben

Don't you think keeping phy support in Ethernet driver will harm to keep it's generic approach? through development and reviews we always try to keep any driver generic so that it can be used by others.

As of now apart from switch mv88e61xx, there is no phy support in driver/net/phy/. Being this first one- May I take this opportunity to help you to create a framework for PHYs?

Regards..
Prafulla . .

Quoted 3 lines

regards,
Ben

#12 lore raw

PATCH 1/1 Marvell Sheevaplug Board support

In reply to Prafulla Wadaskar

Hi Prafulla,

Quoted 21 lines · On Thursday 21 May 2009 22:24:30 Prafulla Wadaskar wrote:

References: http://plugcomputer.org/
Serial console Setup
http://openplug.org/plugwiki/index.php/Serial_terminal_program#Linux
OpenOCD Setup
http://openplug.org/plugwiki/index.php/Setting_Up_OpenOCD_Under_Linux

This patch is tested for-
1. Boot from DRAM/NAND flash
2. File transfer using tftp
3. NAND flash read/write/erase

---
 MAKEALL                               |    1 +
 Makefile                              |    8 +-
 board/Marvell/sheevaplug/Makefile     |   52 +++++++++
 board/Marvell/sheevaplug/config.mk    |   25 +++++
 board/Marvell/sheevaplug/nand.c       |   80 ++++++++++++++
 board/Marvell/sheevaplug/sheevaplug.c |  135 +++++++++++++++++++++++
 board/Marvell/sheevaplug/sheevaplug.h |   37 +++++++
 include/configs/sheevaplug.h          |  191
Quoted 8 lines

+++++++++++++++++++++++++++++++++ 8 files changed, 526 insertions(+), 3 deletions(-)

 create mode 100644 board/Marvell/sheevaplug/Makefile
 create mode 100644 board/Marvell/sheevaplug/config.mk
 create mode 100644 board/Marvell/sheevaplug/nand.c
 create mode 100644 board/Marvell/sheevaplug/sheevaplug.c
 create mode 100644 board/Marvell/sheevaplug/sheevaplug.h
 create mode 100644 include/configs/sheevaplug.h

You didn't add a maintainer for this new board to MAINTAINERS. Please add this in your next patch version. And for the MV88F6281GTW_GE board as well.

Quoted 27 lines
MAKEALL +1 -0
index 6719d7b..e3d33cb 100755
@@ -144,6 +144,7 @@ LIST_8xx="		\
 	RPXlite		\
 	RPXlite_DW	\
 	RRvision	\
+	sheevaplug	\
 	SM850		\
 	spc1920		\
 	SPD823TS	\
Makefile +3 -0
index 8144ecd..34a863b 100644
@@ -1122,6 +1122,9 @@ RRvision_LCD_config:	unconfig
 	@echo "#define CONFIG_SHARP_LQ104V7DS01" >>$(obj)include/config.h
 	@$(MKCONFIG) -a RRvision ppc mpc8xx RRvision
 
+sheevaplug_config: unconfig
+	@$(MKCONFIG) $(@:_config=) arm arm926ejs $(@:_config=) Marvell kirkwood
+
 SM850_config	:	unconfig
 	@$(MKCONFIG) $(@:_config=) ppc mpc8xx tqm8xx tqc
 

Makefile lpd7a400_config \ · line 2813

Quoted 6 lines
Makefile +0 -3
@@ -2808,9 +2811,6 @@ lpd7a400_config \
 lpd7a404_config:	unconfig
 	@$(MKCONFIG) $(@:_config=) arm lh7a40x lpd7a40x
 
-mv88f6281gtw_ge_config: unconfig
-	@$(MKCONFIG) $(@:_config=) arm arm926ejs $(@:_config=) Marvell kirkwood
-

Why do you remove this board here?

Makefile omap2420h4_config : unconfig · line 3114

Quoted 9 lines
Makefile +2 -0
 mx1ads_config	:	unconfig
 	@$(MKCONFIG) $(@:_config=) arm arm920t mx1ads NULL imx
 
@@ -3110,6 +3110,8 @@ omap2420h4_config	: unconfig
 qong_config		: unconfig
 	@$(MKCONFIG) $(@:_config=) arm arm1136 qong davedenx mx31
 
+sheevapluge_config: unconfig
+	@$(MKCONFIG) $(@:_config=) arm arm926ejs $(@:_config=) Marvell kirkwood

"sheevapluge" here and "sheevaplug" a few lines above? This probably just slipped in.

Thanks.

Best regards,
Stefan

=====================================================================
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: office at denx.de
=====================================================================

#13 lore raw

PATCH 1/1 Marvell Sheevaplug Board support

In reply to Prafulla Wadaskar

Dear Prafulla Wadaskar,

Quoted 10 lines · In message <[email protected]> you wrote:

References: http://plugcomputer.org/
Serial console Setup
http://openplug.org/plugwiki/index.php/Serial_terminal_program#Linux
OpenOCD Setup
http://openplug.org/plugwiki/index.php/Setting_Up_OpenOCD_Under_Linux

This patch is tested for-
1. Boot from DRAM/NAND flash
2. File transfer using tftp
3. NAND flash read/write/erase

...

MAKEALL LIST_8xx=" \ · line 148

Quoted 10 lines
MAKEALL +1 -0
index 6719d7b..e3d33cb 100755
@@ -144,6 +144,7 @@ LIST_8xx="		\
 	RPXlite		\
 	RPXlite_DW	\
 	RRvision	\
+	sheevaplug	\
 	SM850		\

Why do you add an ARM board right in the middle of MPC8xx PowerPC boards? You obviously never tested this.

Please do not submit untested code!!!

MAKEALL RRvision_LCD_config: unconfig · line 1129

Quoted 9 lines
MAKEALL +3 -0
@@ -1122,6 +1122,9 @@ RRvision_LCD_config:	unconfig
 	@echo "#define CONFIG_SHARP_LQ104V7DS01" >>$(obj)include/config.h
 	@$(MKCONFIG) -a RRvision ppc mpc8xx RRvision
 
+sheevaplug_config: unconfig
+	@$(MKCONFIG) $(@:_config=) arm arm926ejs $(@:_config=) Marvell kirkwood
+
 SM850_config	:	unconfig
 	@$(MKCONFIG) $(@:_config=) ppc mpc8xx tqm8xx tqc

Why do you add an ARM board right in the middle of MPC8xx PowerPC boards?

MAKEALL lpd7a400_config \ · line 2813

Quoted 7 lines
MAKEALL +0 -3
@@ -2808,9 +2811,6 @@ lpd7a400_config \
 lpd7a404_config:	unconfig
 	@$(MKCONFIG) $(@:_config=) arm lh7a40x lpd7a40x
 
-mv88f6281gtw_ge_config: unconfig
-	@$(MKCONFIG) $(@:_config=) arm arm926ejs $(@:_config=) Marvell kirkwood
-

Why do you delete other boards?

MAKEALL omap2420h4_config : unconfig · line 3114

Quoted 6 lines
MAKEALL +2 -0
@@ -3110,6 +3110,8 @@ omap2420h4_config	: unconfig
 qong_config		: unconfig
 	@$(MKCONFIG) $(@:_config=) arm arm1136 qong davedenx mx31
 
+sheevapluge_config: unconfig
+	@$(MKCONFIG) $(@:_config=) arm arm926ejs $(@:_config=) Marvell kirkwood

Why do you add the baord twice?

MAKEALL omap2420h4_config : unconfig · line 3117

Quoted 3 lines
MAKEALL +3 -0
+# (C) Copyright 2009
+# Marvell Semiconductor <www.marvell.com>
+# Prafulla Wadaskar <[email protected]>

This makes no sense. Either Marvell holds the Copyright, or you do. Same in other files.

MAKEALL omap2420h4_config : unconfig

Quoted 6 lines
MAKEALL +6 -0
+/*
+ * For booting Linux, the board info and command line data
+ * have to be in the first 8 MB of memory, since this is
+ * the maximum mapped by the Linux kernel during initialization.
+ */
+#define	CONFIG_BOOTMAPSZ	(8 << 20)	/* Initial Memmap for Linux */

Line too long.

MAKEALL

Quoted 2 lines
MAKEALL +2 -0
+#define CONFIG_MTDPARTS			"orion_nand:512k(uboot),"	\
+	"1m at 4m(psm), 3m at 1m(kernel),13m at 5m(rootfs) rw\0"

This will not work. The embedded space is not allowed.

MAKEALL

Quoted 5 lines
MAKEALL +5 -0
+#ifdef CONFIG_CMD_NET
+#define CONFIG_NETCONSOLE	/* include NetConsole support   */
+#define CONFIG_NET_MULTI	/* specify more that one ports available */
+#define	CONFIG_MII		/* expose smi ove miiphy interface */
+#define CONFIG_KIRKWOOD_EGIGA	/* Enable kirkwood Gbe Controller Driver */

Line too long.

Best regards,

Wolfgang Denk

Signature · 5 lines
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Marriage is the triumph  of  imagination  over  intelligence.  Second
marriage is the triumph of hope over experience.
#14 lore raw

PATCH 1/1 Marvell Sheevaplug Board support

Quoted 6 lines
Quoted 2 lines

+#define CONFIG_MTDPARTS

"orion_nand:512k(uboot)," \

include/configs/sheevaplug.h line 142

Quoted 1 line
include/configs/sheevaplug.h new file +1 -0
+	"1m at 4m(psm), 3m at 1m(kernel),13m at 5m(rootfs) rw\0"

This will not work. The embedded space is not allowed.

These are the parameters will be passed to the kernel I didn't understand what will not work.
Can you pls explain this?

Regards...
Prafulla . .

#15 lore raw

PATCH 1/1 Marvell Sheevaplug Board support

Quoted 13 lines

-----Original Message-----
From: u-boot-bounces at lists.denx.de
[mailto:u-boot-bounces at lists.denx.de] On Behalf Of Prafulla Wadaskar
Sent: Friday, May 22, 2009 5:38 PM
To: Wolfgang Denk
Cc: Manas Saksena; Ronen Shitrit; Nicolas Pitre;
u-boot at lists.denx.de; Ashish Karkare; Prabhanjan Sarnaik; Lennert Buijtenhek
Subject: Re: [U-Boot] [PATCH] Marvell Sheevaplug Board support

Quoted 1 line
Quoted 8 lines
Quoted 5 lines
Quoted 1 line

+#define CONFIG_MTDPARTS

"orion_nand:512k(uboot)," \

include/configs/sheevaplug.h line 142

Quoted 1 line
include/configs/sheevaplug.h new file +1 -0
+	"1m at 4m(psm), 3m at 1m(kernel),13m at 5m(rootfs) rw\0"

This will not work. The embedded space is not allowed.

These are the parameters will be passed to the kernel I didn't understand what will not work.
Can you pls explain this?

Hi I got it.... ;-( sorry....
Regards..
Prafulla . .

Quoted 8 lines

Regards...
Prafulla . .
_______________________________________________
U-Boot mailing list
U-Boot at lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

#16 lore raw

PATCH 1/1 Marvell Sheevaplug Board support

From: Written-by: Prafulla Wadaskar <[email protected]>

References: http://plugcomputer.org/
Serial console Setup
http://openplug.org/plugwiki/index.php/Serial_terminal_program#Linux
OpenOCD Setup
http://openplug.org/plugwiki/index.php/Setting_Up_OpenOCD_Under_Linux

This patch is tested for-
1. Boot from DRAM/NAND flash
2. File transfer using tftp
3. NAND flash read/write/erase
4. System bring up (Kernel and RFS) from NDND Flash

---
Change log:
v1: updated as per review comment
copyright statement corrected.
mtdparts definition updated.
code moved to valid location in Makefile and MAKEALL all code lines checked for max size 80 chars

 MAKEALL                               |    1 +
 Makefile                              |    4 +-
 board/Marvell/sheevaplug/Makefile     |   52 +++++++++
 board/Marvell/sheevaplug/config.mk    |   25 +++++
 board/Marvell/sheevaplug/nand.c       |   80 ++++++++++++++
 board/Marvell/sheevaplug/sheevaplug.c |  135 ++++++++++++++++++++++++
 board/Marvell/sheevaplug/sheevaplug.h |   37 +++++++
 include/configs/sheevaplug.h          |  186 +++++++++++++++++++++++++++++++++
 8 files changed, 519 insertions(+), 1 deletions(-)
 create mode 100644 board/Marvell/sheevaplug/Makefile
 create mode 100644 board/Marvell/sheevaplug/config.mk
 create mode 100644 board/Marvell/sheevaplug/nand.c
 create mode 100644 board/Marvell/sheevaplug/sheevaplug.c
 create mode 100644 board/Marvell/sheevaplug/sheevaplug.h
 create mode 100644 include/configs/sheevaplug.h
MAKEALL +1 -0
index 6719d7b..e9b3fa7 100755
@@ -517,6 +517,7 @@ LIST_ARM9="			\
 	omap730p2		\
 	sbc2410x		\
 	scb9328			\
+	sheevaplug		\
 	smdk2400		\
 	smdk2410		\
 	trab			\
Makefile +3 -1
index 8144ecd..daebc59 100644
@@ -2882,6 +2882,9 @@ sbc2410x_config: unconfig
 scb9328_config	:	unconfig
 	@$(MKCONFIG) $(@:_config=) arm arm920t scb9328 NULL imx
 
+sheevaplug_config: unconfig
+	@$(MKCONFIG) $(@:_config=) arm arm926ejs $(@:_config=) Marvell kirkwood
+
 smdk2400_config	:	unconfig
 	@$(MKCONFIG) $(@:_config=) arm arm920t smdk2400 samsung s3c24x0
 
@@ -3110,7 +3113,6 @@ omap2420h4_config	: unconfig
 qong_config		: unconfig
 	@$(MKCONFIG) $(@:_config=) arm arm1136 qong davedenx mx31
 
-
 #########################################################################
 ## ARM1176 Systems
 #########################################################################
board/Marvell/sheevaplug/Makefile new file +52 -0

52 lines not on this page · raw message

board/Marvell/sheevaplug/config.mk new file +25 -0
new file mode 100644
index 0000000..a4ea769
@@ -0,0 +1,25 @@
+#
+# (C) Copyright 2009
+# Marvell Semiconductor <www.marvell.com>
+# Written-by: Prafulla Wadaskar <[email protected]>
+#
+# See file CREDITS for list of people who contributed to this
+# project.
+#
+# This program is free software; you can redistribute it and/or
+# modify it under the terms of the GNU General Public License as
+# published by the Free Software Foundation; either version 2 of
+# the License, or (at your option) any later version.
+#
+# This program is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU General Public License
+# along with this program; if not, write to the Free Software
+# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston,
+# MA 02110-1301 USA
+#
+
+TEXT_BASE = 0x00600000
board/Marvell/sheevaplug/nand.c new file +80 -0

80 lines not on this page · raw message

board/Marvell/sheevaplug/sheevaplug.c new file +135 -0

135 lines not on this page · raw message

board/Marvell/sheevaplug/sheevaplug.h new file +37 -0
new file mode 100644
index 0000000..eb6de80
@@ -0,0 +1,37 @@
+/*
+ * (C) Copyright 2009
+ * Marvell Semiconductor <www.marvell.com>
+ * Written-by: Prafulla Wadaskar <[email protected]>
+ *
+ * See file CREDITS for list of people who contributed to this
+ * project.
+ *
+ * This program is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU General Public License as
+ * published by the Free Software Foundation; either version 2 of
+ * the License, or (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program; if not, write to the Free Software
+ * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston,
+ * MA 02110-1301 USA
+ */
+
+#ifndef __SHEEVAPLUG_H
+#define __SHEEVAPLUG_H
+
+#ifndef MACH_TYPE_SHEEVAPLUG
+#define MACH_TYPE_SHEEVAPLUG	2097
+#endif
+
+#define SHEEVAPLUG_OE_LOW		(~(0))
+#define SHEEVAPLUG_OE_HIGH		(~(0))
+#define SHEEVAPLUG_OE_VAL_LOW		(1 << 29)	/* USB_PWEN low */
+#define SHEEVAPLUG_OE_VAL_HIGH		(1 << 17)	/* LED pin high */
+
+#endif /* __SHEEVAPLUG_H */
include/configs/sheevaplug.h new file +186 -0

186 lines not on this page · raw message

Signature · 1 line
1.5.3.3
#17 lore raw

PATCH 1/1 Marvell Sheevaplug Board support

In reply to Prafulla Wadaskar

Dear Prafulla Wadaskar,

Quoted 8 lines · In message <[email protected]>…
Quoted 6 lines
Quoted 2 lines

+#define CONFIG_MTDPARTS

"orion_nand:512k(uboot)," \

include/configs/sheevaplug.h line 142

Quoted 1 line
include/configs/sheevaplug.h new file +1 -0
+	"1m at 4m(psm), 3m at 1m(kernel),13m at 5m(rootfs) rw\0"

This will not work. The embedded space is not allowed.

These are the parameters will be passed to the kernel I didn't understand what will not work.

The Linux kernel will not be able to parse this.

Quoted 1 line

Can you pls explain this?

Please remove the space before "3m at 1m(kernel)", i. e. write:

	"1m at 4m(psm),3m at 1m(kernel),13m at 5m(rootfs) rw\0"

Best regards,

Wolfgang Denk

Signature · 4 lines
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
The high cost of living hasn't affected its popularity.
#18 lore raw

PATCH v2 1/1 Marvell Sheevaplug Board support

Reference:
http://plugcomputer.org/
http://openplug.org/plugwiki/index.php/Das_U-boot_plug_support

This patch is tested for-
1. Boot from DRAM/NAND flash
2. File transfer using tftp
3. NAND flash read/write/erase
4. Linux kernel and RFS Boot from NAND

---
Change log:
updated as per feedback for v1

 MAKEALL                               |    1 +
 Makefile                              |    4 +-
 board/Marvell/sheevaplug/Makefile     |   51 +++++++++
 board/Marvell/sheevaplug/config.mk    |   25 +++++
 board/Marvell/sheevaplug/sheevaplug.c |  135 +++++++++++++++++++++++
 board/Marvell/sheevaplug/sheevaplug.h |   37 +++++++
 include/configs/sheevaplug.h          |  191 +++++++++++++++++++++++++++++++++
 7 files changed, 443 insertions(+), 1 deletions(-)
 create mode 100644 board/Marvell/sheevaplug/Makefile
 create mode 100644 board/Marvell/sheevaplug/config.mk
 create mode 100644 board/Marvell/sheevaplug/sheevaplug.c
 create mode 100644 board/Marvell/sheevaplug/sheevaplug.h
 create mode 100644 include/configs/sheevaplug.h
MAKEALL +1 -0
index 6719d7b..e9b3fa7 100755
@@ -517,6 +517,7 @@ LIST_ARM9="			\
 	omap730p2		\
 	sbc2410x		\
 	scb9328			\
+	sheevaplug		\
 	smdk2400		\
 	smdk2410		\
 	trab			\
Makefile +3 -1
index 8144ecd..daebc59 100644
@@ -2882,6 +2882,9 @@ sbc2410x_config: unconfig
 scb9328_config	:	unconfig
 	@$(MKCONFIG) $(@:_config=) arm arm920t scb9328 NULL imx
 
+sheevaplug_config: unconfig
+	@$(MKCONFIG) $(@:_config=) arm arm926ejs $(@:_config=) Marvell kirkwood
+
 smdk2400_config	:	unconfig
 	@$(MKCONFIG) $(@:_config=) arm arm920t smdk2400 samsung s3c24x0
 
@@ -3110,7 +3113,6 @@ omap2420h4_config	: unconfig
 qong_config		: unconfig
 	@$(MKCONFIG) $(@:_config=) arm arm1136 qong davedenx mx31
 
-
 #########################################################################
 ## ARM1176 Systems
 #########################################################################
board/Marvell/sheevaplug/Makefile new file +51 -0

51 lines not on this page · raw message

board/Marvell/sheevaplug/config.mk new file +25 -0
new file mode 100644
index 0000000..a4ea769
@@ -0,0 +1,25 @@
+#
+# (C) Copyright 2009
+# Marvell Semiconductor <www.marvell.com>
+# Written-by: Prafulla Wadaskar <[email protected]>
+#
+# See file CREDITS for list of people who contributed to this
+# project.
+#
+# This program is free software; you can redistribute it and/or
+# modify it under the terms of the GNU General Public License as
+# published by the Free Software Foundation; either version 2 of
+# the License, or (at your option) any later version.
+#
+# This program is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU General Public License
+# along with this program; if not, write to the Free Software
+# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston,
+# MA 02110-1301 USA
+#
+
+TEXT_BASE = 0x00600000
board/Marvell/sheevaplug/sheevaplug.c new file +135 -0

135 lines not on this page · raw message

board/Marvell/sheevaplug/sheevaplug.h new file +37 -0
new file mode 100644
index 0000000..eb6de80
@@ -0,0 +1,37 @@
+/*
+ * (C) Copyright 2009
+ * Marvell Semiconductor <www.marvell.com>
+ * Written-by: Prafulla Wadaskar <[email protected]>
+ *
+ * See file CREDITS for list of people who contributed to this
+ * project.
+ *
+ * This program is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU General Public License as
+ * published by the Free Software Foundation; either version 2 of
+ * the License, or (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program; if not, write to the Free Software
+ * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston,
+ * MA 02110-1301 USA
+ */
+
+#ifndef __SHEEVAPLUG_H
+#define __SHEEVAPLUG_H
+
+#ifndef MACH_TYPE_SHEEVAPLUG
+#define MACH_TYPE_SHEEVAPLUG	2097
+#endif
+
+#define SHEEVAPLUG_OE_LOW		(~(0))
+#define SHEEVAPLUG_OE_HIGH		(~(0))
+#define SHEEVAPLUG_OE_VAL_LOW		(1 << 29)	/* USB_PWEN low */
+#define SHEEVAPLUG_OE_VAL_HIGH		(1 << 17)	/* LED pin high */
+
+#endif /* __SHEEVAPLUG_H */
include/configs/sheevaplug.h new file +191 -0

191 lines not on this page · raw message

Signature · 1 line
1.5.3.3
#19 lore raw

PATCH v2 1/1 Marvell Sheevaplug Board support

Dear Prafulla Wadaskar,

Quoted 9 lines · In message <[email protected]> you wrote:

Reference:
http://plugcomputer.org/
http://openplug.org/plugwiki/index.php/Das_U-boot_plug_support

This patch is tested for-
1. Boot from DRAM/NAND flash
2. File transfer using tftp
3. NAND flash read/write/erase
4. Linux kernel and RFS Boot from NAND

Entry in MAINTAINERS missing.

...

include/configs/sheevaplug.h line 99

Quoted 12 lines
include/configs/sheevaplug.h new file +12 -0
+/*
+ * Commands configuration
+ */
+#define CONFIG_CMD_ENV
+#define CONFIG_CMD_RUN
+#define CONFIG_CMD_LOADB
+#define CONFIG_CMD_NET
+#define CONFIG_CMD_AUTOSCRIPT
+#define CONFIG_CMD_MEMORY
+#define CONFIG_CMD_BOOTD
+#define CONFIG_CMD_SAVEENV
+#define CONFIG_CMD_NAND

Please sort such lists.

...

include/configs/sheevaplug.h line 140

Quoted 2 lines
include/configs/sheevaplug.h new file +2 -0
+#define CONFIG_MTDPARTS			"orion_nand:512k(uboot),"	\
+	"1m at 4m(psm),3m at 1m(kernel),13m at 5m(rootfs) rw\0"

Is this weird partition setup intentional?

...

include/configs/sheevaplug.h line 174

Quoted 6 lines
include/configs/sheevaplug.h new file +6 -0
+/*
+ * Ethernet Driver configuration
+ */
+#ifdef CONFIG_CMD_NET
+#define CONFIG_CMD_DHCP
+#define CONFIG_CMD_PING

I prefer to have all command related definition close together. Move up?

include/configs/sheevaplug.h line 183

Quoted 9 lines
include/configs/sheevaplug.h new file +9 -0
+#define CONFIG_NETCONSOLE	/* include NetConsole support   */
+#define CONFIG_NET_MULTI	/* specify more that one ports available */
+#define	CONFIG_MII		/* expose smi ove miiphy interface */
+#define CONFIG_KIRKWOOD_EGIGA	/* Enable kirkwood Gbe Controller Driver */
+#define CONFIG_SYS_FAULT_ECHO_LINK_DOWN	/* detect link using phy */
+#define CONFIG_KIRKWOOD_EGIGA_PORTS	{1,0}	/* enable port 0 only */
+#define CONFIG_PHY_BASE_ADR	0
+#define CONFIG_ENV_OVERWRITE	/* ethaddr can be reprogrammed */
+#endif /* CONFIG_CMD_NET */

...

Best regards,

Wolfgang Denk

Signature · 5 lines
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Totally illogical, there was no chance.
	-- Spock, "The Galileo Seven", stardate 2822.3
#20 lore raw

PATCH v2 1/1 Marvell Sheevaplug Board support

Quoted 6 lines

...

Quoted 1 line

+#define CONFIG_MTDPARTS

"orion_nand:512k(uboot)," \

include/configs/sheevaplug.h line 140

Quoted 1 line
include/configs/sheevaplug.h new file +1 -0
+	"1m at 4m(psm),3m at 1m(kernel),13m at 5m(rootfs) rw\0"

Is this weird partition setup intentional?

No,
This partition is setup purposely on this board, specially apps in the RFS stack need it. I wish to keep it there to remove dependency and to establish smooth system bring up. Otherwise user has to add it manually after new uboot flash to work system correctly.

but if it conflicts with common u-boot guidelines, I can remove it.

Regards..
Prafulla . .

#21 lore raw

PATCH v2 1/1 Marvell Sheevaplug Board support

Dear Prafulla Wadaskar,

Quoted 10 lines · In message <[email protected]>…
Quoted 6 lines

...

Quoted 1 line

+#define CONFIG_MTDPARTS =09

"orion_nand:512k(uboot)," \

include/configs/sheevaplug.h line 140

Quoted 1 line
include/configs/sheevaplug.h new file +1 -0
+	"1m at 4m(psm),3m at 1m(kernel),13m at 5m(rootfs) rw\0"

=20
Is this weird partition setup intentional?

No,
This partition is setup purposely on this board, specially apps in the RFS stack need it. I wish to keep it there to remove dependency and to establish smooth system bring up. Otherwise user has to add it manually after new uboot flash to work system correctly.

So yes, it was intentional, right?

Quoted 1 line

but if it conflicts with common u-boot guidelines, I can remove it.

No, it does not conflict with anything. It just looked weird to me and I wanted to make sure it was intentional and not a missed problem.

Best regards,

Wolfgang Denk

Signature · 5 lines
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Why can you only have two doors on a chicken coop? If it had four  it
would be a chicken sedan.
#22 lore raw

PATCH v2 1/3 nand: Add Marvell Kirkwood NAND driver

This patch adds a NAND driver for the Marvell Kirkwood SoC's.

---
Change log:
v2: updated as per feedback for v1 (cosmetic change)

 drivers/mtd/nand/Makefile        |    1 +
 drivers/mtd/nand/kirkwood_nand.c |   81 ++++++++++++++++++++++++++++++++++++++
 2 files changed, 82 insertions(+), 0 deletions(-)
 create mode 100644 drivers/mtd/nand/kirkwood_nand.c
drivers/mtd/nand/Makefile +1 -0
index 471cd6b..766c3f0 100644
@@ -40,6 +40,7 @@ COBJS-$(CONFIG_DRIVER_NAND_BFIN) += bfin_nand.o
 COBJS-$(CONFIG_NAND_DAVINCI) += davinci_nand.o
 COBJS-$(CONFIG_NAND_FSL_ELBC) += fsl_elbc_nand.o
 COBJS-$(CONFIG_NAND_FSL_UPM) += fsl_upm.o
+COBJS-$(CONFIG_NAND_KIRKWOOD) += kirkwood_nand.o
 COBJS-$(CONFIG_NAND_NOMADIK) += nomadik.o
 COBJS-$(CONFIG_NAND_S3C2410) += s3c2410_nand.c
 COBJS-$(CONFIG_NAND_S3C64XX) += s3c64xx.o
drivers/mtd/nand/kirkwood_nand.c new file +81 -0

81 lines not on this page · raw message

Signature · 1 line
1.5.3.3
#23 lore raw

PATCH v3 2/3 net: Add Marvell Kirkwood gigabit ethernet driver

This patch adds a egiga driver for the Marvell Kirkwood SoC's.

Contributors:
Yotam Admon <[email protected]>
Michael Blostein <michaelbl at marvell.com

---
Change log:
v2: updated all print messages to provide helpful info

v3: No link dectection bug fixed

 drivers/net/Makefile         |    1 +
 drivers/net/kirkwood_egiga.c |  665 ++++++++++++++++++++++++++++++++++++++++++
 drivers/net/kirkwood_egiga.h |  561 +++++++++++++++++++++++++++++++++++
 include/netdev.h             |    1 +
 4 files changed, 1228 insertions(+), 0 deletions(-)
 create mode 100644 drivers/net/kirkwood_egiga.c
 create mode 100644 drivers/net/kirkwood_egiga.h
drivers/net/Makefile +1 -0
index a360a50..f0c5654 100644
@@ -40,6 +40,7 @@ COBJS-$(CONFIG_ENC28J60) += enc28j60.o
 COBJS-$(CONFIG_FSLDMAFEC) += fsl_mcdmafec.o mcfmii.o
 COBJS-$(CONFIG_GRETH) += greth.o
 COBJS-$(CONFIG_INCA_IP_SWITCH) += inca-ip_sw.o
+COBJS-$(CONFIG_KIRKWOOD_EGIGA) += kirkwood_egiga.o
 COBJS-$(CONFIG_DRIVER_KS8695ETH) += ks8695eth.o
 COBJS-$(CONFIG_DRIVER_LAN91C96) += lan91c96.o
 COBJS-$(CONFIG_MACB) += macb.o
drivers/net/kirkwood_egiga.c new file +665 -0

665 lines not on this page · raw message

drivers/net/kirkwood_egiga.h new file +561 -0

561 lines not on this page · raw message

include/netdev.h +1 -0
index 63cf730..b73aa8e 100644
@@ -52,6 +52,7 @@ int fec_initialize (bd_t *bis);
 int greth_initialize(bd_t *bis);
 void gt6426x_eth_initialize(bd_t *bis);
 int inca_switch_initialize(bd_t *bis);
+int kirkwood_egiga_initialize(bd_t *bis);
 int macb_eth_initialize(int id, void *regs, unsigned int phy_addr);
 int mcdmafec_initialize(bd_t *bis);
 int mcffec_initialize(bd_t *bis);
Signature · 1 line
1.5.3.3
#24 lore raw

PATCH v4 2/3 net: Add Marvell Kirkwood gigabit ethernet driver

This patch adds a egiga driver for the Marvell Kirkwood SoC's.

Contributors:
Yotam Admon <[email protected]>
Michael Blostein <michaelbl at marvell.com

---
Change log:
v2: updated all print messages to provide helpful info

v3: No link dectection bug fixed

v4: some missing indentation fixed
Enabled auto-negociation for interface speed
driver tuned for code size reduction
magic numbers replaced by macros
unwanted cache related code removed

 drivers/net/Makefile         |    1 +
 drivers/net/kirkwood_egiga.c |  664 ++++++++++++++++++++++++++++++++++++++++++
 drivers/net/kirkwood_egiga.h |  503 ++++++++++++++++++++++++++++++++
 include/netdev.h             |    1 +
 4 files changed, 1169 insertions(+), 0 deletions(-)
 create mode 100644 drivers/net/kirkwood_egiga.c
 create mode 100644 drivers/net/kirkwood_egiga.h
drivers/net/Makefile +1 -0
index a360a50..f0c5654 100644
@@ -40,6 +40,7 @@ COBJS-$(CONFIG_ENC28J60) += enc28j60.o
 COBJS-$(CONFIG_FSLDMAFEC) += fsl_mcdmafec.o mcfmii.o
 COBJS-$(CONFIG_GRETH) += greth.o
 COBJS-$(CONFIG_INCA_IP_SWITCH) += inca-ip_sw.o
+COBJS-$(CONFIG_KIRKWOOD_EGIGA) += kirkwood_egiga.o
 COBJS-$(CONFIG_DRIVER_KS8695ETH) += ks8695eth.o
 COBJS-$(CONFIG_DRIVER_LAN91C96) += lan91c96.o
 COBJS-$(CONFIG_MACB) += macb.o
drivers/net/kirkwood_egiga.c new file +664 -0

664 lines not on this page · raw message

drivers/net/kirkwood_egiga.h new file +503 -0

503 lines not on this page · raw message

include/netdev.h +1 -0
index 63cf730..b73aa8e 100644
@@ -52,6 +52,7 @@ int fec_initialize (bd_t *bis);
 int greth_initialize(bd_t *bis);
 void gt6426x_eth_initialize(bd_t *bis);
 int inca_switch_initialize(bd_t *bis);
+int kirkwood_egiga_initialize(bd_t *bis);
 int macb_eth_initialize(int id, void *regs, unsigned int phy_addr);
 int mcdmafec_initialize(bd_t *bis);
 int mcffec_initialize(bd_t *bis);
Signature · 1 line
1.5.3.4
#26 lore raw

PATCH 1/1 kirkwood_egiga.c: fix build error

---
 drivers/net/kirkwood_egiga.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
drivers/net/kirkwood_egiga.c +1 -0
index b43bbf2..3c5db19 100644
@@ -662,3 +662,4 @@ int kirkwood_egiga_initialize(bd_t * bis)
 #endif
 	}
 	return 0;
+}
Signature · 1 line
1.5.3.3
#27 lore raw

PATCH v4 3/3 Marvell Sheevaplug Board support

In reply to Prafulla Wadaskar

Reference:
http://plugcomputer.org/
http://openplug.org/plugwiki/index.php/Das_U-boot_plug_support

This patch is tested for-
1. Boot from DRAM/NAND flash
2. File transfer using tftp
3. NAND flash read/write/erase
4. Linux kernel and RFS Boot from NAND

---
Change log:
v2: updated as per feedback for v1

v3: updated as per feedback for v2

v4: removed PHY driver dependency, coded in sheevaplug.c

 MAINTAINERS                           |    4 +
 MAKEALL                               |    1 +
 Makefile                              |    4 +-
 board/Marvell/sheevaplug/Makefile     |   51 +++++++++
 board/Marvell/sheevaplug/config.mk    |   25 +++++
 board/Marvell/sheevaplug/sheevaplug.c |  155 ++++++++++++++++++++++++++
 board/Marvell/sheevaplug/sheevaplug.h |   41 +++++++
 include/configs/sheevaplug.h          |  191 +++++++++++++++++++++++++++++++++
 8 files changed, 471 insertions(+), 1 deletions(-)
 create mode 100644 board/Marvell/sheevaplug/Makefile
 create mode 100644 board/Marvell/sheevaplug/config.mk
 create mode 100644 board/Marvell/sheevaplug/sheevaplug.c
 create mode 100644 board/Marvell/sheevaplug/sheevaplug.h
 create mode 100644 include/configs/sheevaplug.h
MAINTAINERS +4 -0
index bf076b9..2474481 100644
@@ -655,6 +655,10 @@ Hugo Villeneuve <[email protected]>
 
 	SFFSDR		ARM926EJS
 
+Prafulla Wadaskar <[email protected]>
+
+	sheevaplug	ARM926EJS (Kirkwood SoC)
+
 Richard Woodruff <[email protected]>
 
 	omap2420h4	ARM1136EJS
MAKEALL +1 -0
index c98d03a..4a7ccee 100755
@@ -516,6 +516,7 @@ LIST_ARM9="			\
 	omap730p2		\
 	sbc2410x		\
 	scb9328			\
+	sheevaplug		\
 	smdk2400		\
 	smdk2410		\
 	trab			\
Makefile +3 -1
index 81a5cd0..527e383 100644
@@ -2879,6 +2879,9 @@ sbc2410x_config: unconfig
 scb9328_config	:	unconfig
 	@$(MKCONFIG) $(@:_config=) arm arm920t scb9328 NULL imx
 
+sheevaplug_config: unconfig
+	@$(MKCONFIG) $(@:_config=) arm arm926ejs $(@:_config=) Marvell kirkwood
+
 smdk2400_config	:	unconfig
 	@$(MKCONFIG) $(@:_config=) arm arm920t smdk2400 samsung s3c24x0
 
@@ -3107,7 +3110,6 @@ omap2420h4_config	: unconfig
 qong_config		: unconfig
 	@$(MKCONFIG) $(@:_config=) arm arm1136 qong davedenx mx31
 
-
 #########################################################################
 ## ARM1176 Systems
 #########################################################################
board/Marvell/sheevaplug/Makefile new file +51 -0

51 lines not on this page · raw message

board/Marvell/sheevaplug/config.mk new file +25 -0
new file mode 100644
index 0000000..a4ea769
@@ -0,0 +1,25 @@
+#
+# (C) Copyright 2009
+# Marvell Semiconductor <www.marvell.com>
+# Written-by: Prafulla Wadaskar <[email protected]>
+#
+# See file CREDITS for list of people who contributed to this
+# project.
+#
+# This program is free software; you can redistribute it and/or
+# modify it under the terms of the GNU General Public License as
+# published by the Free Software Foundation; either version 2 of
+# the License, or (at your option) any later version.
+#
+# This program is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU General Public License
+# along with this program; if not, write to the Free Software
+# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston,
+# MA 02110-1301 USA
+#
+
+TEXT_BASE = 0x00600000
board/Marvell/sheevaplug/sheevaplug.c new file +155 -0

155 lines not on this page · raw message

board/Marvell/sheevaplug/sheevaplug.h new file +41 -0

41 lines not on this page · raw message

include/configs/sheevaplug.h new file +191 -0

191 lines not on this page · raw message

Signature · 1 line
1.5.3.3
#28 lore raw

PATCH v4 3/3 Marvell Sheevaplug Board support

Reference:
http://plugcomputer.org/
http://openplug.org/plugwiki/index.php/Das_U-boot_plug_support

This patch is tested for-
1. Boot from DRAM/NAND flash
2. File transfer using tftp
3. NAND flash read/write/erase
4. Linux kernel and RFS Boot from NAND

---
Change log:
v2: updated as per feedback for v1

v3: updated as per feedback for v2

v4: removed PHY driver dependency, coded in sheevaplug.c

 MAINTAINERS                           |    4 +
 MAKEALL                               |    1 +
 Makefile                              |    4 +-
 board/Marvell/sheevaplug/Makefile     |   51 +++++++++
 board/Marvell/sheevaplug/config.mk    |   25 +++++
 board/Marvell/sheevaplug/sheevaplug.c |  155 ++++++++++++++++++++++++++
 board/Marvell/sheevaplug/sheevaplug.h |   41 +++++++
 include/configs/sheevaplug.h          |  191 +++++++++++++++++++++++++++++++++
 8 files changed, 471 insertions(+), 1 deletions(-)
 create mode 100644 board/Marvell/sheevaplug/Makefile
 create mode 100644 board/Marvell/sheevaplug/config.mk
 create mode 100644 board/Marvell/sheevaplug/sheevaplug.c
 create mode 100644 board/Marvell/sheevaplug/sheevaplug.h
 create mode 100644 include/configs/sheevaplug.h
MAINTAINERS +4 -0
index bf076b9..2474481 100644
@@ -655,6 +655,10 @@ Hugo Villeneuve <[email protected]>
 
 	SFFSDR		ARM926EJS
 
+Prafulla Wadaskar <[email protected]>
+
+	sheevaplug	ARM926EJS (Kirkwood SoC)
+
 Richard Woodruff <[email protected]>
 
 	omap2420h4	ARM1136EJS
MAKEALL +1 -0
index c98d03a..4a7ccee 100755
@@ -516,6 +516,7 @@ LIST_ARM9="			\
 	omap730p2		\
 	sbc2410x		\
 	scb9328			\
+	sheevaplug		\
 	smdk2400		\
 	smdk2410		\
 	trab			\
Makefile +3 -1
index 81a5cd0..527e383 100644
@@ -2879,6 +2879,9 @@ sbc2410x_config: unconfig
 scb9328_config	:	unconfig
 	@$(MKCONFIG) $(@:_config=) arm arm920t scb9328 NULL imx
 
+sheevaplug_config: unconfig
+	@$(MKCONFIG) $(@:_config=) arm arm926ejs $(@:_config=) Marvell kirkwood
+
 smdk2400_config	:	unconfig
 	@$(MKCONFIG) $(@:_config=) arm arm920t smdk2400 samsung s3c24x0
 
@@ -3107,7 +3110,6 @@ omap2420h4_config	: unconfig
 qong_config		: unconfig
 	@$(MKCONFIG) $(@:_config=) arm arm1136 qong davedenx mx31
 
-
 #########################################################################
 ## ARM1176 Systems
 #########################################################################
board/Marvell/sheevaplug/Makefile new file +51 -0

51 lines not on this page · raw message

board/Marvell/sheevaplug/config.mk new file +25 -0
new file mode 100644
index 0000000..a4ea769
@@ -0,0 +1,25 @@
+#
+# (C) Copyright 2009
+# Marvell Semiconductor <www.marvell.com>
+# Written-by: Prafulla Wadaskar <[email protected]>
+#
+# See file CREDITS for list of people who contributed to this
+# project.
+#
+# This program is free software; you can redistribute it and/or
+# modify it under the terms of the GNU General Public License as
+# published by the Free Software Foundation; either version 2 of
+# the License, or (at your option) any later version.
+#
+# This program is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU General Public License
+# along with this program; if not, write to the Free Software
+# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston,
+# MA 02110-1301 USA
+#
+
+TEXT_BASE = 0x00600000
board/Marvell/sheevaplug/sheevaplug.c new file +155 -0

155 lines not on this page · raw message

board/Marvell/sheevaplug/sheevaplug.h new file +41 -0

41 lines not on this page · raw message

include/configs/sheevaplug.h new file +191 -0

191 lines not on this page · raw message

Signature · 1 line
1.5.3.4
#29 lore raw

PATCH v4 3/3 Marvell Sheevaplug Board support

In reply to Prafulla Wadaskar
Quoted 19 lines

-----Original Message-----
From: Prafulla Wadaskar [mailto:prafulla at marvell.com]
Sent: Monday, June 08, 2009 5:35 PM
To: u-boot at lists.denx.de
Cc: Nicolas Pitre; Manas Saksena; Lennert Buijtenhek; Prabhanjan Sarnaik; Ronen Shitrit; Ashish Karkare; Prafulla Wadaskar
Subject: [PATCH v4 3/3] Marvell Sheevaplug Board support

Reference:
http://plugcomputer.org/
http://openplug.org/plugwiki/index.php/Das_U-boot_plug_support

This patch is tested for-
1. Boot from DRAM/NAND flash
2. File transfer using tftp
3. NAND flash read/write/erase
4. Linux kernel and RFS Boot from NAND

Quoted 8 lines

---
Change log:
v2: updated as per feedback for v1

v3: updated as per feedback for v2

v4: removed PHY driver dependency, coded in sheevaplug.c

Hi Jean,

Network driver dependency (2/3) in this patch series is accepted by Ben Anther dependency (1/3), the nand driver is all done, waiting for reply from scott. Since this is arm board- who will be custodian to accept this patch? are you? :-)

Regards..
Prafulla . .

#30 lore raw

PATCH v4 3/3 Marvell Sheevaplug Board support

Quoted 26 lines · Prafulla Wadaskar
Quoted 26 lines

-----Original Message-----
From: Prafulla Wadaskar [mailto:prafulla at marvell.com]
Sent: Monday, June 08, 2009 5:35 PM
To: u-boot at lists.denx.de
Cc: Nicolas Pitre; Manas Saksena; Lennert Buijtenhek; Prabhanjan Sarnaik; Ronen Shitrit; Ashish Karkare; Prafulla Wadaskar
Subject: [PATCH v4 3/3] Marvell Sheevaplug Board support

Reference:
http://plugcomputer.org/
http://openplug.org/plugwiki/index.php/Das_U-boot_plug_support

This patch is tested for-
1. Boot from DRAM/NAND flash
2. File transfer using tftp
3. NAND flash read/write/erase
4. Linux kernel and RFS Boot from NAND

---
Change log:
v2: updated as per feedback for v1

v3: updated as per feedback for v2

Quoted 7 lines
Quoted 1 line

v4: removed PHY driver dependency, coded in sheevaplug.c

Hi Jean,

Network driver dependency (2/3) in this patch series is accepted by Ben Anther dependency (1/3), the nand driver is all done, waiting for reply from scott. Since this is arm board- who will be custodian to accept this patch? are you? :-)

the board I the others as you point Ben and Scott

Best Regards,
J.

#31 lore raw

PATCH v4 3/3 Marvell Sheevaplug Board support

In reply to Prafulla Wadaskar

Hi Jean,

I observed that your arm/master is newly rebased, most of my patches are available here, where as Basic Kirkwood support is available on arm/next branch.

I have applied Basic Kirkwood patches from next to master branch and tried to build it there. At the end I get build error saying EABI version mismatch. In this regard, may you please suggest me what additional patches I should pick from next branch to resolve this problem? (I saw certain work in this direction by you)

Or shall I continue working on arm/next?

Regards..
Prafulla . .

Quoted 52 lines

-----Original Message-----
From: u-boot-bounces at lists.denx.de
[mailto:u-boot-bounces at lists.denx.de] On Behalf Of Prafulla Wadaskar
Sent: Friday, June 19, 2009 3:03 PM
To: Jean-Christophe PLAGNIOL-VILLARD; u-boot at lists.denx.de
Cc: Manas Saksena; Ronen Shitrit; Nicolas Pitre; Ashish Karkare; Prabhanjan Sarnaik; Lennert Buijtenhek
Subject: Re: [U-Boot] [PATCH v4 3/3] Marvell Sheevaplug Board support

Quoted 18 lines

-----Original Message-----
From: Prafulla Wadaskar [mailto:prafulla at marvell.com]
Sent: Monday, June 08, 2009 5:35 PM
To: u-boot at lists.denx.de
Cc: Nicolas Pitre; Manas Saksena; Lennert Buijtenhek; Prabhanjan Sarnaik; Ronen Shitrit; Ashish Karkare; Prafulla Wadaskar
Subject: [PATCH v4 3/3] Marvell Sheevaplug Board support

Reference:
http://plugcomputer.org/
http://openplug.org/plugwiki/index.php/Das_U-boot_plug_support

This patch is tested for-
1. Boot from DRAM/NAND flash
2. File transfer using tftp
3. NAND flash read/write/erase
4. Linux kernel and RFS Boot from NAND

Quoted 8 lines

---
Change log:
v2: updated as per feedback for v1

v3: updated as per feedback for v2

v4: removed PHY driver dependency, coded in sheevaplug.c

Hi Jean,

Network driver dependency (2/3) in this patch series is accepted by Ben Anther dependency (1/3), the nand driver is all done, waiting for reply from scott.
Since this is arm board- who will be custodian to accept this patch? are you? :-)

Regards..
Prafulla . .
_______________________________________________
U-Boot mailing list
U-Boot at lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

#32 lore raw

PATCH v4 3/3 Marvell Sheevaplug Board support

Quoted 6 lines · Prafulla Wadaskar

Hi Jean,

I observed that your arm/master is newly rebased, most of my patches are available here, where as Basic Kirkwood support is available on arm/next branch.

I have applied Basic Kirkwood patches from next to master branch and tried to build it there. At the end I get build error saying EABI version mismatch. In this regard, may you please suggest me what additional patches I should pick from next branch to resolve this problem? (I saw certain work in this direction by you)

you need to pick this 2 patch fron the testing branch

http://git.denx.de/?p=u-boot/u-boot-arm.git;a=commit;h=5b30fe639c3ca0141d78820be74ce26120056116
http://git.denx.de/?p=u-boot/u-boot-arm.git;a=commit;h=009130ac00f4679516c6bb5a20f9a97eec98e6bc

Quoted 2 lines

Or shall I continue working on arm/next?

or continue to work on the next I will keep them sync about arm part

Best Regards,
J.

#33 lore raw

PATCH v5 6/6 Marvell Sheevaplug Board support

Reference:
http://plugcomputer.org/
http://openplug.org/plugwiki/index.php/Das_U-boot_plug_support

This patch is tested for-
1. Boot from DRAM/NAND flash
2. File transfer using tftp
3. NAND flash read/write/erase
4. Linux kernel and RFS Boot from NAND
5. Enabled USB PHY init for kernel need
6. Boot from USB supported

Note: to boot Kirkwood kernel with USB support,
you should add "usb start" in the boot sequence

---
Change log:
v2: updated as per feedback for v1

v3: updated as per feedback for v2

v4: removed PHY driver dependency, coded in sheevaplug.c

v5: USB support added

 MAINTAINERS                           |    4 +
 MAKEALL                               |    1 +
 Makefile                              |    4 +-
 board/Marvell/sheevaplug/Makefile     |   51 ++++++++
 board/Marvell/sheevaplug/config.mk    |   25 ++++
 board/Marvell/sheevaplug/sheevaplug.c |  155 +++++++++++++++++++++++++
 board/Marvell/sheevaplug/sheevaplug.h |   41 +++++++
 include/configs/sheevaplug.h          |  206 +++++++++++++++++++++++++++++++++
 8 files changed, 486 insertions(+), 1 deletions(-)
 create mode 100644 board/Marvell/sheevaplug/Makefile
 create mode 100644 board/Marvell/sheevaplug/config.mk
 create mode 100644 board/Marvell/sheevaplug/sheevaplug.c
 create mode 100644 board/Marvell/sheevaplug/sheevaplug.h
 create mode 100644 include/configs/sheevaplug.h
MAINTAINERS +4 -0
index b5b5484..8b16d2f 100644
@@ -659,6 +659,10 @@ Hugo Villeneuve <[email protected]>
 
 	SFFSDR		ARM926EJS
 
+Prafulla Wadaskar <[email protected]>
+
+	sheevaplug	ARM926EJS (Kirkwood SoC)
+
 Richard Woodruff <[email protected]>
 
 	omap2420h4	ARM1136EJS
MAKEALL +1 -0
index fb80cfa..e1cac9b 100755
@@ -520,6 +520,7 @@ LIST_ARM9="			\
 	omap730p2		\
 	sbc2410x		\
 	scb9328			\
+	sheevaplug		\
 	smdk2400		\
 	smdk2410		\
 	trab			\
Makefile +3 -1
index dbc237f..d770296 100644
@@ -2918,6 +2918,9 @@ sbc2410x_config: unconfig
 scb9328_config	:	unconfig
 	@$(MKCONFIG) $(@:_config=) arm arm920t scb9328 NULL imx
 
+sheevaplug_config: unconfig
+	@$(MKCONFIG) $(@:_config=) arm arm926ejs $(@:_config=) Marvell kirkwood
+
 smdk2400_config	:	unconfig
 	@$(MKCONFIG) $(@:_config=) arm arm920t smdk2400 samsung s3c24x0
 
@@ -3146,7 +3149,6 @@ omap2420h4_config	: unconfig
 qong_config		: unconfig
 	@$(MKCONFIG) $(@:_config=) arm arm1136 qong davedenx mx31
 
-
 #########################################################################
 ## ARM1176 Systems
 #########################################################################
board/Marvell/sheevaplug/Makefile new file +51 -0

51 lines not on this page · raw message

board/Marvell/sheevaplug/config.mk new file +25 -0
new file mode 100644
index 0000000..a4ea769
@@ -0,0 +1,25 @@
+#
+# (C) Copyright 2009
+# Marvell Semiconductor <www.marvell.com>
+# Written-by: Prafulla Wadaskar <[email protected]>
+#
+# See file CREDITS for list of people who contributed to this
+# project.
+#
+# This program is free software; you can redistribute it and/or
+# modify it under the terms of the GNU General Public License as
+# published by the Free Software Foundation; either version 2 of
+# the License, or (at your option) any later version.
+#
+# This program is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU General Public License
+# along with this program; if not, write to the Free Software
+# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston,
+# MA 02110-1301 USA
+#
+
+TEXT_BASE = 0x00600000
board/Marvell/sheevaplug/sheevaplug.c new file +155 -0

155 lines not on this page · raw message

board/Marvell/sheevaplug/sheevaplug.h new file +41 -0

41 lines not on this page · raw message

include/configs/sheevaplug.h new file +206 -0

206 lines not on this page · raw message

Signature · 1 line
1.5.3.3
#34 lore raw

PATCH v5 6/6 Marvell Sheevaplug Board support

Quoted 10 lines

-----Original Message-----
From: Prafulla Wadaskar [mailto:prafulla at marvell.com]
Sent: Monday, June 29, 2009 9:01 PM
To: u-boot at lists.denx.de
Cc: Prabhanjan Sarnaik; Ronen Shitrit; Ashish Karkare; Prafulla Wadaskar
Subject: [PATCH v5 6/6] Marvell Sheevaplug Board support

Quoted 3 lines

Reference:
http://plugcomputer.org/
http://openplug.org/plugwiki/index.php/Das_U-boot_plug_support

Hi Jean and Remy
Any feedback on this patch series?
This is widely used board and there are some other Kirkwood board supports pipelined those will have at least MAINTAINERS file dependency from this patch

Please let me know if I need to do anything more to get them in :-)

Regards..
Prafulla . .

#35 lore raw

PATCH v5 6/6 Marvell Sheevaplug Board support

In reply to Prafulla Wadaskar
Quoted 33 lines
include/configs/sheevaplug.h new file +33 -0
+/*
+ * CLKs configurations
+ */
+#define CONFIG_SYS_HZ		1000
+
+/*
+ * NS16550 Configuration
+ */
+#define CONFIG_SYS_NS16550
+#define CONFIG_SYS_NS16550_SERIAL
+#define CONFIG_SYS_NS16550_REG_SIZE	(-4)
+#define CONFIG_SYS_NS16550_CLK		CONFIG_SYS_TCLK
+#define CONFIG_SYS_NS16550_COM1		KW_UART0_BASE
+
+/*
+ * Serial Port configuration
+ * The following definitions let you select what serial you want to use
+ * for your console driver.
+ */
+
+#define CONFIG_CONS_INDEX	1	/*Console on UART0 */
+#define CONFIG_BAUDRATE			115200
+#define CONFIG_SYS_BAUDRATE_TABLE	{ 9600, 19200, 38400, 57600, \
+					  115200,230400, 460800, 921600 }
+/* auto boot */
+#define CONFIG_BOOTDELAY	3	/* default enable autoboot */
+
+/*
+ * For booting Linux, the board info and command line data
+ * have to be in the first 8 MB of memory, since this is
+ * the maximum mapped by the Linux kernel during initialization.
+ */
+#define CONFIG_CMDLINE_TAG	1	/* enable passing of ATAGs  */

include/configs/sheevaplug.h line 90

Quoted 10 lines
include/configs/sheevaplug.h new file +10 -0
+#define CONFIG_INITRD_TAG	1	/* enable INITRD tag */
+#define CONFIG_SETUP_MEMORY_TAGS 1	/* enable memory tag */
+
+#define	CONFIG_SYS_PROMPT	"Marvell>> "	/* Command Prompt */
+#define	CONFIG_SYS_CBSIZE	1024	/* Console I/O Buff Size */
+#define	CONFIG_SYS_PBSIZE	(CONFIG_SYS_CBSIZE \
+		+sizeof(CONFIG_SYS_PROMPT) + 16)	/* Print Buff */
+/*
+ * Commands configuration
+ */

please include config_cmd_default.h

include/configs/sheevaplug.h line 103

Quoted 13 lines
include/configs/sheevaplug.h new file +13 -0
+#define CONFIG_CMD_AUTOSCRIPT
+#define CONFIG_CMD_BOOTD
+#define CONFIG_CMD_DHCP
+#define CONFIG_CMD_ENV
+#define CONFIG_CMD_FAT
+#define CONFIG_CMD_LOADB
+#define CONFIG_CMD_MEMORY
+#define CONFIG_CMD_NAND
+#define CONFIG_CMD_NET
+#define CONFIG_CMD_PING
+#define CONFIG_CMD_RUN
+#define CONFIG_CMD_SAVEENV
+#define CONFIG_CMD_USB

otherwise ok
Best Regards,
J.

#36 lore raw

PATCH v5 6/6 Marvell Sheevaplug Board support

Quoted 10 lines

-----Original Message-----
From: Jean-Christophe PLAGNIOL-VILLARD [mailto:plagnioj at jcrosoft.com]
Sent: Saturday, July 04, 2009 5:16 AM
To: Prafulla Wadaskar
Cc: u-boot at lists.denx.de; Ashish Karkare; Prabhanjan Sarnaik; Ronen Shitrit
Subject: Re: [U-Boot] [PATCH v5 6/6] Marvell Sheevaplug Board support

<snip....>

Quoted 10 lines
Quoted 1 line

+#define CONFIG_SYS_PROMPT "Marvell>> " /*

Command Prompt */

Quoted 1 line

+#define CONFIG_SYS_CBSIZE 1024 /* Console I/O

Buff Size */

include/configs/sheevaplug.h line 90

Quoted 5 lines
include/configs/sheevaplug.h new file +5 -0
+#define	CONFIG_SYS_PBSIZE	(CONFIG_SYS_CBSIZE \
+		+sizeof(CONFIG_SYS_PROMPT) + 16)	/* Print Buff */
+/*
+ * Commands configuration
+ */

please include config_cmd_default.h

Hi Jean
I do not want to include config_cmd_default.h
All commands in this file are not supported/required for this board.

Regards..
Prafulla . .

Quoted 1 line
Quoted 1 line

+#define CONFIG_CMD_AUTOSCRIPT

<snip...>

Quoted 5 lines
Quoted 1 line

+#define CONFIG_CMD_USB

otherwise ok
Best Regards,
J.

#37 lore raw

PATCH v5 6/6 Marvell Sheevaplug Board support

Quoted 21 lines · Prafulla Wadaskar
Quoted 10 lines

-----Original Message-----
From: Jean-Christophe PLAGNIOL-VILLARD [mailto:plagnioj at jcrosoft.com]
Sent: Saturday, July 04, 2009 5:16 AM
To: Prafulla Wadaskar
Cc: u-boot at lists.denx.de; Ashish Karkare; Prabhanjan Sarnaik; Ronen Shitrit
Subject: Re: [U-Boot] [PATCH v5 6/6] Marvell Sheevaplug Board support

<snip....>

Quoted 10 lines
Quoted 1 line

+#define CONFIG_SYS_PROMPT "Marvell>> " /*

Command Prompt */

Quoted 1 line

+#define CONFIG_SYS_CBSIZE 1024 /* Console I/O

Buff Size */

include/configs/sheevaplug.h line 90

Quoted 5 lines
include/configs/sheevaplug.h new file +5 -0
+#define	CONFIG_SYS_PBSIZE	(CONFIG_SYS_CBSIZE \
+		+sizeof(CONFIG_SYS_PROMPT) + 16)	/* Print Buff */
+/*
+ * Commands configuration
+ */

please include config_cmd_default.h

Quoted 3 lines

Hi Jean
I do not want to include config_cmd_default.h
All commands in this file are not supported/required for this board.

include/config_cmd_default.h

please include this one and undef what you do not need

Best Regards,
J.

#38 lore raw

PATCH v5 6/6 Marvell Sheevaplug Board support

Quoted 35 lines

-----Original Message-----
From: Jean-Christophe PLAGNIOL-VILLARD [mailto:plagnioj at jcrosoft.com]
Sent: Wednesday, July 08, 2009 2:00 AM
To: Prafulla Wadaskar
Cc: u-boot at lists.denx.de; Ashish Karkare; Prabhanjan Sarnaik; Ronen Shitrit
Subject: Re: [U-Boot] [PATCH v5 6/6] Marvell Sheevaplug Board support

Quoted 8 lines · Prafulla Wadaskar
Quoted 8 lines

-----Original Message-----
From: Jean-Christophe PLAGNIOL-VILLARD [mailto:plagnioj at jcrosoft.com]
Sent: Saturday, July 04, 2009 5:16 AM
To: Prafulla Wadaskar
Cc: u-boot at lists.denx.de; Ashish Karkare; Prabhanjan

Sarnaik; Ronen

Quoted 11 lines
Quoted 4 lines

Shitrit
Subject: Re: [U-Boot] [PATCH v5 6/6] Marvell Sheevaplug Board support

<snip....>

Quoted 6 lines
Quoted 1 line

+#define CONFIG_SYS_PROMPT "Marvell>> " /*

Command Prompt */

Quoted 1 line

+#define CONFIG_SYS_CBSIZE 1024 /* Console I/O

Buff Size */

Review

Quoted 2 lines
(quoted diff) +2 -0
+#define	CONFIG_SYS_PBSIZE	(CONFIG_SYS_CBSIZE \
+		+sizeof(CONFIG_SYS_PROMPT) + 16)	

/* Print Buff */

Quoted 3 lines
Quoted 3 lines
Quoted 3 lines

+/*
+ * Commands configuration
+ */

Quoted 7 lines
Quoted 4 lines
Quoted 1 line

please include config_cmd_default.h

Hi Jean
I do not want to include config_cmd_default.h All commands in this file are not supported/required for this board.

include/config_cmd_default.h

please include this one and undef what you do not needis

Hi Jean,
Total 13 commands used for this board out of which only 7 are configured in config_cmd_default.h.
There are total 20 commands defined in config_cmd_default.h i.e. I need to undef 13 commands
This will add ~15 lines to the code unnecessarily.
Secondly config_cmd_default.h may be updated frequently for commands addition, which may not be supported/required on this board. Then again we have to apply undef patch for this board. Is it mandatory to include this file?

Regards..
Prafulla . .

Quoted 4 lines

Best Regards,
J.

#39 lore raw

PATCH v5 6/6 Marvell Sheevaplug Board support

Quoted 14 lines · On Wednesday 08 July 2009 07:52:27 Prafulla Wadaskar wrote:
Quoted 6 lines
Quoted 6 lines
Quoted 5 lines
Quoted 3 lines

+/*
+ * Commands configuration
+ */

please include config_cmd_default.h

Quoted 7 lines
Quoted 3 lines

Hi Jean
I do not want to include config_cmd_default.h All commands in this file are not supported/required for this board.

include/config_cmd_default.h

please include this one and undef what you do not needis

Quoted 9 lines

Hi Jean,
Total 13 commands used for this board out of which only 7 are configured in config_cmd_default.h. There are total 20 commands defined in config_cmd_default.h i.e. I need to undef 13 commands This will add ~15 lines to the code unnecessarily.
Secondly config_cmd_default.h may be updated frequently for commands addition, which may not be supported/required on this board. Then again we have to apply undef patch for this board. Is it mandatory to include this file?

It's not mandatory. But one advantage is that by using this file (and not uncommenting most of the stuff) all boards have the same look-and-feel by supporting the same command sets.

But your command selection looks fine and I think that it's ok to define then the way you did.

Best regards,
Stefan

=====================================================================
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: office at denx.de
=====================================================================

#40 lore raw

PATCH v5 6/6 Marvell Sheevaplug Board support

In reply to Prafulla Wadaskar
Quoted 6 lines
Quoted 6 lines
Quoted 4 lines
Quoted 1 line

please include config_cmd_default.h

Hi Jean
I do not want to include config_cmd_default.h All commands in this file are not supported/required for this board.

include/config_cmd_default.h

Quoted 7 lines
Quoted 1 line

please include this one and undef what you do not needis

Hi Jean,
Total 13 commands used for this board out of which only 7 are configured in config_cmd_default.h.
There are total 20 commands defined in config_cmd_default.h i.e. I need to undef 13 commands
This will add ~15 lines to the code unnecessarily.
Secondly config_cmd_default.h may be updated frequently for commands addition, which may not be supported/required on this board. Then again we have to apply undef patch for this board. Is it mandatory to include this file?

mandatory no
but keep the same config style will be better

Best Regards,
J.

#41 lore raw

PATCH 1/2 usb: bugfix driver/usb/host/ehci-hcd.c function ehci_submit_root

This patch is tested for USB host interface on Kirkwood based Sheevaplug platform (i.e arm little-endian machine)

---
 drivers/usb/host/ehci-hcd.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/usb/host/ehci-hcd.c +1 -1
index bbd547b..7a55638 100644
@@ -550,7 +550,7 @@ ehci_submit_root(struct usb_device *dev, unsigned long pipe, void *buffer,
 	      req->requesttype, req->requesttype,
 	      le16_to_cpu(req->value), le16_to_cpu(req->index));
 
-	typeReq = req->request << 8 | req->requesttype;
+	typeReq = req->request | req->requesttype << 8;
 
 	switch (le16_to_cpu(typeReq)) {
 	case DeviceRequest | USB_REQ_GET_DESCRIPTOR:
Signature · 1 line
1.5.3.3
#42 lore raw

PATCH 1/2 usb: bugfix driver/usb/host/ehci-hcd.c function ehci_submit_root

Hi,

cc Remy Bohmer
Quoted 13 lines · Prafulla Wadaskar

This patch is tested for USB host interface on Kirkwood based Sheevaplug platform (i.e arm little-endian machine)

---
 drivers/usb/host/ehci-hcd.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/usb/host/ehci-hcd.c +0 -0
index bbd547b..7a55638 100644

drivers/usb/host/ehci-hcd.c ehci_submit_root(struct usb_device *dev, unsigned long pipe, void *buffer, · line 556

Quoted 8 lines
drivers/usb/host/ehci-hcd.c +1 -1
@@ -550,7 +550,7 @@ ehci_submit_root(struct usb_device *dev, unsigned long pipe, void *buffer,
 	      req->requesttype, req->requesttype,
 	      le16_to_cpu(req->value), le16_to_cpu(req->index));
 
-	typeReq = req->request << 8 | req->requesttype;
+	typeReq = req->request | req->requesttype << 8;
 
 	switch (le16_to_cpu(typeReq)) {
 

Regards Michael

#43 lore raw

PATCH 1/2 usb: bugfix driver/usb/host/ehci-hcd.c function ehci_submit_root

Hello Michael,

2009/7/10 Michael Trimarchi <[email protected]>:

Quoted 14 lines

Hi,

cc Remy Bohmer
Quoted 9 lines · Prafulla Wadaskar

This patch is tested for USB host interface on Kirkwood based Sheevaplug platform (i.e arm little-endian machine)

---
?drivers/usb/host/ehci-hcd.c | ? ?2 +-
?1 files changed, 1 insertions(+), 1 deletions(-)

Quoted 11 lines

drivers/usb/host/ehci-hcd.c ehci_submit_root(struct usb_device *dev, unsigned long · line 555

Quoted 11 lines
drivers/usb/host/ehci-hcd.c +1 -0
index bbd547b..7a55638 100644
@@ -550,7 +550,7 @@ ehci_submit_root(struct usb_device *dev, unsigned long
 pipe, void *buffer,
 ? ? ? ? ? ? ?req->requesttype, req->requesttype,
 ? ? ? ? ? ? ?le16_to_cpu(req->value), le16_to_cpu(req->index));
 ?- ? ? ? typeReq = req->request << 8 | req->requesttype;
+ ? ? ? typeReq = req->request | req->requesttype << 8;
 ? ? ? ? ?switch (le16_to_cpu(typeReq)) {

To be sure about the difference of opinions here about the le16_to_cpu() macro. Do you agree with this patch? If so, I will apply it.

Kind Regards,

Remy

#44 lore raw

PATCH 1/2 usb: bugfix driver/usb/host/ehci-hcd.c function ehci_submit_root

Hello Stefan and Remy

Quoted 18 lines · Remy Bohmer

Hello Michael,

2009/7/10 Michael Trimarchi <[email protected]>:

Quoted 14 lines

Hi,

cc Remy Bohmer
Quoted 8 lines · Prafulla Wadaskar

This patch is tested for USB host interface on Kirkwood based Sheevaplug platform (i.e arm little-endian machine)

---
 drivers/usb/host/ehci-hcd.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
Quoted 17 lines
Quoted 4 lines
Quoted 4 lines
drivers/usb/host/ehci-hcd.c +0 -0
index bbd547b..7a55638 100644
Quoted 8 lines

drivers/usb/host/ehci-hcd.c ehci_submit_root(struct usb_device *dev, unsigned long · line 556

Quoted 8 lines
drivers/usb/host/ehci-hcd.c +1 -0
@@ -550,7 +550,7 @@ ehci_submit_root(struct usb_device *dev, unsigned long
 pipe, void *buffer,
             req->requesttype, req->requesttype,
             le16_to_cpu(req->value), le16_to_cpu(req->index));
 -       typeReq = req->request << 8 | req->requesttype;
+       typeReq = req->request | req->requesttype << 8;
         switch (le16_to_cpu(typeReq)) {
 

To be sure about the difference of opinions here about the le16_to_cpu() macro. Do you agree with this patch? If so, I will apply it.

Linux don't do the swap, ohci hcd switch don't do the swap. I think that we must
remove the macro.
Stefan, is it possible to test this patch on the vct machine? is that a big endian?
machine? I don't understand how other machine can work, I only imagine that macro fix
the bug raised by Prafulla, but change the shift without test without the macro is only a workaround for the marvell board.
Sorry for the delay, but I don't have the ixp465 big endian with me now.

Quoted 4 lines

Kind Regards,

Remy

Michael

#45 lore raw

PATCH 1/1 usb: bugfix driver/usb/host/ehci-hcd.c function ehci_submit_root

This change is cheked in Linux source and fix found to be in sync. This patch is tested for USB host interface on Kirkwood based Sheevaplug platform (ARM little endian board)

Risk: the impact of this patch is not validated on big endian board. This need to be checked...

---
Change log:
v1: le16_to_cpu macro removed for typeReq

 drivers/usb/host/ehci-hcd.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)
drivers/usb/host/ehci-hcd.c +2 -2
index bbd547b..830ae31 100644
@@ -550,9 +550,9 @@ ehci_submit_root(struct usb_device *dev, unsigned long pipe, void *buffer,
 	      req->requesttype, req->requesttype,
 	      le16_to_cpu(req->value), le16_to_cpu(req->index));
 
-	typeReq = req->request << 8 | req->requesttype;
+	typeReq = req->request | req->requesttype << 8;
 
-	switch (le16_to_cpu(typeReq)) {
+	switch (typeReq) {
 	case DeviceRequest | USB_REQ_GET_DESCRIPTOR:
 		switch (le16_to_cpu(req->value) >> 8) {
 		case USB_DT_DEVICE:
Signature · 1 line
1.5.3.3
#46 lore raw

PATCH 1/1 usb: bugfix driver/usb/host/ehci-hcd.c function ehci_submit_root

Hello Prafulla,

2009/7/17 Prafulla Wadaskar <[email protected]>:

Quoted 11 lines

This change is cheked in Linux source and fix found to be in sync. This patch is tested for USB host interface on Kirkwood based Sheevaplug platform (ARM little endian board)

Risk: the impact of this patch is not validated on big endian board. This need to be checked...

---
Change log:
v1: le16_to_cpu macro removed for typeReq

As discussed previously: Applied to u-boot-usb.
Thanks!

Kind Regards,

Remy

#47 lore raw

PATCH 1/1 usb: bugfix driver/usb/host/ehci-hcd.c function ehci_submit_root

Quoted 21 lines

-----Original Message-----
From: l.pinguin at gmail.com [mailto:l.pinguin at gmail.com] On Behalf Of Remy Bohmer
Sent: Saturday, July 18, 2009 2:29 AM
To: Prafulla Wadaskar
Cc: u-boot at lists.denx.de; Ashish Karkare; Prabhanjan Sarnaik
Subject: Re: [U-Boot] [PATCH v1] usb: bugfix driver/usb/host/ehci-hcd.c function ehci_submit_root

Hello Prafulla,

2009/7/17 Prafulla Wadaskar <[email protected]>:

Quoted 7 lines

This change is cheked in Linux source and fix found to be in sync. This patch is tested for USB host interface on Kirkwood based Sheevaplug platform (ARM little endian board)

Risk: the impact of this patch is not validated on big endian board. This need to be checked...

Quoted 7 lines
Quoted 4 lines

---
Change log:
v1: le16_to_cpu macro removed for typeReq

As discussed previously: Applied to u-boot-usb.
Thanks!

Many thanks Remy :-)

Regards..
Prafulla . .

Quoted 5 lines

Kind Regards,

Remy

#48 lore raw

PATCH 1/1 usb: bugfix driver/usb/host/ehci-hcd.c function ehci_submit_root

In reply to Remy Bohmer
Quoted 21 lines

-----Original Message-----
From: l.pinguin at gmail.com [mailto:l.pinguin at gmail.com] On Behalf Of Remy Bohmer
Sent: Saturday, July 18, 2009 2:29 AM
To: Prafulla Wadaskar
Cc: u-boot at lists.denx.de; Ashish Karkare; Prabhanjan Sarnaik
Subject: Re: [U-Boot] [PATCH v1] usb: bugfix driver/usb/host/ehci-hcd.c function ehci_submit_root

Hello Prafulla,

2009/7/17 Prafulla Wadaskar <[email protected]>:

Quoted 7 lines

This change is cheked in Linux source and fix found to be in sync. This patch is tested for USB host interface on Kirkwood based Sheevaplug platform (ARM little endian board)

Risk: the impact of this patch is not validated on big endian board. This need to be checked...

Quoted 7 lines
Quoted 4 lines

---
Change log:
v1: le16_to_cpu macro removed for typeReq

As discussed previously: Applied to u-boot-usb.
Thanks!

Dear Remy
I could not find this patch on u-boot.git/master.
I think pull request for usb (including this patch) is pending. Can you pls do the needful?

Regards..
Prafulla . .

Quoted 5 lines

Kind Regards,

Remy

#49 lore raw

PATCH v6 2/2 Marvell Sheevaplug Board support

In reply to Prafulla Wadaskar

Reference:
http://plugcomputer.org/
http://openplug.org/plugwiki/index.php/Das_U-boot_plug_support

This patch is tested for-
1. Boot from DRAM/NAND flash
2. File transfer using tftp
3. NAND flash read/write/erase
4. Linux kernel and RFS Boot from NAND
5. Enabled USB PHY init for kernel need
6. Boot from USB supported

Note: to boot Kirkwood kernel with USB support,
you should add "usb start" in the boot sequence

---
Change log:
v2: updated as per feedback for v1

v3: updated as per feedback for v2

v4: removed PHY driver dependency, coded in sheevaplug.c

v5: USB support added

v6: config_cmd_default.h used in board config

 MAINTAINERS                           |    4 +
 MAKEALL                               |    1 +
 Makefile                              |    4 +-
 board/Marvell/sheevaplug/Makefile     |   51 +++++++++
 board/Marvell/sheevaplug/config.mk    |   25 ++++
 board/Marvell/sheevaplug/sheevaplug.c |  155 ++++++++++++++++++++++++++
 board/Marvell/sheevaplug/sheevaplug.h |   41 +++++++
 include/configs/sheevaplug.h          |  197 +++++++++++++++++++++++++++++++++
 8 files changed, 477 insertions(+), 1 deletions(-)
 create mode 100644 board/Marvell/sheevaplug/Makefile
 create mode 100644 board/Marvell/sheevaplug/config.mk
 create mode 100644 board/Marvell/sheevaplug/sheevaplug.c
 create mode 100644 board/Marvell/sheevaplug/sheevaplug.h
 create mode 100644 include/configs/sheevaplug.h
MAINTAINERS +4 -0
index 705bac5..2f3b63c 100644
@@ -673,6 +673,10 @@ Hugo Villeneuve <[email protected]>
 
 	SFFSDR		ARM926EJS
 
+Prafulla Wadaskar <[email protected]>
+
+	sheevaplug	ARM926EJS (Kirkwood SoC)
+
 Richard Woodruff <[email protected]>
 
 	omap2420h4	ARM1136EJS
MAKEALL +1 -0
index 41f1445..e987d4a 100755
@@ -522,6 +522,7 @@ LIST_ARM9="			\
 	omap730p2		\
 	sbc2410x		\
 	scb9328			\
+	sheevaplug		\
 	smdk2400		\
 	smdk2410		\
 	trab			\
Makefile +3 -1
index d427760..a66c4c7 100644
@@ -2924,6 +2924,9 @@ sbc2410x_config: unconfig
 scb9328_config	:	unconfig
 	@$(MKCONFIG) $(@:_config=) arm arm920t scb9328 NULL imx
 
+sheevaplug_config: unconfig
+	@$(MKCONFIG) $(@:_config=) arm arm926ejs $(@:_config=) Marvell kirkwood
+
 smdk2400_config	:	unconfig
 	@$(MKCONFIG) $(@:_config=) arm arm920t smdk2400 samsung s3c24x0
 
@@ -3168,7 +3171,6 @@ omap2420h4_config	: unconfig
 qong_config		: unconfig
 	@$(MKCONFIG) $(@:_config=) arm arm1136 qong davedenx mx31
 
-
 #########################################################################
 ## ARM1176 Systems
 #########################################################################
board/Marvell/sheevaplug/Makefile new file +51 -0

51 lines not on this page · raw message

board/Marvell/sheevaplug/config.mk new file +25 -0
new file mode 100644
index 0000000..a4ea769
@@ -0,0 +1,25 @@
+#
+# (C) Copyright 2009
+# Marvell Semiconductor <www.marvell.com>
+# Written-by: Prafulla Wadaskar <[email protected]>
+#
+# See file CREDITS for list of people who contributed to this
+# project.
+#
+# This program is free software; you can redistribute it and/or
+# modify it under the terms of the GNU General Public License as
+# published by the Free Software Foundation; either version 2 of
+# the License, or (at your option) any later version.
+#
+# This program is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU General Public License
+# along with this program; if not, write to the Free Software
+# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston,
+# MA 02110-1301 USA
+#
+
+TEXT_BASE = 0x00600000
board/Marvell/sheevaplug/sheevaplug.c new file +155 -0

155 lines not on this page · raw message

board/Marvell/sheevaplug/sheevaplug.h new file +41 -0

41 lines not on this page · raw message

include/configs/sheevaplug.h new file +197 -0

197 lines not on this page · raw message

Signature · 1 line
1.5.3.3
#50 lore raw

PATCH v6 2/2 Marvell Sheevaplug Board support

include/configs/sheevaplug.h line 92

Quoted 3 lines

+ */

include/configs/sheevaplug.h new file +2 -0
+#undef CONFIG_CMD_FLASH
+#define CONFIG_SYS_NO_FLASH		/* Declare no flash (NOR/SPI) */

please move this 2

include/configs/sheevaplug.h line 101

Quoted 9 lines
include/configs/sheevaplug.h new file +9 -0
+
+#include <config_cmd_default.h>
+#define CONFIG_CMD_AUTOSCRIPT
+#define CONFIG_CMD_DHCP
+#define CONFIG_CMD_ENV
+#define CONFIG_CMD_FAT
+#define CONFIG_CMD_NAND
+#define CONFIG_CMD_PING
+#define CONFIG_CMD_USB

here

Quoted 1 line

+

Otherwise fine

Best Regards,
J.

#51 lore raw

PATCH v6 2/2 Marvell Sheevaplug Board support

Dear Jean-Christophe PLAGNIOL-VILLARD,

Quoted 4 lines · In message <[email protected]> you wrote:

include/configs/sheevaplug.h line 92

Quoted 3 lines

+ */

include/configs/sheevaplug.h new file +2 -0
+#undef CONFIG_CMD_FLASH
+#define CONFIG_SYS_NO_FLASH		/* Declare no flash (NOR/SPI) */

please move this 2

Quoted 10 lines

include/configs/sheevaplug.h line 101

Quoted 9 lines
include/configs/sheevaplug.h new file +9 -0
+
+#include <config_cmd_default.h>
+#define CONFIG_CMD_AUTOSCRIPT
+#define CONFIG_CMD_DHCP
+#define CONFIG_CMD_ENV
+#define CONFIG_CMD_FAT
+#define CONFIG_CMD_NAND
+#define CONFIG_CMD_PING
+#define CONFIG_CMD_USB

here

Why?

Best regards,

Wolfgang Denk

Signature · 5 lines
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
"Unibus timeout fatal trap program lost sorry"  -  An  error  message
printed by DEC's RSTS operating system for the PDP-11
#52 lore raw

PATCH v6 2/2 Marvell Sheevaplug Board support

Quoted 18 lines · Wolfgang Denk

Dear Jean-Christophe PLAGNIOL-VILLARD,

Quoted 4 lines · In message <[email protected]> you wrote:

include/configs/sheevaplug.h line 92

Quoted 3 lines

+ */

include/configs/sheevaplug.h new file +2 -0
+#undef CONFIG_CMD_FLASH
+#define CONFIG_SYS_NO_FLASH		/* Declare no flash (NOR/SPI) */

please move this 2

Quoted 10 lines

include/configs/sheevaplug.h line 101

Quoted 9 lines
include/configs/sheevaplug.h new file +9 -0
+
+#include <config_cmd_default.h>
+#define CONFIG_CMD_AUTOSCRIPT
+#define CONFIG_CMD_DHCP
+#define CONFIG_CMD_ENV
+#define CONFIG_CMD_FAT
+#define CONFIG_CMD_NAND
+#define CONFIG_CMD_PING
+#define CONFIG_CMD_USB

here

Quoted 1 line

Why?

how this suppose to work?
you undef the CMD_FLASH et redefine it from the default?

Best Regards,
J.

#53 lore raw

PATCH v6 2/2 Marvell Sheevaplug Board support

Dear Jean-Christophe PLAGNIOL-VILLARD,

Quoted 15 lines · In message <[email protected]> you wrote:
Quoted 15 lines
Quoted 14 lines

include/configs/sheevaplug.h line 92

Quoted 3 lines
include/configs/sheevaplug.h new file +2 -0
+#undef CONFIG_CMD_FLASH
+#define CONFIG_SYS_NO_FLASH		/* Declare no flash (NOR/SPI) */

please move this 2

include/configs/sheevaplug.h line 101

Quoted 9 lines
include/configs/sheevaplug.h new file +9 -0
+
+#include <config_cmd_default.h>
+#define CONFIG_CMD_AUTOSCRIPT
+#define CONFIG_CMD_DHCP
+#define CONFIG_CMD_ENV
+#define CONFIG_CMD_FAT
+#define CONFIG_CMD_NAND
+#define CONFIG_CMD_PING
+#define CONFIG_CMD_USB

here

Quoted 3 lines
Quoted 1 line

Why?

how this suppose to work?
you undef the CMD_FLASH et redefine it from the default?

Good. It would be nice if you added such an explanation to your comment, so people understand why you are making such requests. Otherwise they might assume you just had to make any comment.

Best regards,

Wolfgang Denk

Signature · 5 lines
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
       There is enough for the need of everyone in this world,
       but not for the greed of everyone.     - Mahatma Gandhi
#54 lore raw

PATCH v6 2/2 Marvell Sheevaplug Board support

Quoted 18 lines · Wolfgang Denk

Dear Jean-Christophe PLAGNIOL-VILLARD,

Quoted 15 lines · In message <[email protected]> you wrote:
Quoted 15 lines
Quoted 14 lines

include/configs/sheevaplug.h line 92

Quoted 3 lines
include/configs/sheevaplug.h new file +2 -0
+#undef CONFIG_CMD_FLASH
+#define CONFIG_SYS_NO_FLASH		/* Declare no flash (NOR/SPI) */

please move this 2

include/configs/sheevaplug.h line 101

Quoted 9 lines
include/configs/sheevaplug.h new file +9 -0
+
+#include <config_cmd_default.h>
+#define CONFIG_CMD_AUTOSCRIPT
+#define CONFIG_CMD_DHCP
+#define CONFIG_CMD_ENV
+#define CONFIG_CMD_FAT
+#define CONFIG_CMD_NAND
+#define CONFIG_CMD_PING
+#define CONFIG_CMD_USB

here

Quoted 7 lines
Quoted 3 lines
Quoted 1 line

Why?

how this suppose to work?
you undef the CMD_FLASH et redefine it from the default?

Good. It would be nice if you added such an explanation to your comment, so people understand why you are making such requests. Otherwise they might assume you just had to make any comment.

ok it was too obvious for me

Best Regards,
J.

#55 lore raw

PATCH v6 2/2 Marvell Sheevaplug Board support

Quoted 11 lines

-----Original Message-----
From: Jean-Christophe PLAGNIOL-VILLARD [mailto:plagnioj at jcrosoft.com]
Sent: Sunday, July 12, 2009 9:37 PM
To: Wolfgang Denk
Cc: Prafulla Wadaskar; Manas Saksena; Ronen Shitrit; Nicolas Pitre; u-boot at lists.denx.de; Ashish Karkare; Prabhanjan Sarnaik; Lennert Buijtenhek
Subject: Re: [U-Boot] [PATCH v6 2/2] Marvell Sheevaplug Board support

Quoted 6 lines
Quoted 5 lines · Wolfgang Denk

Dear Jean-Christophe PLAGNIOL-VILLARD,

Quoted 2 lines · In message <[email protected]> you wrote:
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines

+#undef CONFIG_CMD_FLASH

Dear Jean
I can define this line below

Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

+#define CONFIG_SYS_NO_FLASH /*

But I can't define this line below since CONFIG_CMD_IMLS is defined in config_cmd_default.h under ifndef condition, then I will have to undef it again. Pls suggest??

Secondly,
I think config_cmd_default.h need be tuned for its better usability. FLASH/FPGA/NET/SETGETDCR/IMLS are board specific, should be removed. I know the impact will be to update all other configs which are using it.

Thirdly,
On some of Embedded systems, where memory footprint is a very critical issue, we need to bring down u-boot binary size as small as possible. With this reference using config_cmd_default.h will be problematic.
For this I think-
we should add one more configuration like CONFIG_SMALL_IMAGE to generate smallest image u-boot binary.
This is my requirement for some of board.
What do you think to make it generic ?

In brief,
I am not enjoying using this file :-(
I prefer it should be more generic.
I wish NOT to use this file, shall I ?

Regards..
Prafulla . .

Quoted 22 lines

Declare no flash (NOR/SPI) */

Quoted 3 lines
Quoted 3 lines
Quoted 3 lines
Quoted 3 lines

please move this 2

Review

Quoted 2 lines
(quoted diff) +2 -0
+
+#include <config_cmd_default.h> #define 

CONFIG_CMD_AUTOSCRIPT

Quoted 5 lines
Quoted 5 lines
Quoted 5 lines
Quoted 4 lines

Review

Quoted 3 lines
(quoted diff) +3 -0
+#define CONFIG_CMD_DHCP #define CONFIG_CMD_ENV #define 
+CONFIG_CMD_FAT #define CONFIG_CMD_NAND #define 
+CONFIG_CMD_PING #define CONFIG_CMD_USB

here

Quoted 7 lines
Quoted 3 lines
Quoted 1 line

Why?

how this suppose to work?
you undef the CMD_FLASH et redefine it from the default?

Good. It would be nice if you added such an explanation to your comment, so people understand why you are making such requests. Otherwise they might assume you just had to make any comment.

ok it was too obvious for me

Best Regards,
J.

#56 lore raw

PATCH v6 2/2 Marvell Sheevaplug Board support

Quoted 6 lines · On Monday 13 July 2009 08:06:00 Prafulla Wadaskar wrote:
Quoted 5 lines · Wolfgang Denk
Quoted 4 lines

Dear Jean-Christophe PLAGNIOL-VILLARD,

Quoted 1 line · In message <[email protected]> you wrote:
Quoted 1 line
Quoted 1 line
Quoted 1 line

+#undef CONFIG_CMD_FLASH

Quoted 8 lines

Dear Jean
I can define this line below

Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

+#define CONFIG_SYS_NO_FLASH /*

But I can't define this line below since CONFIG_CMD_IMLS is defined in config_cmd_default.h under ifndef condition, then I will have to undef it again. Pls suggest??

Yes, it seems that config_cmd_default needs some cleanup here. It originates to a time where NOR-FLASH was present on all boards. This is not the case any more. Something like this would be a first step (yes I know, the list is now not alphabetically sorted any more):

include/config_cmd_default.h +1 -1
index 0376e44..4990839 100644
@@ -21,10 +21,10 @@
 #define CONFIG_CMD_CONSOLE     /* coninfo                      */
 #define CONFIG_CMD_ECHO                /* echo arguments               */
 #define CONFIG_CMD_SAVEENV     /* saveenv                      */
-#define CONFIG_CMD_FLASH       /* flinfo, erase, protect       */
 #define CONFIG_CMD_FPGA                /* FPGA configuration Support   */
 #define CONFIG_CMD_IMI         /* iminfo                       */
 #ifndef CONFIG_SYS_NO_FLASH
+#define CONFIG_CMD_FLASH       /* flinfo, erase, protect       */
 #define CONFIG_CMD_IMLS                /* List all found images        */
 #endif
 #define CONFIG_CMD_ITEST       /* Integer (and string) test    */
Quoted 4 lines

Secondly,
I think config_cmd_default.h need be tuned for its better usability. FLASH/FPGA/NET/SETGETDCR/IMLS are board specific, should be removed. I know the impact will be to update all other configs which are using it.

Full Ack.

Quoted 9 lines

Thirdly,
On some of Embedded systems, where memory footprint is a very critical issue, we need to bring down u-boot binary size as small as possible. With this reference using config_cmd_default.h will be problematic. For this I think-
we should add one more configuration like CONFIG_SMALL_IMAGE to generate
smallest image u-boot binary. This is my requirement for some of board. What do you think to make it generic ?

Quoted 4 lines

In brief,
I am not enjoying using this file :-(
I prefer it should be more generic.
I wish NOT to use this file, shall I ?

Again, I don't think its mandatory to use this file. I know that Jean- Christophe asked you to include it, but I personally don't think it has to be done.

Jean-Christophe is on vacation for 1 week. So unfortunately not much will happen in the ARM repository in the meantime.

Best regards,
Stefan

=====================================================================
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: office at denx.de
=====================================================================

#58 lore raw

PATCH v2 1/3 nand: Add Marvell Kirkwood NAND driver

This patch adds a NAND driver for the Marvell Kirkwood SoC's.

---
Change log:
v2: updated as per feedback for v1 (cosmetic change)

 drivers/mtd/nand/Makefile        |    1 +
 drivers/mtd/nand/kirkwood_nand.c |   81 ++++++++++++++++++++++++++++++++++++++
 2 files changed, 82 insertions(+), 0 deletions(-)
 create mode 100644 drivers/mtd/nand/kirkwood_nand.c
drivers/mtd/nand/Makefile +1 -0
index 471cd6b..766c3f0 100644
@@ -40,6 +40,7 @@ COBJS-$(CONFIG_DRIVER_NAND_BFIN) += bfin_nand.o
 COBJS-$(CONFIG_NAND_DAVINCI) += davinci_nand.o
 COBJS-$(CONFIG_NAND_FSL_ELBC) += fsl_elbc_nand.o
 COBJS-$(CONFIG_NAND_FSL_UPM) += fsl_upm.o
+COBJS-$(CONFIG_NAND_KIRKWOOD) += kirkwood_nand.o
 COBJS-$(CONFIG_NAND_NOMADIK) += nomadik.o
 COBJS-$(CONFIG_NAND_S3C2410) += s3c2410_nand.c
 COBJS-$(CONFIG_NAND_S3C64XX) += s3c64xx.o
drivers/mtd/nand/kirkwood_nand.c new file +81 -0

81 lines not on this page · raw message

Signature · 1 line
1.5.3.4
#59 lore raw

PATCH v2 1/3 nand: Add Marvell Kirkwood NAND driver

drivers/mtd/nand/kirkwood_nand.c line 2

Quoted 8 lines · Prafulla Wadaskar
drivers/mtd/nand/kirkwood_nand.c new file +2 -0
new file mode 100644
index 0000000..9cdbe20
@@ -0,0 +1,81 @@
+/*
+ * Copyright (C) Marvell International Ltd. and its affiliates

No year?

drivers/mtd/nand/kirkwood_nand.c line 27

Quoted 4 lines
drivers/mtd/nand/kirkwood_nand.c new file +4 -0
+#include <common.h>
+#include <asm/io.h>
+#include <asm/arch/kirkwood.h>
+#include <nand.h>

I don't see kirkwood.h in upstream, so I guess this should go via an arch tree.

-Scott

#60 lore raw

PATCH v2 1/3 nand: Add Marvell Kirkwood NAND driver

Quoted 12 lines

-----Original Message-----
From: Scott Wood [mailto:scottwood at freescale.com]
Sent: Tuesday, June 23, 2009 3:35 AM
To: Prafulla Wadaskar
Cc: u-boot at lists.denx.de; Ashish Karkare; Prabhanjan Sarnaik; Ronen Shitrit
Subject: Re: [U-Boot] [PATCH v2 1/3][repost] nand: Add Marvell Kirkwood NAND driver

On Sun, Jun 14, 2009 at 10:32:47PM +0530, Prafulla Wadaskar wrote:

Quoted 11 lines

drivers/mtd/nand/kirkwood_nand.c line 2

Quoted 9 lines
drivers/mtd/nand/kirkwood_nand.c new file +2 -0
new file mode 100644
index 0000000..9cdbe20
@@ -0,0 +1,81 @@
+/*
+ * Copyright (C) Marvell International Ltd. and its affiliates

No year?

I will correct this.

Quoted 8 lines

drivers/mtd/nand/kirkwood_nand.c line 27

Quoted 5 lines
drivers/mtd/nand/kirkwood_nand.c new file +4 -0
+#include <common.h>
+#include <asm/io.h>
+#include <asm/arch/kirkwood.h>
+#include <nand.h>

I don't see kirkwood.h in upstream, so I guess this should go via an arch tree.

Kirkwood support is available in arm/next, I hope it will be pulled soon :-) Any way this is dependency for this driver but is this blocker?

I have two options-
1. remove dependency from this patch or
2. get Basic Kirkwood support up streamed
There are some other drivers in pipeline i.e. i2c,spi,usb that needs Basic Kirkwood support. So I wish to go for second option Hi Jean,
Can you pls help to resolve this dependency?

Please let me know your feedback on this issue ASAP so that I can release next spin

Regards..
Prafulla . .

#61 lore raw

PATCH v2 1/3 nand: Add Marvell Kirkwood NAND driver

Quoted 37 lines · Prafulla Wadaskar
Quoted 12 lines

-----Original Message-----
From: Scott Wood [mailto:scottwood at freescale.com]
Sent: Tuesday, June 23, 2009 3:35 AM
To: Prafulla Wadaskar
Cc: u-boot at lists.denx.de; Ashish Karkare; Prabhanjan Sarnaik; Ronen Shitrit
Subject: Re: [U-Boot] [PATCH v2 1/3][repost] nand: Add Marvell Kirkwood NAND driver

On Sun, Jun 14, 2009 at 10:32:47PM +0530, Prafulla Wadaskar wrote:

Quoted 11 lines

drivers/mtd/nand/kirkwood_nand.c line 2

Quoted 9 lines
drivers/mtd/nand/kirkwood_nand.c new file +2 -0
new file mode 100644
index 0000000..9cdbe20
@@ -0,0 +1,81 @@
+/*
+ * Copyright (C) Marvell International Ltd. and its affiliates

No year?

I will correct this.

Quoted 8 lines

drivers/mtd/nand/kirkwood_nand.c line 27

Quoted 5 lines
drivers/mtd/nand/kirkwood_nand.c new file +4 -0
+#include <common.h>
+#include <asm/io.h>
+#include <asm/arch/kirkwood.h>
+#include <nand.h>

I don't see kirkwood.h in upstream, so I guess this should go via an arch tree.

Kirkwood support is available in arm/next, I hope it will be pulled soon :-) Any way this is dependency for this driver but is this blocker?

Quoted 6 lines

I have two options-
1. remove dependency from this patch or
2. get Basic Kirkwood support up streamed
There are some other drivers in pipeline i.e. i2c,spi,usb that needs Basic Kirkwood support. So I wish to go for second option Hi Jean,
Can you pls help to resolve this dependency?

Wolfgang is in vacancy so we will have to wait until he will came back the will be present in the arm tree until and then I will send him a pull request

Best Regards,
J.

#62 lore raw

PATCH v2 1/3 nand: Add Marvell Kirkwood NAND driver

In reply to Prafulla Wadaskar

Prafulla,

Quoted 35 lines
Quoted 10 lines

-----Original Message-----
From: Scott Wood [mailto:scottwood at freescale.com]
Sent: Tuesday, June 23, 2009 3:35 AM
To: Prafulla Wadaskar
Cc: u-boot at lists.denx.de; Ashish Karkare; Prabhanjan Sarnaik; Ronen Shitrit
Subject: Re: [U-Boot] [PATCH v2 1/3][repost] nand: Add Marvell Kirkwood NAND driver

On Sun, Jun 14, 2009 at 10:32:47PM +0530, Prafulla Wadaskar wrote:

Quoted 11 lines

drivers/mtd/nand/kirkwood_nand.c line 2

Quoted 9 lines
drivers/mtd/nand/kirkwood_nand.c new file +2 -0
new file mode 100644
index 0000000..9cdbe20
@@ -0,0 +1,81 @@
+/*
+ * Copyright (C) Marvell International Ltd. and its affiliates

No year?

I will correct this.

Quoted 7 lines

drivers/mtd/nand/kirkwood_nand.c line 27

Quoted 4 lines
drivers/mtd/nand/kirkwood_nand.c new file +4 -0
+#include <common.h>
+#include <asm/io.h>
+#include <asm/arch/kirkwood.h>
+#include <nand.h>

I don't see kirkwood.h in upstream, so I guess this should go via an arch tree.

Kirkwood support is available in arm/next, I hope it will be pulled soon :-) Any way this is dependency for this driver but is this blocker?

Quoted 7 lines

I have two options-
1. remove dependency from this patch or
2. get Basic Kirkwood support up streamed
There are some other drivers in pipeline i.e. i2c,spi,usb that needs Basic Kirkwood support. So I wish to go for second option Hi Jean, Can you pls help to resolve this dependency?

Could you give me a rough time schedule for these new drivers? Do we talk from a view weeks or months?

I have to start writing my board support functions and it would be helpful to decide on which u-boot I want to start (1.1.4 marvell or marvell git).

Thanks,
Dieter

Quoted 9 lines

Please let me know your feedback on this issue ASAP so that I can release next spin

Regards..
Prafulla . .
_______________________________________________
U-Boot mailing list
U-Boot at lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

#63 lore raw

PATCH v2 1/3 nand: Add Marvell Kirkwood NAND driver

Quoted 55 lines

-----Original Message-----
From: Dieter Kiermaier [mailto:dk-arm-linux at gmx.de]
Sent: Tuesday, June 23, 2009 1:23 PM
To: u-boot at lists.denx.de
Cc: Prafulla Wadaskar; Scott Wood; Jean-Christophe PLAGNIOL-VILLARD; Ashish Karkare; Prabhanjan Sarnaik; Ronen Shitrit
Subject: Re: [U-Boot] [PATCH v2 1/3][repost] nand: Add Marvell Kirkwood NAND driver

Prafulla,

Quoted 5 lines
Quoted 5 lines

-----Original Message-----
From: Scott Wood [mailto:scottwood at freescale.com]
Sent: Tuesday, June 23, 2009 3:35 AM
To: Prafulla Wadaskar
Cc: u-boot at lists.denx.de; Ashish Karkare; Prabhanjan

Sarnaik; Ronen

Quoted 17 lines
Quoted 5 lines

Shitrit
Subject: Re: [U-Boot] [PATCH v2 1/3][repost] nand: Add Marvell Kirkwood NAND driver

On Sun, Jun 14, 2009 at 10:32:47PM +0530, Prafulla Wadaskar wrote:

Quoted 11 lines

drivers/mtd/nand/kirkwood_nand.c line 2

Quoted 9 lines
drivers/mtd/nand/kirkwood_nand.c new file +2 -0
new file mode 100644
index 0000000..9cdbe20
@@ -0,0 +1,81 @@
+/*
+ * Copyright (C) Marvell International Ltd. and its affiliates

No year?

Quoted 8 lines

I will correct this.

Quoted 6 lines

drivers/mtd/nand/kirkwood_nand.c line 27

Quoted 4 lines
drivers/mtd/nand/kirkwood_nand.c new file +4 -0
+#include <common.h>
+#include <asm/io.h>
+#include <asm/arch/kirkwood.h>
+#include <nand.h>

I don't see kirkwood.h in upstream, so I guess this

should go via an

Quoted 8 lines
Quoted 1 line

arch tree.

Kirkwood support is available in arm/next, I hope it will be pulled soon
:-) Any way this is dependency for this driver but is this blocker?

I have two options-
1. remove dependency from this patch or 2. get Basic

Kirkwood support

Quoted 1 line

up streamed There are some other drivers in pipeline i.e.

Quoted 8 lines

i2c,spi,usb

Quoted 1 line

that needs Basic Kirkwood support. So I wish to go for

second option

Quoted 2 lines

Hi Jean, Can you pls help to resolve this dependency?

Could you give me a rough time schedule for these new drivers? Do we talk from a view weeks or months?

SPI is ready to use (available on git.marvell.com) USB will be ready latest by ~10thJuly2009 I2C lowest priority (as per need)

Quoted 4 lines

I have to start writing my board support functions and it would be helpful to decide on which u-boot I want to start (1.1.4 marvell or marvell git).

Please use marvell git, 1.1.4 is now outdated and not recommended for new development

Regards..
Prafulla . .

Quoted 16 lines

Thanks,
Dieter

Quoted 9 lines

Please let me know your feedback on this issue ASAP so that I can release next spin

Regards..
Prafulla . .
_______________________________________________
U-Boot mailing list
U-Boot at lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

#64 lore raw

PATCH v2 1/3 nand: Add Marvell Kirkwood NAND driver

Am Dienstag 23 Juni 2009 10:01:28 schrieb Prafulla Wadaskar:

Quoted 67 lines
Quoted 67 lines

-----Original Message-----
From: Dieter Kiermaier [mailto:dk-arm-linux at gmx.de]
Sent: Tuesday, June 23, 2009 1:23 PM
To: u-boot at lists.denx.de
Cc: Prafulla Wadaskar; Scott Wood; Jean-Christophe PLAGNIOL-VILLARD; Ashish Karkare; Prabhanjan Sarnaik; Ronen Shitrit
Subject: Re: [U-Boot] [PATCH v2 1/3][repost] nand: Add Marvell Kirkwood NAND driver

Prafulla,

Quoted 5 lines
Quoted 5 lines

-----Original Message-----
From: Scott Wood [mailto:scottwood at freescale.com]
Sent: Tuesday, June 23, 2009 3:35 AM
To: Prafulla Wadaskar
Cc: u-boot at lists.denx.de; Ashish Karkare; Prabhanjan

Sarnaik; Ronen

Quoted 17 lines
Quoted 5 lines

Shitrit
Subject: Re: [U-Boot] [PATCH v2 1/3][repost] nand: Add Marvell Kirkwood NAND driver

On Sun, Jun 14, 2009 at 10:32:47PM +0530, Prafulla Wadaskar wrote:

Quoted 11 lines

drivers/mtd/nand/kirkwood_nand.c line 2

Quoted 9 lines
drivers/mtd/nand/kirkwood_nand.c new file +2 -0
new file mode 100644
index 0000000..9cdbe20
@@ -0,0 +1,81 @@
+/*
+ * Copyright (C) Marvell International Ltd. and its affiliates

No year?

Quoted 8 lines

I will correct this.

Quoted 6 lines

drivers/mtd/nand/kirkwood_nand.c line 27

Quoted 4 lines
drivers/mtd/nand/kirkwood_nand.c new file +4 -0
+#include <common.h>
+#include <asm/io.h>
+#include <asm/arch/kirkwood.h>
+#include <nand.h>

I don't see kirkwood.h in upstream, so I guess this

should go via an

Quoted 9 lines
Quoted 1 line

arch tree.

Kirkwood support is available in arm/next, I hope it will be pulled soon

:-) Any way this is dependency for this driver but is this blocker?

I have two options-
1. remove dependency from this patch or 2. get Basic

Kirkwood support

Quoted 1 line

up streamed There are some other drivers in pipeline i.e.

i2c,spi,usb

Quoted 1 line

that needs Basic Kirkwood support. So I wish to go for

second option

Quoted 7 lines
Quoted 4 lines
Quoted 1 line

Hi Jean, Can you pls help to resolve this dependency?

Could you give me a rough time schedule for these new drivers? Do we talk from a view weeks or months?

SPI is ready to use (available on git.marvell.com) USB will be ready latest by ~10thJuly2009

Thats fine - you made me a birthday present :)

Quoted 1 line

I2C lowest priority (as per need)

Can I do something to push I2C priority?

Quoted 7 lines
Quoted 4 lines

I have to start writing my board support functions and it would be helpful to decide on which u-boot I want to start (1.1.4 marvell or marvell git).

Please use marvell git, 1.1.4 is now outdated and not recommended for new development

Thats my opinion, too.
Thanks,
Dieter

Quoted 16 lines

Regards..
Prafulla . .

Quoted 12 lines

Thanks,
Dieter

Quoted 9 lines

Please let me know your feedback on this issue ASAP so that I can release next spin

Regards..
Prafulla . .
_______________________________________________
U-Boot mailing list
U-Boot at lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

#65 lore raw

PATCH v2 1/3 nand: Add Marvell Kirkwood NAND driver

Quoted 3 lines
Quoted 2 lines

I2C lowest priority (as per need)

Can I do something to push I2C priority?

If the I/O is shared with gpio you can use bitbanging with few hours

Best Regards,
J.

#66 lore raw

PATCH v2 1/3 nand: Add Marvell Kirkwood NAND driver

Am Dienstag 23 Juni 2009 10:35:31 schrieb Jean-Christophe PLAGNIOL-VILLARD:

Quoted 5 lines
Quoted 3 lines
Quoted 1 line

I2C lowest priority (as per need)

Can I do something to push I2C priority?

If the I/O is shared with gpio you can use bitbanging with few hours

I think this would be the best to start - due to the fact that I need bitbanging for FPGA flashing, too.

Quoted 3 lines

Best Regards,
J.

@Prafulla:
in kirkwood/cpu.c
there are 2 functions:
kw_config_gpio()
kw_config_mpp()

If I implement additional functions like
kw_gpio_direction(int gpio, enum direction)
kw_gpio_set(int gpio, int value)
int value kw_gpio_get(int gpio)

If the functions are implemented in cpu.c are they accessible from cmd_xxx.c functions?

Would this be ok to get it mainline or should there be an special driver for gpio access?

Sorry for my newbie questions :)

Dieter

#67 lore raw

PATCH v2 1/3 nand: Add Marvell Kirkwood NAND driver

Quoted 11 lines

-----Original Message-----
From: Dieter Kiermaier [mailto:dk-arm-linux at gmx.de]
Sent: Tuesday, June 23, 2009 2:18 PM
To: Jean-Christophe PLAGNIOL-VILLARD
Cc: Prafulla Wadaskar; u-boot at lists.denx.de; Scott Wood; Ashish Karkare; Prabhanjan Sarnaik; Ronen Shitrit
Subject: Re: [U-Boot] [PATCH v2 1/3][repost] nand: Add Marvell Kirkwood NAND driver

Quoted 6 lines

Am Dienstag 23 Juni 2009 10:35:31 schrieb Jean-Christophe PLAGNIOL-VILLARD:

Quoted 3 lines
Quoted 3 lines
Quoted 1 line

I2C lowest priority (as per need)

Can I do something to push I2C priority?

Any way this driver will be arround TWSI controller interface by h/w Again if you are using different pins then may not be helpful for you

Quoted 5 lines
Quoted 2 lines

If the I/O is shared with gpio you can use bitbanging with few hours

I think this would be the best to start - due to the fact that I need bitbanging for FPGA flashing, too.

This is a good Idea, start your development with accessing GPIO registers directly

Regards..
Prafulla . . .

#68 lore raw

PATCH v2 1/3 nand: Add Marvell Kirkwood NAND driver

Am Dienstag 23 Juni 2009 12:38:05 schrieb Prafulla Wadaskar:

Quoted 11 lines
Quoted 11 lines

-----Original Message-----
From: Dieter Kiermaier [mailto:dk-arm-linux at gmx.de]
Sent: Tuesday, June 23, 2009 2:18 PM
To: Jean-Christophe PLAGNIOL-VILLARD
Cc: Prafulla Wadaskar; u-boot at lists.denx.de; Scott Wood; Ashish Karkare; Prabhanjan Sarnaik; Ronen Shitrit
Subject: Re: [U-Boot] [PATCH v2 1/3][repost] nand: Add Marvell Kirkwood NAND driver

Am Dienstag 23 Juni 2009 10:35:31 schrieb Jean-Christophe

Quoted 8 lines
Quoted 4 lines

PLAGNIOL-VILLARD:

Quoted 3 lines
Quoted 3 lines
Quoted 1 line

I2C lowest priority (as per need)

Can I do something to push I2C priority?

Any way this driver will be arround TWSI controller interface by h/w Again if you are using different pins then may not be helpful for you

I2C by hardware is ok because the pins are not multiplexed with other important functions as its the case for SPI.
And also I2C isn't _so_ important to bring up the first board revision :)

Quoted 7 lines
Quoted 4 lines
Quoted 1 line

If the I/O is shared with gpio you can use bitbanging with few hours

I think this would be the best to start - due to the fact that I need bitbanging for FPGA flashing, too.

This is a good Idea, start your development with accessing GPIO registers directly

I start working on gpio stuff now and sending my patches to you. Maybe it is helpful for others, too,

Dieter

Quoted 3 lines

Regards..
Prafulla . . .

#69 lore raw

PATCH v2 1/3 nand: Add Marvell Kirkwood NAND driver

Quoted 8 lines · On Tuesday 23 June 2009 13:23:18 Dieter Kiermaier wrote:
Quoted 5 lines
Quoted 2 lines

I think this would be the best to start - due to the fact that I need bitbanging for FPGA flashing, too.

This is a good Idea, start your development with accessing GPIO registers directly

I start working on gpio stuff now and sending my patches to you. Maybe it is helpful for others, too,

Please send your patches not only to Prafulla but to the list as well.

Thanks.

Best regards,
Stefan

=====================================================================
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: office at denx.de
=====================================================================

#70 lore raw

PATCH v2 1/3 nand: Add Marvell Kirkwood NAND driver

In reply to Dieter Kiermaier
Quoted 41 lines

-----Original Message-----
From: Dieter Kiermaier [mailto:dk-arm-linux at gmx.de]
Sent: Tuesday, June 23, 2009 4:53 PM
To: Prafulla Wadaskar
Cc: Jean-Christophe PLAGNIOL-VILLARD; u-boot at lists.denx.de; Scott Wood; Ashish Karkare; Prabhanjan Sarnaik; Ronen Shitrit
Subject: Re: [U-Boot] [PATCH v2 1/3][repost] nand: Add Marvell Kirkwood NAND driver

Am Dienstag 23 Juni 2009 12:38:05 schrieb Prafulla Wadaskar:

Quoted 9 lines
Quoted 9 lines

-----Original Message-----
From: Dieter Kiermaier [mailto:dk-arm-linux at gmx.de]
Sent: Tuesday, June 23, 2009 2:18 PM
To: Jean-Christophe PLAGNIOL-VILLARD
Cc: Prafulla Wadaskar; u-boot at lists.denx.de; Scott Wood; Ashish Karkare; Prabhanjan Sarnaik; Ronen Shitrit
Subject: Re: [U-Boot] [PATCH v2 1/3][repost] nand: Add Marvell Kirkwood NAND driver

Quoted 8 lines
Quoted 6 lines

Am Dienstag 23 Juni 2009 10:35:31 schrieb Jean-Christophe

PLAGNIOL-VILLARD:

Quoted 3 lines
Quoted 3 lines
Quoted 1 line

I2C lowest priority (as per need)

Can I do something to push I2C priority?

Any way this driver will be arround TWSI controller

interface by h/w

Quoted 1 line

Again if you are using different pins then may not be

helpful for you

Quoted 1 line

I2C by hardware is ok because the pins are not multiplexed with other important functions as its the case for SPI. And also I2C isn't _so_ important to bring up the first board revision :)

Quoted 3 lines
Quoted 3 lines
Quoted 2 lines

If the I/O is shared with gpio you can use bitbanging with few hours

Quoted 7 lines
Quoted 5 lines
Quoted 2 lines

I think this would be the best to start - due to the fact that I need bitbanging for FPGA flashing, too.

This is a good Idea, start your development with accessing GPIO registers directly

I start working on gpio stuff now and sending my patches to you. Maybe it is helpful for others, too,

You are most welcomed as one of kirkwood developer for u-boot community
Post your patches to mailing list so that everyone can review and provide you feedback, follow u-boot development guidelines, go through u-boot development documentation..

Best of luck :-)

Regards..
Prafulla . .

Quoted 8 lines

Dieter

Quoted 3 lines

Regards..
Prafulla . . .

#71 lore raw

PATCH v2 1/3 nand: Add Marvell Kirkwood NAND driver

Am Dienstag 23 Juni 2009 14:06:46 schrieb Prafulla Wadaskar:

Quoted 51 lines
Quoted 42 lines

-----Original Message-----
From: Dieter Kiermaier [mailto:dk-arm-linux at gmx.de]
Sent: Tuesday, June 23, 2009 4:53 PM
To: Prafulla Wadaskar
Cc: Jean-Christophe PLAGNIOL-VILLARD; u-boot at lists.denx.de; Scott Wood; Ashish Karkare; Prabhanjan Sarnaik; Ronen Shitrit
Subject: Re: [U-Boot] [PATCH v2 1/3][repost] nand: Add Marvell Kirkwood NAND driver

Am Dienstag 23 Juni 2009 12:38:05 schrieb Prafulla Wadaskar:

Quoted 9 lines
Quoted 9 lines

-----Original Message-----
From: Dieter Kiermaier [mailto:dk-arm-linux at gmx.de]
Sent: Tuesday, June 23, 2009 2:18 PM
To: Jean-Christophe PLAGNIOL-VILLARD
Cc: Prafulla Wadaskar; u-boot at lists.denx.de; Scott Wood; Ashish Karkare; Prabhanjan Sarnaik; Ronen Shitrit
Subject: Re: [U-Boot] [PATCH v2 1/3][repost] nand: Add Marvell Kirkwood NAND driver

Quoted 8 lines
Quoted 6 lines

Am Dienstag 23 Juni 2009 10:35:31 schrieb Jean-Christophe

PLAGNIOL-VILLARD:

Quoted 3 lines
Quoted 3 lines
Quoted 1 line

I2C lowest priority (as per need)

Can I do something to push I2C priority?

Any way this driver will be arround TWSI controller

interface by h/w

Quoted 1 line

Again if you are using different pins then may not be

helpful for you

I2C by hardware is ok because the pins are not multiplexed with other important functions as its the case for SPI. And also I2C isn't _so_ important to bring up the first board revision :)

Quoted 3 lines
Quoted 3 lines
Quoted 2 lines

If the I/O is shared with gpio you can use bitbanging with few hours

Quoted 8 lines
Quoted 5 lines
Quoted 2 lines

I think this would be the best to start - due to the fact that I need bitbanging for FPGA flashing, too.

This is a good Idea, start your development with accessing GPIO registers directly

I start working on gpio stuff now and sending my patches to you. Maybe it is helpful for others, too,

Quoted 7 lines

You are most welcomed as one of kirkwood developer for u-boot community Post your patches to mailing list so that everyone can review and provide you feedback, follow u-boot development guidelines, go through u-boot development documentation..

Best of luck :-)

Thanks to all - it's time to give something back to the community :) And sure - I will send the patches as well to the list!

Dieter

Quoted 7 lines

Regards..
Prafulla . .

Quoted 4 lines

Dieter

Quoted 2 lines

Regards..
Prafulla . . .

#72 lore raw

PATCH v2 1/3 nand: Add Marvell Kirkwood NAND driver

In reply to Scott Wood
Quoted 24 lines

-----Original Message-----
From: Scott Wood [mailto:scottwood at freescale.com]
Sent: Tuesday, June 23, 2009 3:35 AM
To: Prafulla Wadaskar
Cc: u-boot at lists.denx.de; Ashish Karkare; Prabhanjan Sarnaik; Ronen Shitrit
Subject: Re: [U-Boot] [PATCH v2 1/3][repost] nand: Add Marvell Kirkwood NAND driver

drivers/mtd/nand/kirkwood_nand.c line 2

Quoted 9 lines · Prafulla Wadaskar
drivers/mtd/nand/kirkwood_nand.c new file +2 -0
new file mode 100644
index 0000000..9cdbe20
@@ -0,0 +1,81 @@
+/*
+ * Copyright (C) Marvell International Ltd. and its affiliates

No year?

Quoted 7 lines

drivers/mtd/nand/kirkwood_nand.c line 27

Quoted 4 lines
drivers/mtd/nand/kirkwood_nand.c new file +4 -0
+#include <common.h>
+#include <asm/io.h>
+#include <asm/arch/kirkwood.h>
+#include <nand.h>

I don't see kirkwood.h in upstream, so I guess this should go via an arch tree.

Hi Jean,
Similar to spi driver, can you please pull this driver too? I am posting the new spin for suggested modification

Regards..
Prafulla . .

Quoted 5 lines

-Scott

#73 lore raw

PATCH v2 1/3 nand: Add Marvell Kirkwood NAND driver

Quoted 31 lines · Prafulla Wadaskar
Quoted 24 lines

-----Original Message-----
From: Scott Wood [mailto:scottwood at freescale.com]
Sent: Tuesday, June 23, 2009 3:35 AM
To: Prafulla Wadaskar
Cc: u-boot at lists.denx.de; Ashish Karkare; Prabhanjan Sarnaik; Ronen Shitrit
Subject: Re: [U-Boot] [PATCH v2 1/3][repost] nand: Add Marvell Kirkwood NAND driver

drivers/mtd/nand/kirkwood_nand.c line 2

Quoted 9 lines · Prafulla Wadaskar
drivers/mtd/nand/kirkwood_nand.c new file +2 -0
new file mode 100644
index 0000000..9cdbe20
@@ -0,0 +1,81 @@
+/*
+ * Copyright (C) Marvell International Ltd. and its affiliates

No year?

Quoted 7 lines

drivers/mtd/nand/kirkwood_nand.c line 27

Quoted 4 lines
drivers/mtd/nand/kirkwood_nand.c new file +4 -0
+#include <common.h>
+#include <asm/io.h>
+#include <asm/arch/kirkwood.h>
+#include <nand.h>

I don't see kirkwood.h in upstream, so I guess this should go via an arch tree.

Quoted 4 lines

Hi Jean,
Similar to spi driver, can you please pull this driver too? I am posting the new spin for suggested modification

please fix the year and I will

Best Regards,
J.

#74 lore raw

PATCH v3 2/6 nand: Add Marvell Kirkwood NAND driver

This patch adds a NAND driver for the Marvell Kirkwood SoC's

---
Change log:
v2: updated as per feedback for v1 (cosmetic change)

v3: missing year added for copy right statement

 drivers/mtd/nand/Makefile        |    1 +
 drivers/mtd/nand/kirkwood_nand.c |   82 ++++++++++++++++++++++++++++++++++++++
 2 files changed, 83 insertions(+), 0 deletions(-)
 create mode 100644 drivers/mtd/nand/kirkwood_nand.c
drivers/mtd/nand/Makefile +1 -0
index 71dd5b9..d4d3948 100644
@@ -40,6 +40,7 @@ COBJS-$(CONFIG_DRIVER_NAND_BFIN) += bfin_nand.o
 COBJS-$(CONFIG_NAND_DAVINCI) += davinci_nand.o
 COBJS-$(CONFIG_NAND_FSL_ELBC) += fsl_elbc_nand.o
 COBJS-$(CONFIG_NAND_FSL_UPM) += fsl_upm.o
+COBJS-$(CONFIG_NAND_KIRKWOOD) += kirkwood_nand.o
 COBJS-$(CONFIG_NAND_MPC5121_NFC) += mpc5121_nfc.o
 COBJS-$(CONFIG_NAND_NOMADIK) += nomadik.o
 COBJS-$(CONFIG_NAND_S3C2410) += s3c2410_nand.c
drivers/mtd/nand/kirkwood_nand.c new file +82 -0

82 lines not on this page · raw message

Signature · 1 line
1.5.3.3
#75 lore raw

PATCH v3 2/6 nand: Add Marvell Kirkwood NAND driver

Quoted 8 lines · Prafulla Wadaskar

This patch adds a NAND driver for the Marvell Kirkwood SoC's

---
Change log:
v2: updated as per feedback for v1 (cosmetic change)

v3: missing year added for copy right statement

Scott I guess it's ok for you

Best Regards,
J.

#76 lore raw

PATCH v3 2/6 nand: Add Marvell Kirkwood NAND driver

Quoted 10 lines · Jean-Christophe PLAGNIOL-VILLARD
Quoted 8 lines · Prafulla Wadaskar

This patch adds a NAND driver for the Marvell Kirkwood SoC's

---
Change log:
v2: updated as per feedback for v1 (cosmetic change)

v3: missing year added for copy right statement

Scott I guess it's ok for you

ACK

-Scott

#77 lore raw

PATCH v3 2/6 nand: Add Marvell Kirkwood NAND driver

In reply to Prafulla Wadaskar
Quoted 7 lines · Prafulla Wadaskar

This patch adds a NAND driver for the Marvell Kirkwood SoC's

---
Change log:
v2: updated as per feedback for v1 (cosmetic change)

Quoted 6 lines

v3: missing year added for copy right statement

 drivers/mtd/nand/Makefile        |    1 +
 drivers/mtd/nand/kirkwood_nand.c |   82 ++++++++++++++++++++++++++++++++++++++
 2 files changed, 83 insertions(+), 0 deletions(-)
 create mode 100644 drivers/mtd/nand/kirkwood_nand.c

applied to u-boot-arm

Best Regards,
J.

#78 lore raw

PATCH v3 2/6 nand: Add Marvell Kirkwood NAND driver

Quoted 21 lines

-----Original Message-----
From: Jean-Christophe PLAGNIOL-VILLARD [mailto:plagnioj at jcrosoft.com]
Sent: Wednesday, July 08, 2009 2:58 AM
To: Prafulla Wadaskar
Cc: u-boot at lists.denx.de; Ashish Karkare; Prabhanjan Sarnaik; Ronen Shitrit
Subject: Re: [U-Boot] [PATCH v3 2/6] nand: Add Marvell Kirkwood NAND driver

Quoted 9 lines · Prafulla Wadaskar

This patch adds a NAND driver for the Marvell Kirkwood SoC's

---
Change log:
v2: updated as per feedback for v1 (cosmetic change)

v3: missing year added for copy right statement

Quoted 7 lines
Quoted 2 lines
 drivers/mtd/nand/Makefile        |    1 +
 drivers/mtd/nand/kirkwood_nand.c |   82 

++++++++++++++++++++++++++++++++++++++

Quoted 1 line
 2 files changed, 83 insertions(+), 0 deletions(-)  create 

mode 100644

Quoted 1 line

drivers/mtd/nand/kirkwood_nand.c

applied to u-boot-arm

Thanks jean :-)

Regards..
Prafulla . .

Quoted 4 lines

Best Regards,
J.

#79 lore raw

PATCH v2 1/3 nand: Add Marvell Kirkwood NAND driver

In reply to Jean-Christophe PLAGNIOL-VILLARD
Quoted 43 lines

-----Original Message-----
From: Jean-Christophe PLAGNIOL-VILLARD [mailto:plagnioj at jcrosoft.com]
Sent: Saturday, June 27, 2009 8:53 PM
To: Prafulla Wadaskar
Cc: Scott Wood; u-boot at lists.denx.de; Ashish Karkare; Prabhanjan Sarnaik; Ronen Shitrit
Subject: Re: [U-Boot] [PATCH v2 1/3][repost] nand: Add Marvell Kirkwood NAND driver

Quoted 7 lines · Prafulla Wadaskar
Quoted 7 lines

-----Original Message-----
From: Scott Wood [mailto:scottwood at freescale.com]
Sent: Tuesday, June 23, 2009 3:35 AM
To: Prafulla Wadaskar
Cc: u-boot at lists.denx.de; Ashish Karkare; Prabhanjan

Sarnaik; Ronen

Quoted 17 lines
Quoted 17 lines

Shitrit
Subject: Re: [U-Boot] [PATCH v2 1/3][repost] nand: Add Marvell Kirkwood NAND driver

drivers/mtd/nand/kirkwood_nand.c line 2

Quoted 9 lines · Prafulla Wadaskar
drivers/mtd/nand/kirkwood_nand.c new file +2 -0
new file mode 100644
index 0000000..9cdbe20
@@ -0,0 +1,81 @@
+/*
+ * Copyright (C) Marvell International Ltd. and its affiliates

No year?

Quoted 6 lines
Quoted 6 lines

drivers/mtd/nand/kirkwood_nand.c line 27

Quoted 4 lines
drivers/mtd/nand/kirkwood_nand.c new file +4 -0
+#include <common.h>
+#include <asm/io.h>
+#include <asm/arch/kirkwood.h>
+#include <nand.h>

I don't see kirkwood.h in upstream, so I guess this

Quoted 7 lines

should go via an

Quoted 5 lines
Quoted 1 line

arch tree.

Hi Jean,
Similar to spi driver, can you please pull this driver too? I am posting the new spin for suggested modification

please fix the year and I will

Hi Jean
I have already posted v3 for this, but I could not find this in your today's pull request
Ref: http://lists.denx.de/pipermail/u-boot/2009-June/055110.html
Can you please apply this one?

Regards..
Prafulla . .

Quoted 4 lines

Best Regards,
J.

#80 lore raw

PATCH v2 1/3 nand: Add Marvell Kirkwood NAND driver

Quoted 12 lines
Quoted 12 lines
Quoted 6 lines
Quoted 6 lines

drivers/mtd/nand/kirkwood_nand.c line 27

Quoted 4 lines
drivers/mtd/nand/kirkwood_nand.c new file +4 -0
+#include <common.h>
+#include <asm/io.h>
+#include <asm/arch/kirkwood.h>
+#include <nand.h>

I don't see kirkwood.h in upstream, so I guess this

should go via an

Quoted 5 lines
Quoted 1 line

arch tree.

Hi Jean,
Similar to spi driver, can you please pull this driver too? I am posting the new spin for suggested modification

Quoted 5 lines
Quoted 1 line

please fix the year and I will

Hi Jean
I have already posted v3 for this, but I could not find this in your today's pull request
Ref: http://lists.denx.de/pipermail/u-boot/2009-June/055110.html
Can you please apply this one?

I've not seen it but I'll send other pull requests for this release :)

Best Regards,
J.

#81 lore raw

PATCH v2 1/3 nand: Add Marvell Kirkwood NAND driver

In reply to Jean-Christophe PLAGNIOL-VILLARD
Quoted 13 lines

-----Original Message-----
From: Jean-Christophe PLAGNIOL-VILLARD [mailto:plagnioj at jcrosoft.com]
Sent: Saturday, June 13, 2009 7:32 PM
To: Prafulla Wadaskar
Cc: u-boot at lists.denx.de; Manas Saksena; Ronen Shitrit; Nicolas Pitre; Ashish Karkare; Prabhanjan Sarnaik; Lennert Buijtenhek; Scott Wood
Subject: Re: [U-Boot] [PATCH v2 1/3][repost] nand: Add Marvell Kirkwood NAND driver

On 17:34 Mon 08 Jun , Prafulla Wadaskar wrote:

Quoted 8 lines
Quoted 7 lines

This patch adds a NAND driver for the Marvell Kirkwood SoC's.

---
Change log:
v2: updated as per feedback for v1 (cosmetic change)

Scott what is status for you?

Hi Scott,
I have re-posted this driver twice.. Any updates on this?

Regards..
Prafulla . .

Quoted 4 lines

Best Regards,
J.

#82 lore raw

PATCH v2 1/3 nand: Add Marvell Kirkwood NAND driver

Quoted 3 lines · Prafulla Wadaskar
Quoted 1 line

Scott what is status for you?

Hi Scott,
I have re-posted this driver twice.. Any updates on this?

Sorry, I was out the previous week and have been busy catching up this past week. I'll try to get to the stack of pending NAND stuff soon.

-Scott

#83 lore raw

PATCH v3 4/5 Marvell Sheevaplug Board support

In reply to Prafulla Wadaskar

Reference:
http://plugcomputer.org/
http://openplug.org/plugwiki/index.php/Das_U-boot_plug_support

This patch is tested for-
1. Boot from DRAM/NAND flash
2. File transfer using tftp
3. NAND flash read/write/erase
4. Linux kernel and RFS Boot from NAND

---
Change log:
v2: updated as per feedback for v1

v3: updated as per feedback for v2

 MAINTAINERS                           |    4 +
 MAKEALL                               |    1 +
 Makefile                              |    4 +-
 board/Marvell/sheevaplug/Makefile     |   51 +++++++++
 board/Marvell/sheevaplug/config.mk    |   25 +++++
 board/Marvell/sheevaplug/sheevaplug.c |  133 +++++++++++++++++++++++
 board/Marvell/sheevaplug/sheevaplug.h |   37 +++++++
 include/configs/sheevaplug.h          |  191 +++++++++++++++++++++++++++++++++
 8 files changed, 445 insertions(+), 1 deletions(-)
 create mode 100644 board/Marvell/sheevaplug/Makefile
 create mode 100644 board/Marvell/sheevaplug/config.mk
 create mode 100644 board/Marvell/sheevaplug/sheevaplug.c
 create mode 100644 board/Marvell/sheevaplug/sheevaplug.h
 create mode 100644 include/configs/sheevaplug.h
MAINTAINERS +4 -0
index bf076b9..2474481 100644
@@ -655,6 +655,10 @@ Hugo Villeneuve <[email protected]>
 
 	SFFSDR		ARM926EJS
 
+Prafulla Wadaskar <[email protected]>
+
+	sheevaplug	ARM926EJS (Kirkwood SoC)
+
 Richard Woodruff <[email protected]>
 
 	omap2420h4	ARM1136EJS
MAKEALL +1 -0
index 6719d7b..e9b3fa7 100755
@@ -517,6 +517,7 @@ LIST_ARM9="			\
 	omap730p2		\
 	sbc2410x		\
 	scb9328			\
+	sheevaplug		\
 	smdk2400		\
 	smdk2410		\
 	trab			\
Makefile +3 -1
index 8144ecd..daebc59 100644
@@ -2882,6 +2882,9 @@ sbc2410x_config: unconfig
 scb9328_config	:	unconfig
 	@$(MKCONFIG) $(@:_config=) arm arm920t scb9328 NULL imx
 
+sheevaplug_config: unconfig
+	@$(MKCONFIG) $(@:_config=) arm arm926ejs $(@:_config=) Marvell kirkwood
+
 smdk2400_config	:	unconfig
 	@$(MKCONFIG) $(@:_config=) arm arm920t smdk2400 samsung s3c24x0
 
@@ -3110,7 +3113,6 @@ omap2420h4_config	: unconfig
 qong_config		: unconfig
 	@$(MKCONFIG) $(@:_config=) arm arm1136 qong davedenx mx31
 
-
 #########################################################################
 ## ARM1176 Systems
 #########################################################################
board/Marvell/sheevaplug/Makefile new file +51 -0

51 lines not on this page · raw message

board/Marvell/sheevaplug/config.mk new file +25 -0
new file mode 100644
index 0000000..a4ea769
@@ -0,0 +1,25 @@
+#
+# (C) Copyright 2009
+# Marvell Semiconductor <www.marvell.com>
+# Written-by: Prafulla Wadaskar <[email protected]>
+#
+# See file CREDITS for list of people who contributed to this
+# project.
+#
+# This program is free software; you can redistribute it and/or
+# modify it under the terms of the GNU General Public License as
+# published by the Free Software Foundation; either version 2 of
+# the License, or (at your option) any later version.
+#
+# This program is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU General Public License
+# along with this program; if not, write to the Free Software
+# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston,
+# MA 02110-1301 USA
+#
+
+TEXT_BASE = 0x00600000
board/Marvell/sheevaplug/sheevaplug.c new file +133 -0

133 lines not on this page · raw message

board/Marvell/sheevaplug/sheevaplug.h new file +37 -0
new file mode 100644
index 0000000..eb6de80
@@ -0,0 +1,37 @@
+/*
+ * (C) Copyright 2009
+ * Marvell Semiconductor <www.marvell.com>
+ * Written-by: Prafulla Wadaskar <[email protected]>
+ *
+ * See file CREDITS for list of people who contributed to this
+ * project.
+ *
+ * This program is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU General Public License as
+ * published by the Free Software Foundation; either version 2 of
+ * the License, or (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program; if not, write to the Free Software
+ * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston,
+ * MA 02110-1301 USA
+ */
+
+#ifndef __SHEEVAPLUG_H
+#define __SHEEVAPLUG_H
+
+#ifndef MACH_TYPE_SHEEVAPLUG
+#define MACH_TYPE_SHEEVAPLUG	2097
+#endif
+
+#define SHEEVAPLUG_OE_LOW		(~(0))
+#define SHEEVAPLUG_OE_HIGH		(~(0))
+#define SHEEVAPLUG_OE_VAL_LOW		(1 << 29)	/* USB_PWEN low */
+#define SHEEVAPLUG_OE_VAL_HIGH		(1 << 17)	/* LED pin high */
+
+#endif /* __SHEEVAPLUG_H */
include/configs/sheevaplug.h new file +191 -0

191 lines not on this page · raw message

Signature · 1 line
1.5.3.3
#84 lore raw

PATCH v10 1/1 Marvell Kirkwood family SOC support

In reply to Prafulla Wadaskar

Dear Jean and Wolfgang

May you kindly provide your valued comments on this patch since this in important patch to be mainlined FIRST. It might have skipped from your queue :-)

Shall I resend it?

Regards..
Prafulla . .

#85 lore raw

PATCH v10 1/1 Marvell Kirkwood family SOC support

In reply to Prafulla Wadaskar
Quoted 12 lines · On Thursday 21 May 2009 22:24:29 Prafulla Wadaskar wrote:

Kirkwood family controllers are highly integrated SOCs based on Feroceon-88FR131/Sheeva-88SV131 cpu core.

SOC versions supported:-
1) 88F6281-A0 define CONFIG_KW88F6281_A0
2) 88F6192-A0 define CONFIG_KW88F6192_A0

Other supported features:-
1) get_random_hex() fucntion
2) SPI port controller driver
3) PCI Express port initialization

Quoted 6 lines

Contributors:
Yotam Admon <[email protected]>
Michael Blostein <[email protected]

Thanks.

Best regards,
Stefan

=====================================================================
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: office at denx.de
=====================================================================

#86 lore raw

PATCH 1/6 net: merge bugfix: Marvell Kirkwood gigabit ethernet driver

This patch looks okay on u-boot-net.git/next branch
but when it was merged to u-boot.git/master the last line is missing

---
 drivers/net/kirkwood_egiga.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
drivers/net/kirkwood_egiga.c +1 -0
index b43bbf2..3c5db19 100644
@@ -662,3 +662,4 @@ int kirkwood_egiga_initialize(bd_t * bis)
 #endif
 	}
 	return 0;
+}
Signature · 1 line
1.5.3.3
#87 lore raw

PATCH 1/6 net: merge bugfix: Marvell Kirkwood gigabit ethernet driver

Quoted 7 lines · Prafulla Wadaskar

This patch looks okay on u-boot-net.git/next branch
but when it was merged to u-boot.git/master the last line is missing

---
 drivers/net/kirkwood_egiga.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

Ben is ok If I apply it?

Best Regards,
J.

#88 lore raw

PATCH 1/6 net: merge bugfix: Marvell Kirkwood gigabit ethernet driver

Quoted 10 lines · Jean-Christophe PLAGNIOL-VILLARD
Quoted 8 lines · Prafulla Wadaskar

This patch looks okay on u-boot-net.git/next branch
but when it was merged to u-boot.git/master the last line is missing

---
 drivers/net/kirkwood_egiga.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
Quoted 5 lines

Ben is ok If I apply it?

Best Regards,
J.

OK.

regards,
Ben

#90 lore raw

PATCH 3/6 arm: Kirkwood: arch specific updated for ehci-Kirkwood driver support

This patch abstracts Kirkwood arch specific changes to support ehci-kirkwood driver

---
 cpu/arm926ejs/kirkwood/cpu.c             |    6 +-----
 include/asm-arm/arch-kirkwood/cpu.h      |    8 ++++++++
 include/asm-arm/arch-kirkwood/kirkwood.h |    1 +
 3 files changed, 10 insertions(+), 5 deletions(-)
cpu/arm926ejs/kirkwood/cpu.c +1 -5
index 194ba1c..795a739 100644
@@ -74,7 +74,7 @@ unsigned char get_random_hex(void)
  * 64 KByte granularity (e.g., a value of 0x00FF specifies 256 = 16 MByte).
  * NOTE: A value of 0x0 specifies 64-KByte size.
  */
-static unsigned int kw_winctrl_calcsize(unsigned int sizeval)
+unsigned int kw_winctrl_calcsize(unsigned int sizeval)
 {
 	int i;
 	unsigned int j = 0;
@@ -87,10 +87,6 @@ static unsigned int kw_winctrl_calcsize(unsigned int sizeval)
 	return (0x0000ffff & j);
 }
 
-/* prepares data to be loaded in win_Ctrl register */
-#define KWCPU_WIN_CTRL_DATA(size, target, attr, en) (en | (target << 4) \
-			| (attr << 8) | (kw_winctrl_calcsize(size) << 16))
-
 /*
  * kw_config_adr_windows - Configure address Windows
  *
include/asm-arm/arch-kirkwood/cpu.h +8 -0
index 36064ae..d1440af 100644
@@ -29,6 +29,9 @@
 
 #ifndef __ASSEMBLY__
 
+#define KWCPU_WIN_CTRL_DATA(size, target, attr, en) (en | (target << 4) \
+			| (attr << 8) | (kw_winctrl_calcsize(size) << 16))
+
 #define KWGBE_PORT_SERIAL_CONTROL1_REG(_x)	\
 		((_x ? KW_EGIGA0_BASE : KW_EGIGA1_BASE) + 0x44c)
 
@@ -57,6 +60,10 @@ enum kwcpu_target {
 
 enum kwcpu_attrib {
 	KWCPU_ATTR_SASRAM = 0x01,
+	KWCPU_ATTR_DRAM_CS0 = 0x0e,
+	KWCPU_ATTR_DRAM_CS1 = 0x0d,
+	KWCPU_ATTR_DRAM_CS2 = 0x0b,
+	KWCPU_ATTR_DRAM_CS3 = 0x07,
 	KWCPU_ATTR_NANDFLASH = 0x2f,
 	KWCPU_ATTR_SPIFLASH = 0x1e,
 	KWCPU_ATTR_BOOTROM = 0x1d,
@@ -155,5 +162,6 @@ int kw_config_mpp(unsigned int mpp0_7, unsigned int mpp8_15,
 		unsigned int mpp16_23, unsigned int mpp24_31,
 		unsigned int mpp32_39, unsigned int mpp40_47,
 		unsigned int mpp48_55);
+unsigned int kw_winctrl_calcsize(unsigned int sizeval);
 #endif /* __ASSEMBLY__ */
 #endif /* _KWCPU_H */
include/asm-arm/arch-kirkwood/kirkwood.h +1 -0
index d5f25f9..52dafc2 100644
@@ -55,6 +55,7 @@
 #define KW_CPU_REG_BASE			(KW_REGISTER(0x20100))
 #define KW_TIMER_BASE			(KW_REGISTER(0x20300))
 #define KW_REG_PCIE_BASE		(KW_REGISTER(0x40000))
+#define KW_USB20_BASE			(KW_REGISTER(0x50000))
 #define KW_EGIGA0_BASE			(KW_REGISTER(0x72000))
 #define KW_EGIGA1_BASE			(KW_REGISTER(0x76000))
 
Signature · 1 line
1.5.3.3
#91 lore raw

PATCH 3/6 arm: Kirkwood: arch specific updated for ehci-Kirkwood driver support

Quoted 8 lines · Prafulla Wadaskar

This patch abstracts Kirkwood arch specific changes to support ehci-kirkwood driver

---
 cpu/arm926ejs/kirkwood/cpu.c             |    6 +-----
 include/asm-arm/arch-kirkwood/cpu.h      |    8 ++++++++
 include/asm-arm/arch-kirkwood/kirkwood.h |    1 +
 3 files changed, 10 insertions(+), 5 deletions(-)

applied to u-boot-arm

Best Regards,
J.

#92 lore raw

PATCH 4/6 usb: bugfix driver/usb/host/ehci-hcd.c function ehci_submit_root

---
 drivers/usb/host/ehci-hcd.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/usb/host/ehci-hcd.c +1 -1
index bbd547b..7a55638 100644
@@ -550,7 +550,7 @@ ehci_submit_root(struct usb_device *dev, unsigned long pipe, void *buffer,
 	      req->requesttype, req->requesttype,
 	      le16_to_cpu(req->value), le16_to_cpu(req->index));
 
-	typeReq = req->request << 8 | req->requesttype;
+	typeReq = req->request | req->requesttype << 8;
 
 	switch (le16_to_cpu(typeReq)) {
 	case DeviceRequest | USB_REQ_GET_DESCRIPTOR:
Signature · 1 line
1.5.3.3
#93 lore raw

PATCH 4/6 usb: bugfix driver/usb/host/ehci-hcd.c function ehci_submit_root

Quoted 10 lines · Prafulla Wadaskar
---
 drivers/usb/host/ehci-hcd.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/usb/host/ehci-hcd.c +0 -0
index bbd547b..7a55638 100644

drivers/usb/host/ehci-hcd.c ehci_submit_root(struct usb_device *dev, unsigned long pipe, void *buffer, · line 554

Quoted 6 lines
drivers/usb/host/ehci-hcd.c +1 -1
@@ -550,7 +550,7 @@ ehci_submit_root(struct usb_device *dev, unsigned long pipe, void *buffer,
 	      req->requesttype, req->requesttype,
 	      le16_to_cpu(req->value), le16_to_cpu(req->index));
 
-	typeReq = req->request << 8 | req->requesttype;
+	typeReq = req->request | req->requesttype << 8;
 

Sorry, but I'm not sure in this inversion. Are your sure?

drivers/usb/host/ehci-hcd.c ehci_submit_root(struct usb_device *dev, unsigned long pipe, void *buffer, · line 556

Quoted 3 lines
drivers/usb/host/ehci-hcd.c +0 -0
 	switch (le16_to_cpu(typeReq)) {
 

Maybe this one has no sense...
Michael

Quoted 2 lines

case DeviceRequest | USB_REQ_GET_DESCRIPTOR:

#94 lore raw

PATCH 4/6 usb: bugfix driver/usb/host/ehci-hcd.c function ehci_submit_root

Quoted 24 lines

-----Original Message-----
From: Michael Trimarchi [mailto:trimarchi at gandalf.sssup.it]
Sent: Monday, June 29, 2009 5:48 PM
To: Prafulla Wadaskar
Cc: u-boot at lists.denx.de; Ashish Karkare; Prabhanjan Sarnaik; Ronen Shitrit
Subject: Re: [U-Boot] [PATCH 4/6] usb: bugfix driver/usb/host/ehci-hcd.c function ehci_submit_root

Review

Quoted 6 lines · Prafulla Wadaskar
---
 drivers/usb/host/ehci-hcd.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
(quoted diff) +0 -0

b/drivers/usb/host/ehci-hcd.c

drivers/usb/host/ehci-hcd.c ehci_submit_root(struct usb_device

Quoted 4 lines

index bbd547b..7a55638 100644

drivers/usb/host/ehci-hcd.c +0 -0
@@ -550,7 +550,7 @@ ehci_submit_root(struct usb_device 

*dev, unsigned long pipe, void *buffer,

Quoted 7 lines

drivers/usb/host/ehci-hcd.c ehci_submit_root(struct usb_device *dev, unsigned long pipe, void *buffer, · line 554

Quoted 6 lines
drivers/usb/host/ehci-hcd.c +1 -1
 	      req->requesttype, req->requesttype,
 	      le16_to_cpu(req->value), le16_to_cpu(req->index));
 
-	typeReq = req->request << 8 | req->requesttype;
+	typeReq = req->request | req->requesttype << 8;
 

Sorry, but I'm not sure in this inversion. Are your sure?

Hi Michael

I spend enough time debugging USB bring up on Kirkwood assuming this shouldn't be really problem, but it was, with this patch the things are working and logical too.

Regards..
Prafulla . .

#95 lore raw

PATCH 4/6 usb: bugfix driver/usb/host/ehci-hcd.c function ehci_submit_root

Quoted 39 lines · Prafulla Wadaskar
Quoted 30 lines

-----Original Message-----
From: Michael Trimarchi [mailto:trimarchi at gandalf.sssup.it]
Sent: Monday, June 29, 2009 5:48 PM
To: Prafulla Wadaskar
Cc: u-boot at lists.denx.de; Ashish Karkare; Prabhanjan Sarnaik; Ronen Shitrit
Subject: Re: [U-Boot] [PATCH 4/6] usb: bugfix driver/usb/host/ehci-hcd.c function ehci_submit_root

Review

Quoted 7 lines · Prafulla Wadaskar
---
 drivers/usb/host/ehci-hcd.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
(quoted diff) +0 -0

b/drivers/usb/host/ehci-hcd.c

drivers/usb/host/ehci-hcd.c ehci_submit_root(struct usb_device · line 550

Quoted 5 lines

index bbd547b..7a55638 100644

drivers/usb/host/ehci-hcd.c +0 -0
@@ -550,7 +550,7 @@ ehci_submit_root(struct usb_device 
 

*dev, unsigned long pipe, void *buffer,

Quoted 9 lines

drivers/usb/host/ehci-hcd.c ehci_submit_root(struct usb_device *dev, unsigned long pipe, void *buffer,

Quoted 7 lines
drivers/usb/host/ehci-hcd.c +1 -1
 	      req->requesttype, req->requesttype,
 	      le16_to_cpu(req->value), le16_to_cpu(req->index));
 
-	typeReq = req->request << 8 | req->requesttype;
+	typeReq = req->request | req->requesttype << 8;
 
 

Sorry, but I'm not sure in this inversion. Are your sure?

Quoted 7 lines

Hi Michael

I spend enough time debugging USB bring up on Kirkwood assuming this shouldn't be really problem, but it was, with this patch the things are working and logical too.

Regards..
Prafulla . .

Yes, I have drinked somenthing today :(. Linux do the same

typeReq = (cmd->bRequestType << 8) | cmd->bRequest;

Sorry
Michael

#97 lore raw

PATCH 4/6 usb: bugfix driver/usb/host/ehci-hcd.c function ehci_submit_root

Quoted 10 lines · Jean-Christophe PLAGNIOL-VILLARD
Quoted 6 lines · Prafulla Wadaskar
---
 drivers/usb/host/ehci-hcd.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

Remy could you look the marvell usb patch?

I think that this one is correct but not yet tested

Quoted 8 lines

Best Regards,
J.
_______________________________________________
U-Boot mailing list
U-Boot at lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

-------------- next part --------------
A non-text attachment was scrubbed...
Name: ehci_fix.patch
Type: text/x-patch
Size: 7064 bytes
Desc: not available
Url : http://lists.denx.de/pipermail/u-boot/attachments/20090704/d20a1a61/attachment.bin

#98 lore raw

PATCH 4/6 usb: bugfix driver/usb/host/ehci-hcd.c function ehci_submit_root

Hello All,

2009/7/4 Michael Trimarchi <[email protected]>:

Quoted 5 lines
Quoted 4 lines · Jean-Christophe PLAGNIOL-VILLARD
Quoted 1 line · Prafulla Wadaskar
Quoted 8 lines
Quoted 7 lines
Quoted 4 lines

---
?drivers/usb/host/ehci-hcd.c | ? ?2 +-
?1 files changed, 1 insertions(+), 1 deletions(-)

Remy could you look the marvell usb patch?

I think that this one is correct but not yet tested

Sorry for not being very responsive these days... it is vacation time... ;-)

This patch of Michael looks good, and I prefer that patch above the marvell usb patch.
If anybody of you are able of testing it, I can apply it. (I do not have the proper hardware myself)

Kind Regards,

Remy

#99 lore raw

PATCH 4/6 usb: bugfix driver/usb/host/ehci-hcd.c function ehci_submit_root

Quoted 27 lines

-----Original Message-----
From: u-boot-bounces at lists.denx.de [mailto:u-boot-bounces at lists.denx.de] On Behalf Of Remy Bohmer
Sent: Wednesday, July 08, 2009 12:16 AM
To: Michael Trimarchi; Ashish Karkare; Prabhanjan Sarnaik; Ronen Shitrit
Cc: u-boot at lists.denx.de
Subject: Re: [U-Boot] [PATCH 4/6] usb: bugfix driver/usb/host/ehci-hcd.c function ehci_submit_root

Hello All,

2009/7/4 Michael Trimarchi <[email protected]>:

Quoted 12 lines
Quoted 11 lines · Jean-Christophe PLAGNIOL-VILLARD
Quoted 5 lines · Prafulla Wadaskar

---
?drivers/usb/host/ehci-hcd.c | ? ?2 +-
?1 files changed, 1 insertions(+), 1 deletions(-)

Remy could you look the marvell usb patch?

Quoted 7 lines
Quoted 1 line

I think that this one is correct but not yet tested

Sorry for not being very responsive these days... it is vacation time... ;-)

This patch of Michael looks good, and I prefer that patch above the marvell usb patch.

Patch by me ;-D

Quoted 2 lines

If anybody of you are able of testing it, I can apply it. (I do not have the proper hardware myself)

Hi Kumar
I have seen a patch by you to this file
Ref: http://lists.denx.de/pipermail/u-boot/2009-July/055652.html
I hope you have h/w and tested ehci-hcd driver :-)
Can you pls comment on this?
FYI: I have tested it for Sheevaplug Kirkwood hardware
If you get a chance, pls go through my patch, I feel it is logical and even in the kernel too. (ref: line 379: linux/drivers/usb/core/hcd.c)

I wonder why it has not been detected on any other platforms yet! Any one ...Any comments ??

Regards..
Prafulla . .

Quoted 9 lines

Kind Regards,

Remy
_______________________________________________
U-Boot mailing list
U-Boot at lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

#100 lore raw

PATCH 4/6 usb: bugfix driver/usb/host/ehci-hcd.c function ehci_submit_root

Quoted 52 lines · Prafulla Wadaskar
Quoted 30 lines

-----Original Message-----
From: u-boot-bounces at lists.denx.de [mailto:u-boot-bounces at lists.denx.de] On Behalf Of Remy Bohmer
Sent: Wednesday, July 08, 2009 12:16 AM
To: Michael Trimarchi; Ashish Karkare; Prabhanjan Sarnaik; Ronen Shitrit
Cc: u-boot at lists.denx.de
Subject: Re: [U-Boot] [PATCH 4/6] usb: bugfix driver/usb/host/ehci-hcd.c function ehci_submit_root

Hello All,

2009/7/4 Michael Trimarchi <[email protected]>:

Quoted 13 lines
Quoted 11 lines · Jean-Christophe PLAGNIOL-VILLARD
Quoted 5 lines · Prafulla Wadaskar
---
 drivers/usb/host/ehci-hcd.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

Remy could you look the marvell usb patch?

Quoted 8 lines
Quoted 2 lines

I think that this one is correct but not yet tested

Sorry for not being very responsive these days... it is vacation time... ;-)

This patch of Michael looks good, and I prefer that patch above the marvell usb patch.

Patch by me ;-D

Quoted 3 lines

If anybody of you are able of testing it, I can apply it. (I do not have the proper hardware myself)

Hi Kumar
I have seen a patch by you to this file
Ref: http://lists.denx.de/pipermail/u-boot/2009-July/055652.html
I hope you have h/w and tested ehci-hcd driver :-)
Can you pls comment on this?
FYI: I have tested it for Sheevaplug Kirkwood hardware
If you get a chance, pls go through my patch, I feel it is logical and even in the kernel too. (ref: line 379: linux/drivers/usb/core/hcd.c)

Quoted 3 lines

I wonder why it has not been detected on any other platforms yet! Any one ...Any comments ??

Because there was an error in the switch :( maybe, that I fix in my patch, but I can't test now because I don't have any hardware.

- typeReq = req->request << 8 | req->requesttype;
+ typeReq = req->request | req->requesttype << 8;

- switch (le16_to_cpu(typeReq)) {
+ switch (typeReq) {

Michael

Quoted 13 lines

Regards..
Prafulla . .

Quoted 9 lines

Kind Regards,

Remy
_______________________________________________
U-Boot mailing list
U-Boot at lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

#101 lore raw

PATCH 4/6 usb: bugfix driver/usb/host/ehci-hcd.c function ehci_submit_root

Quoted 61 lines · Michael Trimarchi
Quoted 53 lines · Prafulla Wadaskar
Quoted 29 lines

-----Original Message-----
From: u-boot-bounces at lists.denx.de [mailto:u-boot-bounces at lists.denx.de ] On Behalf Of Remy Bohmer
Sent: Wednesday, July 08, 2009 12:16 AM
To: Michael Trimarchi; Ashish Karkare; Prabhanjan Sarnaik; Ronen Shitrit
Cc: u-boot at lists.denx.de
Subject: Re: [U-Boot] [PATCH 4/6] usb: bugfix driver/usb/host/ehci- hcd.c function ehci_submit_root

Hello All,

2009/7/4 Michael Trimarchi <[email protected]>:

Quoted 13 lines
Quoted 11 lines · Jean-Christophe PLAGNIOL-VILLARD
Quoted 5 lines · Prafulla Wadaskar

---
drivers/usb/host/ehci-hcd.c | 2 +-

1 files changed, 1 insertions(+), 1 deletions(-)

Remy could you look the marvell usb patch?

Quoted 8 lines
Quoted 2 lines

I think that this one is correct but not yet tested

Sorry for not being very responsive these days... it is vacation time... ;-)

This patch of Michael looks good, and I prefer that patch above the marvell usb patch.

Patch by me ;-D

Quoted 3 lines

If anybody of you are able of testing it, I can apply it. (I do not have the proper hardware myself)

Hi Kumar
I have seen a patch by you to this file
Ref: http://lists.denx.de/pipermail/u-boot/2009-July/055652.html
I hope you have h/w and tested ehci-hcd driver :-)
Can you pls comment on this?
FYI: I have tested it for Sheevaplug Kirkwood hardware If you get a chance, pls go through my patch, I feel it is logical and even in the kernel too. (ref: line 379: linux/drivers/usb/core/ hcd.c)

Quoted 3 lines

I wonder why it has not been detected on any other platforms yet! Any one ...Any comments ??

Because there was an error in the switch :( maybe, that I fix in my patch,
but I can't test now because I don't have any hardware.

drivers/usb/host/ehci-hcd.c ehci_submit_root(struct usb_device *dev, unsigned long pipe, void *buffer,

Quoted 4 lines
drivers/usb/host/ehci-hcd.c +2 -2
-	typeReq = req->request << 8 | req->requesttype;
+	typeReq = req->request | req->requesttype << 8;
-	switch (le16_to_cpu(typeReq)) {
+	switch (typeReq) {

I'm quite confused by this.. I was just fixing some warnings from the fact that we did some read's but never used the results. If that code has changed (or is going to) than my patch is not needed. I don't think the patch I posted has any side effects beyond getting rid of the warnings.

- k

#102 lore raw

PATCH 4/6 usb: bugfix driver/usb/host/ehci-hcd.c function ehci_submit_root

Quoted 51 lines

-----Original Message-----
From: Kumar Gala [mailto:galak at kernel.crashing.org]
Sent: Wednesday, July 08, 2009 7:43 PM
To: Michael Trimarchi
Cc: Prafulla Wadaskar; Remy Bohmer; u-boot at lists.denx.de; Ashish Karkare; Prabhanjan Sarnaik; Ronen Shitrit
Subject: Re: [U-Boot] [PATCH 4/6] usb: bugfix driver/usb/host/ehci-hcd.c function ehci_submit_root

Quoted 12 lines · Michael Trimarchi
Quoted 11 lines · Prafulla Wadaskar
Quoted 11 lines

-----Original Message-----
From: u-boot-bounces at lists.denx.de [mailto:u-boot-bounces at lists.denx.de
] On Behalf Of Remy Bohmer
Sent: Wednesday, July 08, 2009 12:16 AM
To: Michael Trimarchi; Ashish Karkare; Prabhanjan Sarnaik; Ronen Shitrit
Cc: u-boot at lists.denx.de
Subject: Re: [U-Boot] [PATCH 4/6] usb: bugfix

driver/usb/host/ehci-

Quoted 24 lines
Quoted 24 lines
Quoted 24 lines

hcd.c function ehci_submit_root

Hello All,

2009/7/4 Michael Trimarchi <[email protected]>:

Quoted 10 lines
Quoted 8 lines · Jean-Christophe PLAGNIOL-VILLARD
Quoted 5 lines · Prafulla Wadaskar

---
drivers/usb/host/ehci-hcd.c | 2 +-

1 files changed, 1 insertions(+), 1 deletions(-)
Quoted 5 lines
Quoted 3 lines

Remy could you look the marvell usb patch?

I think that this one is correct but not yet tested

Sorry for not being very responsive these days... it is vacation time... ;-)

Quoted 9 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line

This patch of Michael looks good, and I prefer that patch

above the

Quoted 5 lines
Quoted 5 lines
Quoted 2 lines

marvell usb patch.

Patch by me ;-D

Quoted 1 line

If anybody of you are able of testing it, I can apply it.

(I do not

Quoted 1 line
Quoted 1 line
Quoted 1 line

have the proper hardware myself)

Dear Remy
This patch is last dependency to enable Kirkwood Sheevaplug board support. And I think, nobody else has tested it.
Please kindly apply it before sending pull request for usb.

Regards..
Prafulla . .

Quoted 34 lines
Quoted 8 lines
Quoted 8 lines
Quoted 1 line

Hi Kumar
I have seen a patch by you to this file
Ref: http://lists.denx.de/pipermail/u-boot/2009-July/055652.html
I hope you have h/w and tested ehci-hcd driver :-) Can you pls comment on this?
FYI: I have tested it for Sheevaplug Kirkwood hardware If

you get a

Quoted 1 line
Quoted 1 line

chance, pls go through my patch, I feel it is logical and

even in the

Review

Quoted 13 lines
Quoted 6 lines

kernel too. (ref: line 379: linux/drivers/usb/core/ hcd.c)

I wonder why it has not been detected on any other platforms yet! Any one ...Any comments ??

Because there was an error in the switch :( maybe, that I fix in my patch, but I can't test now because I don't have any hardware.

(quoted diff) +2 -2
-	typeReq = req->request << 8 | req->requesttype;
+	typeReq = req->request | req->requesttype << 8;
-	switch (le16_to_cpu(typeReq)) {
+	switch (typeReq) {

I'm quite confused by this.. I was just fixing some warnings from the fact that we did some read's but never used the results. If that code has changed (or is going to) than my patch is not needed. I don't think the patch I posted has any side effects beyond getting rid of the warnings.

- k

#103 lore raw

PATCH 4/6 usb: bugfix driver/usb/host/ehci-hcd.c function ehci_submit_root

In reply to Jean-Christophe PLAGNIOL-VILLARD
Quoted 11 lines

-----Original Message-----
From: Jean-Christophe PLAGNIOL-VILLARD [mailto:plagnioj at jcrosoft.com]
Sent: Saturday, July 04, 2009 5:17 AM
To: Prafulla Wadaskar
Cc: u-boot at lists.denx.de; Ashish Karkare; Prabhanjan Sarnaik; Ronen Shitrit
Subject: Re: [U-Boot] [PATCH 4/6] usb: bugfix driver/usb/host/ehci-hcd.c function ehci_submit_root

Quoted 7 lines
Quoted 5 lines · Prafulla Wadaskar
---
 drivers/usb/host/ehci-hcd.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

Remy could you look the marvell usb patch?

Dear Remy
Gentle reminder.
Regards..
Prafulla . .

Quoted 4 lines

Best Regards,
J.

#104 lore raw

PATCH 5/6 usb: add Marvell Kirkwood ehci host controller driver

This driver is tested on Sheevaplug platform

---
 drivers/usb/host/Makefile        |    1 +
 drivers/usb/host/ehci-kirkwood.c |  108 ++++++++++++++++++++++++++++++++++++++
 2 files changed, 109 insertions(+), 0 deletions(-)
 create mode 100644 drivers/usb/host/ehci-kirkwood.c
drivers/usb/host/Makefile +1 -0
index ec1d689..940d4a8 100644
@@ -37,6 +37,7 @@ COBJS-$(CONFIG_USB_SL811HS) += sl811-hcd.o
 COBJS-$(CONFIG_USB_EHCI) += ehci-hcd.o
 COBJS-$(CONFIG_USB_EHCI_FSL) += ehci-fsl.o
 COBJS-$(CONFIG_USB_EHCI_IXP4XX) += ehci-ixp.o
+COBJS-$(CONFIG_USB_EHCI_KIRKWOOD) += ehci-kirkwood.o
 COBJS-$(CONFIG_USB_EHCI_PCI) += ehci-pci.o
 COBJS-$(CONFIG_USB_EHCI_VCT) += ehci-vct.o
 
drivers/usb/host/ehci-kirkwood.c new file +108 -0

108 lines not on this page · raw message

Signature · 1 line
1.5.3.3
#105 lore raw

PATCH 5/6 usb: add Marvell Kirkwood ehci host controller driver

Quoted 11 lines

-----Original Message-----
From: Prafulla Wadaskar [mailto:prafulla at marvell.com]
Sent: Monday, June 29, 2009 8:57 PM
To: u-boot at lists.denx.de
Cc: Prabhanjan Sarnaik; Ronen Shitrit; Ashish Karkare; Prafulla Wadaskar
Subject: [PATCH 5/6] usb: add Marvell Kirkwood ehci host controller driver

Quoted 1 line

This driver is tested on Sheevaplug platform

Dear Remy

Sorry for pinging :-)
May be this has been skipped from your huge inbox :-)
Can you pls kindly provide your feedback on this patch or Shall I repost it?

Regards..
Prafulla . .

#106 lore raw

PATCH 5/6 usb: add Marvell Kirkwood ehci host controller driver

Hi,

2009/7/8 Prafulla Wadaskar <[email protected]>:

Quoted 11 lines
Quoted 11 lines

-----Original Message-----
From: Prafulla Wadaskar [mailto:prafulla at marvell.com]
Sent: Monday, June 29, 2009 8:57 PM
To: u-boot at lists.denx.de
Cc: Prabhanjan Sarnaik; Ronen Shitrit; Ashish Karkare; Prafulla Wadaskar
Subject: [PATCH 5/6] usb: add Marvell Kirkwood ehci host controller driver
This driver is tested on Sheevaplug platform

Quoted 4 lines

Dear Remy

Sorry for pinging :-)
May be this has been skipped from your huge inbox :-)

No, it was in there, I just overlooked it...

Quoted 1 line

Can you pls kindly provide your feedback on this patch or Shall I repost it?

This patch looks fine to me.
Applied to u-boot-usb.

Thanks.

Remy

#107 lore raw

PATCH 5/6 usb: add Marvell Kirkwood ehci host controller driver

Quoted 19 lines · Remy Bohmer

Hi,

2009/7/8 Prafulla Wadaskar <[email protected]>:

Quoted 11 lines
Quoted 11 lines

-----Original Message-----
From: Prafulla Wadaskar [mailto:prafulla at marvell.com]
Sent: Monday, June 29, 2009 8:57 PM
To: u-boot at lists.denx.de
Cc: Prabhanjan Sarnaik; Ronen Shitrit; Ashish Karkare; Prafulla Wadaskar
Subject: [PATCH 5/6] usb: add Marvell Kirkwood ehci host controller driver
This driver is tested on Sheevaplug platform

Quoted 4 lines

Dear Remy

Sorry for pinging :-)
May be this has been skipped from your huge inbox :-)

Quoted 6 lines

No, it was in there, I just overlooked it...

Quoted 1 line

Can you pls kindly provide your feedback on this patch or Shall I repost it?

This patch looks fine to me.
Applied to u-boot-usb.

please send the pull request to finsh the sheevaplug support mainline

Best Regards,
J.

#108 lore raw

PATCH 5/6 usb: add Marvell Kirkwood ehci host controller driver

In reply to Remy Bohmer
Quoted 31 lines

-----Original Message-----
From: l.pinguin at gmail.com [mailto:l.pinguin at gmail.com] On Behalf Of Remy Bohmer
Sent: Thursday, July 09, 2009 1:20 AM
To: Prafulla Wadaskar
Cc: u-boot at lists.denx.de; Prabhanjan Sarnaik; Ronen Shitrit; Ashish Karkare
Subject: Re: [PATCH 5/6] usb: add Marvell Kirkwood ehci host controller driver

Hi,

2009/7/8 Prafulla Wadaskar <[email protected]>:

Quoted 9 lines
Quoted 9 lines

-----Original Message-----
From: Prafulla Wadaskar [mailto:prafulla at marvell.com]
Sent: Monday, June 29, 2009 8:57 PM
To: u-boot at lists.denx.de
Cc: Prabhanjan Sarnaik; Ronen Shitrit; Ashish Karkare; Prafulla Wadaskar
Subject: [PATCH 5/6] usb: add Marvell Kirkwood ehci host

controller

Quoted 5 lines
Quoted 1 line

driver This driver is tested on Sheevaplug platform

Dear Remy

Sorry for pinging :-)
May be this has been skipped from your huge inbox :-)

Quoted 8 lines

No, it was in there, I just overlooked it...

Quoted 1 line

Can you pls kindly provide your feedback on this patch or

Shall I repost it?

This patch looks fine to me.
Applied to u-boot-usb.

Thanks Remy
As stated in other email thread too.
Now all dependencies for Sheevaplug board support are in accepted state except this patch http://lists.denx.de/pipermail/u-boot/2009-June/055112.html

Regards..
Prafulla . .

Quoted 4 lines

Thanks.

Remy

#109 lore raw

PATCH 5/6 usb: add Marvell Kirkwood ehci host controller driver

Hello Prafulla,

Quoted 2 lines

As stated in other email thread too.
Now all dependencies for Sheevaplug board support are in accepted state except this patch http://lists.denx.de/pipermail/u-boot/2009-June/055112.html

I know that but I cannot test it because I do not have the hardware, so I depend on others here. (it might be even you). I already mentioned that I would prefer the cleanup patch from Michael Trimarchi, if it is correct.

At least there is 1 significant difference between your patch and the patch of Michael

Your patch contains this:
--------------------------------------------------------
- typeReq = req->request << 8 | req->requesttype;
+ typeReq = req->request | req->requesttype << 8;

switch (le16_to_cpu(typeReq)) {
--------------------------------------------------------

and Michael patch contains this:
--------------------------------------------------------
- typeReq = req->request << 8 | req->requesttype;
+ typeReq = req->request | req->requesttype << 8;

- switch (le16_to_cpu(typeReq)) {
+ switch (typeReq) {
--------------------------------------------------------

So,@least one of them is wrong.
This difference is reason enough for me to not pull either patch in until this is clear.

Kind Regards,

Remy

#110 lore raw

PATCH 5/6 usb: add Marvell Kirkwood ehci host controller driver

Quoted 37 lines

-----Original Message-----
From: l.pinguin at gmail.com [mailto:l.pinguin at gmail.com] On Behalf Of Remy Bohmer
Sent: Thursday, July 09, 2009 1:00 PM
To: Prafulla Wadaskar; Michael Trimarchi
Cc: u-boot at lists.denx.de; Prabhanjan Sarnaik; Ronen Shitrit; Ashish Karkare
Subject: Re: [PATCH 5/6] usb: add Marvell Kirkwood ehci host controller driver

Hello Prafulla,

Quoted 4 lines

As stated in other email thread too.
Now all dependencies for Sheevaplug board support are in accepted state except this patch
http://lists.denx.de/pipermail/u-boot/2009-June/055112.html

I know that but I cannot test it because I do not have the hardware, so I depend on others here. (it might be even you). I already mentioned that I would prefer the cleanup patch from Michael Trimarchi, if it is correct.

At least there is 1 significant difference between your patch and the patch of Michael

Your patch contains this:
--------------------------------------------------------

(quoted diff) +1 -2
-	typeReq = req->request << 8 | req->requesttype;
+	typeReq = req->request | req->requesttype << 8;
 
 	switch (le16_to_cpu(typeReq)) {
--------------------------------------------------------

and Michael patch contains this:
--------------------------------------------------------

Review

Quoted 5 lines
(quoted diff) +2 -2
-	typeReq = req->request << 8 | req->requesttype;
+	typeReq = req->request | req->requesttype << 8;
 
-	switch (le16_to_cpu(typeReq)) {
+	switch (typeReq) {

Dear Remy
These two lines makes no difference for me since le16_to_cpu macro doesn't change anything for arm little-endian machines (i.e. Sheevaplug) Well.. for big endian machines someone need to check since it swaps bytes.

I think we should not remove this macro since it provides arch specific abstraction.

Regards..
Prafulla . .

Quoted 10 lines

--------------------------------------------------------

So, at least one of them is wrong.
This difference is reason enough for me to not pull either patch in until this is clear.

Kind Regards,

Remy

#111 lore raw

PATCH 5/6 usb: add Marvell Kirkwood ehci host controller driver

Hi,

Quoted 16 lines
Quoted 16 lines

At least there is 1 significant difference between your patch and the patch of Michael

Your patch contains this:
--------------------------------------------------------
- ? ? typeReq = req->request << 8 | req->requesttype;
+ ? ? typeReq = req->request | req->requesttype << 8;

? ? ? switch (le16_to_cpu(typeReq)) {
--------------------------------------------------------

and Michael patch contains this:
--------------------------------------------------------
- ? ? typeReq = req->request << 8 | req->requesttype;
+ ? ? typeReq = req->request | req->requesttype << 8;

Quoted 5 lines
Quoted 2 lines

- ? ? switch (le16_to_cpu(typeReq)) {
+ ? ? switch (typeReq) {

Dear Remy
These two lines makes no difference for me since le16_to_cpu macro doesn't change anything for arm little-endian machines (i.e. Sheevaplug) Well.. for big endian machines someone need to check since it swaps bytes.

Exactly!

Quoted 1 line

I think we should not remove this macro since it provides arch specific abstraction.

Well, that depends, if it is not needed it should be removed... So, still I would not prefer to apply patches from which it is obvious that there is something wrong with it.

Kind Regards,

Remy

#112 lore raw

PATCH 5/6 usb: add Marvell Kirkwood ehci host controller driver

In reply to Prafulla Wadaskar
Quoted 42 lines · Prafulla Wadaskar
Quoted 42 lines

-----Original Message-----
From: l.pinguin at gmail.com [mailto:l.pinguin at gmail.com] On Behalf Of Remy Bohmer
Sent: Thursday, July 09, 2009 1:00 PM
To: Prafulla Wadaskar; Michael Trimarchi
Cc: u-boot at lists.denx.de; Prabhanjan Sarnaik; Ronen Shitrit; Ashish Karkare
Subject: Re: [PATCH 5/6] usb: add Marvell Kirkwood ehci host controller driver

Hello Prafulla,

Quoted 5 lines

As stated in other email thread too.
Now all dependencies for Sheevaplug board support are in accepted state except this patch
http://lists.denx.de/pipermail/u-boot/2009-June/055112.html

I know that but I cannot test it because I do not have the hardware, so I depend on others here. (it might be even you). I already mentioned that I would prefer the cleanup patch from Michael Trimarchi, if it is correct.

At least there is 1 significant difference between your patch and the patch of Michael

Your patch contains this:
--------------------------------------------------------

(quoted diff) +1 -2
-	typeReq = req->request << 8 | req->requesttype;
+	typeReq = req->request | req->requesttype << 8;
 
 	switch (le16_to_cpu(typeReq)) {
--------------------------------------------------------

and Michael patch contains this:
--------------------------------------------------------

(quoted diff) +1 -1
-	typeReq = req->request << 8 | req->requesttype;
+	typeReq = req->request | req->requesttype << 8;
Quoted 9 lines

Review

Quoted 3 lines
(quoted diff) +1 -1
-	switch (le16_to_cpu(typeReq)) {
+	switch (typeReq) {

Dear Remy
These two lines makes no difference for me since le16_to_cpu macro doesn't change anything for arm little-endian machines (i.e. Sheevaplug) Well.. for big endian machines someone need to check since it swaps bytes.

I think we should not remove this macro since it provides arch specific abstraction.

If you don't remove the macro I think that you have trouble with big endian machines.

http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=blob;f=drivers/usb/core/hcd.c;h=95ccfa0b9fc52876f5166b3edea039409adf9a33;hb=HEAD

line 442

Michael

Quoted 15 lines

Regards..
Prafulla . .

Quoted 11 lines

--------------------------------------------------------

So, at least one of them is wrong.
This difference is reason enough for me to not pull either patch in until this is clear.

Kind Regards,

Remy

#113 lore raw

PATCH 5/6 usb: add Marvell Kirkwood ehci host controller driver

Quoted 64 lines

-----Original Message-----
From: Michael Trimarchi [mailto:trimarchi at gandalf.sssup.it]
Sent: Thursday, July 09, 2009 9:54 PM
To: Prafulla Wadaskar
Cc: Remy Bohmer; u-boot at lists.denx.de; Prabhanjan Sarnaik; Ronen Shitrit; Ashish Karkare
Subject: Re: [PATCH 5/6] usb: add Marvell Kirkwood ehci host controller driver

Quoted 5 lines · Prafulla Wadaskar
Quoted 5 lines

-----Original Message-----
From: l.pinguin at gmail.com [mailto:l.pinguin at gmail.com] On

Behalf Of

Quoted 4 lines
Quoted 4 lines

Remy Bohmer
Sent: Thursday, July 09, 2009 1:00 PM
To: Prafulla Wadaskar; Michael Trimarchi
Cc: u-boot at lists.denx.de; Prabhanjan Sarnaik; Ronen

Shitrit; Ashish

Quoted 7 lines
Quoted 7 lines

Karkare
Subject: Re: [PATCH 5/6] usb: add Marvell Kirkwood ehci host controller driver

Hello Prafulla,

Quoted 6 lines
Quoted 6 lines
Quoted 5 lines

As stated in other email thread too.
Now all dependencies for Sheevaplug board support are in accepted state except this patch
http://lists.denx.de/pipermail/u-boot/2009-June/055112.html

I know that but I cannot test it because I do not have the

hardware,

Quoted 5 lines
Quoted 5 lines

so I depend on others here. (it might be even you). I already mentioned that I would prefer the cleanup patch from Michael Trimarchi, if it is correct.

At least there is 1 significant difference between your

patch and the

Quoted 15 lines
Quoted 15 lines

patch of Michael

Your patch contains this:
--------------------------------------------------------

(quoted diff) +1 -2
-	typeReq = req->request << 8 | req->requesttype;
+	typeReq = req->request | req->requesttype << 8;
 
 	switch (le16_to_cpu(typeReq)) {
--------------------------------------------------------

and Michael patch contains this:
--------------------------------------------------------

(quoted diff) +1 -1
-	typeReq = req->request << 8 | req->requesttype;
+	typeReq = req->request | req->requesttype << 8;
Quoted 6 lines

Review

Quoted 3 lines
(quoted diff) +1 -1
-	switch (le16_to_cpu(typeReq)) {
+	switch (typeReq) {

Dear Remy
These two lines makes no difference for me since le16_to_cpu macro doesn't change anything for arm little-endian machines

Quoted 8 lines

(i.e. Sheevaplug) Well.. for big endian machines someone need to check since it swaps bytes.

Quoted 2 lines

I think we should not remove this macro since it provides

arch specific abstraction.

Quoted 1 line

If you don't remove the macro I think that you have trouble with big endian machines.

Dear Michael
At least common change in both the patch can be applied, this will at least resolve fix for little endian machines. We can defer second change until somebody tests it

Regards..
Prafulla . .

Quoted 2 lines

http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.g

it;a=blob;f=drivers/usb/core/hcd.c;h=95ccfa0b9fc52876f5166b3edea039409adf9a33;hb=HEAD

Quoted 22 lines

line 442

Michael

Quoted 8 lines

Regards..
Prafulla . .

Quoted 4 lines

--------------------------------------------------------

So, at least one of them is wrong.
This difference is reason enough for me to not pull either

patch in

Quoted 7 lines
Quoted 7 lines

until this is clear.

Kind Regards,

Remy