spaces (label, UUID)
PATCH 1/1 spaces (label, UUID)
Hi,
This patch should fix a small problem that Vladimir spotted and commented on IRC, plus adds a quotes on the label (looks nicer) and clearer in my opinion.
Cheers,
Signature · 2 lines
Carles Pina i Estany http://pinux.info
=== modified file 'ChangeLog'
ChangeLog +5 -0
@@ -1,3 +1,8 @@ +2009-12-28 Carles Pina i Estany <[email protected]> + + * normal/misc.c (grub_normal_print_device_info): Add spaces and double + quotes. + 2009-12-27 Vladimir Serbinenko <[email protected]> * normal/menu_text.c (grub_print_message_indented): Prevent
=== modified file 'normal/misc.c'
misc.c +5 -1
@@ -68,7 +68,10 @@ grub_normal_print_device_info (const chaif (grub_errno ==GRUB_ERR_NONE ) {if (label &&grub_strlen (label)) -grub_printf_ (N_ ("- Label %s" ), label); + { +grub_putchar (' ' ); +grub_printf_ (N_ ("- Label \"%s\"" ), label); + }grub_free (label); } grub_errno =GRUB_ERR_NONE ;
@@ -81,6 +84,7 @@ grub_normal_print_device_info (const chaif (grub_errno ==GRUB_ERR_NONE ) {grub_unixtime2datetime (tm, &datetime); +grub_putchar (' ' ); grub_printf_ (N_("- Last modification time %d-%02d-%02d " "%02d:%02d:%02d %s"), datetime.year, datetime.month, datetime.day,
Hi,
Quoted 1 line · Carles Pina i Estany
This patch should fix a small problem that Vladimir spotted and
Committed.
Signature · 2 lines
Carles Pina i Estany http://pinux.info
Quoted 16 lines · Carles Pina i Estany
=== modified file '
normal/misc.c'misc.c +4
-1@@ -68,7 +68,10 @@ grub_normal_print_device_info (const chaif (grub_errno ==GRUB_ERR_NONE ) {if (label &&grub_strlen (label)) -grub_printf_ (N_ ("- Label %s" ), label); + { +grub_putchar (' ' ); +grub_printf_ (N_ ("- Label \"%s\"" ), label); + }grub_free (label); } grub_errno =GRUB_ERR_NONE ;
misc.c grub_normal_print_device_info (const cha · line 90
Quoted 7 lines
misc.c +1
-0@@ -81,6 +84,7 @@ grub_normal_print_device_info (const chaif (grub_errno ==GRUB_ERR_NONE ) {grub_unixtime2datetime (tm, &datetime); +grub_putchar (' ' ); grub_printf_ (N_("- Last modification time %d-%02d-%02d " "%02d:%02d:%02d %s"), datetime.year, datetime.month, datetime.day,
Why not just add a space before the -?
Uhm, I guess I know the answer in advance :-)
Carles, we shouldn't avoid changing translatable strings at the cost of making the code bigger or less efficient. It's not hard for translators to reuse the old string.
I notice that you committed it already. Please can you adjust?
Signature · 3 lines
Robert Millan "Be the change you want to see in the world" -- Gandhi
Hi,
Quoted 16 lines · Robert Millan
misc.c grub_normal_print_device_info (const cha · line 74
Quoted 12 lines · Carles Pina i Estany
=== modified file '
normal/misc.c'misc.c +4
-1@@ -68,7 +68,10 @@ grub_normal_print_device_info (const chaif (grub_errno ==GRUB_ERR_NONE ) {if (label &&grub_strlen (label)) -grub_printf_ (N_ ("- Label %s" ), label); + { +grub_putchar (' ' ); +grub_printf_ (N_ ("- Label \"%s\"" ), label); + }Why not just add a space before the -?
Quoted 1 line
Uhm, I guess I know the answer in advance :-)
I think that you thought about half of the reasons :-)
Quoted 3 lines
Carles, we shouldn't avoid changing translatable strings at the cost of making the code bigger or less efficient. It's not hard for translators to reuse the old string.
This is half of the reason (and not too bad: this translation will appear as "fuzzy" so it's not everything lost)
The other reason:
http://lists.gnu.org/archive/html/grub-devel/2009-12/msg00131.html
Avoiding to have trailing spaces helps the translators (they will do less mistakes).
Of course makes the code slightly bigger (source code and binary)
Quoted 1 line
I notice that you committed it already. Please can you adjust?
Yes I can adjust, but could you reconfirm if I should adjust after above message?
Thanks,
Signature · 2 lines
Carles Pina i Estany http://pinux.info
Quoted 31 lines · Carles Pina i Estany
Hi,
Quoted 16 lines · Robert Millan
misc.c grub_normal_print_device_info (const cha · line 74
Quoted 12 lines · Carles Pina i Estany
=== modified file '
normal/misc.c'misc.c +4
-1@@ -68,7 +68,10 @@ grub_normal_print_device_info (const chaif (grub_errno ==GRUB_ERR_NONE ) {if (label &&grub_strlen (label)) -grub_printf_ (N_ ("- Label %s" ), label); + { +grub_putchar (' ' ); +grub_printf_ (N_ ("- Label \"%s\"" ), label); + }Why not just add a space before the -?
Quoted 1 line
Uhm, I guess I know the answer in advance :-)
I think that you thought about half of the reasons :-)
Quoted 3 lines
Carles, we shouldn't avoid changing translatable strings at the cost of making the code bigger or less efficient. It's not hard for translators to reuse the old string.
This is half of the reason (and not too bad: this translation will appear as "fuzzy" so it's not everything lost)
Quoted 7 lines
The other reason:
http://lists.gnu.org/archive/html/grub-devel/2009-12/msg00131.htmlAvoiding to have trailing spaces helps the translators (they will do less mistakes).
Of course makes the code slightly bigger (source code and binary)
Meh, ok. I hope we don't have a lot of these...
Signature · 3 lines
Robert Millan "Be the change you want to see in the world" -- Gandhi
Quoted 5 lines · Carles Pina i Estany
Quoted 3 lines
misc.c grub_normal_print_device_info (const cha · line 73
Quoted 3 lines
misc.c +2
-0+grub_putchar (' ' ); +grub_printf_ (N_ ("- Label \"%s\"" ), label);Avoiding to have trailing spaces helps the translators (they will do less mistakes).
In this case it is a space at the beginning, not the end of the string -- does it still have this problem for translators? Or are you perhaps just trying to make code a bit more consistent re: beginning/end of strings?
-Isaac
Hi,
Quoted 9 lines · Isaac Dupree
Quoted 5 lines · Carles Pina i Estany
Quoted 3 lines
misc.c grub_normal_print_device_info (const cha · line 73
Quoted 3 lines
misc.c +2
-0+grub_putchar (' ' ); +grub_printf_ (N_ ("- Label \"%s\"" ), label);Avoiding to have trailing spaces helps the translators (they will do less mistakes).
In this case it is a space at the beginning, not the end of the string -- does it still have this problem for translators? Or are
I would say that it's the same kind of problem.
Quoted 2 lines
you perhaps just trying to make code a bit more consistent re:
beginning/end of strings?
This is true too.
Signature · 2 lines
Carles Pina i Estany http://pinux.info