ppc4xx: Add T3COPR board support (PPC460GT based)
PATCH v2 1/1 ppc4xx: Add T3COPR board support (PPC460GT based)
This patch adds support for the T3CORP board, based on the AppliedMicro (AMCC) PPC460GT.
---
v2: - Fixed spelling: fibre -> fiber
- Rebased on next, no changes to toplevel Makefile needed anymore
MAINTAINERS | 1 + MAKEALL | 1 + board/t3corp/Makefile | 53 +++++ board/t3corp/chip_config.c | 59 +++++ board/t3corp/config.mk | 39 ++++ board/t3corp/init.S | 99 ++++++++ board/t3corp/t3corp.c | 198 ++++++++++++++++ boards.cfg | 1 + include/configs/t3corp.h | 544 ++++++++++++++++++++++++++++++++++++++++++++ 9 files changed, 995 insertions(+), 0 deletions(-) create mode 100644 board/t3corp/Makefile create mode 100644 board/t3corp/chip_config.c create mode 100644 board/t3corp/config.mk create mode 100644 board/t3corp/init.S create mode 100644 board/t3corp/t3corp.c create mode 100644 include/configs/t3corp.h
MAINTAINERS +1 -0
@@ -392,6 +392,7 @@ Stefan Roese <[email protected]> rainier PPC440GRx sequoia PPC440EPx sycamore PPC405GPr + t3corp PPC460GT taishan PPC440GX walnut PPC405GP yellowstone PPC440GR
MAKEALL +1 -0
@@ -262,6 +262,7 @@ LIST_4xx=" \ sc3 \ sequoia \ sequoia_nand \ + t3corp \ taihu \ taishan \ v5fx30teval \
board/t3corp/Makefile new file +53 -0
53 lines not on this page · raw message
board/t3corp/chip_config.c new file +59 -0
59 lines not on this page · raw message
board/t3corp/config.mk new file +39 -0
@@ -0,0 +1,39 @@ +# +# (C) Copyright 2010 +# Stefan Roese, DENX Software Engineering, sr at denx.de. +# +# See file CREDITS for list of people who contributed to this +# project. +# +# This program is free software; you can redistribute it and/or +# modify it under the terms of the GNU General Public License as +# published by the Free Software Foundation; either version 2 of +# the License, or (at your option) any later version. +# +# This program is distributed in the hope that it will be useful, +# but WITHOUT ANY WARRANTY; without even the implied warranty of +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +# GNU General Public License for more details. +# +# You should have received a copy of the GNU General Public License +# along with this program; if not, write to the Free Software +# Foundation, Inc., 59 Temple Place, Suite 330, Boston, +# MA 02111-1307 USA +# +# + +sinclude $(OBJTREE)/board/$(BOARDDIR)/config.tmp + +ifndef TEXT_BASE +TEXT_BASE = 0xFFFA0000 +endif + +PLATFORM_CPPFLAGS += -DCONFIG_440=1 + +ifeq ($(debug),1) +PLATFORM_CPPFLAGS += -DDEBUG +endif + +ifeq ($(dbcr),1) +PLATFORM_CPPFLAGS += -DCONFIG_SYS_INIT_DBCR=0x8cff0000 +endif
board/t3corp/init.S new file +99 -0
99 lines not on this page · raw message
board/t3corp/t3corp.c new file +198 -0
198 lines not on this page · raw message
boards.cfg +1 -0
@@ -183,6 +183,7 @@ lwmon5 powerpc ppc4xx ML2 powerpc ppc4xx sbc405 powerpc ppc4xx sc3 powerpc ppc4xx +t3corp powerpc ppc4xx zeus powerpc ppc4xx acadia powerpc ppc4xx - amcc bamboo powerpc ppc4xx - amcc
include/configs/t3corp.h new file +544 -0
544 lines not on this page · raw message
Signature · 1 line
1.7.1
PATCH v2 1/1 ppc4xx: Add T3COPR board support (PPC460GT based)
Dear Stefan Roese,
Quoted 2 lines · In message <[email protected]> you wrote:
This patch adds support for the T3CORP board, based on the AppliedMicro (AMCC) PPC460GT.
General question: should we rename "amcc" into "apm" ?
...
Quoted 2 lines
(quoted diff) +2
-0+int board_early_init_r(void) +{
...
board/t3corp/t3corp.c line 135
Quoted 8 lines
board/t3corp/t3corp.c new file +8
-0+/* Add TLB entry for 0xfn00.0000 -> 0x4.cn00.0000 */ +program_tlb (CONFIG_SYS_FLASH_BASE_PHYS ,CONFIG_SYS_FLASH_BASE , +CONFIG_SYS_FLASH_SIZE ,TLB_WORD2_I_ENABLE ); + +/* +* Now accessing of the whole 64Mbytes of NOR FLASH at virtual address +* 0xfc00.0000 is possible +*/
What about the configuration with 128 MiB NOR flash? Would it not be more flexible to use something like
program_tlb(CONFIG_SYS_FLASH_END_PHYS-flash_info[0].size, -flash_info[0].size, flash_info[0].size, TLB_WORD2_I_ENABLE);
with
CONFIG_SYS_FLASH_END_PHYS_H = 0x4
and CONFIG_SYS_FLASH_END_PHYS_L = 0xD0000000
?
BTW: Please use "flash" (globally) instead of FLASH - "flash" is not an abbreviation.
board/t3corp/t3corp.c line 181
Quoted 4 lines
board/t3corp/t3corp.c new file +4
-0+int board_pcie_last (void ) +{ +/* +* Only PCIe0 for now, PCIe1 hangs on this boards
"on this board" or "on these boards"
Best regards,
Wolfgang Denk
Signature · 6 lines
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de Lots of people drink from the wrong bottle sometimes. -- Edith Keeler, "The City on the Edge of Forever", stardate unknown
PATCH v2 1/1 ppc4xx: Add T3COPR board support (PPC460GT based)
Hi Wolfgang,
Quoted 4 lines · On Tuesday 29 June 2010 09:52:00 Wolfgang Denk wrote:
Quoted 2 lines
This patch adds support for the T3CORP board, based on the AppliedMicro (AMCC) PPC460GT.
General question: should we rename "amcc" into "apm" ?
Personally, I don't like the idea to change all existing references from AMCC to APM. But you are right. Its better to use AppliedMicro or APM from now on. I'll switch to APM in the next patch version.
Quoted 7 lines
..
Quoted 2 lines
(quoted diff) +2
-0+int board_early_init_r(void) +{..
Quoted 10 lines
board/t3corp/t3corp.c line 135
Quoted 8 lines
board/t3corp/t3corp.c new file +8
-0+/* Add TLB entry for 0xfn00.0000 -> 0x4.cn00.0000 */ +program_tlb (CONFIG_SYS_FLASH_BASE_PHYS ,CONFIG_SYS_FLASH_BASE , +CONFIG_SYS_FLASH_SIZE ,TLB_WORD2_I_ENABLE ); + +/* +* Now accessing of the whole 64Mbytes of NOR FLASH at virtual address +* 0xfc00.0000 is possible +*/ What about the configuration with 128 MiB NOR flash?
Oops. This is a copy-n-paste error. There is no 128 MiB configuration for the T3CORP board. I'll fix the comment and the code in the next patch version.
Quoted 7 lines
Would it not be
more flexible to use something likeprogram_tlb(CONFIG_SYS_FLASH_END_PHYS-flash_info[0].size, -flash_info[0].size, flash_info[0].size, TLB_WORD2_I_ENABLE);
Quoted 5 lines
with
CONFIG_SYS_FLASH_END_PHYS_H = 0x4and
CONFIG_SYS_FLASH_END_PHYS_L=0xD0000000?
Not necessary with a fixed 64MiB board.
Quoted 2 lines
BTW: Please use "flash" (globally) instead of FLASH - "flash" is not an abbreviation.
OK.
Quoted 6 lines
board/t3corp/t3corp.c line 181
Quoted 4 lines
board/t3corp/t3corp.c new file +4
-0+int board_pcie_last (void ) +{ +/* +* Only PCIe0 for now, PCIe1 hangs on this boards "on this board" or "on these boards"
OK. Thanks for the review.
Cheers,
Stefan
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-0 Fax: (+49)-8142-66989-80 Email: office at denx.de