Skip to contentSkip to conversation

mx6dl: Add initial support for Wandboard dual lite

PATCH Superseded Fabio Estevam 3 participants 4 messages Mar 10, 2013 Arm (32-bit)

v2 of 5 Superseded Latest is v5 →

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 mx6dl: Add initial support for Wandboard dual lite

From: Fabio Estevam <[email protected]>

Add initial support for Wandboard dual lite.

Wandboard is a development board that has two variants: one version based on mx6 dual lite and another one based on mx6 solo.

For details on the features of Wandboard, please refer to:
http://www.wandboard.org/

---
This applies on top of Eric's series for adding nitrogen6x boards support.

Changes since v1:
- Use get_ram_size
- Remove ARP_TIMEOUT
- Remove unneeded "1u"

 MAINTAINERS                                |    1 +
 arch/arm/include/asm/arch-mx6/mx6dl_pins.h |    3 +
 board/wandboard/Makefile                   |   29 ++++
 board/wandboard/wandboard.c                |  180 ++++++++++++++++++++++++
 boards.cfg                                 |    1 +
 include/configs/wandboard.h                |  208 ++++++++++++++++++++++++++++
 6 files changed, 422 insertions(+)
 create mode 100644 board/wandboard/Makefile
 create mode 100644 board/wandboard/wandboard.c
 create mode 100644 include/configs/wandboard.h
MAINTAINERS +1 -0
index 42e7664..9e1e169 100644
@@ -659,6 +659,7 @@ Fabio Estevam <[email protected]>
 	mx53smd		i.MX53
 	mx6qsabresd	i.MX6Q
 	mx6qsabreauto	i.MX6Q
+	wandboard	i.MX6DL
 
 Daniel Gorsulowski <[email protected]>
 
arch/arm/include/asm/arch-mx6/mx6dl_pins.h +3 -0
index 9494e41..9846f1b 100644
@@ -50,6 +50,8 @@
 #define NO_MUX_I                0
 #define NO_PAD_I                0
 enum {
+	MX6_PAD_CSI0_DAT10__UART1_TXD		= IOMUX_PAD(0x0360, 0x004C, 3, 0x0000, 0, 0),
+	MX6_PAD_CSI0_DAT11__UART1_RXD		= IOMUX_PAD(0x0364, 0x0050, 3, 0x08FC, 1, 0),
 	MX6_PAD_DI0_DISP_CLK__IPU1_DI0_DISP_CLK = IOMUX_PAD(0x03B0, 0x009C, 0, 0x0000, 0, PAD_CTL_DSE_120ohm),
 	MX6_PAD_DI0_PIN15__IPU1_DI0_PIN15	= IOMUX_PAD(0x03B4, 0x00A0, 0, 0x0000, 0, PAD_CTL_DSE_120ohm),
 	MX6_PAD_DI0_PIN2__IPU1_DI0_PIN2	= IOMUX_PAD(0x03B8, 0x00A4, 0, 0x0000, 0, PAD_CTL_DSE_120ohm),
@@ -90,6 +92,7 @@ enum {
 	MX6_PAD_EIM_D27__UART2_RXD		= IOMUX_PAD(0x0540, 0x0170, 4, 0x0904, 1, 0),
 	MX6_PAD_EIM_D28__I2C1_SDA		= IOMUX_PAD(0x0544, 0x0174, 1 | IOMUX_CONFIG_SION, 0x086C, 1, 0),
 	MX6_PAD_EIM_D28__GPIO_3_28		= IOMUX_PAD(0x0544, 0x0174, 5, 0x0000, 0, 0),
+	MX6_PAD_EIM_D29__GPIO_3_29		= IOMUX_PAD(0x0548, 0x0178, 5, 0x0000, 0, 0),
 	MX6_PAD_ENET_MDC__ENET_MDC		= IOMUX_PAD(0x05B8, 0x01E8, 1, 0x0000, 0,  0),
 	MX6_PAD_ENET_MDIO__ENET_MDIO		= IOMUX_PAD(0x05BC, 0x01EC, 1, 0x0810, 0, 0),
 	MX6_PAD_ENET_REF_CLK__ENET_TX_CLK	= IOMUX_PAD(0x05C0, 0x01F0, 1, 0x0000, 0, 0),
board/wandboard/Makefile new file +29 -0
new file mode 100644
index 0000000..014ea6c
@@ -0,0 +1,29 @@
+#
+# (C) Copyright 2013 Freescale Semiconductor, Inc.
+#
+# This program is free software; you can redistribute it and/or
+# modify it under the terms of the GNU General Public License as
+# published by the Free Software Foundation; either version 2 of
+# the License, or (at your option) any later version.
+#
+
+include $(TOPDIR)/config.mk
+
+LIB    = $(obj)lib$(BOARD).o
+
+COBJS  := wandboard.o
+
+SRCS   := $(COBJS:.o=.c)
+OBJS   := $(addprefix $(obj),$(COBJS))
+
+$(LIB):        $(obj).depend $(OBJS)
+	$(call cmd_link_o_target, $(OBJS))
+
+#########################################################################
+
+# defines $(obj).depend target
+include $(SRCTREE)/rules.mk
+
+sinclude $(obj).depend
+
+#########################################################################
board/wandboard/wandboard.c new file +180 -0

180 lines not on this page · raw message

boards.cfg +1 -0
index 7c3e5f5..3518609 100644
@@ -259,6 +259,7 @@ nitrogen6q                   arm         armv7       nitrogen6x          boundar
 nitrogen6q2g                 arm         armv7       nitrogen6x          boundary       mx6		nitrogen6x:IMX_CONFIG=board/boundary/nitrogen6x/nitrogen6q2g.cfg,MX6Q
 nitrogen6s                   arm         armv7       nitrogen6x          boundary       mx6		nitrogen6x:IMX_CONFIG=board/boundary/nitrogen6x/nitrogen6s.cfg,MX6S
 nitrogen6s1g                 arm         armv7       nitrogen6x          boundary       mx6		nitrogen6x:IMX_CONFIG=board/boundary/nitrogen6x/nitrogen6s1g.cfg,MX6S
+wandboard_dl		     arm	 armv7	     wandboard		 -		mx6 wandboard:IMX_CONFIG=board/boundary/nitrogen6x/nitrogen6dl.cfg,MX6DL
 cm_t35                       arm         armv7       cm_t35              -              omap3
 omap3_overo                  arm         armv7       overo               -              omap3
 omap3_pandora                arm         armv7       pandora             -              omap3
include/configs/wandboard.h new file +208 -0

208 lines not on this page · raw message

Signature · 1 line
1.7.9.5
#1 lore raw

PATCH v2 1/1 mx6dl: Add initial support for Wandboard dual lite

Dear Fabio Estevam,

Quoted 2 lines · In message <[email protected]> you wrote:

Add initial support for Wandboard dual lite.

...

Quoted 4 lines

Changes since v1:
- Use get_ram_size
- Remove ARP_TIMEOUT
- Remove unneeded "1u"

Thanks. I have still a question:

board/wandboard/wandboard.c line 47

Quoted 6 lines
board/wandboard/wandboard.c new file +6 -0
+int dram_init(void)
+{
+	gd->ram_size = get_ram_size((void *)PHYS_SDRAM, PHYS_SDRAM_SIZE);
+
+	return 0;
+}

I see this new code does not reference imx_ddr_size() any more. If it's so easy to switch to get_ram_size(), should we not then also convert the existing MX53 and MX6 boards to using get_ram_size(), and remove the then unneeded imx_ddr_size() code?

Or would there be any drawbacks?

Best regards,

Wolfgang Denk

Signature · 6 lines
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
As far as the laws of mathematics refer to reality, they are not cer-
tain, and as far as they are certain, they do not refer  to  reality.
                                                   -- Albert Einstein
#2 lore raw

PATCH v2 1/1 mx6dl: Add initial support for Wandboard dual lite

Hi Wolfgang,

Quoted 26 lines · Wolfgang Denk

Dear Fabio Estevam,

Quoted 2 lines · In message <[email protected]> you wrote:

Add initial support for Wandboard dual lite.

...

Quoted 4 lines

Changes since v1:
- Use get_ram_size
- Remove ARP_TIMEOUT
- Remove unneeded "1u"

Thanks. I have still a question:

board/wandboard/wandboard.c line 47

Quoted 6 lines
board/wandboard/wandboard.c new file +6 -0
+int dram_init(void)
+{
+	gd->ram_size = get_ram_size((void *)PHYS_SDRAM, PHYS_SDRAM_SIZE);
+
+	return 0;
+}

I see this new code does not reference imx_ddr_size() any more. If it's so easy to switch to get_ram_size(), should we not then also convert the existing MX53 and MX6 boards to using get_ram_size(), and remove the then unneeded imx_ddr_size() code?

Quoted 2 lines

Or would there be any drawbacks?

In the specific case of Nitrogen6X, we're defining different configurations for each of the memory arrangements, so we could skip the call to imx_ddr_size().

For that matter, we could skip the call to get_ram_size() entirely because we're configuring each of the DDR settings very explicitly.

Since there are timing difference between the x128M and x256M DDR chips we're using, we've split them off into separate files:

	1066mhz_4x128mx16.cfg
	1066mhz_4x256mx16.cfg

and defined two board configurations to select between the two.

Regards,

Eric

#3 lore raw

PATCH v2 1/1 mx6dl: Add initial support for Wandboard dual lite

Dear Eric Nelson,

Quoted 6 lines · In message <[email protected]> you wrote:
Quoted 6 lines

I see this new code does not reference imx_ddr_size() any more. If it's so easy to switch to get_ram_size(), should we not then also convert the existing MX53 and MX6 boards to using get_ram_size(), and remove the then unneeded imx_ddr_size() code?

Quoted 6 lines
Quoted 2 lines

Or would there be any drawbacks?

In the specific case of Nitrogen6X, we're defining different configurations for each of the memory arrangements, so we could skip the call to imx_ddr_size().

Well, that was the starting point of my questions - don;t you want to have a single image runnign on all of your systems? That's exactly get_ram_size() has been made for...

Quoted 2 lines

For that matter, we could skip the call to get_ram_size() entirely because we're configuring each of the DDR settings very explicitly.

get_ram_size() is not about configuring, but about verifying / checking the result of such a configuration.

Quoted 2 lines

Since there are timing difference between the x128M and x256M DDR chips we're using, we've split them off into separate files:

That's OK - but this is still no reason not to support all these
configurations in a single U-Boot image. After all, this is exactly
how U-Boot has been designed right from the beginning.

Best regards,

Wolfgang Denk

Signature · 5 lines
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Committee, n.:  A group of men who individually can do nothing but as
a group decide that nothing can be done.                 - Fred Allen