Skip to contentSkip to conversation

Add support for the Dallas/Maxim DS1705

PATCH In review Jean Delvare 2 participants 6 messages Mar 12, 2013

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 5/5 Add support for the Dallas/Maxim DS1705

Basically it's the same as the original DS17 but much faster.

---
 Documentation/hwmon/lm75 |    8 ++++----
 drivers/hwmon/Kconfig    |    2 +-
 drivers/hwmon/lm75.c     |    7 +++++++
 3 files changed, 12 insertions(+), 5 deletions(-)
Documentation/hwmon/lm75 +4 -4
@@ -12,11 +12,11 @@ Supported chips:
     Addresses scanned: I2C 0x48 - 0x4f
     Datasheet: Publicly available at the National Semiconductor website
                http://www.national.com/
-  * Dallas Semiconductor DS75, DS1775
-    Prefixes: 'ds75', 'ds1775'
+  * Dallas Semiconductor (now Maxim) DS75, DS1775, DS7505
+    Prefixes: 'ds75', 'ds1775', 'ds7505'
     Addresses scanned: none
-    Datasheet: Publicly available at the Dallas Semiconductor website
-               http://www.maxim-ic.com/
+    Datasheet: Publicly available at the Maxim website
+               http://www.maximintegrated.com/
   * Maxim MAX6625, MAX6626
     Prefixes: 'max6625', 'max6626'
     Addresses scanned: none
drivers/hwmon/Kconfig +1 -1
@@ -588,7 +588,7 @@ config SENSORS_LM75
 	  temperature sensor chip, with models including:
 
 		- Analog Devices ADT75
-		- Dallas Semiconductor DS75 and DS1775
+		- Dallas Semiconductor DS75, DS1775 and DS7505
 		- Maxim MAX6625 and MAX6626
 		- Microchip MCP980x
 		- National Semiconductor LM75, LM75A
drivers/hwmon/lm75.c +7 -0
@@ -38,6 +38,7 @@ enum lm75_type {		/* keep sorted in alph
 	adt75,
 	ds1775,
 	ds75,
+	ds7505,
 	lm75,
 	lm75a,
 	max6625,
@@ -202,6 +203,11 @@ lm75_probe(struct i2c_client *client, co
 		data->resolution = 11;
 		data->sample_time = HZ;
 		break;
+	case ds7505:
+		set_mask |= 3 << 5;		/* 12-bit mode */
+		data->resolution = 12;
+		data->sample_time = HZ / 4;
+		break;
 	case lm75:
 	case lm75a:
 		data->resolution = 9;
@@ -289,6 +295,7 @@ static const struct i2c_device_id lm75_i
 	{ "adt75", adt75, },
 	{ "ds1775", ds1775, },
 	{ "ds75", ds75, },
+	{ "ds7505", ds7505, },
 	{ "lm75", lm75, },
 	{ "lm75a", lm75a, },
 	{ "max6625", max6625, },
Signature · 6 lines
Jean Delvare

_______________________________________________
lm-sensors mailing list
[email protected]
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
maintainer
#1 lore raw
Quoted 12 lines · Jean Delvare

Basically it's the same as the original DS17 but much faster.

---
 Documentation/hwmon/lm75 |    8 ++++----
 drivers/hwmon/Kconfig    |    2 +-
 drivers/hwmon/lm75.c     |    7 +++++++
 3 files changed, 12 insertions(+), 5 deletions(-)

Documentation/hwmon/lm75 Supported chips: · line 15

Quoted 6 lines
Documentation/hwmon/lm75 +1 -2
@@ -12,11 +12,11 @@ Supported chips:
     Addresses scanned: I2C 0x48 - 0x4f
     Datasheet: Publicly available at the National Semiconductor website
                http://www.national.com/
-  * Dallas Semiconductor DS75, DS1775
-    Prefixes: 'ds75', 'ds1775'
+  * Dallas Semiconductor (now Maxim) DS75, DS1775, DS7505

Hi Jean,

Headline says DS1705. Looking into the datasheets, I guess the headline is wrong, or I am missing something.

Otherwise Acked-by: Guenter Roeck <[email protected]>

Quoted 59 lines
Documentation/hwmon/lm75 +3 -2
+    Prefixes: 'ds75', 'ds1775', 'ds7505'
     Addresses scanned: none
-    Datasheet: Publicly available at the Dallas Semiconductor website
-               http://www.maxim-ic.com/
+    Datasheet: Publicly available at the Maxim website
+               http://www.maximintegrated.com/
   * Maxim MAX6625, MAX6626
     Prefixes: 'max6625', 'max6626'
     Addresses scanned: none
drivers/hwmon/Kconfig +1 -1
@@ -588,7 +588,7 @@ config SENSORS_LM75
 	  temperature sensor chip, with models including:
 
 		- Analog Devices ADT75
-		- Dallas Semiconductor DS75 and DS1775
+		- Dallas Semiconductor DS75, DS1775 and DS7505
 		- Maxim MAX6625 and MAX6626
 		- Microchip MCP980x
 		- National Semiconductor LM75, LM75A
drivers/hwmon/lm75.c +7 -0
@@ -38,6 +38,7 @@ enum lm75_type {		/* keep sorted in alph
 	adt75,
 	ds1775,
 	ds75,
+	ds7505,
 	lm75,
 	lm75a,
 	max6625,
@@ -202,6 +203,11 @@ lm75_probe(struct i2c_client *client, co
 		data->resolution = 11;
 		data->sample_time = HZ;
 		break;
+	case ds7505:
+		set_mask |= 3 << 5;		/* 12-bit mode */
+		data->resolution = 12;
+		data->sample_time = HZ / 4;
+		break;
 	case lm75:
 	case lm75a:
 		data->resolution = 9;
@@ -289,6 +295,7 @@ static const struct i2c_device_id lm75_i
 	{ "adt75", adt75, },
 	{ "ds1775", ds1775, },
 	{ "ds75", ds75, },
+	{ "ds7505", ds7505, },
 	{ "lm75", lm75, },
 	{ "lm75a", lm75a, },
 	{ "max6625", max6625, },
Signature · 7 lines
-- 
Jean Delvare

_______________________________________________
lm-sensors mailing list
[email protected]
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

_______________________________________________
lm-sensors mailing list
[email protected]
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

#2 lore raw
In reply to Jean Delvare
Quoted 22 lines · Guenter Roeck
Quoted 12 lines · Jean Delvare

Basically it's the same as the original DS17 but much faster.

---
 Documentation/hwmon/lm75 |    8 ++++----
 drivers/hwmon/Kconfig    |    2 +-
 drivers/hwmon/lm75.c     |    7 +++++++
 3 files changed, 12 insertions(+), 5 deletions(-)

Documentation/hwmon/lm75 Supported chips: · line 15

Quoted 6 lines
Documentation/hwmon/lm75 +1 -2
@@ -12,11 +12,11 @@ Supported chips:
     Addresses scanned: I2C 0x48 - 0x4f
     Datasheet: Publicly available at the National Semiconductor website
                http://www.national.com/
-  * Dallas Semiconductor DS75, DS1775
-    Prefixes: 'ds75', 'ds1775'
+  * Dallas Semiconductor (now Maxim) DS75, DS1775, DS7505

Hi Jean,

Quoted 2 lines

Headline says DS1705. Looking into the datasheets, I guess the headline is wrong, or I am missing something.

Doh, yes, typo in the headline _and_ the header comment (DS75 not DS17.) Not sure how I managed to miss both. Thanks for spotting, will resend.

Quoted 1 line

Otherwise Acked-by: Guenter Roeck <[email protected]>

BTW I'll take all these patches in my own tree if this is OK with you. Not sure why you took my previous lm75 patch (Update header inclusion) in yours.

Signature · 6 lines
Jean Delvare

_______________________________________________
lm-sensors mailing list
[email protected]
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
maintainer
#3 lore raw
In reply to Jean Delvare
Quoted 30 lines · Jean Delvare
Quoted 22 lines · Guenter Roeck
Quoted 12 lines · Jean Delvare

Basically it's the same as the original DS17 but much faster.

---
 Documentation/hwmon/lm75 |    8 ++++----
 drivers/hwmon/Kconfig    |    2 +-
 drivers/hwmon/lm75.c     |    7 +++++++
 3 files changed, 12 insertions(+), 5 deletions(-)

Documentation/hwmon/lm75 Supported chips: · line 15

Quoted 6 lines
Documentation/hwmon/lm75 +1 -2
@@ -12,11 +12,11 @@ Supported chips:
     Addresses scanned: I2C 0x48 - 0x4f
     Datasheet: Publicly available at the National Semiconductor website
                http://www.national.com/
-  * Dallas Semiconductor DS75, DS1775
-    Prefixes: 'ds75', 'ds1775'
+  * Dallas Semiconductor (now Maxim) DS75, DS1775, DS7505

Hi Jean,

Quoted 2 lines

Headline says DS1705. Looking into the datasheets, I guess the headline is wrong, or I am missing something.

Doh, yes, typo in the headline _and_ the header comment (DS75 not DS17.) Not sure how I managed to miss both. Thanks for spotting, will resend.

Quoted 6 lines
Quoted 1 line

Otherwise Acked-by: Guenter Roeck <[email protected]>

BTW I'll take all these patches in my own tree if this is OK with you. Not sure why you took my previous lm75 patch (Update header inclusion) in yours.

Mostly because you had asked me to handle 3.8. Maybe that was a misunderstanding. Sorry if I stepped on your feet ... want me to drop it ?

Thanks,
Guenter

_______________________________________________
lm-sensors mailing list
[email protected]
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

#4 lore raw
In reply to Jean Delvare
Quoted 7 lines · Guenter Roeck
Quoted 3 lines · Jean Delvare

BTW I'll take all these patches in my own tree if this is OK with you. Not sure why you took my previous lm75 patch (Update header inclusion) in yours.

Mostly because you had asked me to handle 3.8. Maybe that was a misunderstanding. Sorry if I stepped on your feet ... want me to drop it ?

Ah, yes, now I remember. But I really only meant the big RC1 push. Yes, please drop it, sorry for the confusion.

Signature · 6 lines
Jean Delvare

_______________________________________________
lm-sensors mailing list
[email protected]
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
maintainer
#5 lore raw
In reply to Jean Delvare
Quoted 6 lines · Jean Delvare
Quoted 5 lines · Guenter Roeck
Quoted 3 lines · Jean Delvare

BTW I'll take all these patches in my own tree if this is OK with you. Not sure why you took my previous lm75 patch (Update header inclusion) in yours.

Quoted 6 lines
Quoted 2 lines

Mostly because you had asked me to handle 3.8. Maybe that was a misunderstanding. Sorry if I stepped on your feet ... want me to drop it ?

Ah, yes, now I remember. But I really only meant the big RC1 push. Yes, please drop it, sorry for the confusion.

Done. Feel free to add my Reviewed-by to the patch.

Thanks,
Guenter

_______________________________________________
lm-sensors mailing list
[email protected]
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors