xfree86: Handle drm race condition
Subsystems (4)
v2 cover xfree86: Handle drm race condition
Update: Squashes a couple commits to avoid potential hang if git bisecting. No other changes from v1.
----
When starting up (on Ubuntu), X can hit an error trying to set the version on the drm device. We believe this is a race with plymouth (or the kernel), since adding some delay to the boot results in a functioning session for affected users.
So far we have not found a reliable way to reproduce the bug synthetically. It appears to affect users on fast booting hardware (e.g. SSDs) when using the Intel graphics driver.
We have not root-caused the bug yet. Currently we suspect the actual breakage is underneath X (plymouth/lightdm/kernel), and are still experimenting. However, this patch does seem to improve things for users, so it or parts of it may be worth your consideration for inclusion in xserver.
I'm including the patch broken down into easily pickable chunks. Note the final patch in the series is highly optional; it handles EAGAIN being passed from the ioctl - which looks impossible to happen in practice.
https://bugs.launchpad.net/ubuntu/+source/libdrm/+bug/982889
Bryce Harrington (7):
xfree86: (Cleanup) Close fd if drm interface 1.4 could not be set.
xfree86: Track error code and add label for error handling.
xfree86: Provide more details on failure
xfree86: Keep trying to set interface on drm for 2 seconds.
xfree86: Fix race condition failure opening drm.
xfree86: Be verbose if waiting on opening the drm device
xfree86: Also handle EAGAIN errors from drmSetInterfaceVersion().
hw/xfree86/os-support/linux/lnx_platform.c | 43 ++++++++++++++++++++++------ 1 file changed, 35 insertions(+), 8 deletions(-)
Signature · 1 line
1.7.9.5
PATCH v2 1/7 xfree86: (Cleanup) Close fd if drm interface 1.4 could not be set.
--- hw/xfree86/os-support/linux/lnx_platform.c | 1 + 1 file changed, 1 insertion(+)
hw/xfree86/os-support/linux/lnx_platform.c +1 -0
@@ -34,6 +34,7 @@ get_drm_info(struct OdevAttributes *attribs, char *path) sv.drm_dd_minor =-1 ;/* Don't care */ if (drmSetInterfaceVersion (fd, &sv)) {ErrorF ("setversion 1.4 failed\n" ); +close (fd);return FALSE; }
Signature · 1 line
1.7.9.5
PATCH v2 2/7 xfree86: Track error code and add label for error handling.
In reply to Bryce Harrington--- hw/xfree86/os-support/linux/lnx_platform.c | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-)
hw/xfree86/os-support/linux/lnx_platform.c +6 -4
@@ -23,6 +23,7 @@ get_drm_info(struct OdevAttributes *attribs, char *path)drmSetVersion sv;char *buf;int fd; +int err =0 ; fd =open (path,O_RDWR ,O_CLOEXEC );if (fd ==-1 )
@@ -32,10 +33,10 @@ get_drm_info(struct OdevAttributes *attribs, char *path) sv.drm_di_minor =4 ; sv.drm_dd_major =-1 ;/* Don't care */ sv.drm_dd_minor =-1 ;/* Don't care */ -if (drmSetInterfaceVersion (fd, &sv)) { + err =drmSetInterfaceVersion (fd, &sv); +if (err) {ErrorF ("setversion 1.4 failed\n" ); -close (fd); -return FALSE; + goto out; }xf86_add_platform_device (attribs);
@@ -44,8 +45,9 @@ get_drm_info(struct OdevAttributes *attribs, char *path)xf86_add_platform_device_attrib (xf86_num_platform_devices -1 ,ODEV_ATTRIB_BUSID , buf);drmFreeBusid (buf); +out:close (fd); -return TRUE; +return (err ==0 ); } Bool
Signature · 1 line
1.7.9.5
PATCH v2 3/7 xfree86: Provide more details on failure
In reply to Bryce Harrington--- hw/xfree86/os-support/linux/lnx_platform.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)
hw/xfree86/os-support/linux/lnx_platform.c +3 -1
@@ -7,6 +7,8 @@#include <xf86drm.h> #include <fcntl.h> #include <unistd.h> +#include <errno.h> +#include <string.h> /* Linux platform device support */ #include "xf86_OSproc.h"
@@ -35,7 +37,7 @@ get_drm_info(struct OdevAttributes *attribs, char *path) sv.drm_dd_minor =-1 ;/* Don't care */ err =drmSetInterfaceVersion (fd, &sv);if (err) { -ErrorF ("setversion 1.4 failed\n" ); +ErrorF ("setversion 1.4 failed: %s\n" ,strerror (-err)); goto out; }
Signature · 1 line
1.7.9.5
PATCH v2 4/7 xfree86: Keep trying to set interface on drm for 2 seconds.
In reply to Bryce HarringtonAnd if we've had to delay booting due to not being able to set the interface, fess up.
--- hw/xfree86/os-support/linux/lnx_platform.c | 20 +++++++++++++++----- 1 file changed, 15 insertions(+), 5 deletions(-)
hw/xfree86/os-support/linux/lnx_platform.c +15 -5
@@ -26,16 +26,26 @@ get_drm_info(struct OdevAttributes *attribs, char *path)char *buf;int fd;int err =0 ; +int tries =0 ; fd =open (path,O_RDWR ,O_CLOEXEC );if (fd ==-1 )return FALSE; - sv.drm_di_major =1 ; - sv.drm_di_minor =4 ; - sv.drm_dd_major =-1 ;/* Don't care */ - sv.drm_dd_minor =-1 ;/* Don't care */ - err =drmSetInterfaceVersion (fd, &sv); +while (tries++ <2000 ) { + sv.drm_di_major =1 ; + sv.drm_di_minor =4 ; + sv.drm_dd_major =-1 ;/* Don't care */ + sv.drm_dd_minor =-1 ;/* Don't care */ + + err =drmSetInterfaceVersion (fd, &sv); +if (!err) { +if (tries >1 ) +LogMessage (X_INFO ,"setversion 1.4 succeeded on try #%d\n" , tries); +break ; + } +usleep (1000 ); + }if (err) {ErrorF ("setversion 1.4 failed: %s\n" ,strerror (-err)); goto out;
Signature · 1 line
1.7.9.5
PATCH v2 5/7 xfree86: Fix race condition failure opening drm.
In reply to Bryce HarringtonIf other processes have had drm open previously, xserver may attempt to open the device too early and fail, with xserver error exit "Cannot run in framebuffer mode" or Xorg.0.log messages about "setversion 1.4 failed".
In this situation, we're receiving back -EACCES from libdrm. To address this we need to re-set ourselves as the drm master, and keep trying to set the interface until it works (or until we give up).
See https://bugs.launchpad.net/ubuntu/+source/libdrm/+bug/982889
--- hw/xfree86/os-support/linux/lnx_platform.c | 6 ++++++ 1 file changed, 6 insertions(+)
hw/xfree86/os-support/linux/lnx_platform.c +6 -0
@@ -43,8 +43,14 @@ get_drm_info(struct OdevAttributes *attribs, char *path)if (tries >1 )LogMessage (X_INFO ,"setversion 1.4 succeeded on try #%d\n" , tries);break ; + }if (err != -EACCES ) { +break ; } +usleep (1000 ); + +if (!drmSetMaster (fd)) +LogMessage (X_INFO ,"drmSetMaster succeeded\n" ); }if (err) {ErrorF ("setversion 1.4 failed: %s\n" ,strerror (-err));
Signature · 1 line
1.7.9.5
PATCH v2 6/7 xfree86: Be verbose if waiting on opening the drm device
In reply to Bryce Harrington--- hw/xfree86/os-support/linux/lnx_platform.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-)
hw/xfree86/os-support/linux/lnx_platform.c +4 -1
@@ -43,7 +43,10 @@ get_drm_info(struct OdevAttributes *attribs, char *path)if (tries >1 )LogMessage (X_INFO ,"setversion 1.4 succeeded on try #%d\n" , tries);break ; - }if (err != -EACCES ) { + }if (err == -EACCES ) { +if (tries %500 ==0 ) +LogMessage (X_INFO ,"waiting on drm device...\n" ); + }else {break ; }
Signature · 1 line
1.7.9.5
PATCH v2 7/7 xfree86: Also handle EAGAIN errors from drmSetInterfaceVersion().
In reply to Bryce HarringtonIt has been suggested that the kernel may pass EAGAIN when the device is unavailable. This hasn't been seen in practice, and examination of the function definition in libdrm suggests EAGAIN is handled internally so would not be seen by the xserver when making this call. So, this patch is probably unneeded. But include support anyway.
--- hw/xfree86/os-support/linux/lnx_platform.c | 3 +++ 1 file changed, 3 insertions(+)
hw/xfree86/os-support/linux/lnx_platform.c +3 -0
@@ -46,6 +46,9 @@ get_drm_info(struct OdevAttributes *attribs, char *path) }if (err == -EACCES ) {if (tries %500 ==0 )LogMessage (X_INFO ,"waiting on drm device...\n" ); + }if (err == -EAGAIN ) { +if (tries %500 ==0 ) +LogMessage (X_INFO ,"drm device busy...\n" ); }else {break ; }
Signature · 1 line
1.7.9.5
Quoted 2 lines · Bryce Harrington
Update: Squashes a couple commits to avoid potential hang if git bisecting. No other changes from v1.
I'd probably drop the last EAGAIN patch as that is part of the libdrm API, but other than that it looks to be a reasonably self-contained w/a for this perplexing problem.
-Chris
Signature · 1 line
Chris Wilson, Intel Open Source Technology Centre
Hey,
Op 19-03-13 10:21, Chris Wilson schreef:
Quoted 10 lines · Bryce Harrington
Quoted 2 lines
Update: Squashes a couple commits to avoid potential hang if git bisecting. No other changes from v1.
I'd probably drop the last EAGAIN patch as that is part of the libdrm API, but other than that it looks to be a reasonably self-contained w/a for this perplexing problem.
Reviewed-by Chris Wilson <[email protected]>-Chris
And completely wrong, version I pushed to ubuntu's xorg-server for comparison:
Quoted 1 line
8--
hw/xfree86/os-support/linux/lnx_platform.c +38 -6
@@ -7,6 +7,7 @@#include <xf86drm.h> #include <fcntl.h> #include <unistd.h> +#include <errno.h> /* Linux platform device support */ #include "xf86_OSproc.h"
@@ -17,23 +18,54 @@#include "hotplug.h" +static Bool get_drm_master (int fd) +{ +int ret, tries =400 ; + +LogMessage (X_INFO ,"spinning!\n" ); + +while (tries--) { +if (drmSetMaster (fd) >=0 ) +return TRUE; + +if (errno !=EINVAL ) +break ; + +usleep (10000 ); + } +return FALSE; +} +static Bool get_drm_info (struct OdevAttributes *attribs,char *path) {drmSetVersion sv;char *buf;int fd; +int err =0 ; fd =open (path,O_RDWR ,O_CLOEXEC );if (fd ==-1 )return FALSE; - sv.drm_di_major =1 ; - sv.drm_di_minor =4 ; - sv.drm_dd_major =-1 ;/* Don't care */ - sv.drm_dd_minor =-1 ;/* Don't care */ -if (drmSetInterfaceVersion (fd, &sv)) { -ErrorF ("setversion 1.4 failed\n" ); +while (1 ) { + sv.drm_di_major =1 ; + sv.drm_di_minor =4 ; + sv.drm_dd_major =-1 ;/* Don't care */ + sv.drm_dd_minor =-1 ;/* Don't care */ + + err =drmSetInterfaceVersion (fd, &sv); +if (!err) +break ; + +if (err == -EACCES ) { +if (get_drm_master (fd)) +continue ; +ErrorF ("drmSetMaster failed with -%i(%m)\n" , errno); + }else +ErrorF ("drmSetInterfaceVersion failed with %i(%s)\n" , err,strerror (-err)); + +close (fd);return FALSE; }
Quoted 10 lines · Maarten Lankhorst
Hey,
Op 19-03-13 10:21, Chris Wilson schreef:
Quoted 7 lines · Bryce Harrington
Quoted 2 lines
Update: Squashes a couple commits to avoid potential hang if git bisecting. No other changes from v1.
I'd probably drop the last EAGAIN patch as that is part of the libdrm API, but other than that it looks to be a reasonably self-contained w/a for this perplexing problem.
Quoted 6 lines
Quoted 3 lines
Reviewed-by Chris Wilson <[email protected]>-Chris
And completely wrong, version I pushed to ubuntu's xorg-server for comparison:
Nacked-by Maarten Lankhorst <[email protected]>
So you pushed the busy-spin into drmSetMaster(), which is just a tighter variant of the above.
Anything which adds the minimal delay, warns about that delay, and works around the issue is fine by me.
-Chris
Signature · 1 line
Chris Wilson, Intel Open Source Technology Centre
Hey,
Op 19-03-13 11:27, Chris Wilson schreef:
Quoted 16 lines · Maarten Lankhorst
Quoted 15 lines
Hey,
Op 19-03-13 10:21, Chris Wilson schreef:
Quoted 10 lines · Bryce Harrington
Quoted 2 lines
Update: Squashes a couple commits to avoid potential hang if git bisecting. No other changes from v1.
I'd probably drop the last EAGAIN patch as that is part of the libdrm API, but other than that it looks to be a reasonably self-contained w/a for this perplexing problem.
Reviewed-by Chris Wilson <[email protected]>-Chris
And completely wrong, version I pushed to ubuntu's xorg-server for comparison:
Quoted 7 lines
Quoted 1 line
Nacked-by Maarten Lankhorst <[email protected]>So you pushed the busy-spin into
drmSetMaster(), which is just a tighter variant of the above.Anything which adds the minimal delay, warns about that delay, and works around the issue is fine by me.
-Chris
Here's what I think is happening, based on the information I have.
Because of the delayed fput in recent kernels, it is possible for plymouth to exit and not drop master right away. It's put onto a workqueue to be freed slightly later. Xorg-server starts in the meantime, opens a fd, but because the fd hasn't been closed by plymouth yet, it didn't get implicitly authenticated and it didn't get drm master either.
The drmSetMaster call is needed, but the spinning is really just waiting for the workqueue to run.
bryce's patch never worked, it just caused it to try drmsetinterfaceversion for a few seconds before timing out. That call was failing because his patch series never tried to obtain drm master.
The get_drm_info call also makes it more likely to run into the same problem as well. It opens the fd and immediately closes it again. This will re-trigger the race..
For testing I did a small patch in the drm core that drops drm master when opening device. The patch is attached inline below.
radeon and intel driver both fail to load with it. Intel doesn't return an error, and falls back silently to modesetting. radeon however complains similar to this:
[ 42.876] (==) RADEON(G0): Depth 24, (--) framebuffer bpp 32 [ 42.876] (II) RADEON(G0): Pixel depth = 24 bits stored in 4 bytes (32 bpp pixmaps) [ 42.876] (==) RADEON(G0): Default visual is TrueColor [ 42.876] (==) RADEON(G0): RGB weight 888 [ 42.876] (II) RADEON(G0): Using 8 bits per RGB (8 bit DAC) [ 42.876] (--) RADEON(G0): Chipset: "TURKS" (ChipID = 0x6741) [ 42.961] (EE) RADEON(G0): [drm] failed to set drm interface version. [ 42.961] (EE) RADEON(G0): Kernel modesetting setup failed
I've seen this error before in one of the races, so it's not just a theoretical issue. Just another possible failure mode.
I think all drivers have to be fixed to handle this case correctly, and they should probably all do the same spinning as well.
drivers/gpu/drm/drm_fops.c +1 -0
@@ -339,6 +339,7 @@ static int drm_open_helper(struct inode *inode, struct file *filp, } }mutex_unlock (&dev->struct_mutex); +drm_dropmaster_ioctl (dev,NULL , priv); }else {/* get a reference to the master */ priv->master =drm_master_get (priv->minor->master);
Dave Airlie
maintainerQuoted 5 lines
Because of the delayed fput in recent kernels, it is possible for plymouth to exit and not drop master right away. It's put onto a workqueue to be freed slightly later. Xorg-server starts in the meantime, opens a fd, but because the fd hasn't been closed by plymouth yet, it didn't get implicitly authenticated and it didn't get drm master either.
I thought plymouth explicitly dropped master, and closed later. I know we "ab"use that fact on Fedora so X can grab the bo from plymouth before it exits.
Dave.
A message that is not in the archive (sent off-list or not yet received): CAPM=9twNnKV9DUNJ-BfrnXTrj=W+AGyxqauCPMW2kCx39bj_pA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org
Op 19-03-13 12:10, Dave Airlie schreef:
Quoted 8 lines
Quoted 4 lines
Because of the delayed fput in recent kernels, it is possible for plymouth to exit and not drop master right away. It's put onto a workqueue to be freed slightly later. Xorg-server starts in the meantime, opens a fd, but because the fd hasn't been closed by plymouth yet, it didn't get implicitly authenticated and it didn't get drm master either.
I thought plymouth explicitly dropped master, and closed later. I know we "ab"use that fact on Fedora so X can grab the bo from plymouth before it exits.
Quoted 6 lines
Dave.
_______________________________________________
[email protected]: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: http://lists.x.org/mailman/listinfo/xorg-devel
Well from trying the dropmaster kernel patch, it simply looks like there are just too many places that could get affected by this assumption.
Lets just try something ugly in the flush callback that's called before final fput instead, that should fix all our problems!
XXX: the big if is duplicated from drm_release, and it should probably be split into a separate function. However if you're hit by the plymouth race, this might be a good thing to try.
The fix for drivers other than radeon/i915 is left as an excercise for the reader.
drivers/gpu/drm/drm_fops.c +44 -0
@@ -177,6 +177,50 @@ err: }EXPORT_SYMBOL (drm_open); +int drm_flush (struct file *filp,fl_owner_t id) +{ +struct drm_file *file_priv = filp->private_data; +struct drm_device *dev = file_priv->minor->dev; + +if (atomic_long_read (&filp->f_count) !=1 || !file_priv->is_master) +return 0 ; + +mutex_lock (&dev->struct_mutex); + +if (file_priv->is_master) { +struct drm_master *master = file_priv->master; +struct drm_file *temp; +list_for_each_entry (temp, &dev->filelist, lhead) { +if ((temp->master == file_priv->master) && + (temp != file_priv)) + temp->authenticated =0 ; + } + +/** +* Since the master is disappearing, so is the +* possibility to lock. +*/ + +if (master->lock.hw_lock) { +if (dev->sigdata.lock == master->lock.hw_lock) + dev->sigdata.lock =NULL ; + master->lock.hw_lock =NULL ; + master->lock.file_priv =NULL ; +wake_up_interruptible_all (&master->lock.lock_queue); + } + +if (file_priv->minor->master == file_priv->master) { +/* drop the reference held my the minor */ +if (dev->driver->master_drop) + dev->driver->master_drop (dev, file_priv, true); +drm_master_put (&file_priv->minor->master); + } + } +mutex_unlock (&dev->struct_mutex); +return 0 ; +} +EXPORT_SYMBOL (drm_flush); +/** * File \c open operation. *
drivers/gpu/drm/i915/i915_drv.c +1 -0
@@ -1018,6 +1018,7 @@ static const struct vm_operations_struct i915_gem_vm_ops = {static const struct file_operations i915_driver_fops = { .owner =THIS_MODULE , .open = drm_open, + .flush = drm_flush, .release = drm_release, .unlocked_ioctl = drm_ioctl, .mmap = drm_gem_mmap,
drivers/gpu/drm/radeon/radeon_drv.c +1 -0
@@ -361,6 +361,7 @@ radeon_pci_resume(struct pci_dev *pdev)static const struct file_operations radeon_driver_kms_fops = { .owner =THIS_MODULE , .open = drm_open, + .flush = drm_flush, .release = drm_release, .unlocked_ioctl = drm_ioctl, .mmap = radeon_mmap,
include/drm/drmP.h +2 -0
@@ -1320,6 +1320,8 @@ extern int drm_stub_open(struct inode *inode, struct file *filp);extern int drm_fasync (int fd,struct file *filp,int on);extern ssize_t drm_read (struct file *filp,char __user *buffer,size_t count,loff_t *offset); + +extern int drm_flush (struct file *filp,fl_owner_t id);extern int drm_release (struct inode *inode,struct file *filp);/* Mapping support (drm_vm.h) */
_______________________________________________
[email protected]: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: http://lists.x.org/mailman/listinfo/xorg-devel
Quoted 4 lines · Maarten Lankhorst
The drmSetMaster call is needed, but the spinning is really just waiting for the workqueue to run.
bryce's patch never worked, it just caused it to try drmsetinterfaceversion for a few seconds before timing out. That call was failing because his patch series never tried to obtain drm master.
You missed that the series Bryce posted did contain the drmSetMaster() call inside the loop to retry drmSetVersion(). :)
Your explanation as to why the delay is required is certainly intriguing. Thanks,
-Chris
Signature · 1 line
Chris Wilson, Intel Open Source Technology Centre
Hey,
Op 19-03-13 22:13, Chris Wilson schreef:
Quoted 9 lines · Maarten Lankhorst
Quoted 4 lines
The drmSetMaster call is needed, but the spinning is really just waiting for the workqueue to run.
bryce's patch never worked, it just caused it to try drmsetinterfaceversion for a few seconds before timing out. That call was failing because his patch series never tried to obtain drm master.
You missed that the series Bryce posted did contain the
drmSetMaster()call inside the loop to retrydrmSetVersion(). :)
Oh I must have missed that.
Is the drmSetInterfaceVersion call really needed here? If I look at DRM_IOCTL_GET_UNIQUE, I don't see any requirement of drm master or anything, so it looks to me like for this specific race the drmSetInterfaceVersion call can be skipped entirely without any side effects. This would end up with cleaner code here, and drop the master requirement entirely.
Of course there's still a race that needs to be investigated, and is currently not completely understood, I think.
~Maarten
Op 20-03-13 09:40, Maarten Lankhorst schreef:
Quoted 12 lines
Hey,
Op 19-03-13 22:13, Chris Wilson schreef:
Quoted 9 lines · Maarten Lankhorst
Quoted 4 lines
The drmSetMaster call is needed, but the spinning is really just waiting for the workqueue to run.
bryce's patch never worked, it just caused it to try drmsetinterfaceversion for a few seconds before timing out. That call was failing because his patch series never tried to obtain drm master.
You missed that the series Bryce posted did contain the
drmSetMaster()call inside the loop to retrydrmSetVersion(). :)
Quoted 9 lines
Oh I must have missed that.
Is the drmSetInterfaceVersion call really needed here? If I look at
DRM_IOCTL_GET_UNIQUE, I don't see any requirement of drm master or anything, so it looks to me like for this specific race the drmSetInterfaceVersion call can be skipped entirely without any side effects. This would end up with cleaner code here, and drop the master requirement entirely.Of course there's still a race that needs to be investigated, and is currently not completely understood, I think.
Or worse, is that drmGetBusId call there even useful? From digging at the kernel it seems it's a per master value. So if a device is hotplugged, it wouldn't be set yet. If someone else holds master, it wouldn't be set either. In fact it would only be ever set from DRIOpenDRMMaster, but that call only happens a lot later, if it even happens at all.
It seems to me like opening the fd there should be removed entirely, and the bus id should be retrieved from the udev event instead.
I'll try to get something working for this.
~Maarten
Quoted 4 lines · Maarten Lankhorst
Is the drmSetInterfaceVersion call really needed here? If I look at
DRM_IOCTL_GET_UNIQUE, I don't see any requirement of drm master or anything, so it looks to me like for this specific race the drmSetInterfaceVersion call can be skipped entirely without any side effects. This would end up with cleaner code here, and drop the master requirement entirely.
Indeed, it does look like drmSetVersion() at that point is overkill. Instead we will hit the race later in the drivers. For the purposes of clearer code, we could happily lose that drmSetVersion().
Quoted 1 line
Of course there's still a race that needs to be investigated, and is currently not completely understood, I think.
We are all in agreement. Ultimately we want to root cause the race, in the meantime we need a fallback to make sure that no desktop is left behind!
-Chris
Signature · 1 line
Chris Wilson, Intel Open Source Technology Centre
Quoted 2 lines · Bryce Harrington
Update: Squashes a couple commits to avoid potential hang if git bisecting. No other changes from v1.
I'm seeing another variation (both in lp and reported by Ben) whereby it appears that the open("/dev/dri/card0") fails and so needs be pushed into the repeat loop.
-Chris
Signature · 1 line
Chris Wilson, Intel Open Source Technology Centre
Quoted 11 lines · Chris Wilson
Quoted 2 lines · Bryce Harrington
Update: Squashes a couple commits to avoid potential hang if git bisecting. No other changes from v1.
I'm seeing another variation (both in lp and reported by Ben) whereby it appears that the
open("/dev/dri/card0")fails and so needs be pushed into the repeat loop.
-ChrisSignature · 1 line
Chris Wilson, Intel Open Source Technology Centre
I can reproduce very easily. Let me know if I can help.
Signature · 1 line
Ben Widawsky, Intel Open Source Technology Center