Skip to contentSkip to conversation

pinctrl: rockchip: missing unlock on error in rockchip_set_pull()

PATCH In review Dan Carpenter 3 participants 3 messages Nov 14, 2013 – Nov 19, 2013

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 pinctrl: rockchip: missing unlock on error in rockchip_set_pull()

We need to unlock here before returning -EINVAL.

Fixes 6ca5274d1d12 ('pinctrl: rockchip: add rk3188 specifics')
drivers/pinctrl/pinctrl-rockchip.c +1 -0
index e939c28..bfd1824 100644
@@ -504,6 +504,7 @@ static int rockchip_set_pull(struct rockchip_pin_bank *bank,
 			data |= (3 << bit);
 			break;
 		default:
+			spin_unlock_irqrestore(&bank->slock, flags);
 			dev_err(info->dev, "unsupported pull setting %d\n",
 				pull);
 			return -EINVAL;
maintainer Acked-by on v1 1/1
#1 lore raw

Am Donnerstag, 14. November 2013, 09:22:54 schrieb Dan Carpenter:

Quoted 1 line

We need to unlock here before returning -EINVAL.

I seem to say this a lot recently: thanks for the catch :-)

Quoted 2 lines
Fixes 6ca5274d1d12 ('pinctrl: rockchip: add rk3188 specifics')
Quoted 12 lines
(quoted diff) +0 -0

b/drivers/pinctrl/pinctrl-rockchip.c index e939c28..bfd1824 100644

drivers/pinctrl/pinctrl-rockchip.c +1 -0
@@ -504,6 +504,7 @@ static int rockchip_set_pull(struct rockchip_pin_bank
 *bank, data |= (3 << bit);
 			break;
 		default:
+			spin_unlock_irqrestore(&bank->slock, flags);
 			dev_err(info->dev, "unsupported pull setting %d\n",
 				pull);
 			return -EINVAL;