pinctrl: rockchip: missing unlock on error in rockchip_set_pull()
Subsystems (3)
PATCH 1/1 pinctrl: rockchip: missing unlock on error in rockchip_set_pull()
We need to unlock here before returning -EINVAL.
Fixes 6ca5274d1d12 ('pinctrl: rockchip: add rk3188 specifics')
Signed-off-by Dan Carpenter <[email protected]>
drivers/pinctrl/pinctrl-rockchip.c +1 -0
@@ -504,6 +504,7 @@ static int rockchip_set_pull(struct rockchip_pin_bank *bank, data |= (3 << bit);break ;default : +spin_unlock_irqrestore (&bank->slock, flags);dev_err (info->dev,"unsupported pull setting %d\n" , pull);return -EINVAL ;
Am Donnerstag, 14. November 2013, 09:22:54 schrieb Dan Carpenter:
Quoted 1 line
We need to unlock here before returning
-EINVAL.
I seem to say this a lot recently: thanks for the catch :-)
Quoted 2 lines
Fixes 6ca5274d1d12 ('pinctrl: rockchip: add rk3188 specifics')Signed-off-by Dan Carpenter <[email protected]>
Acked-by Heiko Stuebner <[email protected]>
Quoted 12 lines
(quoted diff) +0
-0
b/drivers/pinctrl/pinctrl-rockchip.cindex e939c28..bfd1824 100644drivers/pinctrl/pinctrl-rockchip.c +1
-0@@ -504,6 +504,7 @@ static int rockchip_set_pull(struct rockchip_pin_bank *bank, data |= (3 << bit);break ;default : +spin_unlock_irqrestore (&bank->slock, flags);dev_err (info->dev,"unsupported pull setting %d\n" , pull);return -EINVAL ;
Quoted 4 lines · Dan Carpenter
We need to unlock here before returning
-EINVAL.Fixes 6ca5274d1d12 ('pinctrl: rockchip: add rk3188 specifics')Signed-off-by Dan Carpenter <[email protected]>
Applied with Heiko's ACK.
Thanks!
Linus Walleij