ARM: shmobile: koelsch: Conditionally select MICREL_PHY
PATCH 1/1 ARM: shmobile: koelsch: Conditionally select MICREL_PHY
The koelsch board uses has an SH ethernet controller which uses a Micrel phy. Select MICREL_PHY for koelsch if SH_ETH is enabled to make use of the Micrel-specific phy driver rather than relying on the generic phy driver.
--- arch/arm/mach-shmobile/Kconfig | 3 +++ 1 file changed, 3 insertions(+)
arch/arm/mach-shmobile/Kconfig +3 -0
@@ -41,6 +41,7 @@ config MACH_GENMAI config MACH_KOELSCH bool "Koelsch board" depends on ARCH_R8A7791 + select MICREL_PHY if SH_ETH config MACH_KZM9D bool "KZM9D board"
@@ -269,11 +270,13 @@ config MACH_KOELSCH bool "Koelsch board" depends on ARCH_R8A7791 select USE_OF + select MICREL_PHY if SH_ETH config MACH_KOELSCH_REFERENCE bool "Koelsch board - Reference Device Tree Implementation" depends on ARCH_R8A7791 select USE_OF + select MICREL_PHY if SH_ETH ---help--- Use reference implementation of Koelsch board support which makes use of device tree at the expense
Signature · 1 line
1.8.4
PATCH 1/1 ARM: shmobile: koelsch: Conditionally select MICREL_PHY
Hello.
Quoted 3 lines · Simon Horman
The koelsch board uses has an SH ethernet controller which uses a Micrel phy. Select
MICREL_PHYfor koelsch ifSH_ETHis enabled to make use of the Micrel-specific phy driver rather than relying on the generic phy driver.
Frankly speaking, I'm seeing no advantages to doing that.
Quoted 1 line
Signed-off-by Simon Horman <[email protected]>
Analogous changes are needed for BOCK-W and Lager boards since they all
use the same KSZ8041RNLI PHY chip. I was going to submit such changes with the PHY IRQ patches but since no IRQ is generated still, this got delayed...
WBR, Sergei
PATCH 1/1 ARM: shmobile: koelsch: Conditionally select MICREL_PHY
Quoted 5 lines · On 12/16/2013 04:25 PM, I wrote:
Quoted 3 lines
The koelsch board uses has an SH ethernet controller which uses a Micrel phy. Select
MICREL_PHYfor koelsch ifSH_ETHis enabled to make use of the Micrel-specific phy driver rather than relying on the generic phy driver.Frankly speaking, I'm seeing no advantages to doing that.
Although wait, Geert has reported the absence of Rx FIFO overflow messages
with this PHY driver, IIRC.
Quoted 5 lines
Quoted 1 line
Signed-off-by Simon Horman <[email protected]>Analogous changes are needed for BOCK-W and Lager boards since they all
use the same KSZ8041RNLI PHY chip. I was going to submit such changes with the PHY IRQ patches but since no IRQ is generated still, this got delayed...
Only I was going to do it via defconfigs...
WBR, Sergei
PATCH 1/1 ARM: shmobile: koelsch: Conditionally select MICREL_PHY
Quoted 11 lines · Sergei Shtylyov
Quoted 5 lines · On 12/16/2013 04:25 PM, I wrote:
Quoted 3 lines
The koelsch board uses has an SH ethernet controller which uses a Micrel phy. Select
MICREL_PHYfor koelsch ifSH_ETHis enabled to make use of the Micrel-specific phy driver rather than relying on the generic phy driver.Frankly speaking, I'm seeing no advantages to doing that.
Although wait, Geert has reported the absence of Rx FIFO overflow
messages with this PHY driver, IIRC.
Quoted 7 lines
Quoted 5 lines
Quoted 1 line
Signed-off-by Simon Horman <[email protected]>Analogous changes are needed for BOCK-W and Lager boards since they all
use the same KSZ8041RNLI PHY chip. I was going to submit such changes with the PHY IRQ patches but since no IRQ is generated still, this got delayed...Only I was going to do it via defconfigs...
That was my initial approach too. However I have been convinced that Kconfig is a better way forwards.
PATCH 1/1 ARM: shmobile: koelsch: Conditionally select MICREL_PHY
Quoted 10 lines · Simon Horman
Quoted 9 lines · Sergei Shtylyov
Quoted 5 lines · On 12/16/2013 04:25 PM, I wrote:
Quoted 3 lines
The koelsch board uses has an SH ethernet controller which uses a Micrel phy. Select
MICREL_PHYfor koelsch ifSH_ETHis enabled to make use of the Micrel-specific phy driver rather than relying on the generic phy driver.Frankly speaking, I'm seeing no advantages to doing that.
Although wait, Geert has reported the absence of Rx FIFO overflow
messages with this PHY driver, IIRC.
I spoke too soon: apparently the statistical relevance of my reporting was too low. I still see them from time to time, but I think less than before (no numbers available).
Quoted 10 lines
Quoted 7 lines
Quoted 5 lines
Quoted 1 line
Signed-off-by Simon Horman <[email protected]>Analogous changes are needed for BOCK-W and Lager boards since they all
use the same KSZ8041RNLI PHY chip. I was going to submit such changes with the PHY IRQ patches but since no IRQ is generated still, this got delayed...Only I was going to do it via defconfigs...
That was my initial approach too. However I have been convinced that
Kconfigis a better way forwards.
Kconfig has the advantage that the minimal defconfigs will be smaller, so less churn there.
However, it does mean you cannot disable the option anymore via your .config.
In this case it's a bit difficult to decide, as sh_eth will work both with and without
the specific PHY-driver.
If no users want to disable it, I'd go for Kconfig.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert at linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
PATCH 1/1 ARM: shmobile: koelsch: Conditionally select MICREL_PHY
Quoted 31 lines · Geert Uytterhoeven
Quoted 10 lines · Simon Horman
Quoted 9 lines · Sergei Shtylyov
Quoted 5 lines · On 12/16/2013 04:25 PM, I wrote:
Quoted 3 lines
The koelsch board uses has an SH ethernet controller which uses a Micrel phy. Select
MICREL_PHYfor koelsch ifSH_ETHis enabled to make use of the Micrel-specific phy driver rather than relying on the generic phy driver.Frankly speaking, I'm seeing no advantages to doing that.
Although wait, Geert has reported the absence of Rx FIFO overflow
messages with this PHY driver, IIRC.I spoke too soon: apparently the statistical relevance of my reporting was too low. I still see them from time to time, but I think less than before (no numbers available).
Quoted 10 lines
Quoted 7 lines
Quoted 5 lines
Quoted 1 line
Signed-off-by Simon Horman <[email protected]>Analogous changes are needed for BOCK-W and Lager boards since they all
use the same KSZ8041RNLI PHY chip. I was going to submit such changes with the PHY IRQ patches but since no IRQ is generated still, this got delayed...Only I was going to do it via defconfigs...
That was my initial approach too. However I have been convinced that
Kconfigis a better way forwards.
Kconfighas the advantage that the minimal defconfigs will be smaller, so less churn there.
However, it does mean you cannot disable the option anymore via your .config.
Quoted 5 lines
In this case it's a bit difficult to decide, as
sh_ethwill work both with and without
the specific PHY-driver.If no users want to disable it, I'd go for
Kconfig.
It is indeed a tricky choice. But I think we should try going for Kconfig.
PATCH 1/1 ARM: shmobile: koelsch: Conditionally select MICREL_PHY
Quoted 32 lines · Simon Horman
Quoted 31 lines · Geert Uytterhoeven
Quoted 10 lines · Simon Horman
Quoted 9 lines · Sergei Shtylyov
Quoted 5 lines · On 12/16/2013 04:25 PM, I wrote:
Quoted 3 lines
The koelsch board uses has an SH ethernet controller which uses a Micrel phy. Select
MICREL_PHYfor koelsch ifSH_ETHis enabled to make use of the Micrel-specific phy driver rather than relying on the generic phy driver.Frankly speaking, I'm seeing no advantages to doing that.
Although wait, Geert has reported the absence of Rx FIFO overflow
messages with this PHY driver, IIRC.I spoke too soon: apparently the statistical relevance of my reporting was too low. I still see them from time to time, but I think less than before (no numbers available).
Quoted 10 lines
Quoted 7 lines
Quoted 5 lines
Quoted 1 line
Signed-off-by Simon Horman <[email protected]>Analogous changes are needed for BOCK-W and Lager boards since they all
use the same KSZ8041RNLI PHY chip. I was going to submit such changes with the PHY IRQ patches but since no IRQ is generated still, this got delayed...Only I was going to do it via defconfigs...
That was my initial approach too. However I have been convinced that
Kconfigis a better way forwards.
Kconfighas the advantage that the minimal defconfigs will be smaller, so less churn there.
However, it does mean you cannot disable the option anymore via your .config.
Quoted 7 lines
Quoted 5 lines
In this case it's a bit difficult to decide, as
sh_ethwill work both with and without
the specific PHY-driver.If no users want to disable it, I'd go for
Kconfig.It is indeed a tricky choice. But I think we should try going for
Kconfig.
I have decided to queue this up.
PATCH 1/1 ARM: shmobile: koelsch: Conditionally select MICREL_PHY
In reply to Sergei ShtylyovQuoted 9 lines · Sergei Shtylyov
Hello.
Quoted 3 lines · Simon Horman
The koelsch board uses has an SH ethernet controller which uses a Micrel phy. Select
MICREL_PHYfor koelsch ifSH_ETHis enabled to make use of the Micrel-specific phy driver rather than relying on the generic phy driver.Frankly speaking, I'm seeing no advantages to doing that.
I think there is an advantage to using the hardware-specific driver. Even if it make any difference at run-time with the present code.
Quoted 6 lines
Quoted 1 line
Signed-off-by Simon Horman <[email protected]>Analogous changes are needed for BOCK-W and Lager boards since
they all use the same KSZ8041RNLI PHY chip. I was going to submit such changes with the PHY IRQ patches but since no IRQ is generated still, this got delayed...
I believe that similar changes are needed for almost all of the shmobile boards. If you would like to handle some or all of them that is quite fine by me.
PATCH 1/1 ARM: shmobile: koelsch: Conditionally select MICREL_PHY
In reply to Simon HormanHello.
Quoted 14 lines · Simon Horman
The koelsch board uses has an SH ethernet controller which uses a Micrel phy. Select
MICREL_PHYfor koelsch ifSH_ETHis enabled to make use of the Micrel-specific phy driver rather than relying on the generic phy driver.Signed-off-by Simon Horman <[email protected]>--- arch/arm/mach-shmobile/Kconfig | 3 +++ 1 file changed, 3 insertions(+)arch/arm/mach-shmobile/Kconfig +0
-0
arch/arm/mach-shmobile/Kconfig config MACH_GENMAI · line 47
Quoted 7 lines
arch/arm/mach-shmobile/Kconfig +1
-0@@ -41,6 +41,7 @@ config MACH_GENMAI config MACH_KOELSCH bool "Koelsch board" depends on ARCH_R8A7791 + select MICREL_PHY if SH_ETH config MACH_KZM9D bool "KZM9D board"
Simon, did you initially remove that hunk when committing?
WBR, Sergei
PATCH 1/1 ARM: shmobile: koelsch: Conditionally select MICREL_PHY
Quoted 23 lines · Sergei Shtylyov
Hello.
Quoted 19 lines · Simon Horman
The koelsch board uses has an SH ethernet controller which uses a Micrel phy. Select
MICREL_PHYfor koelsch ifSH_ETHis enabled to make use of the Micrel-specific phy driver rather than relying on the generic phy driver.Signed-off-by Simon Horman <[email protected]>--- arch/arm/mach-shmobile/Kconfig | 3 +++ 1 file changed, 3 insertions(+)arch/arm/mach-shmobile/Kconfig +1
-0@@ -41,6 +41,7 @@ config MACH_GENMAI config MACH_KOELSCH bool "Koelsch board" depends on ARCH_R8A7791 + select MICREL_PHY if SH_ETH
Quoted 4 lines
arch/arm/mach-shmobile/Kconfig config MACH_GENMAI · line 47
Quoted 2 lines
arch/arm/mach-shmobile/Kconfig +0
-0config MACH_KZM9D bool "KZM9D board"Simon, did you initially remove that hunk when committing?
Thanks for noticing.
I will queue up the following:
From: Simon Horman <[email protected]>
ARM: shmobile: koelsch: Conditionally select MICREL_PHY for Multiplatform
The koelsch board uses has an SH ethernet controller which uses a Micrel phy. Select MICREL_PHY for koelsch if SH_ETH is enabled to make use of the Micrel-specific phy driver rather than relying on the generic phy driver.
--- arch/arm/mach-shmobile/Kconfig | 1 + 1 file changed, 1 insertion(+)
arch/arm/mach-shmobile/Kconfig +1 -0
@@ -45,6 +45,7 @@ config MACH_GENMAI config MACH_KOELSCH bool "Koelsch board" depends on ARCH_R8A7791 + select MICREL_PHY if SH_ETH config MACH_KZM9D bool "KZM9D board"
Signature · 1 line
1.8.4