Skip to contentSkip to conversation

apf27dev: add max1027 in the dts

PATCH Superseded Philippe Reynes 2 participants 2 messages Aug 31, 2014 – Sep 1, 2014

Subsystems (2)

v3 of 4 Superseded Latest is v4 →

lore
Share & tools
lore
#0 lore raw

PATCH v3 1/1 apf27dev: add max1027 in the dts

---
 arch/arm/boot/dts/imx27-apf27dev.dts |   17 +++++++++++++++++
 1 files changed, 17 insertions(+), 0 deletions(-)

Changelog:
v3: (thanks Alexander Shiyan for the feedback)
- add datasheet pin name as comment

v2: (thanks Alexander Shiyan for the feedback)
- spi mode 0 is the default so no need to explicitly define it

arch/arm/boot/dts/imx27-apf27dev.dts +17 -0
index b982309..0c08fbb 100644
@@ -82,6 +82,16 @@
 	pinctrl-names = "default";
 	pinctrl-0 = <&pinctrl_cspi1 &pinctrl_cspi1_cs>;
 	status = "okay";
+
+	adc at 0 {
+		compatible = "maxim,max1027";
+		reg = <0>;
+		interrupt-parent = <&gpio5>;
+		interrupts = <15 IRQ_TYPE_EDGE_FALLING>;
+		pinctrl-names = "default";
+		pinctrl-0 = <&pinctrl_max1027>;
+		spi-max-frequency = <10000000>;
+	};
 };
 
 &cspi2 {
@@ -230,6 +240,13 @@
 		pinctrl_sdhc2_cd: sdhc2cdgrp {
 			fsl,pins = <MX27_PAD_TOUT__GPIO3_14 0x0>;
 		};
+
+		pinctrl_max1027: max1027 {
+			 fsl,pins = <
+				 MX27_PAD_UART1_CTS__GPIO5_14 0 /* CNVST */
+				 MX27_PAD_UART1_RTS__GPIO5_15 0 /* EOC */
+			>;
+		};
 	};
 };
 
Signature · 1 line
1.7.4.4
#1 lore raw
Quoted 35 lines · Philippe Reynes
---
 arch/arm/boot/dts/imx27-apf27dev.dts |   17 +++++++++++++++++
 1 files changed, 17 insertions(+), 0 deletions(-)

Changelog:
v3: (thanks Alexander Shiyan for the feedback)
- add datasheet pin name as comment

v2: (thanks Alexander Shiyan for the feedback)
- spi mode 0 is the default so no need to explicitly define it

arch/arm/boot/dts/imx27-apf27dev.dts +10 -0
index b982309..0c08fbb 100644
@@ -82,6 +82,16 @@
 	pinctrl-names = "default";
 	pinctrl-0 = <&pinctrl_cspi1 &pinctrl_cspi1_cs>;
 	status = "okay";
+
+	adc at 0 {
+		compatible = "maxim,max1027";
+		reg = <0>;
+		interrupt-parent = <&gpio5>;
+		interrupts = <15 IRQ_TYPE_EDGE_FALLING>;
+		pinctrl-names = "default";
+		pinctrl-0 = <&pinctrl_max1027>;
+		spi-max-frequency = <10000000>;
+	};
 };
 
 &cspi2 {

arch/arm/boot/dts/imx27-apf27dev.dts line 244

Quoted 5 lines
arch/arm/boot/dts/imx27-apf27dev.dts +2 -0
@@ -230,6 +240,13 @@
 		pinctrl_sdhc2_cd: sdhc2cdgrp {
 			fsl,pins = <MX27_PAD_TOUT__GPIO3_14 0x0>;
 		};
+
+		pinctrl_max1027: max1027 {

The pinctrl entries are alphabetically sorted in there. Can you also do that for your addition?

arch/arm/boot/dts/imx27-apf27dev.dts line 247

Quoted 3 lines
arch/arm/boot/dts/imx27-apf27dev.dts +3 -0
+			 fsl,pins = <
+				 MX27_PAD_UART1_CTS__GPIO5_14 0 /* CNVST */
+				 MX27_PAD_UART1_RTS__GPIO5_15 0 /* EOC */

Can you follow the convention to use hex value for the config cell, i.e. s/0/0x0?

Shawn

Quoted 8 lines
arch/arm/boot/dts/imx27-apf27dev.dts +2 -0
+			>;
+		};
 	};
 };
 
Signature · 1 line
1.7.4.4