Skip to contentSkip to conversation

bcache-tools: Adding package.

PATCH New Jean-Christophe DUBOIS 3 participants 3 messages Sep 7, 2014 – Sep 21, 2014

lore
Share & tools
lore
#0 lore raw

PATCH v8 1/1 bcache-tools: Adding package.

This is the bcache tools, required to setup the linux bcache feature of the Linux kernel.

---
Changes v1 to v2
* Remove 'support' word from comment statement in Config.in.
* Use github helper to get the project site instead of hardcoded URL.
Changes v2 to v3
* Added bcache-tools description in Config help.
* Added bcache-tools URL in Config help.
* Added BR2_LARGEFILE BR2_USE_WCHAR and BR2_USE_MMU dependencies in Config.
* Added BR2_PACKAGE_UTIL_LINUX selection in Config.
* Added new requirements in Config comment.
* Use POST_EXTRACT_HOOKS to modify Makefile.
* Pass $(TARGET_CONFIGURE_OPTS) in env variables to $(MAKE).
* Create man8 dir as part of PRE_INSTALL_TARGET_HOOKS.
Changes v3 to v4
* Move from .zip file to .tar.gz as download file in .mk file.
* Use complete git tag as version in .mk file.
* Remove explicit extract rule from .mk file (use implicite rule).
Changes v4 to v5
* Remove explicit package name in .mk (rely on default behavior).
Changes v5 to v6
* Switch spaces to tabs in Config.in
* Don't patch Makefile for pkg-config in .mk file.
Changes v6 to v7
* change eudev dependency to udev dependency in Makefile.
Changes v7 to v8
* remove makefile dependency on udev
* install /lib/udev/rules.d directory in PRE_INSTALL_TARGET_HOOKS

---
 package/Config.in                    |  1 +
 package/bcache-tools/Config.in       | 22 +++++++++++++++++++++
 package/bcache-tools/bcache-tools.mk | 37 ++++++++++++++++++++++++++++++++++++
 3 files changed, 60 insertions(+)
 create mode 100644 package/bcache-tools/Config.in
 create mode 100644 package/bcache-tools/bcache-tools.mk
package/Config.in +1 -0
index 883dd66..ef0a22a 100644
@@ -280,6 +280,7 @@ endmenu
 	source "package/a10disp/Config.in"
 	source "package/acpid/Config.in"
 	source "package/avrdude/Config.in"
+	source "package/bcache-tools/Config.in"
 	source "package/cdrkit/Config.in"
 	source "package/cryptsetup/Config.in"
 	source "package/cwiid/Config.in"
package/bcache-tools/Config.in new file +22 -0
new file mode 100644
index 0000000..a3f7897
@@ -0,0 +1,22 @@
+config BR2_PACKAGE_BCACHE_TOOLS
+	bool "bcache tools"
+	depends on BR2_PACKAGE_HAS_UDEV
+	depends on BR2_LARGEFILE # util-linux
+	depends on BR2_USE_WCHAR # util-linux
+	depends on BR2_USE_MMU # util-linux (libblkid)
+	select BR2_PACKAGE_UTIL_LINUX
+	select BR2_PACKAGE_UTIL_LINUX_LIBUUID
+	select BR2_PACKAGE_UTIL_LINUX_LIBBLKID
+	help
+	  Bcache is a Linux kernel block layer cache. It allows one or
+	  more fast disk drives such as flash-based solid state drives (SSDs)
+	  to act as a cache for one or more slower hard disk drives.
+
+	  http://bcache.evilpiepirate.org/
+
+	  This is the user space bcache tools, required to setup the linux
+	  bcache feature of the Linux kernel.
+
+comment "bcache-tools needs udev /dev management and a toolchain w/ largefile, wchar"
+	depends on BR2_USE_MMU
+	depends on !BR2_PACKAGE_HAS_UDEV || !BR2_LARGEFILE || !BR2_USE_WCHAR
package/bcache-tools/bcache-tools.mk new file +37 -0
new file mode 100644
index 0000000..e537471
@@ -0,0 +1,37 @@
+################################################################################
+#
+# bcache-tools
+#
+################################################################################
+
+BCACHE_TOOLS_VERSION = v1.0.7
+BCACHE_TOOLS_SITE = $(call github,g2p,bcache-tools,$(BCACHE_TOOLS_VERSION))
+BCACHE_TOOLS_LICENSE = GPLv2
+BCACHE_TOOLS_LICENSE_FILES = COPYING
+BCACHE_TOOLS_DEPENDENCIES = host-pkgconf util-linux
+
+# We pass $(TARGET_CONFIGURE_OPTS) as environment variable to allow
+# the bcache-tools Makefile to alter CFLAGS
+define BCACHE_TOOLS_BUILD_CMDS
+	$(TARGET_MAKE_ENV) $(TARGET_CONFIGURE_OPTS) $(MAKE) -C $(@D)
+endef
+
+# The bcache-tools Makefile expects the man8 directory to exist.
+define BCACHE_TOOLS_INSTALL_MAN8
+	$(INSTALL) -m 0755 -d $(TARGET_DIR)/usr/share/man/man8
+endef
+
+# The bcache-tools Makefile expects the /lib/udev/rules.d directory to exist.
+define BCACHE_TOOLS_INSTALL_UDEV
+	$(INSTALL) -m 0755 -d $(TARGET_DIR)/lib/udev/rules.d
+endef
+
+BCACHE_TOOLS_PRE_INSTALL_TARGET_HOOKS += BCACHE_TOOLS_INSTALL_MAN8
+BCACHE_TOOLS_PRE_INSTALL_TARGET_HOOKS += BCACHE_TOOLS_INSTALL_UDEV
+
+define BCACHE_TOOLS_INSTALL_TARGET_CMDS
+	$(TARGET_MAKE_ENV) $(TARGET_CONFIGURE_OPTS) $(MAKE) -C $(@D) \
+		DESTDIR=$(TARGET_DIR) install
+endef
+
+$(eval $(generic-package))
Signature · 1 line
1.9.1
#1 lore raw

PATCH v8 1/1 bcache-tools: Adding package.

Jean-Christophe, All,

On 2014-09-07 22:27 +0200, Jean-Christophe DUBOIS spake thusly:

Quoted 4 lines

This is the bcache tools, required to setup the linux bcache feature of the Linux kernel.

Yet, a small comment below...

[--SNIP--]

Quoted 26 lines
package/bcache-tools/bcache-tools.mk new file +20 -0
new file mode 100644
index 0000000..e537471
@@ -0,0 +1,37 @@
+################################################################################
+#
+# bcache-tools
+#
+################################################################################
+
+BCACHE_TOOLS_VERSION = v1.0.7
+BCACHE_TOOLS_SITE = $(call github,g2p,bcache-tools,$(BCACHE_TOOLS_VERSION))
+BCACHE_TOOLS_LICENSE = GPLv2
+BCACHE_TOOLS_LICENSE_FILES = COPYING
+BCACHE_TOOLS_DEPENDENCIES = host-pkgconf util-linux
+
+# We pass $(TARGET_CONFIGURE_OPTS) as environment variable to allow
+# the bcache-tools Makefile to alter CFLAGS
+define BCACHE_TOOLS_BUILD_CMDS
+	$(TARGET_MAKE_ENV) $(TARGET_CONFIGURE_OPTS) $(MAKE) -C $(@D)
+endef
+
+# The bcache-tools Makefile expects the man8 directory to exist.
+define BCACHE_TOOLS_INSTALL_MAN8

package/bcache-tools/bcache-tools.mk line 30

Quoted 10 lines
package/bcache-tools/bcache-tools.mk new file +10 -0
+	$(INSTALL) -m 0755 -d $(TARGET_DIR)/usr/share/man/man8
+endef
+
+# The bcache-tools Makefile expects the /lib/udev/rules.d directory to exist.
+define BCACHE_TOOLS_INSTALL_UDEV
+	$(INSTALL) -m 0755 -d $(TARGET_DIR)/lib/udev/rules.d
+endef
+
+BCACHE_TOOLS_PRE_INSTALL_TARGET_HOOKS += BCACHE_TOOLS_INSTALL_MAN8
+BCACHE_TOOLS_PRE_INSTALL_TARGET_HOOKS += BCACHE_TOOLS_INSTALL_UDEV

Sorry, I was not clear enough in my previous mails (although I did send a corrective email to fix this): there is not need to have two hooks, you should create the two directories in the same hook.

No need to resend, the comitter can do the change, hopefully! ;-)

Thank you! :-)

Regards,
Yann E. MORIN.

Quoted 13 lines
package/bcache-tools/bcache-tools.mk new file +6 -0
+define BCACHE_TOOLS_INSTALL_TARGET_CMDS
+	$(TARGET_MAKE_ENV) $(TARGET_CONFIGURE_OPTS) $(MAKE) -C $(@D) \
+		DESTDIR=$(TARGET_DIR) install
+endef
+
+$(eval $(generic-package))
Signature · 6 lines
1.9.1

_______________________________________________
buildroot mailing list
buildroot at busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot
Signature · 6 lines
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
#2 lore raw

PATCH v8 1/1 bcache-tools: Adding package.

In reply to Jean-Christophe DUBOIS

Dear Jean-Christophe DUBOIS,

Quoted 4 lines · Jean-Christophe DUBOIS

This is the bcache tools, required to setup the linux bcache feature of the Linux kernel.

Thanks, patch applied, after doing the change suggested by Yann (use only one hook to create the missing directories).

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com