Skip to contentSkip to conversation

usb: remove unnecessary CONFIG_PM dependency from USB_OTG

PATCH RESEND Superseded Nathan Sullivan 3 participants 3 messages Oct 26, 2015 – Oct 27, 2015 USB

v1 of 4 Superseded Latest is v4 →

lore
Share & tools
lore
#0 lore raw

PATCH RESEND 1/1 usb: remove unnecessary CONFIG_PM dependency from USB_OTG

The USB gadget support currently depends on power management (CONFIG_PM) being enabled, but does not actually need it enabled. Remove this dependency.

Tested on Bay Trail hardware with dwc3 USB.

---
 drivers/usb/core/Kconfig |    1 -
 1 file changed, 1 deletion(-)
drivers/usb/core/Kconfig +0 -1
index a99c89e..9c5cdf3 100644
@@ -43,7 +43,6 @@ config USB_DYNAMIC_MINORS
 
 config USB_OTG
 	bool "OTG support"
-	depends on PM
 	default n
 	help
 	  The most notable feature of USB OTG is support for a
Signature · 1 line
1.7.10.4
#1 lore raw
Quoted 1 line · Nathan Sullivan

The USB gadget support currently depends on power management

Why you said gadget? The thing you change is for OTG.

Quoted 29 lines

(CONFIG_PM) being enabled, but does not actually need it enabled. Remove this dependency.

Tested on Bay Trail hardware with dwc3 USB.

---
 drivers/usb/core/Kconfig |    1 -
 1 file changed, 1 deletion(-)
drivers/usb/core/Kconfig +0 -1
index a99c89e..9c5cdf3 100644
@@ -43,7 +43,6 @@ config USB_DYNAMIC_MINORS
 
 config USB_OTG
 	bool "OTG support"
-	depends on PM
 	default n
 	help
 	  The most notable feature of USB OTG is support for a
Signature · 6 lines
1.7.10.4

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Signature · 2 lines
Best Regards,
Peter Chen
#2 lore raw
In reply to Nathan Sullivan

Hello.

Quoted 16 lines · Nathan Sullivan

The USB gadget support currently depends on power management (CONFIG_PM) being enabled, but does not actually need it enabled. Remove this dependency.

Tested on Bay Trail hardware with dwc3 USB.

---
  drivers/usb/core/Kconfig |    1 -
  1 file changed, 1 deletion(-)
drivers/usb/core/Kconfig +0 -0
index a99c89e..9c5cdf3 100644

drivers/usb/core/Kconfig config USB_DYNAMIC_MINORS · line 46

Quoted 5 lines
drivers/usb/core/Kconfig +0 -1
@@ -43,7 +43,6 @@ config USB_DYNAMIC_MINORS
 
  config USB_OTG
  	bool "OTG support"
-	depends on PM
  	default n

You could as well delete the above line.

[...]

MBR, Sergei