Skip to contentSkip to conversation

CLK: s3c2410: removed unneeded code in s3c24xx_clkout_set_parent

PATCH Superseded Mutharaju, Prasanna (P.) 2 participants 2 messages Nov 30, 2015

Subsystems (3)

v1 of 3 Superseded Latest is v3 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 CLK: s3c2410: removed unneeded code in s3c24xx_clkout_set_parent

From: Prasanna Karthik <[email protected]>

Remove unneeded variable used to store return value.

---
 drivers/clk/samsung/clk-s3c2410-dclk.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
drivers/clk/samsung/clk-s3c2410-dclk.c +1 -2
index e9eb935..ec6fb14 100644
@@ -77,12 +77,11 @@ static u8 s3c24xx_clkout_get_parent(struct clk_hw *hw)
 static int s3c24xx_clkout_set_parent(struct clk_hw *hw, u8 index)
 {
 	struct s3c24xx_clkout *clkout = to_s3c24xx_clkout(hw);
-	int ret = 0;
 
 	s3c2410_modify_misccr((clkout->mask << clkout->shift),
 			      (index << clkout->shift));
 
-	return ret;
+	return 0;
 }
 
 static const struct clk_ops s3c24xx_clkout_ops = {
Signature · 1 line
1.9.1
#1 lore raw

PATCH 1/1 CLK: s3c2410: removed unneeded code in s3c24xx_clkout_set_parent

Quoted 5 lines · Prasanna (P.)

From: Prasanna Karthik <[email protected]>

Remove unneeded variable used to store return value.

You need to sign it off too.

The prefix in subject should be lowercase 'clk:' and you are removing rather a variable, not code.

The patch looks good, so with these changes:

Best regards,
Krzysztof

Quoted 23 lines
---
 drivers/clk/samsung/clk-s3c2410-dclk.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
drivers/clk/samsung/clk-s3c2410-dclk.c +1 -2
index e9eb935..ec6fb14 100644
@@ -77,12 +77,11 @@ static u8 s3c24xx_clkout_get_parent(struct clk_hw *hw)
 static int s3c24xx_clkout_set_parent(struct clk_hw *hw, u8 index)
 {
 	struct s3c24xx_clkout *clkout = to_s3c24xx_clkout(hw);
-	int ret = 0;
 
 	s3c2410_modify_misccr((clkout->mask << clkout->shift),
 			      (index << clkout->shift));
 
-	return ret;
+	return 0;
 }
 
 static const struct clk_ops s3c24xx_clkout_ops = {