Skip to contentSkip to conversation

Staging: iio: accel: Fixed NULL comparison style

PATCH Superseded Bhaktipriya Shridhar 2 participants 2 messages Dec 13, 2015

Subsystems (3)
Staging IIO Staging - industrial io

v1 of 3 Superseded Latest is v3 →

lore
Share & tools
lore

Bhaktipriya Shridhar

author
#0 lore raw

PATCH 1/1 Staging: iio: accel: Fixed NULL comparison style

This patch fixes checkpatch.pl check:
CHECK: Comparison to NULL could be written "!rx_p"
+ if (*rx_p == NULL) {

Signed-off-by Bhaktipriya Shridhar <[email protected]>
---
 drivers/staging/iio/accel/sca3000_ring.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/iio/accel/sca3000_ring.c +1 -1
index 20b878d..5339b10 100644
@@ -48,7 +48,7 @@ static int sca3000_read_data(struct sca3000_state *st,
 		}
 	};
 	*rx_p = kmalloc(len, GFP_KERNEL);
-	if (*rx_p == NULL) {
+	if (!rx_p) {
 		ret = -ENOMEM;
 		goto error_ret;
 	}
Signature · 1 line
2.1.4
#1 lore raw
Quoted 4 lines · Bhaktipriya Shridhar

This patch fixes checkpatch.pl check:
CHECK: Comparison to NULL could be written "!rx_p"
+ if (*rx_p == NULL) {

Actually it should be "if (!*rx_p)". checkpatch.pl appears to have a bug here.

regards,
dan carpenter

Quoted 20 lines
Signed-off-by Bhaktipriya Shridhar <[email protected]>
---
 drivers/staging/iio/accel/sca3000_ring.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/iio/accel/sca3000_ring.c +1 -1
index 20b878d..5339b10 100644
@@ -48,7 +48,7 @@ static int sca3000_read_data(struct sca3000_state *st,
 		}
 	};
 	*rx_p = kmalloc(len, GFP_KERNEL);
-	if (*rx_p == NULL) {
+	if (!rx_p) {
 		ret = -ENOMEM;
 		goto error_ret;
 	}
Signature · 1 line
2.1.4