Skip to contentSkip to conversation

Adds package/nvme: new package

PATCH Superseded Mamatha Inamdar 3 participants 6 messages Jan 20, 2016 – Jan 21, 2016

v6 of 9 Superseded Latest is v9 →

lore
Share & tools
lore

Mamatha Inamdar

author
#0 lore raw

PATCH v6 1/2 Adds package/nvme: new package

Add support for building NVME utility - a utility for interacting with standard NVM Express (optimized PCI Express SSD interface) devices.

Signed-off-by Mamatha Inamdar <[email protected]>
---
 package/nvme/0001-NVME-Makefile-cleanup.patch |   25 +++++++++++++++++++++++++
 package/nvme/nvme.hash                        |    2 ++
 package/nvme/nvme.mk                          |   22 ++++++++++++++++++++++
 3 files changed, 49 insertions(+)
 create mode 100644 package/nvme/0001-NVME-Makefile-cleanup.patch
 create mode 100644 package/nvme/nvme.hash
 create mode 100755 package/nvme/nvme.mk
package/nvme/0001-NVME-Makefile-cleanup.patch new file +25 -0
new file mode 100644
index 0000000..74beac9
@@ -0,0 +1,25 @@
+From 985a18605f8decd766370a7d9873c77c16b9253c Mon Sep 17 00:00:00 2001
+From: Mamatha Inamdar <[email protected]>
+Date: Mon, 18 Jan 2016 12:40:00 +0530
+Subject: [PATCH V2] NVME Makefile update
+
+Makefile cleanup: remove -Werror flag in CFLAGS
+
+Signed-off-by: Mamatha Inamdar <[email protected]>
+---
+ Makefile | 2 +-
+ 1 file changed, 1 insertion(+), 1 deletion(-)
+
+diff --git a/Makefile b/Makefile
+index d0c0ce4..003928b 100644
+--- a/Makefile
++++ b/Makefile
+@@ -1,4 +1,4 @@
+-CFLAGS += -std=gnu99 -O2 -g -Wall -Werror
++CFLAGS += -std=gnu99 -O2 -g -Wall
+ CPPFLAGS += -I $(SRC) -D_GNU_SOURCE
+ NVME = nvme
+ INSTALL ?= install
+--
+1.9.3
+
package/nvme/nvme.hash new file +2 -0
new file mode 100644
index 0000000..539a2b6
@@ -0,0 +1,2 @@
+# Locally computed:
+sha256  914319930a51372293c981562b165ae6af0de70f7da37e42da23940fe23aa387 nvme-v0.2.tar.gz
package/nvme/nvme.mk new file +22 -0
new file mode 100755
index 0000000..f06ed47
@@ -0,0 +1,22 @@
+################################################################################
+#
+# nvme
+#
+################################################################################
+
+NVME_VERSION = v0.2
+NVME_SITE = $(call github,linux-nvme,nvme-cli,$(NVME_VERSION))
+NVME_LICENSE = GPLv2+
+NVME_LICENSE_FILES = COPYING
+
+define NVME_BUILD_CMDS
+	$(TARGET_MAKE_ENV) $(TARGET_CONFIGURE_OPTS) $(MAKE) \
+		LIBUDEV=1 -C $(@D)
+endef
+
+define NVME_INSTALL_TARGET_CMDS
+	$(TARGET_MAKE_ENV) $(MAKE) -C $(@D) DESTDIR=$(TARGET_DIR) \
+		PREFIX=/usr install-bin
+endef
+
+$(eval $(generic-package))
author
#1 lore raw

PATCH 2/2 package/nvme: new package

This patch is to add NVME Config file

Signed-off-by Mamatha Inamdar <[email protected]>
---
 package/Config.in      |    1 +
 package/nvme/Config.in |    6 ++++++
 2 files changed, 7 insertions(+)
 create mode 100644 package/nvme/Config.in
package/Config.in +1 -0
index e0c2e2a..4d173d4 100644
@@ -380,6 +380,7 @@ endif
 	source "package/neard/Config.in"
 	source "package/nvidia-driver/Config.in"
 	source "package/nvidia-tegra23/Config.in"
+	source "package/nvme/Config.in"
 	source "package/ofono/Config.in"
 	source "package/ola/Config.in"
 	source "package/on2-8170-modules/Config.in"
package/nvme/Config.in new file +6 -0
new file mode 100644
index 0000000..8b5d37d
@@ -0,0 +1,6 @@
+config BR2_PACKAGE_NVME
+	bool "nvme"
+	help
+	  System utilities for IBM Power NVME devices
+
+	  https://github.com/linux-nvme/nvme-cli
#2 lore raw

PATCH 2/2 package/nvme: new package

Hi Mamatha,

Quoted 1 line · Mamatha Inamdar

This patch is to add NVME Config file

This should be part of the previous patch. That's what Thomas meant when he asked you to send a single patch. He only used a list to indicate what should change in this single patch compared to your previous submissions.

baruch

Signature · 3 lines
     http://baruch.siach.name/blog/                  ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch at tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -
author
#3 lore raw

PATCH 2/2 package/nvme: new package

Hi Baruch,

Thanks...Will send single patch

Quoted 10 lines · Baruch Siach

Hi Mamatha,

Quoted 1 line · Mamatha Inamdar

This patch is to add NVME Config file

This should be part of the previous patch. That's what Thomas meant when he asked you to send a single patch. He only used a list to indicate what should change in this single patch compared to your previous submissions.

baruch

#4 lore raw

PATCH v6 1/2 Adds package/nvme: new package

In reply to Mamatha Inamdar

Dear Mamatha Inamdar,

Quoted 4 lines · Mamatha Inamdar

Add support for building NVME utility - a utility for interacting with standard NVM Express (optimized PCI Express SSD interface) devices.

Signed-off-by Mamatha Inamdar <[email protected]>

Once again, there should be a *single* patch adding the package. Please merge your two patches into one.

Best regards,

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
author
#5 lore raw

PATCH v6 1/2 Adds package/nvme: new package

Hi Thomas,

Sorry...based on your two points I created the patch.... will send single patch now.

Quoted 13 lines · Thomas Petazzoni

Dear Mamatha Inamdar,

Quoted 4 lines · Mamatha Inamdar

Add support for building NVME utility - a utility for interacting with standard NVM Express (optimized PCI Express SSD interface) devices.

Signed-off-by Mamatha Inamdar <[email protected]>

Once again, there should be a *single* patch adding the package. Please merge your two patches into one.

Best regards,

Thomas