Skip to contentSkip to conversation

staging: media: omap4iss: Replace a bit shift by a use of BIT.

PATCH Superseded Arushi Singhal 3 participants 3 messages Mar 24, 2017 – Mar 26, 2017

Subsystems (2)

v2 of 3 Superseded Latest is v3 →

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 staging: media: omap4iss: Replace a bit shift by a use of BIT.

This patch replaces bit shifting on 1 with the BIT(x) macro. This was done with coccinelle:
@@
constant c;
@@

-1 << c
+BIT(c)

---
changes in v2
-Remove unnecessary parenthesis

 drivers/staging/media/omap4iss/iss_csi2.c    | 2 +-
 drivers/staging/media/omap4iss/iss_ipipe.c   | 2 +-
 drivers/staging/media/omap4iss/iss_ipipeif.c | 2 +-
 drivers/staging/media/omap4iss/iss_resizer.c | 2 +-
 4 files changed, 4 insertions(+), 4 deletions(-)
drivers/staging/media/omap4iss/iss_csi2.c +1 -1
index f71d5f2f179f..f6acc541e8a2 100644
@@ -1268,7 +1268,7 @@ static int csi2_init_entities(struct iss_csi2_device *csi2, const char *subname)
 	snprintf(name, sizeof(name), "CSI2%s", subname);
 	snprintf(sd->name, sizeof(sd->name), "OMAP4 ISS %s", name);
 
-	sd->grp_id = 1 << 16;	/* group ID for iss subdevs */
+	sd->grp_id = BIT(16);	/* group ID for iss subdevs */
 	v4l2_set_subdevdata(sd, csi2);
 	sd->flags |= V4L2_SUBDEV_FL_HAS_DEVNODE;
 
drivers/staging/media/omap4iss/iss_ipipe.c +1 -1
index d38782e8e84c..d86ef8a031f2 100644
@@ -508,7 +508,7 @@ static int ipipe_init_entities(struct iss_ipipe_device *ipipe)
 	v4l2_subdev_init(sd, &ipipe_v4l2_ops);
 	sd->internal_ops = &ipipe_v4l2_internal_ops;
 	strlcpy(sd->name, "OMAP4 ISS ISP IPIPE", sizeof(sd->name));
-	sd->grp_id = 1 << 16;	/* group ID for iss subdevs */
+	sd->grp_id = BIT(16);	/* group ID for iss subdevs */
 	v4l2_set_subdevdata(sd, ipipe);
 	sd->flags |= V4L2_SUBDEV_FL_HAS_DEVNODE;
 
drivers/staging/media/omap4iss/iss_ipipeif.c +1 -1
index 23de8330731d..cb88b2bd0d82 100644
@@ -739,7 +739,7 @@ static int ipipeif_init_entities(struct iss_ipipeif_device *ipipeif)
 	v4l2_subdev_init(sd, &ipipeif_v4l2_ops);
 	sd->internal_ops = &ipipeif_v4l2_internal_ops;
 	strlcpy(sd->name, "OMAP4 ISS ISP IPIPEIF", sizeof(sd->name));
-	sd->grp_id = 1 << 16;	/* group ID for iss subdevs */
+	sd->grp_id = BIT(16);	/* group ID for iss subdevs */
 	v4l2_set_subdevdata(sd, ipipeif);
 	sd->flags |= V4L2_SUBDEV_FL_HAS_DEVNODE;
 
drivers/staging/media/omap4iss/iss_resizer.c +1 -1
index f1d352c711d5..4bbfa20b3c38 100644
@@ -782,7 +782,7 @@ static int resizer_init_entities(struct iss_resizer_device *resizer)
 	v4l2_subdev_init(sd, &resizer_v4l2_ops);
 	sd->internal_ops = &resizer_v4l2_internal_ops;
 	strlcpy(sd->name, "OMAP4 ISS ISP resizer", sizeof(sd->name));
-	sd->grp_id = 1 << 16;	/* group ID for iss subdevs */
+	sd->grp_id = BIT(16);	/* group ID for iss subdevs */
 	v4l2_set_subdevdata(sd, resizer);
 	sd->flags |= V4L2_SUBDEV_FL_HAS_DEVNODE;
 
Signature · 1 line
2.11.0
Acked-by on v2 1/1
#1 lore raw

Hi Arushi,

Thank you for the patch.

Quoted 10 lines · On Friday 24 Mar 2017 21:31:45 Arushi Singhal wrote:

This patch replaces bit shifting on 1 with the BIT(x) macro. This was done with coccinelle:
@@
constant c;
@@

-1 << c
+BIT(c)

Greg, as this is a staging driver, do you want to merge the patch through your tree ?

Quoted 66 lines

---
changes in v2
-Remove unnecessary parenthesis

 drivers/staging/media/omap4iss/iss_csi2.c    | 2 +-
 drivers/staging/media/omap4iss/iss_ipipe.c   | 2 +-
 drivers/staging/media/omap4iss/iss_ipipeif.c | 2 +-
 drivers/staging/media/omap4iss/iss_resizer.c | 2 +-
 4 files changed, 4 insertions(+), 4 deletions(-)
(quoted diff) +0 -0

b/drivers/staging/media/omap4iss/iss_csi2.c index
f71d5f2f179f..f6acc541e8a2 100644

drivers/staging/media/omap4iss/iss_csi2.c +1 -1
@@ -1268,7 +1268,7 @@ static int csi2_init_entities(struct iss_csi2_device
 *csi2, const char *subname) snprintf(name, sizeof(name), "CSI2%s",
 subname);
 	snprintf(sd->name, sizeof(sd->name), "OMAP4 ISS %s", name);
 
-	sd->grp_id = 1 << 16;	/* group ID for iss subdevs */
+	sd->grp_id = BIT(16);	/* group ID for iss subdevs */
 	v4l2_set_subdevdata(sd, csi2);
 	sd->flags |= V4L2_SUBDEV_FL_HAS_DEVNODE;
(quoted diff) +0 -0

b/drivers/staging/media/omap4iss/iss_ipipe.c index d38782e8e84c..d86ef8a031f2 100644

drivers/staging/media/omap4iss/iss_ipipe.c +1 -1
@@ -508,7 +508,7 @@ static int ipipe_init_entities(struct iss_ipipe_device
 *ipipe) v4l2_subdev_init(sd, &ipipe_v4l2_ops);
 	sd->internal_ops = &ipipe_v4l2_internal_ops;
 	strlcpy(sd->name, "OMAP4 ISS ISP IPIPE", sizeof(sd->name));
-	sd->grp_id = 1 << 16;	/* group ID for iss subdevs */
+	sd->grp_id = BIT(16);	/* group ID for iss subdevs */
 	v4l2_set_subdevdata(sd, ipipe);
 	sd->flags |= V4L2_SUBDEV_FL_HAS_DEVNODE;
 
(quoted diff) +0 -0

b/drivers/staging/media/omap4iss/iss_ipipeif.c index 23de8330731d..cb88b2bd0d82 100644

drivers/staging/media/omap4iss/iss_ipipeif.c +1 -1
@@ -739,7 +739,7 @@ static int ipipeif_init_entities(struct
 iss_ipipeif_device *ipipeif) v4l2_subdev_init(sd, &ipipeif_v4l2_ops);
 	sd->internal_ops = &ipipeif_v4l2_internal_ops;
 	strlcpy(sd->name, "OMAP4 ISS ISP IPIPEIF", sizeof(sd->name));
-	sd->grp_id = 1 << 16;	/* group ID for iss subdevs */
+	sd->grp_id = BIT(16);	/* group ID for iss subdevs */
 	v4l2_set_subdevdata(sd, ipipeif);
 	sd->flags |= V4L2_SUBDEV_FL_HAS_DEVNODE;
 
(quoted diff) +0 -0

b/drivers/staging/media/omap4iss/iss_resizer.c index f1d352c711d5..4bbfa20b3c38 100644

drivers/staging/media/omap4iss/iss_resizer.c +1 -1
@@ -782,7 +782,7 @@ static int resizer_init_entities(struct
 iss_resizer_device *resizer) v4l2_subdev_init(sd, &resizer_v4l2_ops);
 	sd->internal_ops = &resizer_v4l2_internal_ops;
 	strlcpy(sd->name, "OMAP4 ISS ISP resizer", sizeof(sd->name));
-	sd->grp_id = 1 << 16;	/* group ID for iss subdevs */
+	sd->grp_id = BIT(16);	/* group ID for iss subdevs */
 	v4l2_set_subdevdata(sd, resizer);
 	sd->flags |= V4L2_SUBDEV_FL_HAS_DEVNODE;
Signature · 3 lines
Regards,

Laurent Pinchart
#2 lore raw

Em Sun, 26 Mar 2017 20:57:02 +0300
Laurent Pinchart <[email protected]> escreveu:

Quoted 14 lines

Hi Arushi,

Thank you for the patch.

Quoted 9 lines · On Friday 24 Mar 2017 21:31:45 Arushi Singhal wrote:

This patch replaces bit shifting on 1 with the BIT(x) macro. This was done with coccinelle:
@@
constant c;
@@

-1 << c
+BIT(c)

Quoted 6 lines
Quoted 1 line

Greg, as this is a staging driver, do you want to merge the patch through your tree ?

As this is at staging/media, better to merge via my tree.

Regards,
Mauro

Quoted 54 lines
Quoted 54 lines

---
changes in v2
-Remove unnecessary parenthesis

 drivers/staging/media/omap4iss/iss_csi2.c    | 2 +-
 drivers/staging/media/omap4iss/iss_ipipe.c   | 2 +-
 drivers/staging/media/omap4iss/iss_ipipeif.c | 2 +-
 drivers/staging/media/omap4iss/iss_resizer.c | 2 +-
 4 files changed, 4 insertions(+), 4 deletions(-)
(quoted diff) +0 -0

b/drivers/staging/media/omap4iss/iss_csi2.c index
f71d5f2f179f..f6acc541e8a2 100644

drivers/staging/media/omap4iss/iss_csi2.c +1 -1
@@ -1268,7 +1268,7 @@ static int csi2_init_entities(struct iss_csi2_device
 *csi2, const char *subname) snprintf(name, sizeof(name), "CSI2%s",
 subname);
 	snprintf(sd->name, sizeof(sd->name), "OMAP4 ISS %s", name);
 
-	sd->grp_id = 1 << 16;	/* group ID for iss subdevs */
+	sd->grp_id = BIT(16);	/* group ID for iss subdevs */
 	v4l2_set_subdevdata(sd, csi2);
 	sd->flags |= V4L2_SUBDEV_FL_HAS_DEVNODE;
(quoted diff) +0 -0

b/drivers/staging/media/omap4iss/iss_ipipe.c index d38782e8e84c..d86ef8a031f2 100644

drivers/staging/media/omap4iss/iss_ipipe.c +1 -1
@@ -508,7 +508,7 @@ static int ipipe_init_entities(struct iss_ipipe_device
 *ipipe) v4l2_subdev_init(sd, &ipipe_v4l2_ops);
 	sd->internal_ops = &ipipe_v4l2_internal_ops;
 	strlcpy(sd->name, "OMAP4 ISS ISP IPIPE", sizeof(sd->name));
-	sd->grp_id = 1 << 16;	/* group ID for iss subdevs */
+	sd->grp_id = BIT(16);	/* group ID for iss subdevs */
 	v4l2_set_subdevdata(sd, ipipe);
 	sd->flags |= V4L2_SUBDEV_FL_HAS_DEVNODE;
 
(quoted diff) +0 -0

b/drivers/staging/media/omap4iss/iss_ipipeif.c index 23de8330731d..cb88b2bd0d82 100644

drivers/staging/media/omap4iss/iss_ipipeif.c +1 -1
@@ -739,7 +739,7 @@ static int ipipeif_init_entities(struct
 iss_ipipeif_device *ipipeif) v4l2_subdev_init(sd, &ipipeif_v4l2_ops);
 	sd->internal_ops = &ipipeif_v4l2_internal_ops;
 	strlcpy(sd->name, "OMAP4 ISS ISP IPIPEIF", sizeof(sd->name));
-	sd->grp_id = 1 << 16;	/* group ID for iss subdevs */
+	sd->grp_id = BIT(16);	/* group ID for iss subdevs */
 	v4l2_set_subdevdata(sd, ipipeif);
 	sd->flags |= V4L2_SUBDEV_FL_HAS_DEVNODE;
 
Quoted 14 lines

drivers/staging/media/omap4iss/iss_resizer.c static int resizer_init_entities(struct · line 787

Quoted 13 lines
(quoted diff) +0 -0

b/drivers/staging/media/omap4iss/iss_resizer.c index f1d352c711d5..4bbfa20b3c38 100644

drivers/staging/media/omap4iss/iss_resizer.c +1 -1
@@ -782,7 +782,7 @@ static int resizer_init_entities(struct
 iss_resizer_device *resizer) v4l2_subdev_init(sd, &resizer_v4l2_ops);
 	sd->internal_ops = &resizer_v4l2_internal_ops;
 	strlcpy(sd->name, "OMAP4 ISS ISP resizer", sizeof(sd->name));
-	sd->grp_id = 1 << 16;	/* group ID for iss subdevs */
+	sd->grp_id = BIT(16);	/* group ID for iss subdevs */
 	v4l2_set_subdevdata(sd, resizer);
 	sd->flags |= V4L2_SUBDEV_FL_HAS_DEVNODE;  

Thanks,
Mauro