Skip to contentSkip to conversation

ARM: dts: imx: Add support for Advantech DMS-BA16

PATCH Superseded Ken Lin 2 participants 4 messages Feb 6, 2018 – Feb 9, 2018

Subsystems (3)

v3 of 4 Superseded Latest is v4 →

lore
Share & tools
lore

Ken Lin

author
#0 lore raw

PATCH v3 1/1 ARM: dts: imx: Add support for Advantech DMS-BA16

Add support for Advantech DMS-BA16 board, which uses the Advantech BA-16 module.

---
Changes in v3:
- Fix the SPDX lines issue
- Fix the eeprom setting issue

 arch/arm/boot/dts/Makefile           |   1 +
 arch/arm/boot/dts/imx6q-dms-ba16.dts | 140 +++++++++++++++++++++++++++++++++++
 2 files changed, 141 insertions(+)
 create mode 100644 arch/arm/boot/dts/imx6q-dms-ba16.dts
arch/arm/boot/dts/Makefile +1 -0
index ade7a38543dc..585c3da4a47a 100644
@@ -435,6 +435,7 @@ dtb-$(CONFIG_SOC_IMX6Q) += \
 	imx6q-dfi-fs700-m60.dtb \
 	imx6q-display5-tianma-tm070-1280x768.dtb \
 	imx6q-dmo-edmqmx6.dtb \
+	imx6q-dms-ba16.dtb \
 	imx6q-evi.dtb \
 	imx6q-gk802.dtb \
 	imx6q-gw51xx.dtb \
arch/arm/boot/dts/imx6q-dms-ba16.dts new file +140 -0

140 lines not on this page · raw message

Signature · 1 line
2.11.0
#1 lore raw
Quoted 83 lines · Ken Lin

Add support for Advantech DMS-BA16 board, which uses the Advantech BA-16 module.

---
Changes in v3:
- Fix the SPDX lines issue
- Fix the eeprom setting issue

 arch/arm/boot/dts/Makefile           |   1 +
 arch/arm/boot/dts/imx6q-dms-ba16.dts | 140 +++++++++++++++++++++++++++++++++++
 2 files changed, 141 insertions(+)
 create mode 100644 arch/arm/boot/dts/imx6q-dms-ba16.dts
arch/arm/boot/dts/Makefile +1 -0
index ade7a38543dc..585c3da4a47a 100644
@@ -435,6 +435,7 @@ dtb-$(CONFIG_SOC_IMX6Q) += \
 	imx6q-dfi-fs700-m60.dtb \
 	imx6q-display5-tianma-tm070-1280x768.dtb \
 	imx6q-dmo-edmqmx6.dtb \
+	imx6q-dms-ba16.dtb \
 	imx6q-evi.dtb \
 	imx6q-gk802.dtb \
 	imx6q-gw51xx.dtb \
arch/arm/boot/dts/imx6q-dms-ba16.dts new file +51 -0
new file mode 100644
index 000000000000..b5047fd88290
@@ -0,0 +1,140 @@
+// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
+
+/dts-v1/;
+
+#include <dt-bindings/gpio/gpio.h>
+#include "imx6q-ba16.dtsi"
+
+/ {
+	model = "Advantech DMS-BA16";
+	compatible = "advantech,imx6q-dms-ba16", "advantech,imx6q-ba16", "fsl,imx6q";
+
+	reg_usb_otg_vbus: regulator-usbotgvbus {
+		compatible = "regulator-fixed";
+		regulator-name = "usb_otg_vbus";
+		regulator-min-microvolt = <5000000>;
+		regulator-max-microvolt = <5000000>;
+		pinctrl-names = "default";
+		pinctrl-0 = <&pinctrl_usbotgvbus>;
+		gpio = <&gpio4 15 GPIO_ACTIVE_HIGH>;
+		enable-active-high;
+	};
+
+	sys_mclk: clock-sys-mclk {
+		compatible = "fixed-clock";
+		#clock-cells = <0>;
+		clock-frequency = <22000000>;
+	};
+
+	sound {
+		compatible = "fsl,imx6q-ba16-sgtl5000",
+			     "fsl,imx-audio-sgtl5000";
+		model = "imx6q-ba16-sgtl5000";
+		ssi-controller = <&ssi1>;
+		audio-codec = <&sgtl5000>;
+		audio-routing =
+			"MIC_IN", "Mic Jack",
+			"Mic Jack", "Mic Bias",
+			"Headphone Jack", "HP_OUT";
+		mux-int-port = <1>;
+		mux-ext-port = <4>;
+	};
+};
+
+&ecspi5 {
+	cs-gpios = <&gpio1 17 GPIO_ACTIVE_HIGH>;
+	pinctrl-names = "default";
+	pinctrl-0 = <&pinctrl_ecspi5>;
+	status = "okay";
+
+	m25_eeprom: m25p80 at 0 {
+		compatible = "atmel,at25256B", "atmel,at25";

arch/arm/boot/dts/imx6q-dms-ba16.dts line 61

Quoted 10 lines
arch/arm/boot/dts/imx6q-dms-ba16.dts new file +10 -0
+		spi-max-frequency = <20000000>;
+		size = <0x8000>;
+		pagesize = <64>;
+		reg = <0>;
+		address-width = <16>;
+	};
+};
+
+&iomuxc {
+

Unnecessary newline.

arch/arm/boot/dts/imx6q-dms-ba16.dts line 62

Quoted 1 line
arch/arm/boot/dts/imx6q-dms-ba16.dts new file +1 -0
+	pinctrl_usbotgvbus: usbotgvbusgrp {

Please keep the pinctrl entries under iomuxc node alphabetically sorted.

arch/arm/boot/dts/imx6q-dms-ba16.dts line 65

Quoted 3 lines
arch/arm/boot/dts/imx6q-dms-ba16.dts new file +3 -0
+		fsl,pins = <
+			MX6QDL_PAD_KEY_ROW4__GPIO4_IO15 0x000b0
+			MX6QDL_PAD_GPIO_1__USB_OTG_ID   0x17059

MX6QDL_PAD_GPIO_1__USB_OTG_ID shouldn't belong to this group but pinctrl_usbotg. However that has been defined in imx6q-ba16.dtsi using another USB_OTG_ID pinmux. Confusing.

Shawn

Quoted 78 lines
arch/arm/boot/dts/imx6q-dms-ba16.dts new file +75 -0
+		>;
+	};
+
+	pinctrl_i2c1_gpio: i2c1gpiogrp {
+		fsl,pins = <
+			MX6QDL_PAD_CSI0_DAT8__GPIO5_IO26        0x1b0b0
+			MX6QDL_PAD_CSI0_DAT9__GPIO5_IO27        0x1b0b0
+		>;
+	};
+
+	pinctrl_i2c2_gpio: i2c2gpiogrp {
+		fsl,pins = <
+			MX6QDL_PAD_KEY_COL3__GPIO4_IO12 0x1b0b0
+			MX6QDL_PAD_KEY_ROW3__GPIO4_IO13 0x1b0b0
+		>;
+	};
+
+	pinctrl_i2c3_gpio: i2c3gpiogrp {
+		fsl,pins = <
+			MX6QDL_PAD_GPIO_3__GPIO1_IO03   0x1b0b0
+			MX6QDL_PAD_GPIO_6__GPIO1_IO06   0x1b0b0
+		>;
+	};
+};
+
+&i2c1 {
+	clock-frequency = <100000>;
+	pinctrl-names = "default";
+	pinctrl-0 = <&pinctrl_i2c1>;
+	status = "okay";
+
+	sgtl5000: codec at a {
+		compatible = "fsl,sgtl5000";
+		reg = <0x0a>;
+		clocks = <&sys_mclk>;
+		lrclk-strength = <0x3>;
+		VDDA-supply = <&reg_1p8v>;
+		VDDIO-supply = <&reg_3p3v>;
+	};
+};
+
+&pwm2 {
+	pinctrl-names = "default";
+	pinctrl-0 = <&pinctrl_pwm2>;
+	status = "okay";
+};
+
+&sata {
+	fsl,no-spread-spectrum;
+	fsl,transmit-atten-16ths = <12>;
+	fsl,transmit-boost-mdB = <3330>;
+	fsl,transmit-level-mV = <1133>;
+	fsl,receive-dpll-mode = <1>;
+	status = "okay";
+};
+
+&usbotg {
+	vbus-supply = <&reg_usb_otg_vbus>;
+	pinctrl-names = "default";
+	pinctrl-0 = <&pinctrl_usbotg>;
+	dr_mode = "otg";
+	disable-over-current;
+	status = "okay";
+};
+
+&usdhc4 {
+	pinctrl-names = "default";
+	pinctrl-0 = <&pinctrl_usdhc4>;
+	bus-width = <8>;
+	cd-gpios = <&gpio6 11 GPIO_ACTIVE_LOW>;
+	no-1-8-v;
+	keep-power-in-suspend;
+	wakeup-source;
+	status = "okay";
+};
Signature · 1 line
2.11.0
#2 lore raw

Hi Shawn,

Thanks for pointing out the issues.
Please see my inline comments below.

Quoted 88 lines · Shawn Guo
Quoted 87 lines · Ken Lin

Add support for Advantech DMS-BA16 board, which uses the Advantech BA-16 module.

---
Changes in v3:
- Fix the SPDX lines issue
- Fix the eeprom setting issue

 arch/arm/boot/dts/Makefile           |   1 +
 arch/arm/boot/dts/imx6q-dms-ba16.dts | 140 +++++++++++++++++++++++++++++++++++
 2 files changed, 141 insertions(+)
 create mode 100644 arch/arm/boot/dts/imx6q-dms-ba16.dts
arch/arm/boot/dts/Makefile +1 -0
index ade7a38543dc..585c3da4a47a 100644
@@ -435,6 +435,7 @@ dtb-$(CONFIG_SOC_IMX6Q) += \
      imx6q-dfi-fs700-m60.dtb \
      imx6q-display5-tianma-tm070-1280x768.dtb \
      imx6q-dmo-edmqmx6.dtb \
+     imx6q-dms-ba16.dtb \
      imx6q-evi.dtb \
      imx6q-gk802.dtb \
      imx6q-gw51xx.dtb \
arch/arm/boot/dts/imx6q-dms-ba16.dts new file +55 -0
new file mode 100644
index 000000000000..b5047fd88290
@@ -0,0 +1,140 @@
+// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
+
+/dts-v1/;
+
+#include <dt-bindings/gpio/gpio.h>
+#include "imx6q-ba16.dtsi"
+
+/ {
+     model = "Advantech DMS-BA16";
+     compatible = "advantech,imx6q-dms-ba16", "advantech,imx6q-ba16", "fsl,imx6q";
+
+     reg_usb_otg_vbus: regulator-usbotgvbus {
+             compatible = "regulator-fixed";
+             regulator-name = "usb_otg_vbus";
+             regulator-min-microvolt = <5000000>;
+             regulator-max-microvolt = <5000000>;
+             pinctrl-names = "default";
+             pinctrl-0 = <&pinctrl_usbotgvbus>;
+             gpio = <&gpio4 15 GPIO_ACTIVE_HIGH>;
+             enable-active-high;
+     };
+
+     sys_mclk: clock-sys-mclk {
+             compatible = "fixed-clock";
+             #clock-cells = <0>;
+             clock-frequency = <22000000>;
+     };
+
+     sound {
+             compatible = "fsl,imx6q-ba16-sgtl5000",
+                          "fsl,imx-audio-sgtl5000";
+             model = "imx6q-ba16-sgtl5000";
+             ssi-controller = <&ssi1>;
+             audio-codec = <&sgtl5000>;
+             audio-routing =
+                     "MIC_IN", "Mic Jack",
+                     "Mic Jack", "Mic Bias",
+                     "Headphone Jack", "HP_OUT";
+             mux-int-port = <1>;
+             mux-ext-port = <4>;
+     };
+};
+
+&ecspi5 {
+     cs-gpios = <&gpio1 17 GPIO_ACTIVE_HIGH>;
+     pinctrl-names = "default";
+     pinctrl-0 = <&pinctrl_ecspi5>;
+     status = "okay";
+
+     m25_eeprom: m25p80 at 0 {
+             compatible = "atmel,at25256B", "atmel,at25";
+             spi-max-frequency = <20000000>;
+             size = <0x8000>;
+             pagesize = <64>;
+             reg = <0>;
Quoted 9 lines

arch/arm/boot/dts/imx6q-dms-ba16.dts line 61

Quoted 6 lines
arch/arm/boot/dts/imx6q-dms-ba16.dts new file +6 -0
+             address-width = <16>;
+     };
+};
+
+&iomuxc {
+

Unnecessary newline.

Thanks. Will fix this in the v4.

Quoted 4 lines

arch/arm/boot/dts/imx6q-dms-ba16.dts line 62

Quoted 1 line
arch/arm/boot/dts/imx6q-dms-ba16.dts new file +1 -0
+     pinctrl_usbotgvbus: usbotgvbusgrp {

Please keep the pinctrl entries under iomuxc node alphabetically sorted.

Thanks. Will fix this in the v4.

Quoted 9 lines

arch/arm/boot/dts/imx6q-dms-ba16.dts line 65

Quoted 3 lines
arch/arm/boot/dts/imx6q-dms-ba16.dts new file +3 -0
+             fsl,pins = <
+                     MX6QDL_PAD_KEY_ROW4__GPIO4_IO15 0x000b0
+                     MX6QDL_PAD_GPIO_1__USB_OTG_ID   0x17059

MX6QDL_PAD_GPIO_1__USB_OTG_ID shouldn't belong to this group but pinctrl_usbotg. However that has been defined in imx6q-ba16.dtsi using another USB_OTG_ID pinmux. Confusing.

Shawn

Will correct the USB_OTG_ID pinmux setting in the v4.
Do you mind if I redefine reg_usb_otg_vbus node since we just started using OTG host/device mode on this board ?

Quoted 79 lines
Quoted 79 lines
arch/arm/boot/dts/imx6q-dms-ba16.dts new file +75 -1
+             >;
+     };
+
+     pinctrl_i2c1_gpio: i2c1gpiogrp {
+             fsl,pins = <
+                     MX6QDL_PAD_CSI0_DAT8__GPIO5_IO26        0x1b0b0
+                     MX6QDL_PAD_CSI0_DAT9__GPIO5_IO27        0x1b0b0
+             >;
+     };
+
+     pinctrl_i2c2_gpio: i2c2gpiogrp {
+             fsl,pins = <
+                     MX6QDL_PAD_KEY_COL3__GPIO4_IO12 0x1b0b0
+                     MX6QDL_PAD_KEY_ROW3__GPIO4_IO13 0x1b0b0
+             >;
+     };
+
+     pinctrl_i2c3_gpio: i2c3gpiogrp {
+             fsl,pins = <
+                     MX6QDL_PAD_GPIO_3__GPIO1_IO03   0x1b0b0
+                     MX6QDL_PAD_GPIO_6__GPIO1_IO06   0x1b0b0
+             >;
+     };
+};
+
+&i2c1 {
+     clock-frequency = <100000>;
+     pinctrl-names = "default";
+     pinctrl-0 = <&pinctrl_i2c1>;
+     status = "okay";
+
+     sgtl5000: codec at a {
+             compatible = "fsl,sgtl5000";
+             reg = <0x0a>;
+             clocks = <&sys_mclk>;
+             lrclk-strength = <0x3>;
+             VDDA-supply = <&reg_1p8v>;
+             VDDIO-supply = <&reg_3p3v>;
+     };
+};
+
+&pwm2 {
+     pinctrl-names = "default";
+     pinctrl-0 = <&pinctrl_pwm2>;
+     status = "okay";
+};
+
+&sata {
+     fsl,no-spread-spectrum;
+     fsl,transmit-atten-16ths = <12>;
+     fsl,transmit-boost-mdB = <3330>;
+     fsl,transmit-level-mV = <1133>;
+     fsl,receive-dpll-mode = <1>;
+     status = "okay";
+};
+
+&usbotg {
+     vbus-supply = <&reg_usb_otg_vbus>;
+     pinctrl-names = "default";
+     pinctrl-0 = <&pinctrl_usbotg>;
+     dr_mode = "otg";
+     disable-over-current;
+     status = "okay";
+};
+
+&usdhc4 {
+     pinctrl-names = "default";
+     pinctrl-0 = <&pinctrl_usdhc4>;
+     bus-width = <8>;
+     cd-gpios = <&gpio6 11 GPIO_ACTIVE_LOW>;
+     no-1-8-v;
+     keep-power-in-suspend;
+     wakeup-source;
+     status = "okay";
+};
--

2.11.0

#3 lore raw
Quoted 3 lines · Yung-Ching LIN

Will correct the USB_OTG_ID pinmux setting in the v4.
Do you mind if I redefine reg_usb_otg_vbus node since we just started using OTG host/device mode on this board ?

Not at all. Feel free to change it.

Shawn